Browse Source

chore(codecov): Fix layout and required changes (#75835)

Changes:

- Undo some of my changes in #75644
- Only show comment when coverage drops (not when it increases) and we
have uncovered lines
Armen Zambrano G. 7 months ago
parent
commit
0aa7d4260b
1 changed files with 13 additions and 7 deletions
  1. 13 7
      codecov.yml

+ 13 - 7
codecov.yml

@@ -75,21 +75,27 @@ flag_management:
 
 # Read more here: https://docs.codecov.com/docs/pull-request-comments
 comment:
+  #### FOR TESTING ####
+  # If you want to test in your PR commenting configurations changes,
+  # comment out this line and uncomment the next line in the next section
+  # require_bundle_changes: false
+  ######################
+  # Post comment if there are changes in bundle size increases greater than value specified
+  require_bundle_changes: 'bundle_increase'
+  ######################
   # This is the addition of carry forward builds and fresh builds, thus, it's the addition
   # of the FE and BE builds
   after_n_builds: 22
-  # Show only the git diff / patch coverage, and exclude any comparison between base and head:
-  layout: 'condensed_header, condensed_files, condensed_footer'
+  # What to render in the comment
+  layout: 'diff, condensed_files'
+  # Do not show the project coverage in the comment
   hide_project_coverage: true
   # Update, if exists. Otherwise post new. Skip if deleted.
   behavior: once
-  # Comments will only post when coverage changes. Furthermore, if a comment
-  # already exists, and a newer commit results in no coverage change for the
-  # entire pull, the comment will be deleted.
-  require_changes: true
+  # Only post if coverage drops OR there are uncovered lines of code
+  require_changes: 'coverage_drop OR uncovered_patch'
   require_base: true # must have a base report to post
   require_head: true # must have a head report to post
-  require_bundle_changes: True # only post a comment when there are bundle size changes
   bundle_change_threshold: '10Kb'
 
 cli: