Browse Source

test: Import from sentry-fixture inside test files [1] (#56810)

<!-- Describe your PR here. -->
Ryan Albrecht 1 year ago
parent
commit
0706460dd4

+ 0 - 27
fixtures/js-stubs/types.tsx

@@ -23,39 +23,12 @@ type OverridableStubList<Params = any, Result = Params> = (
 ) => Result[];
 
 type TestStubFixtures = {
-  AccessRequest: OverridableStub;
-  AccountEmails: OverridableStubList;
-  ActivityFeed: OverridableStub;
-  AllAuthenticators: SimpleStub;
-  ApiApplication: OverridableStub;
   ApiToken: OverridableStub;
-  AsanaCreate: SimpleStub;
-  AsanaPlugin: SimpleStub;
-  AuditLogs: OverridableStubList;
-  AuditLogsApiEventNames: SimpleStub;
-  AuthProvider: OverridableStub;
-  AuthProviders: OverridableStubList;
-  Authenticators: SimpleStub;
   AvailableNotificationActions: OverridableStub;
-  BitbucketIntegrationConfig: SimpleStub;
-  Breadcrumb: OverridableStub;
-  Broadcast: OverridableStub;
-  BuiltInSymbolSources: OverridableStubList;
   CodeOwner: OverridableStub;
-  Commit: OverridableStub;
-  CommitAuthor: OverridableStub;
   Config: OverridableStub;
   Dashboard: OverridableVariadicStub;
-  DataScrubbingRelayPiiConfig: SimpleStub;
-  DebugFile: OverridableStub;
-  DebugSymbols: OverridableStub;
-  DeprecatedApiKey: OverridableStub;
-  DetailedEvents: SimpleStub;
-  DiscoverSavedQuery: OverridableStub;
   DocIntegration: OverridableStub;
-  Entries: SimpleStub;
-  Entries123Base: OverridableStub;
-  Entries123Target: OverridableStub;
   Environments: SimpleStub;
   Event: OverridableStub;
   EventAttachment: OverridableStub;

+ 2 - 1
static/app/components/customCommitsResolutionModal.spec.tsx

@@ -1,5 +1,6 @@
 import selectEvent from 'react-select-event';
 import styled from '@emotion/styled';
+import {Commit} from 'sentry-fixture/commit';
 
 import {render, screen, userEvent, waitFor} from 'sentry-test/reactTestingLibrary';
 
@@ -11,7 +12,7 @@ describe('CustomCommitsResolutionModal', function () {
   beforeEach(function () {
     commitsMock = MockApiClient.addMockResponse({
       url: '/projects/org-slug/project-slug/commits/',
-      body: [TestStubs.Commit()],
+      body: [Commit()],
     });
   });
 

+ 3 - 1
static/app/components/events/contexts/app/index.spec.tsx

@@ -1,3 +1,5 @@
+import {DataScrubbingRelayPiiConfig} from 'sentry-fixture/dataScrubbingRelayPiiConfig';
+
 import {render, screen, userEvent} from 'sentry-test/reactTestingLibrary';
 import {textWithMarkupMatcher} from 'sentry-test/utils';
 
@@ -45,7 +47,7 @@ describe('app event context', function () {
   it('display redacted data', async function () {
     render(<AppEventContext event={event} data={appMockData} />, {
       organization: {
-        relayPiiConfig: JSON.stringify(TestStubs.DataScrubbingRelayPiiConfig()),
+        relayPiiConfig: JSON.stringify(DataScrubbingRelayPiiConfig()),
       },
     });
 

+ 3 - 1
static/app/components/events/contexts/browser/index.spec.tsx

@@ -1,3 +1,5 @@
+import {DataScrubbingRelayPiiConfig} from 'sentry-fixture/dataScrubbingRelayPiiConfig';
+
 import {render, screen, userEvent} from 'sentry-test/reactTestingLibrary';
 import {textWithMarkupMatcher} from 'sentry-test/utils';
 
@@ -39,7 +41,7 @@ describe('browser event context', function () {
   it('display redacted data', async function () {
     render(<BrowserEventContext event={event} data={browserMockData} />, {
       organization: {
-        relayPiiConfig: JSON.stringify(TestStubs.DataScrubbingRelayPiiConfig()),
+        relayPiiConfig: JSON.stringify(DataScrubbingRelayPiiConfig()),
       },
     });
 

+ 3 - 1
static/app/components/events/contexts/device/index.spec.tsx

@@ -1,3 +1,5 @@
+import {DataScrubbingRelayPiiConfig} from 'sentry-fixture/dataScrubbingRelayPiiConfig';
+
 import {render, screen, userEvent} from 'sentry-test/reactTestingLibrary';
 import {textWithMarkupMatcher} from 'sentry-test/utils';
 
@@ -56,7 +58,7 @@ describe('device event context', function () {
   it('display redacted data', async function () {
     render(<DeviceEventContext event={event} data={deviceMockData} />, {
       organization: {
-        relayPiiConfig: JSON.stringify(TestStubs.DataScrubbingRelayPiiConfig()),
+        relayPiiConfig: JSON.stringify(DataScrubbingRelayPiiConfig()),
       },
     });
     expect(screen.getByText('Name')).toBeInTheDocument(); // subject

+ 3 - 1
static/app/components/events/contexts/gpu/index.spec.tsx

@@ -1,3 +1,5 @@
+import {DataScrubbingRelayPiiConfig} from 'sentry-fixture/dataScrubbingRelayPiiConfig';
+
 import {render, screen, userEvent} from 'sentry-test/reactTestingLibrary';
 import {textWithMarkupMatcher} from 'sentry-test/utils';
 
@@ -46,7 +48,7 @@ describe.skip('gpu event context', function () {
   it('display redacted data', async function () {
     render(<GPUEventContext event={event} data={gpuMockData} />, {
       organization: {
-        relayPiiConfig: JSON.stringify(TestStubs.DataScrubbingRelayPiiConfig()),
+        relayPiiConfig: JSON.stringify(DataScrubbingRelayPiiConfig()),
       },
     });
 

+ 3 - 1
static/app/components/events/contexts/operatingSystem/index.spec.tsx

@@ -1,3 +1,5 @@
+import {DataScrubbingRelayPiiConfig} from 'sentry-fixture/dataScrubbingRelayPiiConfig';
+
 import {render, screen, userEvent} from 'sentry-test/reactTestingLibrary';
 import {textWithMarkupMatcher} from 'sentry-test/utils';
 
@@ -41,7 +43,7 @@ describe('operating system event context', function () {
   it('display redacted data', async function () {
     render(<OperatingSystemEventContext event={event} data={operatingSystemMockData} />, {
       organization: {
-        relayPiiConfig: JSON.stringify(TestStubs.DataScrubbingRelayPiiConfig()),
+        relayPiiConfig: JSON.stringify(DataScrubbingRelayPiiConfig()),
       },
     });
 

+ 3 - 1
static/app/components/events/eventExtraData/index.spec.tsx

@@ -1,3 +1,5 @@
+import {DataScrubbingRelayPiiConfig} from 'sentry-fixture/dataScrubbingRelayPiiConfig';
+
 import {render, screen, userEvent} from 'sentry-test/reactTestingLibrary';
 import {textWithMarkupMatcher} from 'sentry-test/utils';
 
@@ -172,7 +174,7 @@ describe('EventExtraData', function () {
 
     render(<EventExtraData event={event} />, {
       organization: {
-        relayPiiConfig: JSON.stringify(TestStubs.DataScrubbingRelayPiiConfig()),
+        relayPiiConfig: JSON.stringify(DataScrubbingRelayPiiConfig()),
       },
     });
 

+ 3 - 1
static/app/components/events/eventSdk.spec.tsx

@@ -1,3 +1,5 @@
+import {DataScrubbingRelayPiiConfig} from 'sentry-fixture/dataScrubbingRelayPiiConfig';
+
 import {render, screen, userEvent} from 'sentry-test/reactTestingLibrary';
 import {textWithMarkupMatcher} from 'sentry-test/utils';
 
@@ -20,7 +22,7 @@ describe('event sdk', function () {
 
     render(<EventSdk sdk={event.sdk} meta={event._meta.sdk} />, {
       organization: {
-        relayPiiConfig: JSON.stringify(TestStubs.DataScrubbingRelayPiiConfig()),
+        relayPiiConfig: JSON.stringify(DataScrubbingRelayPiiConfig()),
       },
     });
 

+ 3 - 1
static/app/components/events/interfaces/breadcrumbs/breadcrumb/data/default.spec.tsx

@@ -1,3 +1,5 @@
+import {DataScrubbingRelayPiiConfig} from 'sentry-fixture/dataScrubbingRelayPiiConfig';
+
 import {initializeOrg} from 'sentry-test/initializeOrg';
 import {render, screen, userEvent} from 'sentry-test/reactTestingLibrary';
 import {textWithMarkupMatcher} from 'sentry-test/utils';
@@ -9,7 +11,7 @@ import {BreadcrumbLevelType, BreadcrumbType} from 'sentry/types/breadcrumbs';
 describe('Breadcrumb Data Default', function () {
   const project = TestStubs.Project({
     id: '0',
-    relayPiiConfig: JSON.stringify(TestStubs.DataScrubbingRelayPiiConfig()),
+    relayPiiConfig: JSON.stringify(DataScrubbingRelayPiiConfig()),
   });
 
   const {organization, router} = initializeOrg({

Some files were not shown because too many files changed in this diff