ref: fstringify tests (#23518)

tests/acceptance/page_objects/global_selection.py

@@ -18,9 +18,7 @@ class GlobalSelectionPage(BasePage):
         self.browser.click('[data-test-id="global-header-project-selector"]')
 
     def select_project_by_slug(self, slug):
-        project_item_selector = '//*[@data-test-id="badge-display-name" and text()="{}"]'.format(
-            slug
-        )
+        project_item_selector = f'//*[@data-test-id="badge-display-name" and text()="{slug}"]'
 
         self.open_project_selector()
         self.browser.wait_until(xpath=project_item_selector)
@@ -30,7 +28,7 @@ class GlobalSelectionPage(BasePage):
         self.browser.click('[data-test-id="global-header-environment-selector"]')
 
     def select_environment(self, environment):
-        environment_path = '//*[text()="{}"]'.format(environment)
+        environment_path = f'//*[text()="{environment}"]'
 
         self.open_project_selector()
         self.browser.wait_until(xpath=environment_path)
@@ -40,7 +38,7 @@ class GlobalSelectionPage(BasePage):
         self.browser.click('[data-test-id="global-header-timerange-selector"]')
 
     def select_date(self, date):
-        date_path = '//*[text()="{}"]'.format(date)
+        date_path = f'//*[text()="{date}"]'
 
         self.open_date_selector()
         self.browser.wait_until(xpath=date_path)

tests/acceptance/page_objects/issue_details.py

@@ -9,17 +9,15 @@ class IssueDetailsPage(BasePage):
         self.global_selection = GlobalSelectionPage(browser)
 
     def visit_issue(self, org, groupid):
-        self.browser.get("/organizations/{}/issues/{}/".format(org, groupid))
+        self.browser.get(f"/organizations/{org}/issues/{groupid}/")
         self.wait_until_loaded()
 
     def visit_issue_in_environment(self, org, groupid, environment):
-        self.browser.get(
-            "/organizations/{}/issues/{}/?environment={}".format(org, groupid, environment)
-        )
+        self.browser.get(f"/organizations/{org}/issues/{groupid}/?environment={environment}")
         self.browser.wait_until(".group-detail")
 
     def visit_tag_values(self, org, groupid, tag):
-        self.browser.get("/organizations/{}/issues/{}/tags/{}/".format(org, groupid, tag))
+        self.browser.get(f"/organizations/{org}/issues/{groupid}/tags/{tag}/")
         self.browser.wait_until_not(".loading-indicator")
 
     def get_environment(self):
@@ -29,7 +27,7 @@ class IssueDetailsPage(BasePage):
         self.global_selection.go_back_to_issues()
 
     def api_issue_get(self, groupid):
-        return self.client.get("/api/0/issues/{}/".format(groupid))
+        return self.client.get(f"/api/0/issues/{groupid}/")
 
     def go_to_subtab(self, name):
         tabs = self.browser.find_element_by_css_selector(".group-detail .nav-tabs")

tests/acceptance/page_objects/issue_list.py

@@ -10,17 +10,17 @@ class IssueListPage(BasePage):
         self.global_selection = GlobalSelectionPage(browser)
 
     def visit_issue_list(self, org, query=""):
-        self.browser.get("/organizations/{}/issues/{}".format(org, query))
+        self.browser.get(f"/organizations/{org}/issues/{query}")
         self.wait_until_loaded()
 
     def wait_for_stream(self):
         self.browser.wait_until('[data-test-id="event-issue-header"]', timeout=20)
 
     def select_issue(self, position):
-        self.browser.click('[data-test-id="group"]:nth-child({})'.format(position))
+        self.browser.click(f'[data-test-id="group"]:nth-child({position})')
 
     def navigate_to_issue(self, position):
-        self.browser.click('[data-test-id="group"]:nth-child({}) a'.format(position))
+        self.browser.click(f'[data-test-id="group"]:nth-child({position}) a')
         self.browser.wait_until(".group-detail")
         self.issue_details = IssueDetailsPage(self.browser, self.client)
 

tests/acceptance/sentry_plugins/test_amazon_sqs.py

@@ -10,7 +10,7 @@ class AmazonSQSTest(AcceptanceTestCase):
         self.project = self.create_project(organization=self.org, teams=[self.team], name="Bengal")
         self.create_member(user=self.user, organization=self.org, role="owner", teams=[self.team])
         self.login_as(self.user)
-        self.path = "/{}/{}/settings/plugins/amazon-sqs/".format(self.org.slug, self.project.slug)
+        self.path = f"/{self.org.slug}/{self.project.slug}/settings/plugins/amazon-sqs/"
 
     def test_simple(self):
         self.browser.get(self.path)

tests/acceptance/sentry_plugins/test_asana.py

@@ -10,7 +10,7 @@ class AsanaTest(AcceptanceTestCase):
         self.project = self.create_project(organization=self.org, teams=[self.team], name="Bengal")
         self.create_member(user=self.user, organization=self.org, role="owner", teams=[self.team])
         self.login_as(self.user)
-        self.path = "/{}/{}/settings/plugins/asana/".format(self.org.slug, self.project.slug)
+        self.path = f"/{self.org.slug}/{self.project.slug}/settings/plugins/asana/"
 
     def test_simple(self):
         self.browser.get(self.path)

tests/acceptance/sentry_plugins/test_bitbucket.py

@@ -10,7 +10,7 @@ class BitbucketTest(AcceptanceTestCase):
         self.project = self.create_project(organization=self.org, teams=[self.team], name="Bengal")
         self.create_member(user=self.user, organization=self.org, role="owner", teams=[self.team])
         self.login_as(self.user)
-        self.path = "/{}/{}/settings/plugins/bitbucket/".format(self.org.slug, self.project.slug)
+        self.path = f"/{self.org.slug}/{self.project.slug}/settings/plugins/bitbucket/"
 
     def test_simple(self):
         self.browser.get(self.path)

tests/acceptance/sentry_plugins/test_clubhouse.py

@@ -10,7 +10,7 @@ class ClubhouseTest(AcceptanceTestCase):
         self.project = self.create_project(organization=self.org, teams=[self.team], name="Bengal")
         self.create_member(user=self.user, organization=self.org, role="owner", teams=[self.team])
         self.login_as(self.user)
-        self.path = "/{}/{}/settings/plugins/clubhouse/".format(self.org.slug, self.project.slug)
+        self.path = f"/{self.org.slug}/{self.project.slug}/settings/plugins/clubhouse/"
 
     def test_simple(self):
         self.browser.get(self.path)

tests/acceptance/sentry_plugins/test_github.py

@@ -10,7 +10,7 @@ class GitHubTest(AcceptanceTestCase):
         self.project = self.create_project(organization=self.org, teams=[self.team], name="Bengal")
         self.create_member(user=self.user, organization=self.org, role="owner", teams=[self.team])
         self.login_as(self.user)
-        self.path = "/{}/{}/settings/plugins/github/".format(self.org.slug, self.project.slug)
+        self.path = f"/{self.org.slug}/{self.project.slug}/settings/plugins/github/"
 
     def test_simple(self):
         self.browser.get(self.path)

tests/acceptance/sentry_plugins/test_gitlab.py

@@ -10,7 +10,7 @@ class GitLabTest(AcceptanceTestCase):
         self.project = self.create_project(organization=self.org, teams=[self.team], name="Bengal")
         self.create_member(user=self.user, organization=self.org, role="owner", teams=[self.team])
         self.login_as(self.user)
-        self.path = "/{}/{}/settings/plugins/gitlab/".format(self.org.slug, self.project.slug)
+        self.path = f"/{self.org.slug}/{self.project.slug}/settings/plugins/gitlab/"
 
     def test_simple(self):
         self.browser.get(self.path)

tests/acceptance/sentry_plugins/test_jira.py

@@ -10,7 +10,7 @@ class JIRATest(AcceptanceTestCase):
         self.project = self.create_project(organization=self.org, teams=[self.team], name="Bengal")
         self.create_member(user=self.user, organization=self.org, role="owner", teams=[self.team])
         self.login_as(self.user)
-        self.path = "/{}/{}/settings/plugins/jira/".format(self.org.slug, self.project.slug)
+        self.path = f"/{self.org.slug}/{self.project.slug}/settings/plugins/jira/"
 
     def test_simple(self):
         self.browser.get(self.path)