Browse Source

ref(profiling): drop feature flags (#45122)

Drop redesign and spans feature flags from frontend

---------

Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Jonas 2 years ago
parent
commit
050700eb18

+ 1 - 5
static/app/components/events/interfaces/spans/spanDetail.tsx

@@ -380,10 +380,6 @@ function SpanDetail(props: Props) {
       value => value === 0
     );
 
-    const flamechartSpanFeatureEnabled = organization.features.includes(
-      'profiling-flamechart-spans'
-    );
-
     return (
       <Fragment>
         {renderOrphanSpanMessage()}
@@ -425,7 +421,7 @@ function SpanDetail(props: Props) {
               <Row title="Trace ID" extra={renderTraceButton()}>
                 {span.trace_id}
               </Row>
-              {flamechartSpanFeatureEnabled && profileId && event.projectSlug && (
+              {profileId && event.projectSlug && (
                 <Row
                   title="Profile ID"
                   extra={

+ 2 - 6
static/app/components/profiling/flamegraph/flamegraph.tsx

@@ -183,10 +183,6 @@ function Flamegraph(): ReactElement {
   const canvasPoolManager = useMemo(() => new CanvasPoolManager(), []);
   const scheduler = useCanvasScheduler(canvasPoolManager);
 
-  const hasFlameChartSpans = useMemo(() => {
-    return organization.features.includes('profiling-flamechart-spans');
-  }, [organization.features]);
-
   const hasUIFrames = useMemo(() => {
     const platform = profileGroup.metadata.platform;
     return (
@@ -211,12 +207,12 @@ function Flamegraph(): ReactElement {
   }, [profiledTransaction]);
 
   const spanChart = useMemo(() => {
-    if (!profile || !hasFlameChartSpans) {
+    if (!profile) {
       return null;
     }
 
     return new SpanChart(spanTree, {unit: profile.unit});
-  }, [spanTree, profile, hasFlameChartSpans]);
+  }, [spanTree, profile]);
 
   const flamegraph = useMemo(() => {
     if (typeof threadId !== 'number') {

+ 0 - 4
static/app/components/profiling/profilingTransactionHovercard.tsx

@@ -57,10 +57,6 @@ export function ProfilingTransactionHovercard(props: ProfilingTransactionHoverca
     </Link>
   );
 
-  if (!organization.features.includes('profiling-dashboard-redesign')) {
-    return triggerLink;
-  }
-
   return (
     <StyledHovercard
       delay={250}

+ 4 - 20
static/app/views/profiling/content.tsx

@@ -130,10 +130,6 @@ function ProfilingContent({location}: ProfilingContentProps) {
     );
   }, [selection.projects, projects]);
 
-  const isNewProfilingDashboardEnabled = organization.features.includes(
-    'profiling-dashboard-redesign'
-  );
-
   const eventView = useMemo(() => {
     const _eventView = EventView.fromNewQueryWithLocation(
       {
@@ -239,22 +235,10 @@ function ProfilingContent({location}: ProfilingContentProps) {
                 </ProfilingOnboardingPanel>
               ) : (
                 <Fragment>
-                  {isNewProfilingDashboardEnabled ? (
-                    <PanelsGrid>
-                      <ProfilingSlowestTransactionsPanel />
-                      <ProfileCharts
-                        query={query}
-                        selection={selection}
-                        hideCount={isNewProfilingDashboardEnabled}
-                      />
-                    </PanelsGrid>
-                  ) : (
-                    <ProfileCharts
-                      query={query}
-                      selection={selection}
-                      hideCount={isNewProfilingDashboardEnabled}
-                    />
-                  )}
+                  <PanelsGrid>
+                    <ProfilingSlowestTransactionsPanel />
+                    <ProfileCharts query={query} selection={selection} hideCount />
+                  </PanelsGrid>
                   <ProfileEventsTable
                     columns={fields.slice()}
                     data={transactions.status === 'success' ? transactions.data[0] : null}