Просмотр исходного кода

fix(go.d/nvidia_smi): disable loop mode by default on Win (#19039)

Ilya Mashchenko 3 месяцев назад
Родитель
Сommit
e474f06d2a
1 измененных файлов с 5 добавлено и 2 удалено
  1. 5 2
      src/go/plugin/go.d/modules/nvidia_smi/nvidia_smi.go

+ 5 - 2
src/go/plugin/go.d/modules/nvidia_smi/nvidia_smi.go

@@ -5,6 +5,7 @@ package nvidia_smi
 import (
 	_ "embed"
 	"errors"
+	"runtime"
 	"time"
 
 	"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@@ -28,8 +29,10 @@ func init() {
 func New() *NvidiaSmi {
 	return &NvidiaSmi{
 		Config: Config{
-			Timeout:  confopt.Duration(time.Second * 10),
-			LoopMode: true,
+			Timeout: confopt.Duration(time.Second * 10),
+			// Disable loop mode on Windows due to go.d.plugin's non-graceful exit
+			// which can leave `nvidia_smi` processes running indefinitely.
+			LoopMode: !(runtime.GOOS == "windows"),
 		},
 		binName: "nvidia-smi",
 		charts:  &module.Charts{},