Add a few changes that were missed by the systemd updater support. (#10007)

* Add a check to ensure that the install leaves a clean repo.

* Add a few changes that were missed by the systemd updater support.

.github/workflows/checks.yml

@@ -83,3 +83,15 @@ jobs:
       - name: Run run_install_with_dist_file.sh
         run: |
           ./.github/scripts/run_install_with_dist_file.sh "${DISTFILE}"
+  gitignore-check:
+    name: .gitignore
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+      - name: Prepare environment
+        run: ./packaging/installer/install-required-packages.sh --dont-wait --non-interactive netdata
+      - name: Build netdata
+        run: ./netdata-installer.sh --dont-start-it --disable-telemetry --dont-wait --install /tmp/install
+      - name: Check that repo is clean
+        run: if [ "$(git status --porcelain=v1 | wc -l)" -gt 0 ] ; then exit 1 ; fi

.gitignore

@@ -113,6 +113,7 @@ system/netdata-init-d
 system/netdata.logrotate
 system/netdata.service
 system/netdata.service.*
+system/netdata-updater.service
 !system/netdata.service.in
 !system/netdata.service.*.in
 system/netdata.plist

netdata-installer.sh

@@ -1059,7 +1059,7 @@ run $make install || exit 1
 # -----------------------------------------------------------------------------
 progress "Fix generated files permissions"
 
-run find ./system/ -type f -a \! -name \*.in -a \! -name Makefile\* -a \! -name \*.conf -a \! -name \*.service -a \! -name \*.logrotate -exec chmod 755 {} \;
+run find ./system/ -type f -a \! -name \*.in -a \! -name Makefile\* -a \! -name \*.conf -a \! -name \*.service -a \! -name \*.timer -a \! -name \*.logrotate -exec chmod 755 {} \;
 
 # -----------------------------------------------------------------------------
 progress "Creating standard user and groups for netdata"