Fix handling of workflow artifacts. (#18726)

* Don't use symlinks when preparing static build artifacts.

* Roll back to v4.4.0 for actions/upload-artifact action.

There appears to be a bug in the latest release that is causing some
files to not be found when creating artifacts.

* Bump actions/upload-artifact to v4.4.2 which fixes the bugs.

.github/workflows/build.yml

@@ -151,7 +151,7 @@ jobs:
       - name: Store
         id: store
         if: needs.file-check.outputs.run == 'true'
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v4.4.2
         with:
           name: dist-tarball
           path: artifacts/*.tar.gz
@@ -245,7 +245,7 @@ jobs:
       - name: Store
         id: store
         if: needs.file-check.outputs.run == 'true'
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v4.4.2
         with:
           name: dist-static-${{ matrix.arch }}
           path: artifacts/*.gz.run
@@ -349,7 +349,7 @@ jobs:
           timestamp-digest: SHA256
       - name: Upload Installer
         id: upload
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v4.4.2
         with:
           name: windows-x86_64-installer
           path: packaging\windows\netdata*.exe
@@ -440,7 +440,7 @@ jobs:
       - name: Store Artifacts
         id: store
         if: needs.file-check.outputs.run == 'true'
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v4.4.2
         with:
           name: final-artifacts
           path: artifacts/*
@@ -926,7 +926,7 @@ jobs:
           tags: test:${{ matrix.artifact_key }}
       - name: Upload image artifact
         id: upload
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v4.4.2
         with:
           name: ${{ matrix.artifact_key }}-test-env
           path: /tmp/image.tar

.github/workflows/docker.yml

@@ -178,7 +178,7 @@ jobs:
       - name: Upload Cache
         id: upload-cache
         if: github.repository == 'netdata/netdata' && needs.file-check.outputs.run == 'true' && github.event_name == 'workflow_dispatch'
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v4.4.2
         with:
           name: cache-${{ steps.artifact-name.outputs.platform }}
           path: /tmp/build-cache/*
@@ -296,7 +296,7 @@ jobs:
       - name: Upload digest
         id: upload-digest
         if: github.repository == 'netdata/netdata'
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v4.4.2
         with:
           name: docker-digests-${{ steps.artifact-name.outputs.platform }}
           path: /tmp/digests/*
@@ -451,7 +451,7 @@ jobs:
       - name: Upload digest
         id: upload-digest
         if: github.repository == 'netdata/netdata'
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v4.4.2
         with:
           name: quay-digests-${{ steps.artifact-name.outputs.platform }}
           path: /tmp/digests/*
@@ -607,7 +607,7 @@ jobs:
       - name: Upload digest
         id: upload-digest
         if: github.repository == 'netdata/netdata'
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v4.4.2
         with:
           name: ghcr-digests-${{ steps.artifact-name.outputs.platform }}
           path: /tmp/digests/*

.github/workflows/packaging.yml

@@ -265,7 +265,7 @@ jobs:
         id: artifacts
         if: needs.file-check.outputs.run == 'true'
         continue-on-error: true
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v4.4.2
         with:
           name: ${{ matrix.distro }}-${{ matrix.version }}-${{ matrix.arch }}-packages
           path: ${{ github.workspace }}/artifacts/*

packaging/makeself/jobs/99-makeself.install.sh

@@ -104,13 +104,13 @@ run mkdir -p artifacts
 run mv "${NETDATA_INSTALL_PATH}.gz.run" "artifacts/${FILE}"
 
 [ -f "netdata-${BUILDARCH}-latest.gz.run" ] && rm "netdata-${BUILDARCH}-latest.gz.run"
-run ln -s "artifacts/${FILE}" "netdata-${BUILDARCH}-latest.gz.run"
+run cp "artifacts/${FILE}" "netdata-${BUILDARCH}-latest.gz.run"
 
 if [ "${BUILDARCH}" = "x86_64" ]; then
   [ -f "netdata-latest.gz.run" ] && rm "netdata-latest.gz.run"
-  run ln -s "artifacts/${FILE}" "netdata-latest.gz.run"
+  run cp "artifacts/${FILE}" "netdata-latest.gz.run"
   [ -f "artifacts/netdata-${VERSION}.gz.run" ] && rm "netdata-${VERSION}.gz.run"
-  run ln -s "./${FILE}" "artifacts/netdata-${VERSION}.gz.run"
+  run cp "artifacts/${FILE}" "artifacts/netdata-${VERSION}.gz.run"
 fi
 
 # shellcheck disable=SC2015