Browse Source

Reduce broken pipe errors (#7588)

* tc_broken_pipe: Add exit to tc-qos-helper.sh.in

When Netdata received a kill -9 the script started from tc plugin using pipe stayed alive writting broken pipe,
this PR reduces the number of messages

* tc_broken_pipe: Missing exit

This commit brings exit for lines that were not reporting errors
thiagoftsm 5 years ago
parent
commit
4d958b8cf2
1 changed files with 5 additions and 5 deletions
  1. 5 5
      collectors/tc.plugin/tc-qos-helper.sh.in

+ 5 - 5
collectors/tc.plugin/tc-qos-helper.sh.in

@@ -211,7 +211,7 @@ show_fireqos_names() {
 
 	if [ -f "${fireqos_run_dir}/ifaces/${x}" ]; then
 		name="$(<"${fireqos_run_dir}/ifaces/${x}")"
-		echo "SETDEVICENAME ${name}"
+		echo "SETDEVICENAME ${name}" || exit
 
 		#shellcheck source=/dev/null
 		source "${fireqos_run_dir}/${name}.conf"
@@ -219,7 +219,7 @@ show_fireqos_names() {
 			# shellcheck disable=SC2086
 			setclassname ${n//|/ }
 		done
-		[ -n "${interface_dev}" ] && echo "SETDEVICEGROUP ${interface_dev}"
+		[ -n "${interface_dev}" ] && echo "SETDEVICEGROUP ${interface_dev}" || exit
 
 		return 0
 	fi
@@ -230,7 +230,7 @@ show_fireqos_names() {
 show_tc() {
 	local x="${1}"
 
-	echo "BEGIN ${x}"
+	echo "BEGIN ${x}" || exit
 
 	# netdata can parse the output of tc
 	${tc} -s ${tc_show} show dev "${x}"
@@ -240,7 +240,7 @@ show_tc() {
 		show_fireqos_names "${x}" || show_tc_cls "${x}"
 	fi
 
-	echo "END ${x}"
+	echo "END ${x}" || exit
 }
 
 find_tc_devices() {
@@ -289,7 +289,7 @@ while true; do
 		show_tc "${d}"
 	done
 
-	echo "WORKTIME ${LOOPSLEEPMS_LASTWORK}"
+	echo "WORKTIME ${LOOPSLEEPMS_LASTWORK}" || exit
 
 	loopsleepms ${update_every}