Browse Source

fix(go.d/sensors): ignore 'unknown' values (#18806)

Ilya Mashchenko 4 months ago
parent
commit
393c7b3de9

+ 5 - 0
src/go/plugin/go.d/modules/sensors/lmsensors/scanner.go

@@ -80,6 +80,11 @@ func (sc *Scanner) Scan() ([]*Chip, error) {
 				continue
 			}
 
+			// power average_max can be unknown (https://github.com/netdata/netdata/issues/18805)
+			if content == "unknown" && subfeat != "label" {
+				continue
+			}
+
 			if _, ok := rawSns[feat]; !ok {
 				rawSns[feat] = make(map[string]rawValue)
 			}

+ 1 - 2
src/go/plugin/go.d/modules/sensors/lmsensors/scanner_test.go

@@ -33,7 +33,6 @@ func TestScanner_Scan(t *testing.T) {
 								Average:        ptr(345.0),
 								AverageHighest: ptr(345.0),
 								AverageLowest:  ptr(345.0),
-								AverageMax:     ptr(345.0),
 								AverageMin:     ptr(345.0),
 								Input:          ptr(345.0),
 								InputHighest:   ptr(345.0),
@@ -66,7 +65,7 @@ func TestScanner_Scan(t *testing.T) {
 					{name: "/sys/devices/LNXSYSTM:00/device:00/ACPI0000:00/power1_average", val: "345000000"},
 					{name: "/sys/devices/LNXSYSTM:00/device:00/ACPI0000:00/power1_average_highest", val: "345000000"},
 					{name: "/sys/devices/LNXSYSTM:00/device:00/ACPI0000:00/power1_average_lowest", val: "345000000"},
-					{name: "/sys/devices/LNXSYSTM:00/device:00/ACPI0000:00/power1_average_max", val: "345000000"},
+					{name: "/sys/devices/LNXSYSTM:00/device:00/ACPI0000:00/power1_average_max", val: "unknown"},
 					{name: "/sys/devices/LNXSYSTM:00/device:00/ACPI0000:00/power1_average_min", val: "345000000"},
 					{name: "/sys/devices/LNXSYSTM:00/device:00/ACPI0000:00/power1_input", val: "345000000"},
 					{name: "/sys/devices/LNXSYSTM:00/device:00/ACPI0000:00/power1_input_highest", val: "345000000"},