Browse Source

chore: remove old dashboard leftovers (#19545)

Ilya Mashchenko 1 month ago
parent
commit
0164a51a86

+ 0 - 7
.codacy.yml

@@ -4,13 +4,6 @@ exclude_paths:
   - src/collectors/python.d.plugin/python_modules/urllib3/**
   - src/collectors/python.d.plugin/python_modules/third_party/**
   - packaging/makeself/**
-  - src/web/gui/css/**
-  - src/web/gui/lib/**
-  - src/web/gui/old/**
-  - src/web/gui/src/**
-  - src/web/gui/v1/**
-  - src/web/gui/v2/**
-  - src/web/gui/main.js
   - tests/**
   - aclk/tests/**
   - src/libnetdata/libjudy/**

+ 0 - 54
.github/workflows/dashboard-pr.yml

@@ -1,54 +0,0 @@
----
-# Create a PR to update the react dashboard code.
-name: Dashboard Version PR
-
-on:
-  workflow_dispatch:
-    inputs:
-      dashboard_version:
-        # This must be specified, and must _exactly_ match the version
-        # tag for the release to be used for the update.
-        description: Dashboard Version
-        required: true
-
-env:
-  DISABLE_TELEMETRY: 1
-
-jobs:
-  dashboard-pr:
-    name: Generate Dashboard Version Bump PR
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout
-        id: checkout
-        uses: actions/checkout@v4
-      - name: Update Files
-        id: update
-        run: |
-          src/web/gui/bundle_dashboard_v1.py ${{ github.event.inputs.dashboard_version }}
-      - name: Create Pull Request
-        id: pr
-        uses: peter-evans/create-pull-request@v7
-        with:
-          title: 'Update dashboard to version ${{ github.event.inputs.dashboard_version }}.'
-          body: 'See https://github.com/netdata/dashboard/releases/tag/${{ github.event.inputs.dashboard_version }} for changes.'
-          branch: dashboard-${{ github.event.inputs.dashboard_version }}
-          branch-suffix: timestamp
-          delete-branch: true
-          commit-message: 'Update dashboard to version ${{ github.event.inputs.dashboard_version }}.'
-          token: ${{ secrets.NETDATABOT_GITHUB_TOKEN }}
-      - name: Failure Notification
-        uses: rtCamp/action-slack-notify@v2
-        env:
-          SLACK_COLOR: 'danger'
-          SLACK_FOOTER: ''
-          SLACK_ICON_EMOJI: ':github-actions:'
-          SLACK_TITLE: 'Dashboard update PR creation failed:'
-          SLACK_USERNAME: 'GitHub Actions'
-          SLACK_MESSAGE: |-
-              ${{ github.repository }}: Failed to create PR to update dashboard code to newest release.
-              Checkout: ${{ steps.checkout.outcome }}
-              Update files: ${{ steps.update.outcome }}
-              Create PR: ${{ steps.pr.outcome }}
-          SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_URL }}
-        if: failure()

+ 0 - 8
.gitignore

@@ -60,14 +60,6 @@ README
 TODO.md
 TODO.txt
 
-src/web/gui/chart-info/
-src/web/gui/control.html
-src/web/gui/dashboard.js
-src/web/gui/datasource.css
-src/web/gui/gadget.xml
-src/web/gui/index_new.html
-src/web/gui/version.txt
-
 # related to karma/javascript/node
 /node_modules/
 /coverage/

+ 1 - 1
README.md

@@ -803,6 +803,6 @@ The Netdata ecosystem consists of three key parts:
 
 - **Netdata Cloud**: A commercial, closed-source component, Netdata Cloud enhances the capabilities of the open-source Netdata Agent by providing horizontal scalability, centralized alert notification dispatch (including a mobile app), user management, role-based access control, and other enterprise-grade features. It is available both as a SaaS solution and for on-premises deployment, with a free-to-use community tier also offered.
 
-- **Netdata UI**: The Netdata UI is closed-source, and handles all visualization and dashboard functionalities related to metrics, logs and other collected data, as well as the central configuration and management of the Netdata ecosystem. It serves both the Netdata Agent and Netdata Cloud. The Netdata UI is distributed in binary form with the Netdata Agent and is publicly accessible via a CDN, licensed under the [Netdata Cloud UI License 1 (NCUL1)](https://app.netdata.cloud/LICENSE.txt). It integrates third-party open-source components, detailed in the [Netdata UI third-party licenses](https://github.com/netdata/netdata/blob/master/src/web/gui/v2/3D_PARTY_LICENSES.txt).
+- **Netdata UI**: The Netdata UI is closed-source, and handles all visualization and dashboard functionalities related to metrics, logs and other collected data, as well as the central configuration and management of the Netdata ecosystem. It serves both the Netdata Agent and Netdata Cloud. The Netdata UI is distributed in binary form with the Netdata Agent and is publicly accessible via a CDN, licensed under the [Netdata Cloud UI License 1 (NCUL1)](https://app.netdata.cloud/LICENSE.txt). It integrates third-party open-source components, detailed in the [Netdata UI third-party licenses](https://app.netdata.cloud/3D_PARTY_LICENSES.txt).
 
 The binary installation packages provided by Netdata include the Netdata Agent and the Netdata UI. Since the Netdata Agent is open-source, it is frequently packaged by third parties (e.g., Linux Distributions) excluding the closed-source components (Netdata UI is not included). While their packages can still be useful in providing the necessary back-ends and the APIs of a fully functional monitoring solution, we recommend using the installation packages we provide to experience the full feature set of Netdata.

+ 0 - 2
docs/dashboards-and-charts/README.md

@@ -36,5 +36,3 @@ You can access the dashboard at <https://app.netdata.cloud/> and [sign-in with a
 ### Netdata Agent
 
 To view your Netdata dashboard, open a web browser and enter the address `http://NODE:19999`  - replace `NODE` with your Agent's IP address or hostname. If the Agent is on the same machine, use `http://localhost:19999`.
-
-Documentation for the previous Agent dashboard can still be found [here](/src/web/gui/README.md).

+ 0 - 1
docs/developer-and-contributor-corner/python-collector.txt

@@ -542,7 +542,6 @@ At minimum, to be buildable and testable, the PR needs to include:
 - A basic configuration for the plugin in the appropriate global config file: `collectors/python.d.plugin/python.d.conf`, which is also in YAML format.  Either add a line that reads `# <module_name>: yes` if the module is to be enabled by default, or one that reads `<module_name>: no` if it is to be disabled by default.
 - A makefile for the plugin at `collectors/python.d.plugin/<module_dir>/Makefile.inc`.  Check an existing plugin for what this should look like.
 - A line in `collectors/python.d.plugin/Makefile.am` including the above-mentioned makefile. Place it with the other plugin includes (please keep the includes sorted alphabetically).
-- Optionally, chart information in `src/web/gui/dashboard_info.js`.  This generally involves specifying a name and icon for the section, and may include descriptions for the section or individual charts.
 - Optionally, some default alert configurations for your collector in `health/health.d/<module_name>.conf` and a line adding `<module_name>.conf` in `health/Makefile.am`.
 
 ## Framework class reference

+ 0 - 2
docs/glossary.md

@@ -35,8 +35,6 @@ Missing a term? Let us know or submit a request to expand our glossary. Together
 
 - [**Context**](/docs/dashboards-and-charts/netdata-charts.md#contexts): A way of grouping charts by the types of metrics collected and dimensions displayed. It's kind of like a machine-readable naming and organization scheme.
 
-- [**Custom dashboards**](/src/web/gui/custom/README.md) A dashboard that you can create using simple HTML (no JavaScript is required for basic dashboards).
-
 ## D
 
 - [**Dashboard**](/docs/dashboards-and-charts/README.md): Out-of-the-box visual representation of metrics to provide insight into your infrastructure, its health and performance.

+ 0 - 2
src/collectors/statsd.plugin/README.md

@@ -972,8 +972,6 @@ At this point, you have used StatsD to gather metrics for k6, creating a whole n
 Netdata dashboard in the process. Moreover, you can further customize the icon of the particular section, 
 as well as the description for each chart.
 
-To edit the section, please follow the Netdata [documentation](/src/web/gui/README.md#customizing-the-local-dashboard).
-
 While the following configuration will be placed in a new file, as the documentation suggests, it is 
 instructing to use `dashboard_info.js` as a template. Open the file and see how the rest of sections and collectors have been defined.
 

+ 0 - 1
src/health/notifications/alarm-notify.sh.in

@@ -2490,7 +2490,6 @@ send_ntfy() {
     msg="${host} ${status_message}: ${alarm} - ${info}"
     httpcode=$(docurl -X POST \
                       "${ntfy_auth_header[@]}" \
-                      -H "Icon: https://raw.githubusercontent.com/netdata/netdata/master/src/web/gui/dashboard/images/favicon-196x196.png" \
                       -H "Title: ${host}: ${name//_/ }" \
                       -H "Tags: ${emoji}" \
                       -H "Priority: ${priority}" \