Browse Source

refactor: remove fields associated with pagination

Fix lint errors
jamesgeorge007 1 year ago
parent
commit
4a7aa50375

+ 1 - 1
packages/hoppscotch-common/src/components/new-collections/index.vue

@@ -30,7 +30,7 @@
 import { useService } from "dioc/vue"
 import { ref } from "vue"
 import { useI18n } from "~/composables/i18n"
-import { Picked } from "~/helpers/types/HoppPicked";
+import { Picked } from "~/helpers/types/HoppPicked"
 import { NewWorkspaceService } from "~/services/new-workspace"
 
 defineProps<{

+ 26 - 26
packages/hoppscotch-common/src/helpers/types/HoppPicked.ts

@@ -20,29 +20,29 @@ export type Picked =
       pickedType: "my-collection"
       collectionIndex: number
     }
-  // TODO: Enable this when rest of the implementation is in place
-  // | {
-  //     pickedType: "teams-request"
-  //     requestID: string
-  //   }
-  // | {
-  //     pickedType: "teams-folder"
-  //     folderID: string
-  //   }
-  // | {
-  //     pickedType: "teams-collection"
-  //     collectionID: string
-  //   }
-  // | {
-  //     pickedType: "gql-my-request"
-  //     folderPath: string
-  //     requestIndex: number
-  //   }
-  // | {
-  //     pickedType: "gql-my-folder"
-  //     folderPath: string
-  //   }
-  // | {
-  //     pickedType: "gql-my-collection"
-  //     collectionIndex: number
-  //   }
+// TODO: Enable this when rest of the implementation is in place
+// | {
+//     pickedType: "teams-request"
+//     requestID: string
+//   }
+// | {
+//     pickedType: "teams-folder"
+//     folderID: string
+//   }
+// | {
+//     pickedType: "teams-collection"
+//     collectionID: string
+//   }
+// | {
+//     pickedType: "gql-my-request"
+//     folderPath: string
+//     requestIndex: number
+//   }
+// | {
+//     pickedType: "gql-my-folder"
+//     folderPath: string
+//   }
+// | {
+//     pickedType: "gql-my-collection"
+//     collectionIndex: number
+//   }

+ 0 - 8
packages/hoppscotch-common/src/services/new-workspace/providers/personal.workspace.ts

@@ -557,7 +557,6 @@ export class PersonalWorkspaceProviderService
               collectionID: collectionHandle.value.data.collectionID,
 
               loading: ref(false),
-              mayHaveMoreContent: ref(false),
 
               content: computed(() => {
                 const indexPath = collectionID
@@ -594,9 +593,6 @@ export class PersonalWorkspaceProviderService
                 }
                 return []
               }),
-              loadMore() {
-                return Promise.resolve()
-              },
             },
           })
         })
@@ -628,7 +624,6 @@ export class PersonalWorkspaceProviderService
               workspaceID: workspaceHandle.value.data.workspaceID,
 
               loading: ref(false),
-              mayHaveMoreContent: ref(false),
 
               collections: computed(() => {
                 return this.restCollectionState.value.state.map((coll, id) => {
@@ -638,9 +633,6 @@ export class PersonalWorkspaceProviderService
                   }
                 })
               }),
-              loadMore() {
-                return Promise.resolve()
-              },
             },
           })
         })

+ 0 - 10
packages/hoppscotch-common/src/services/new-workspace/providers/test.workspace.ts

@@ -219,7 +219,6 @@ export class TestWorkspaceProviderService
               workspaceID,
               collectionID,
 
-              mayHaveMoreContent: ref(false),
               loading: ref(false),
 
               content: computed(() => [
@@ -249,10 +248,6 @@ export class TestWorkspaceProviderService
                   },
                 })),
               ]),
-
-              loadMore(_count: number) {
-                return Promise.resolve()
-              },
             },
           })
         })
@@ -288,7 +283,6 @@ export class TestWorkspaceProviderService
               providerID: this.providerID,
               workspaceID,
 
-              mayHaveMoreContent: ref(false),
               loading: ref(false),
 
               collections: computed(() => {
@@ -299,10 +293,6 @@ export class TestWorkspaceProviderService
                   name: x.name,
                 }))
               }),
-
-              loadMore() {
-                return Promise.resolve()
-              },
             },
           })
         })

+ 0 - 6
packages/hoppscotch-common/src/services/new-workspace/view.ts

@@ -28,12 +28,9 @@ export interface RootRESTCollectionView {
   providerID: string
   workspaceID: string
 
-  mayHaveMoreContent: Ref<boolean>
   loading: Ref<boolean>
 
   collections: Ref<RESTCollectionViewCollection[]>
-
-  loadMore(count: number): Promise<void>
 }
 
 export interface RESTCollectionChildrenView {
@@ -41,10 +38,7 @@ export interface RESTCollectionChildrenView {
   workspaceID: string
   collectionID: string
 
-  mayHaveMoreContent: Ref<boolean>
   loading: Ref<boolean>
 
   content: Ref<RESTCollectionViewItem[]>
-
-  loadMore(count: number): Promise<void>
 }