Browse Source

ci: add back -Wall -Werror

Kévin Dunglas 6 months ago
parent
commit
7a524ddbd5
2 changed files with 2 additions and 1 deletions
  1. 1 1
      .github/workflows/sanitizers.yaml
  2. 1 0
      frankenphp.go

+ 1 - 1
.github/workflows/sanitizers.yaml

@@ -91,7 +91,7 @@ jobs:
             ${{ matrix.sanitizer == 'msan' && '--enable-memory-sanitizer' || '' }} \
             --prefix="$(pwd)/target/"
           make -j"$(getconf _NPROCESSORS_ONLN)"
-          sudo make install
+          make install
       -
         name: Add PHP to the PATH
         run: echo "$(pwd)/php/target/bin" >> "$GITHUB_PATH"

+ 1 - 0
frankenphp.go

@@ -13,6 +13,7 @@ package frankenphp
 // We also set these flags for hardening: https://github.com/docker-library/php/blob/master/8.2/bookworm/zts/Dockerfile#L57-L59
 
 // #cgo darwin pkg-config: libxml-2.0
+// #cgo CFLAGS: -Wall -Werror
 // #cgo CFLAGS: -I/usr/local/include/php -I/usr/local/include/php/main -I/usr/local/include/php/TSRM -I/usr/local/include/php/Zend -I/usr/local/include/php/ext -I/usr/local/include/php/ext/date/lib
 // #cgo linux CFLAGS: -D_GNU_SOURCE
 // #cgo darwin LDFLAGS: -L/opt/homebrew/opt/libiconv/lib -liconv