developer.texi 32 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878
  1. \input texinfo @c -*- texinfo -*-
  2. @documentencoding UTF-8
  3. @settitle Developer Documentation
  4. @titlepage
  5. @center @titlefont{Developer Documentation}
  6. @end titlepage
  7. @top
  8. @contents
  9. @chapter Introduction
  10. This text is concerned with the development @emph{of} FFmpeg itself. Information
  11. on using the FFmpeg libraries in other programs can be found elsewhere, e.g. in:
  12. @itemize @bullet
  13. @item
  14. the installed header files
  15. @item
  16. @url{http://ffmpeg.org/doxygen/trunk/index.html, the Doxygen documentation}
  17. generated from the headers
  18. @item
  19. the examples under @file{doc/examples}
  20. @end itemize
  21. If you modify FFmpeg code for your own use case, you are highly encouraged to
  22. @emph{submit your changes back to us}, using this document as a guide. There are
  23. both pragmatic and ideological reasons to do so:
  24. @itemize @bullet
  25. @item
  26. Maintaining external changes to keep up with upstream development is
  27. time-consuming and error-prone. With your code in the main tree, it will be
  28. maintained by FFmpeg developers.
  29. @item
  30. FFmpeg developers include leading experts in the field who can find bugs or
  31. design flaws in your code.
  32. @item
  33. By supporting the project you find useful you ensure it continues to be
  34. maintained and developed.
  35. @end itemize
  36. For more detailed legal information about the use of FFmpeg in
  37. external programs read the @file{LICENSE} file in the source tree and
  38. consult @url{https://ffmpeg.org/legal.html}.
  39. @section Contributing code
  40. All proposed code changes should be submitted for review to
  41. @url{mailto:ffmpeg-devel@@ffmpeg.org, the development mailing list}, as
  42. described in more detail in the @ref{Submitting patches} chapter. The code
  43. should comply with the @ref{Development Policy} and follow the @ref{Coding Rules}.
  44. The developer making the commit and the author are responsible for their changes
  45. and should try to fix issues their commit causes.
  46. @anchor{Coding Rules}
  47. @chapter Coding Rules
  48. @section C language features
  49. FFmpeg is programmed in the ISO C99 language, extended with:
  50. @itemize @bullet
  51. @item
  52. Atomic operations from C11 @file{stdatomic.h}. They are emulated on
  53. architectures/compilers that do not support them, so all FFmpeg-internal code
  54. may use atomics without any extra checks. However, @file{stdatomic.h} must not
  55. be included in public headers, so they stay C99-compatible.
  56. @end itemize
  57. Compiler-specific extensions may be used with good reason, but must not be
  58. depended on, i.e. the code must still compile and work with compilers lacking
  59. the extension.
  60. The following C99 features must not be used anywhere in the codebase:
  61. @itemize @bullet
  62. @item
  63. variable-length arrays;
  64. @item
  65. complex numbers;
  66. @item
  67. mixed statements and declarations.
  68. @end itemize
  69. @section Code formatting conventions
  70. There are the following guidelines regarding the indentation in files:
  71. @itemize @bullet
  72. @item
  73. Indent size is 4.
  74. @item
  75. The TAB character is forbidden outside of Makefiles as is any
  76. form of trailing whitespace. Commits containing either will be
  77. rejected by the git repository.
  78. @item
  79. You should try to limit your code lines to 80 characters; however, do so if
  80. and only if this improves readability.
  81. @item
  82. K&R coding style is used.
  83. @end itemize
  84. The presentation is one inspired by 'indent -i4 -kr -nut'.
  85. @subsection Vim configuration
  86. In order to configure Vim to follow FFmpeg formatting conventions, paste
  87. the following snippet into your @file{.vimrc}:
  88. @example
  89. " indentation rules for FFmpeg: 4 spaces, no tabs
  90. set expandtab
  91. set shiftwidth=4
  92. set softtabstop=4
  93. set cindent
  94. set cinoptions=(0
  95. " Allow tabs in Makefiles.
  96. autocmd FileType make,automake set noexpandtab shiftwidth=8 softtabstop=8
  97. " Trailing whitespace and tabs are forbidden, so highlight them.
  98. highlight ForbiddenWhitespace ctermbg=red guibg=red
  99. match ForbiddenWhitespace /\s\+$\|\t/
  100. " Do not highlight spaces at the end of line while typing on that line.
  101. autocmd InsertEnter * match ForbiddenWhitespace /\t\|\s\+\%#\@@<!$/
  102. @end example
  103. @subsection Emacs configuration
  104. For Emacs, add these roughly equivalent lines to your @file{.emacs.d/init.el}:
  105. @lisp
  106. (c-add-style "ffmpeg"
  107. '("k&r"
  108. (c-basic-offset . 4)
  109. (indent-tabs-mode . nil)
  110. (show-trailing-whitespace . t)
  111. (c-offsets-alist
  112. (statement-cont . (c-lineup-assignments +)))
  113. )
  114. )
  115. (setq c-default-style "ffmpeg")
  116. @end lisp
  117. @section Comments
  118. Use the JavaDoc/Doxygen format (see examples below) so that code documentation
  119. can be generated automatically. All nontrivial functions should have a comment
  120. above them explaining what the function does, even if it is just one sentence.
  121. All structures and their member variables should be documented, too.
  122. Avoid Qt-style and similar Doxygen syntax with @code{!} in it, i.e. replace
  123. @code{//!} with @code{///} and similar. Also @@ syntax should be employed
  124. for markup commands, i.e. use @code{@@param} and not @code{\param}.
  125. @example
  126. /**
  127. * @@file
  128. * MPEG codec.
  129. * @@author ...
  130. */
  131. /**
  132. * Summary sentence.
  133. * more text ...
  134. * ...
  135. */
  136. typedef struct Foobar @{
  137. int var1; /**< var1 description */
  138. int var2; ///< var2 description
  139. /** var3 description */
  140. int var3;
  141. @} Foobar;
  142. /**
  143. * Summary sentence.
  144. * more text ...
  145. * ...
  146. * @@param my_parameter description of my_parameter
  147. * @@return return value description
  148. */
  149. int myfunc(int my_parameter)
  150. ...
  151. @end example
  152. @section Naming conventions
  153. Names of functions, variables, and struct members must be lowercase, using
  154. underscores (_) to separate words. For example, @samp{avfilter_get_video_buffer}
  155. is an acceptable function name and @samp{AVFilterGetVideo} is not.
  156. Struct, union, enum, and typedeffed type names must use CamelCase. All structs
  157. and unions should be typedeffed to the same name as the struct/union tag, e.g.
  158. @code{typedef struct AVFoo @{ ... @} AVFoo;}. Enums are typically not
  159. typedeffed.
  160. Enumeration constants and macros must be UPPERCASE, except for macros
  161. masquerading as functions, which should use the function naming convention.
  162. All identifiers in the libraries should be namespaced as follows:
  163. @itemize @bullet
  164. @item
  165. No namespacing for identifiers with file and lower scope (e.g. local variables,
  166. static functions), and struct and union members,
  167. @item
  168. The @code{ff_} prefix must be used for variables and functions visible outside
  169. of file scope, but only used internally within a single library, e.g.
  170. @samp{ff_w64_demuxer}. This prevents name collisions when FFmpeg is statically
  171. linked.
  172. @item
  173. For variables and functions visible outside of file scope, used internally
  174. across multiple libraries, use @code{avpriv_} as prefix, for example,
  175. @samp{avpriv_report_missing_feature}.
  176. @item
  177. All other internal identifiers, like private type or macro names, should be
  178. namespaced only to avoid possible internal conflicts. E.g. @code{H264_NAL_SPS}
  179. vs. @code{HEVC_NAL_SPS}.
  180. @item
  181. Each library has its own prefix for public symbols, in addition to the
  182. commonly used @code{av_} (@code{avformat_} for libavformat,
  183. @code{avcodec_} for libavcodec, @code{swr_} for libswresample, etc).
  184. Check the existing code and choose names accordingly.
  185. @item
  186. Other public identifiers (struct, union, enum, macro, type names) must use their
  187. library's public prefix (@code{AV}, @code{Sws}, or @code{Swr}).
  188. @end itemize
  189. Furthermore, name space reserved for the system should not be invaded.
  190. Identifiers ending in @code{_t} are reserved by
  191. @url{http://pubs.opengroup.org/onlinepubs/007904975/functions/xsh_chap02_02.html#tag_02_02_02, POSIX}.
  192. Also avoid names starting with @code{__} or @code{_} followed by an uppercase
  193. letter as they are reserved by the C standard. Names starting with @code{_}
  194. are reserved at the file level and may not be used for externally visible
  195. symbols. If in doubt, just avoid names starting with @code{_} altogether.
  196. @section Miscellaneous conventions
  197. @itemize @bullet
  198. @item
  199. fprintf and printf are forbidden in libavformat and libavcodec,
  200. please use av_log() instead.
  201. @item
  202. Casts should be used only when necessary. Unneeded parentheses
  203. should also be avoided if they don't make the code easier to understand.
  204. @end itemize
  205. @anchor{Development Policy}
  206. @chapter Development Policy
  207. @section Patches/Committing
  208. @subheading Licenses for patches must be compatible with FFmpeg.
  209. Contributions should be licensed under the
  210. @uref{http://www.gnu.org/licenses/lgpl-2.1.html, LGPL 2.1},
  211. including an "or any later version" clause, or, if you prefer
  212. a gift-style license, the
  213. @uref{http://opensource.org/licenses/isc-license.txt, ISC} or
  214. @uref{http://mit-license.org/, MIT} license.
  215. @uref{http://www.gnu.org/licenses/gpl-2.0.html, GPL 2} including
  216. an "or any later version" clause is also acceptable, but LGPL is
  217. preferred.
  218. If you add a new file, give it a proper license header. Do not copy and
  219. paste it from a random place, use an existing file as template.
  220. @subheading You must not commit code which breaks FFmpeg!
  221. This means unfinished code which is enabled and breaks compilation,
  222. or compiles but does not work/breaks the regression tests. Code which
  223. is unfinished but disabled may be permitted under-circumstances, like
  224. missing samples or an implementation with a small subset of features.
  225. Always check the mailing list for any reviewers with issues and test
  226. FATE before you push.
  227. @subheading Keep the main commit message short with an extended description below.
  228. The commit message should have a short first line in the form of
  229. a @samp{topic: short description} as a header, separated by a newline
  230. from the body consisting of an explanation of why the change is necessary.
  231. If the commit fixes a known bug on the bug tracker, the commit message
  232. should include its bug ID. Referring to the issue on the bug tracker does
  233. not exempt you from writing an excerpt of the bug in the commit message.
  234. @subheading Testing must be adequate but not excessive.
  235. If it works for you, others, and passes FATE then it should be OK to commit
  236. it, provided it fits the other committing criteria. You should not worry about
  237. over-testing things. If your code has problems (portability, triggers
  238. compiler bugs, unusual environment etc) they will be reported and eventually
  239. fixed.
  240. @subheading Do not commit unrelated changes together.
  241. They should be split them into self-contained pieces. Also do not forget
  242. that if part B depends on part A, but A does not depend on B, then A can
  243. and should be committed first and separate from B. Keeping changes well
  244. split into self-contained parts makes reviewing and understanding them on
  245. the commit log mailing list easier. This also helps in case of debugging
  246. later on.
  247. Also if you have doubts about splitting or not splitting, do not hesitate to
  248. ask/discuss it on the developer mailing list.
  249. @subheading Ask before you change the build system (configure, etc).
  250. Do not commit changes to the build system (Makefiles, configure script)
  251. which change behavior, defaults etc, without asking first. The same
  252. applies to compiler warning fixes, trivial looking fixes and to code
  253. maintained by other developers. We usually have a reason for doing things
  254. the way we do. Send your changes as patches to the ffmpeg-devel mailing
  255. list, and if the code maintainers say OK, you may commit. This does not
  256. apply to files you wrote and/or maintain.
  257. @subheading Cosmetic changes should be kept in separate patches.
  258. We refuse source indentation and other cosmetic changes if they are mixed
  259. with functional changes, such commits will be rejected and removed. Every
  260. developer has his own indentation style, you should not change it. Of course
  261. if you (re)write something, you can use your own style, even though we would
  262. prefer if the indentation throughout FFmpeg was consistent (Many projects
  263. force a given indentation style - we do not.). If you really need to make
  264. indentation changes (try to avoid this), separate them strictly from real
  265. changes.
  266. NOTE: If you had to put if()@{ .. @} over a large (> 5 lines) chunk of code,
  267. then either do NOT change the indentation of the inner part within (do not
  268. move it to the right)! or do so in a separate commit
  269. @subheading Commit messages should always be filled out properly.
  270. Always fill out the commit log message. Describe in a few lines what you
  271. changed and why. You can refer to mailing list postings if you fix a
  272. particular bug. Comments such as "fixed!" or "Changed it." are unacceptable.
  273. Recommended format:
  274. @example
  275. area changed: Short 1 line description
  276. details describing what and why and giving references.
  277. @end example
  278. @subheading Credit the author of the patch.
  279. Make sure the author of the commit is set correctly. (see git commit --author)
  280. If you apply a patch, send an
  281. answer to ffmpeg-devel (or wherever you got the patch from) saying that
  282. you applied the patch.
  283. @subheading Complex patches should refer to discussion surrounding them.
  284. When applying patches that have been discussed (at length) on the mailing
  285. list, reference the thread in the log message.
  286. @subheading Always wait long enough before pushing changes
  287. Do NOT commit to code actively maintained by others without permission.
  288. Send a patch to ffmpeg-devel. If no one answers within a reasonable
  289. time-frame (12h for build failures and security fixes, 3 days small changes,
  290. 1 week for big patches) then commit your patch if you think it is OK.
  291. Also note, the maintainer can simply ask for more time to review!
  292. @section Code
  293. @subheading API/ABI changes should be discussed before they are made.
  294. Do not change behavior of the programs (renaming options etc) or public
  295. API or ABI without first discussing it on the ffmpeg-devel mailing list.
  296. Do not remove widely used functionality or features (redundant code can be removed).
  297. @subheading Remember to check if you need to bump versions for libav*.
  298. Depending on the change, you may need to change the version integer.
  299. Incrementing the first component means no backward compatibility to
  300. previous versions (e.g. removal of a function from the public API).
  301. Incrementing the second component means backward compatible change
  302. (e.g. addition of a function to the public API or extension of an
  303. existing data structure).
  304. Incrementing the third component means a noteworthy binary compatible
  305. change (e.g. encoder bug fix that matters for the decoder). The third
  306. component always starts at 100 to distinguish FFmpeg from Libav.
  307. @subheading Warnings for correct code may be disabled if there is no other option.
  308. Compiler warnings indicate potential bugs or code with bad style. If a type of
  309. warning always points to correct and clean code, that warning should
  310. be disabled, not the code changed.
  311. Thus the remaining warnings can either be bugs or correct code.
  312. If it is a bug, the bug has to be fixed. If it is not, the code should
  313. be changed to not generate a warning unless that causes a slowdown
  314. or obfuscates the code.
  315. @subheading Check untrusted input properly.
  316. Never write to unallocated memory, never write over the end of arrays,
  317. always check values read from some untrusted source before using them
  318. as array index or other risky things.
  319. @section Documentation/Other
  320. @subheading Subscribe to the ffmpeg-devel mailing list.
  321. It is important to be subscribed to the
  322. @uref{https://lists.ffmpeg.org/mailman/listinfo/ffmpeg-devel, ffmpeg-devel}
  323. mailing list. Almost any non-trivial patch is to be sent there for review.
  324. Other developers may have comments about your contribution. We expect you see
  325. those comments, and to improve it if requested. (N.B. Experienced committers
  326. have other channels, and may sometimes skip review for trivial fixes.) Also,
  327. discussion here about bug fixes and FFmpeg improvements by other developers may
  328. be helpful information for you. Finally, by being a list subscriber, your
  329. contribution will be posted immediately to the list, without the moderation
  330. hold which messages from non-subscribers experience.
  331. However, it is more important to the project that we receive your patch than
  332. that you be subscribed to the ffmpeg-devel list. If you have a patch, and don't
  333. want to subscribe and discuss the patch, then please do send it to the list
  334. anyway.
  335. @subheading Subscribe to the ffmpeg-cvslog mailing list.
  336. Diffs of all commits are sent to the
  337. @uref{https://lists.ffmpeg.org/mailman/listinfo/ffmpeg-cvslog, ffmpeg-cvslog}
  338. mailing list. Some developers read this list to review all code base changes
  339. from all sources. Subscribing to this list is not mandatory.
  340. @subheading Keep the documentation up to date.
  341. Update the documentation if you change behavior or add features. If you are
  342. unsure how best to do this, send a patch to ffmpeg-devel, the documentation
  343. maintainer(s) will review and commit your stuff.
  344. @subheading Important discussions should be accessible to all.
  345. Try to keep important discussions and requests (also) on the public
  346. developer mailing list, so that all developers can benefit from them.
  347. @subheading Check your entries in MAINTAINERS.
  348. Make sure that no parts of the codebase that you maintain are missing from the
  349. @file{MAINTAINERS} file. If something that you want to maintain is missing add it with
  350. your name after it.
  351. If at some point you no longer want to maintain some code, then please help in
  352. finding a new maintainer and also don't forget to update the @file{MAINTAINERS} file.
  353. We think our rules are not too hard. If you have comments, contact us.
  354. @chapter Code of conduct
  355. Be friendly and respectful towards others and third parties.
  356. Treat others the way you yourself want to be treated.
  357. Be considerate. Not everyone shares the same viewpoint and priorities as you do.
  358. Different opinions and interpretations help the project.
  359. Looking at issues from a different perspective assists development.
  360. Do not assume malice for things that can be attributed to incompetence. Even if
  361. it is malice, it's rarely good to start with that as initial assumption.
  362. Stay friendly even if someone acts contrarily. Everyone has a bad day
  363. once in a while.
  364. If you yourself have a bad day or are angry then try to take a break and reply
  365. once you are calm and without anger if you have to.
  366. Try to help other team members and cooperate if you can.
  367. The goal of software development is to create technical excellence, not for any
  368. individual to be better and "win" against the others. Large software projects
  369. are only possible and successful through teamwork.
  370. If someone struggles do not put them down. Give them a helping hand
  371. instead and point them in the right direction.
  372. Finally, keep in mind the immortal words of Bill and Ted,
  373. "Be excellent to each other."
  374. @anchor{Submitting patches}
  375. @chapter Submitting patches
  376. First, read the @ref{Coding Rules} above if you did not yet, in particular
  377. the rules regarding patch submission.
  378. When you submit your patch, please use @code{git format-patch} or
  379. @code{git send-email}. We cannot read other diffs :-).
  380. Also please do not submit a patch which contains several unrelated changes.
  381. Split it into separate, self-contained pieces. This does not mean splitting
  382. file by file. Instead, make the patch as small as possible while still
  383. keeping it as a logical unit that contains an individual change, even
  384. if it spans multiple files. This makes reviewing your patches much easier
  385. for us and greatly increases your chances of getting your patch applied.
  386. Use the patcheck tool of FFmpeg to check your patch.
  387. The tool is located in the tools directory.
  388. Run the @ref{Regression tests} before submitting a patch in order to verify
  389. it does not cause unexpected problems.
  390. It also helps quite a bit if you tell us what the patch does (for example
  391. 'replaces lrint by lrintf'), and why (for example '*BSD isn't C99 compliant
  392. and has no lrint()')
  393. Also please if you send several patches, send each patch as a separate mail,
  394. do not attach several unrelated patches to the same mail.
  395. Patches should be posted to the
  396. @uref{https://lists.ffmpeg.org/mailman/listinfo/ffmpeg-devel, ffmpeg-devel}
  397. mailing list. Use @code{git send-email} when possible since it will properly
  398. send patches without requiring extra care. If you cannot, then send patches
  399. as base64-encoded attachments, so your patch is not trashed during
  400. transmission. Also ensure the correct mime type is used
  401. (text/x-diff or text/x-patch or at least text/plain) and that only one
  402. patch is inline or attached per mail.
  403. You can check @url{https://patchwork.ffmpeg.org}, if your patch does not show up, its mime type
  404. likely was wrong.
  405. @subheading Sending patches from email clients
  406. Using @code{git send-email} might not be desirable for everyone. The
  407. following trick allows to send patches via email clients in a safe
  408. way. It has been tested with Outlook and Thunderbird (with X-Unsent
  409. extension) and might work with other applications.
  410. Create your patch like this:
  411. @verbatim
  412. git format-patch -s -o "outputfolder" --add-header "X-Unsent: 1" --suffix .eml --to ffmpeg-devel@ffmpeg.org -1 1a2b3c4d
  413. @end verbatim
  414. Now you'll just need to open the eml file with the email application
  415. and execute 'Send'.
  416. @subheading Reviews
  417. Your patch will be reviewed on the mailing list. You will likely be asked
  418. to make some changes and are expected to send in an improved version that
  419. incorporates the requests from the review. This process may go through
  420. several iterations. Once your patch is deemed good enough, some developer
  421. will pick it up and commit it to the official FFmpeg tree.
  422. Give us a few days to react. But if some time passes without reaction,
  423. send a reminder by email. Your patch should eventually be dealt with.
  424. @chapter New codecs or formats checklist
  425. @enumerate
  426. @item
  427. Did you use av_cold for codec initialization and close functions?
  428. @item
  429. Did you add a long_name under NULL_IF_CONFIG_SMALL to the AVCodec or
  430. AVInputFormat/AVOutputFormat struct?
  431. @item
  432. Did you bump the minor version number (and reset the micro version
  433. number) in @file{libavcodec/version.h} or @file{libavformat/version.h}?
  434. @item
  435. Did you register it in @file{allcodecs.c} or @file{allformats.c}?
  436. @item
  437. Did you add the AVCodecID to @file{avcodec.h}?
  438. When adding new codec IDs, also add an entry to the codec descriptor
  439. list in @file{libavcodec/codec_desc.c}.
  440. @item
  441. If it has a FourCC, did you add it to @file{libavformat/riff.c},
  442. even if it is only a decoder?
  443. @item
  444. Did you add a rule to compile the appropriate files in the Makefile?
  445. Remember to do this even if you're just adding a format to a file that is
  446. already being compiled by some other rule, like a raw demuxer.
  447. @item
  448. Did you add an entry to the table of supported formats or codecs in
  449. @file{doc/general.texi}?
  450. @item
  451. Did you add an entry in the Changelog?
  452. @item
  453. If it depends on a parser or a library, did you add that dependency in
  454. configure?
  455. @item
  456. Did you @code{git add} the appropriate files before committing?
  457. @item
  458. Did you make sure it compiles standalone, i.e. with
  459. @code{configure --disable-everything --enable-decoder=foo}
  460. (or @code{--enable-demuxer} or whatever your component is)?
  461. @end enumerate
  462. @chapter Patch submission checklist
  463. @enumerate
  464. @item
  465. Does @code{make fate} pass with the patch applied?
  466. @item
  467. Was the patch generated with git format-patch or send-email?
  468. @item
  469. Did you sign-off your patch? (@code{git commit -s})
  470. See @uref{https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/plain/Documentation/process/submitting-patches.rst, Sign your work} for the meaning
  471. of @dfn{sign-off}.
  472. @item
  473. Did you provide a clear git commit log message?
  474. @item
  475. Is the patch against latest FFmpeg git master branch?
  476. @item
  477. Are you subscribed to ffmpeg-devel?
  478. (the list is subscribers only due to spam)
  479. @item
  480. Have you checked that the changes are minimal, so that the same cannot be
  481. achieved with a smaller patch and/or simpler final code?
  482. @item
  483. If the change is to speed critical code, did you benchmark it?
  484. @item
  485. If you did any benchmarks, did you provide them in the mail?
  486. @item
  487. Have you checked that the patch does not introduce buffer overflows or
  488. other security issues?
  489. @item
  490. Did you test your decoder or demuxer against damaged data? If no, see
  491. tools/trasher, the noise bitstream filter, and
  492. @uref{http://caca.zoy.org/wiki/zzuf, zzuf}. Your decoder or demuxer
  493. should not crash, end in a (near) infinite loop, or allocate ridiculous
  494. amounts of memory when fed damaged data.
  495. @item
  496. Did you test your decoder or demuxer against sample files?
  497. Samples may be obtained at @url{https://samples.ffmpeg.org}.
  498. @item
  499. Does the patch not mix functional and cosmetic changes?
  500. @item
  501. Did you add tabs or trailing whitespace to the code? Both are forbidden.
  502. @item
  503. Is the patch attached to the email you send?
  504. @item
  505. Is the mime type of the patch correct? It should be text/x-diff or
  506. text/x-patch or at least text/plain and not application/octet-stream.
  507. @item
  508. If the patch fixes a bug, did you provide a verbose analysis of the bug?
  509. @item
  510. If the patch fixes a bug, did you provide enough information, including
  511. a sample, so the bug can be reproduced and the fix can be verified?
  512. Note please do not attach samples >100k to mails but rather provide a
  513. URL, you can upload to @url{https://streams.videolan.org/upload/}.
  514. @item
  515. Did you provide a verbose summary about what the patch does change?
  516. @item
  517. Did you provide a verbose explanation why it changes things like it does?
  518. @item
  519. Did you provide a verbose summary of the user visible advantages and
  520. disadvantages if the patch is applied?
  521. @item
  522. Did you provide an example so we can verify the new feature added by the
  523. patch easily?
  524. @item
  525. If you added a new file, did you insert a license header? It should be
  526. taken from FFmpeg, not randomly copied and pasted from somewhere else.
  527. @item
  528. You should maintain alphabetical order in alphabetically ordered lists as
  529. long as doing so does not break API/ABI compatibility.
  530. @item
  531. Lines with similar content should be aligned vertically when doing so
  532. improves readability.
  533. @item
  534. Consider adding a regression test for your code.
  535. @item
  536. If you added YASM code please check that things still work with --disable-yasm.
  537. @item
  538. Make sure you check the return values of function and return appropriate
  539. error codes. Especially memory allocation functions like @code{av_malloc()}
  540. are notoriously left unchecked, which is a serious problem.
  541. @item
  542. Test your code with valgrind and or Address Sanitizer to ensure it's free
  543. of leaks, out of array accesses, etc.
  544. @end enumerate
  545. @chapter Patch review process
  546. All patches posted to ffmpeg-devel will be reviewed, unless they contain a
  547. clear note that the patch is not for the git master branch.
  548. Reviews and comments will be posted as replies to the patch on the
  549. mailing list. The patch submitter then has to take care of every comment,
  550. that can be by resubmitting a changed patch or by discussion. Resubmitted
  551. patches will themselves be reviewed like any other patch. If at some point
  552. a patch passes review with no comments then it is approved, that can for
  553. simple and small patches happen immediately while large patches will generally
  554. have to be changed and reviewed many times before they are approved.
  555. After a patch is approved it will be committed to the repository.
  556. We will review all submitted patches, but sometimes we are quite busy so
  557. especially for large patches this can take several weeks.
  558. If you feel that the review process is too slow and you are willing to try to
  559. take over maintainership of the area of code you change then just clone
  560. git master and maintain the area of code there. We will merge each area from
  561. where its best maintained.
  562. When resubmitting patches, please do not make any significant changes
  563. not related to the comments received during review. Such patches will
  564. be rejected. Instead, submit significant changes or new features as
  565. separate patches.
  566. Everyone is welcome to review patches. Also if you are waiting for your patch
  567. to be reviewed, please consider helping to review other patches, that is a great
  568. way to get everyone's patches reviewed sooner.
  569. @anchor{Regression tests}
  570. @chapter Regression tests
  571. Before submitting a patch (or committing to the repository), you should at least
  572. test that you did not break anything.
  573. Running 'make fate' accomplishes this, please see @url{fate.html} for details.
  574. [Of course, some patches may change the results of the regression tests. In
  575. this case, the reference results of the regression tests shall be modified
  576. accordingly].
  577. @section Adding files to the fate-suite dataset
  578. When there is no muxer or encoder available to generate test media for a
  579. specific test then the media has to be included in the fate-suite.
  580. First please make sure that the sample file is as small as possible to test the
  581. respective decoder or demuxer sufficiently. Large files increase network
  582. bandwidth and disk space requirements.
  583. Once you have a working fate test and fate sample, provide in the commit
  584. message or introductory message for the patch series that you post to
  585. the ffmpeg-devel mailing list, a direct link to download the sample media.
  586. @section Visualizing Test Coverage
  587. The FFmpeg build system allows visualizing the test coverage in an easy
  588. manner with the coverage tools @code{gcov}/@code{lcov}. This involves
  589. the following steps:
  590. @enumerate
  591. @item
  592. Configure to compile with instrumentation enabled:
  593. @code{configure --toolchain=gcov}.
  594. @item
  595. Run your test case, either manually or via FATE. This can be either
  596. the full FATE regression suite, or any arbitrary invocation of any
  597. front-end tool provided by FFmpeg, in any combination.
  598. @item
  599. Run @code{make lcov} to generate coverage data in HTML format.
  600. @item
  601. View @code{lcov/index.html} in your preferred HTML viewer.
  602. @end enumerate
  603. You can use the command @code{make lcov-reset} to reset the coverage
  604. measurements. You will need to rerun @code{make lcov} after running a
  605. new test.
  606. @section Using Valgrind
  607. The configure script provides a shortcut for using valgrind to spot bugs
  608. related to memory handling. Just add the option
  609. @code{--toolchain=valgrind-memcheck} or @code{--toolchain=valgrind-massif}
  610. to your configure line, and reasonable defaults will be set for running
  611. FATE under the supervision of either the @strong{memcheck} or the
  612. @strong{massif} tool of the valgrind suite.
  613. In case you need finer control over how valgrind is invoked, use the
  614. @code{--target-exec='valgrind <your_custom_valgrind_options>} option in
  615. your configure line instead.
  616. @anchor{Release process}
  617. @chapter Release process
  618. FFmpeg maintains a set of @strong{release branches}, which are the
  619. recommended deliverable for system integrators and distributors (such as
  620. Linux distributions, etc.). At regular times, a @strong{release
  621. manager} prepares, tests and publishes tarballs on the
  622. @url{https://ffmpeg.org} website.
  623. There are two kinds of releases:
  624. @enumerate
  625. @item
  626. @strong{Major releases} always include the latest and greatest
  627. features and functionality.
  628. @item
  629. @strong{Point releases} are cut from @strong{release} branches,
  630. which are named @code{release/X}, with @code{X} being the release
  631. version number.
  632. @end enumerate
  633. Note that we promise to our users that shared libraries from any FFmpeg
  634. release never break programs that have been @strong{compiled} against
  635. previous versions of @strong{the same release series} in any case!
  636. However, from time to time, we do make API changes that require adaptations
  637. in applications. Such changes are only allowed in (new) major releases and
  638. require further steps such as bumping library version numbers and/or
  639. adjustments to the symbol versioning file. Please discuss such changes
  640. on the @strong{ffmpeg-devel} mailing list in time to allow forward planning.
  641. @anchor{Criteria for Point Releases}
  642. @section Criteria for Point Releases
  643. Changes that match the following criteria are valid candidates for
  644. inclusion into a point release:
  645. @enumerate
  646. @item
  647. Fixes a security issue, preferably identified by a @strong{CVE
  648. number} issued by @url{http://cve.mitre.org/}.
  649. @item
  650. Fixes a documented bug in @url{https://trac.ffmpeg.org}.
  651. @item
  652. Improves the included documentation.
  653. @item
  654. Retains both source code and binary compatibility with previous
  655. point releases of the same release branch.
  656. @end enumerate
  657. The order for checking the rules is (1 OR 2 OR 3) AND 4.
  658. @section Release Checklist
  659. The release process involves the following steps:
  660. @enumerate
  661. @item
  662. Ensure that the @file{RELEASE} file contains the version number for
  663. the upcoming release.
  664. @item
  665. Add the release at @url{https://trac.ffmpeg.org/admin/ticket/versions}.
  666. @item
  667. Announce the intent to do a release to the mailing list.
  668. @item
  669. Make sure all relevant security fixes have been backported. See
  670. @url{https://ffmpeg.org/security.html}.
  671. @item
  672. Ensure that the FATE regression suite still passes in the release
  673. branch on at least @strong{i386} and @strong{amd64}
  674. (cf. @ref{Regression tests}).
  675. @item
  676. Prepare the release tarballs in @code{bz2} and @code{gz} formats, and
  677. supplementing files that contain @code{gpg} signatures
  678. @item
  679. Publish the tarballs at @url{https://ffmpeg.org/releases}. Create and
  680. push an annotated tag in the form @code{nX}, with @code{X}
  681. containing the version number.
  682. @item
  683. Propose and send a patch to the @strong{ffmpeg-devel} mailing list
  684. with a news entry for the website.
  685. @item
  686. Publish the news entry.
  687. @item
  688. Send an announcement to the mailing list.
  689. @end enumerate
  690. @bye