12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454 |
- <?php
- declare(strict_types=1);
- /*
- * This file is part of PHP CS Fixer.
- *
- * (c) Fabien Potencier <fabien@symfony.com>
- * Dariusz Rumiński <dariusz.ruminski@gmail.com>
- *
- * This source file is subject to the MIT license that is bundled
- * with this source code in the file LICENSE.
- */
- namespace PhpCsFixer\Tests\Fixer\ReturnNotation;
- use PhpCsFixer\Tests\Test\AbstractFixerTestCase;
- /**
- * @internal
- *
- * @covers \PhpCsFixer\Fixer\ReturnNotation\ReturnAssignmentFixer
- *
- * @extends AbstractFixerTestCase<\PhpCsFixer\Fixer\ReturnNotation\ReturnAssignmentFixer>
- */
- final class ReturnAssignmentFixerTest extends AbstractFixerTestCase
- {
- /**
- * @dataProvider provideFixNestedFunctionsCases
- */
- public function testFixNestedFunctions(string $expected, string $input): void
- {
- $this->doTest($expected, $input);
- }
- /**
- * @return iterable<array{0: non-empty-string, 1?: non-empty-string}>
- */
- public static function provideFixNestedFunctionsCases(): iterable
- {
- yield [
- '<?php
- function A($a0,$a1,$a2,$d)
- {
- if ($a0) {
- return 1;
- // fix me
- }
- if ($a1) {
- return 2;
- // fix me
- }
- $nested0 = function() {
- global $a;
- ++$a;
- $d = 2;
- $nested1 = function () use ($d) {
- if ($d) {
- return 3;
- // fix me
- }
- $nested2 = function (&$d) {
- if ($d) {
- $f = 1;
- return $f; // fix me not
- }
- $d = function () {
- return 4;
- // fix me
- };
- if ($d+1) {
- $f = 1;
- return $f; // fix me not
- }
- };
- return $nested2();
- };
- return $a; // fix me not
- };
- if ($a2) {
- return 5;
- // fix me
- }
- }
- function B($b0, $b1, $b2)
- {
- if ($b0) {
- return 10;
- // fix me
- }
- if ($b1) {
- return 20;
- // fix me
- }
- if ($b2) {
- return 30;
- // fix me
- }
- }
- ',
- '<?php
- function A($a0,$a1,$a2,$d)
- {
- if ($a0) {
- $b = 1;
- return $b; // fix me
- }
- if ($a1) {
- $c = 2;
- return $c; // fix me
- }
- $nested0 = function() {
- global $a;
- ++$a;
- $d = 2;
- $nested1 = function () use ($d) {
- if ($d) {
- $f = 3;
- return $f; // fix me
- }
- $nested2 = function (&$d) {
- if ($d) {
- $f = 1;
- return $f; // fix me not
- }
- $d = function () {
- $a = 4;
- return $a; // fix me
- };
- if ($d+1) {
- $f = 1;
- return $f; // fix me not
- }
- };
- return $nested2();
- };
- return $a; // fix me not
- };
- if ($a2) {
- $d = 5;
- return $d; // fix me
- }
- }
- function B($b0, $b1, $b2)
- {
- if ($b0) {
- $b = 10;
- return $b; // fix me
- }
- if ($b1) {
- $c = 20;
- return $c; // fix me
- }
- if ($b2) {
- $d = 30;
- return $d; // fix me
- }
- }
- ',
- ];
- }
- /**
- * @dataProvider provideFixCases
- */
- public function testFix(string $expected, string $input): void
- {
- $this->doTest($expected, $input);
- }
- /**
- * @return iterable<array{0: non-empty-string, 1?: non-empty-string}>
- */
- public static function provideFixCases(): iterable
- {
- yield [
- '<?php
- function A()
- {
- return 15;
- }
- ',
- '<?php
- function A()
- {
- $a = 15;
- return $a;
- }
- ',
- ];
- yield [
- '<?php
- function A()
- {
- /*0*/return /*1*//*2*/15;/*3*//*4*/ /*5*/ /*6*//*7*//*8*/
- }
- ',
- '<?php
- function A()
- {
- /*0*/$a/*1*/=/*2*/15;/*3*//*4*/ /*5*/ return/*6*/$a/*7*/;/*8*/
- }
- ',
- ];
- yield 'comments with leading space' => [
- '<?php
- function A()
- { #1
- #2
- return #3
- #4
- #5
- #6
- 15 #7
- ; #8
- #9
- #10
- #11
- #12
- #13
- #14
- #15
- }
- ',
- '<?php
- function A()
- { #1
- #2
- $a #3
- #4
- = #5
- #6
- 15 #7
- ; #8
- #9
- return #10
- #11
- $a #12
- #13
- ; #14
- #15
- }
- ',
- ];
- yield [
- '<?php
- abstract class B
- {
- abstract protected function Z();public function A()
- {
- return 16;
- }
- }
- ',
- '<?php
- abstract class B
- {
- abstract protected function Z();public function A()
- {
- $a = 16; return $a;
- }
- }
- ',
- ];
- yield [
- '<?php
- function b() {
- if ($c) {
- return 0;
- }
- return testFunction(654+1);
- }
- ',
- '<?php
- function b() {
- if ($c) {
- $b = 0;
- return $b;
- }
- $a = testFunction(654+1);
- return $a;
- }
- ',
- ];
- yield 'minimal notation' => [
- '<?php $e=function(){return 1;};$f=function(){return 1;};$g=function(){return 1;};',
- '<?php $e=function(){$a=1;return$a;};$f=function(){$a=1;return$a;};$g=function(){$a=1;return$a;};',
- ];
- yield [
- '<?php
- function A()
- {#1
- #2 '.'
- return #3
- #4
- #5
- #6
- 15#7
- ;#8
- #9
- #10
- #11
- #12
- #13
- #14
- #15
- }
- ',
- '<?php
- function A()
- {#1
- #2 '.'
- $a#3
- #4
- =#5
- #6
- 15#7
- ;#8
- #9
- return#10
- #11
- $a#12
- #13
- ;#14
- #15
- }
- ',
- ];
- yield [
- '<?php
- function A($b)
- {
- // Comment
- return a("2", 4, $b);
- }
- ',
- '<?php
- function A($b)
- {
- // Comment
- $value = a("2", 4, $b);
- return $value;
- }
- ',
- ];
- yield [
- '<?php function a($b,$c) {if($c>1){echo 1;} return (1 + 2 + $b); }',
- '<?php function a($b,$c) {if($c>1){echo 1;} $a= (1 + 2 + $b);return $a; }',
- ];
- yield [
- '<?php function a($b,$c) {return (3 * 4 + $b); }',
- '<?php function a($b,$c) {$zz= (3 * 4 + $b);return $zz; }',
- ];
- yield [
- '<?php
- function a() {
- return 4563;
- ?> <?php
- }
- ',
- '<?php
- function a() {
- $a = 4563;
- return $a ?> <?php
- }
- ',
- ];
- yield [
- '<?php
- function a()
- {
- return $c + 1; /*
- var names are case-insensitive */ }
- ',
- '<?php
- function a()
- {
- $A = $c + 1; /*
- var names are case-insensitive */ return $a ;}
- ',
- ];
- yield [
- '<?php
- function A()
- {
- return $f[1]->a();
- }
- ',
- '<?php
- function A()
- {
- $a = $f[1]->a();
- return $a;
- }
- ',
- [
- '<?php
- function a($foos) {
- return array_map(function ($foo) {
- return (string) $foo;
- }, $foos);
- }',
- '<?php
- function a($foos) {
- $bars = array_map(function ($foo) {
- return (string) $foo;
- }, $foos);
- return $bars;
- }',
- ],
- [
- '<?php
- function a($foos) {
- return ($foos = [\'bar\']);
- }',
- '<?php
- function a($foos) {
- $bars = ($foos = [\'bar\']);
- return $bars;
- }',
- ],
- ];
- yield [
- '<?php
- function a($foos) {
- return (function ($foos) {
- return $foos;
- })($foos);
- }',
- '<?php
- function a($foos) {
- $bars = (function ($foos) {
- return $foos;
- })($foos);
- return $bars;
- }',
- ];
- yield 'anonymous classes' => [
- '<?php
- function A()
- {
- return new class {};
- }
- function B()
- {
- return new class() {};
- }
- function C()
- {
- return new class(1,2) { public function Z(Foo $d){} };
- }
- function D()
- {
- return new class extends Y {};
- }
- function E()
- {
- return new class extends Y implements A\O,P {};
- }
- ',
- '<?php
- function A()
- {
- $a = new class {};
- return $a;
- }
- function B()
- {
- $b = new class() {};
- return $b;
- }
- function C()
- {
- $c = new class(1,2) { public function Z(Foo $d){} };
- return $c;
- }
- function D()
- {
- $c = new class extends Y {};
- return $c;
- }
- function E()
- {
- $c = new class extends Y implements A\O,P {};
- return $c;
- }
- ',
- ];
- yield 'lambda' => [
- '<?php
- function A()
- {
- return function () {};
- }
- function B()
- {
- return function ($a, $b) use ($z) {};
- }
- function C()
- {
- return static function ($a, $b) use ($z) {};
- }
- function D()
- {
- return function &() use(&$b) {
- return $b; // do not fix
- };
- // fix
- }
- function E()
- {
- return function &() {
- $z = new A(); return $z; // do not fix
- };
- // fix
- }
- function A99()
- {
- $v = static function ($a, $b) use ($z) {};
- return 15;
- }
- ',
- '<?php
- function A()
- {
- $a = function () {};
- return $a;
- }
- function B()
- {
- $b = function ($a, $b) use ($z) {};
- return $b;
- }
- function C()
- {
- $c = static function ($a, $b) use ($z) {};
- return $c;
- }
- function D()
- {
- $a = function &() use(&$b) {
- return $b; // do not fix
- };
- return $a; // fix
- }
- function E()
- {
- $a = function &() {
- $z = new A(); return $z; // do not fix
- };
- return $a; // fix
- }
- function A99()
- {
- $v = static function ($a, $b) use ($z) {};
- $a = 15;
- return $a;
- }
- ',
- ];
- yield 'arrow functions' => [
- '<?php
- function Foo() {
- return fn($x) => $x + $y;
- }
- ',
- '<?php
- function Foo() {
- $fn1 = fn($x) => $x + $y;
- return $fn1;
- }
- ',
- ];
- yield 'try catch' => [
- '<?php
- function foo()
- {
- if (isSomeCondition()) {
- return getSomeResult();
- }
- try {
- $result = getResult();
- return $result;
- } catch (\Throwable $exception) {
- baz($result ?? null);
- }
- }
- ',
- '<?php
- function foo()
- {
- if (isSomeCondition()) {
- $result = getSomeResult();
- return $result;
- }
- try {
- $result = getResult();
- return $result;
- } catch (\Throwable $exception) {
- baz($result ?? null);
- }
- }
- ',
- ];
- yield 'multiple try/catch blocks separated with conditional return' => [
- '<?php
- function foo()
- {
- try {
- return getResult();
- } catch (\Throwable $exception) {
- error_log($exception->getMessage());
- }
- if (isSomeCondition()) {
- return getSomeResult();
- }
- try {
- $result = $a + $b;
- return $result;
- } catch (\Throwable $th) {
- var_dump($result ?? null);
- }
- }
- ',
- '<?php
- function foo()
- {
- try {
- $result = getResult();
- return $result;
- } catch (\Throwable $exception) {
- error_log($exception->getMessage());
- }
- if (isSomeCondition()) {
- $result = getSomeResult();
- return $result;
- }
- try {
- $result = $a + $b;
- return $result;
- } catch (\Throwable $th) {
- var_dump($result ?? null);
- }
- }
- ',
- ];
- yield 'try/catch/finally' => [
- '<?php
- function foo()
- {
- if (isSomeCondition()) {
- return getSomeResult();
- }
- try {
- $result = getResult();
- return $result;
- } catch (\Throwable $exception) {
- error_log($exception->getMessage());
- } finally {
- baz($result);
- }
- }
- ',
- '<?php
- function foo()
- {
- if (isSomeCondition()) {
- $result = getSomeResult();
- return $result;
- }
- try {
- $result = getResult();
- return $result;
- } catch (\Throwable $exception) {
- error_log($exception->getMessage());
- } finally {
- baz($result);
- }
- }
- ',
- ];
- yield 'multiple try/catch separated with conditional return, with finally block' => [
- '<?php
- function foo()
- {
- try {
- return getResult();
- } catch (\Throwable $exception) {
- error_log($exception->getMessage());
- }
- if (isSomeCondition()) {
- return getSomeResult();
- }
- try {
- $result = $a + $b;
- return $result;
- } catch (\Throwable $th) {
- throw $th;
- } finally {
- echo "result:", $result, \PHP_EOL;
- }
- }
- ',
- '<?php
- function foo()
- {
- try {
- $result = getResult();
- return $result;
- } catch (\Throwable $exception) {
- error_log($exception->getMessage());
- }
- if (isSomeCondition()) {
- $result = getSomeResult();
- return $result;
- }
- try {
- $result = $a + $b;
- return $result;
- } catch (\Throwable $th) {
- throw $th;
- } finally {
- echo "result:", $result, \PHP_EOL;
- }
- }
- ',
- ];
- }
- /**
- * @dataProvider provideDoNotFixCases
- */
- public function testDoNotFix(string $expected): void
- {
- $this->doTest($expected);
- }
- /**
- * @return iterable<array{0: non-empty-string, 1?: non-empty-string}>
- */
- public static function provideDoNotFixCases(): iterable
- {
- yield 'invalid reference stays invalid' => [
- '<?php
- function bar() {
- $foo = &foo();
- return $foo;
- }',
- ];
- yield 'static' => [
- '<?php
- function a() {
- static $a;
- $a = time();
- return $a;
- }
- ',
- ];
- yield 'global' => [
- '<?php
- function a() {
- global $a;
- $a = time();
- return $a;
- }
- ',
- ];
- yield 'passed by reference' => [
- '<?php
- function foo(&$var)
- {
- $var = 1;
- return $var;
- }
- ',
- ];
- yield 'not in function scope' => [
- '<?php
- $a = 1; // var might be global here
- return $a;
- ',
- ];
- yield 'open-close with ;' => [
- '<?php
- function a()
- {
- $a = 1;
- ?>
- <?php
- ;
- return $a;
- }
- ',
- ];
- yield 'open-close single line' => [
- '<?php
- function a()
- {
- $a = 1 ?><?php return $a;
- }',
- ];
- yield 'open-close' => [
- '<?php
- function a()
- {
- $a = 1
- ?>
- <?php
- return $a;
- }
- ',
- ];
- yield 'open-close before function' => [
- '<?php
- $zz = 1 ?><?php
- function a($zz)
- {
- ;
- return $zz;
- }
- ',
- ];
- yield 'return complex statement' => [
- '<?php
- function a($c)
- {
- $a = 1;
- return $a + $c;
- }
- ',
- ];
- yield 'array assign' => [
- '<?php
- function a($c)
- {
- $_SERVER["abc"] = 3;
- return $_SERVER;
- }
- ',
- ];
- yield 'if assign' => [
- '<?php
- function foo ($bar)
- {
- $a = 123;
- if ($bar)
- $a = 12345;
- return $a;
- }
- ',
- ];
- yield 'else assign' => [
- '<?php
- function foo ($bar)
- {
- $a = 123;
- if ($bar)
- ;
- else
- $a = 12345;
- return $a;
- }
- ',
- ];
- yield 'elseif assign' => [
- '<?php
- function foo ($bar)
- {
- $a = 123;
- if ($bar)
- ;
- elseif($b)
- $a = 12345;
- return $a;
- }
- ',
- ];
- yield 'echo $a = N / comment $a = N;' => [
- '<?php
- function a($c)
- {
- $a = 1;
- echo $a."=1";
- return $a;
- }
- function b($c)
- {
- $a = 1;
- echo $a."=1;";
- return $a;
- }
- function c($c)
- {
- $a = 1;
- echo $a;
- // $a =1;
- return $a;
- }
- ',
- ];
- yield 'if ($a = N)' => [
- '<?php
- function a($c)
- {
- if ($a = 1)
- return $a;
- }
- ',
- ];
- yield 'changed after declaration' => [
- '<?php
- function a($c)
- {
- $a = 1;
- $a += 1;
- return $a;
- }
- function b($c)
- {
- $a = 1;
- $a -= 1;
- return $a;
- }
- ',
- ];
- yield 'complex statement' => [
- '<?php
- function a($c)
- {
- $d = $c && $a = 1;
- return $a;
- }
- ',
- ];
- yield 'PHP close tag within function' => [
- '<?php
- function a($zz)
- {
- $zz = 1 ?><?php
- ;
- return $zz;
- }
- ',
- ];
- yield 'import global using "require"' => [
- '<?php
- function a()
- {
- require __DIR__."/test3.php";
- $b = 1;
- return $b;
- }
- ',
- ];
- yield 'import global using "require_once"' => [
- '<?php
- function a()
- {
- require_once __DIR__."/test3.php";
- $b = 1;
- return $b;
- }
- ',
- ];
- yield 'import global using "include"' => [
- '<?php
- function a()
- {
- include __DIR__."/test3.php";
- $b = 1;
- return $b;
- }
- ',
- ];
- yield 'import global using "include_once"' => [
- '<?php
- function a()
- {
- include_once __DIR__."/test3.php";
- $b = 1;
- return $b;
- }
- ',
- ];
- yield 'eval' => [
- '<?php
- $b = function ($z) {
- $c = eval($z);
- return $c;
- };
- $c = function ($x) {
- $x = eval($x);
- $x = 1;
- return $x;
- };
- ',
- ];
- yield '${X}' => [
- '<?php
- function A($g)
- {
- $h = ${$g};
- return $h;
- }
- ',
- ];
- yield '$$' => [
- '<?php
- function B($c)
- {
- $b = $$c;
- return $b;
- }
- ',
- ];
- yield [
- '<?php
- class XYZ
- {
- public function test1()
- {
- $GLOBALS[\'a\'] = 2;
- return $GLOBALS;
- }
- public function test2()
- {
- $_server = 2;
- return $_server;
- }
- public function __destruct()
- {
- $GLOBALS[\'a\'] = 2;
- return $GLOBALS[\'a\']; // destruct cannot return but still lints
- }
- };
- $a = new XYZ();
- $a = 1;
- var_dump($a); // $a = 2 here _╯°□°╯︵┻━┻
- ',
- ];
- yield 'variable returned by reference in function' => [
- '<?php
- function &foo() {
- $var = 1;
- return $var;
- }',
- ];
- yield 'variable returned by reference in method' => [
- '<?php
- class Foo {
- public function &bar() {
- $var = 1;
- return $var;
- }
- }',
- ];
- yield 'variable returned by reference in lambda' => [
- '<?php $a = function &() {$z = new A(); return $z;};',
- ];
- yield [
- '<?php
- function F() {
- $a = 1;
- while(bar()) {
- ++$a;
- }; // keep this
- return $a;
- }
- ',
- ];
- yield 'try/catch/finally' => [
- '<?php
- function add($a, $b): mixed
- {
- try {
- $result = $a + $b;
- return $result;
- } catch (\Throwable $th) {
- throw $th;
- } finally {
- echo \'result:\', $result, \PHP_EOL;
- }
- }
- ',
- ];
- yield 'try with multiple catch blocks' => [
- '<?php
- function foo() {
- try {
- $bar = bar();
- return $bar;
- } catch (\LogicException $e) {
- echo "catch ... ";
- } catch (\RuntimeException $e) {
- echo $bar;
- }
- }',
- ];
- yield 'try/catch/finally with some comments' => [
- '<?php
- function add($a, $b): mixed
- {
- try {
- $result = $a + $b;
- return $result;
- } /* foo */ catch /** bar */ (\LogicException $th) {
- throw $th;
- }
- // Or maybe this....
- catch (\RuntimeException $th) {
- throw $th;
- }
- # Print the result anyway
- finally {
- echo \'result:\', $result, \PHP_EOL;
- }
- }
- ',
- ];
- }
- /**
- * @dataProvider provideDoNotFix80Cases
- *
- * @requires PHP 8.0
- */
- public function testDoNotFix80(string $expected): void
- {
- $this->doTest($expected);
- }
- /**
- * @return iterable<array{0: non-empty-string, 1?: non-empty-string}>
- */
- public static function provideDoNotFix80Cases(): iterable
- {
- yield 'try with non-capturing catch block' => [
- '<?php
- function add($a, $b): mixed
- {
- try {
- $result = $a + $b;
- return $result;
- }
- catch (\Throwable) {
- noop();
- }
- finally {
- echo \'result:\', $result, \PHP_EOL;
- }
- }
- ',
- ];
- }
- /**
- * @dataProvider provideRepetitiveFixCases
- */
- public function testRepetitiveFix(string $expected, ?string $input = null): void
- {
- $this->doTest($expected, $input);
- }
- /**
- * @return iterable<array{0: non-empty-string, 1?: non-empty-string}>
- */
- public static function provideRepetitiveFixCases(): iterable
- {
- yield [
- '<?php
- function foo() {
- return bar();
- }
- ',
- '<?php
- function foo() {
- $a = bar();
- $b = $a;
- return $b;
- }
- ',
- ];
- yield [
- '<?php
- function foo(&$c) {
- $a = $c;
- $b = $a;
- return $b;
- }
- ',
- ];
- $expected = "<?php\n";
- $input = "<?php\n";
- for ($i = 0; $i < 10; ++$i) {
- $expected .= \sprintf("\nfunction foo%d() {\n\treturn bar();\n}", $i);
- $input .= \sprintf("\nfunction foo%d() {\n\t\$a = bar();\n\t\$b = \$a;\n\nreturn \$b;\n}", $i);
- }
- yield [$expected, $input];
- }
- /**
- * @requires PHP 8.0
- *
- * @dataProvider provideFix80Cases
- */
- public function testFix80(string $expected, ?string $input = null): void
- {
- $this->doTest($expected, $input);
- }
- /**
- * @return iterable<array{0: non-empty-string, 1?: non-empty-string}>
- */
- public static function provideFix80Cases(): iterable
- {
- yield 'match' => [
- '<?php
- function Foo($food) {
- return match ($food) {
- "apple" => "This food is an apple",
- "cake" => "This food is a cake",
- };
- }
- ',
- '<?php
- function Foo($food) {
- $return_value = match ($food) {
- "apple" => "This food is an apple",
- "cake" => "This food is a cake",
- };
- return $return_value;
- }
- ',
- ];
- yield 'attribute before anonymous `class`' => [
- '<?php
- function A()
- {
- return new #[Foo] class {};
- }
- ',
- '<?php
- function A()
- {
- $a = new #[Foo] class {};
- return $a;
- }
- ',
- ];
- }
- /**
- * @requires PHP 8.3
- *
- * @dataProvider provideFixPhp83Cases
- */
- public function testFixPhp83(string $expected, ?string $input = null): void
- {
- $this->doTest($expected, $input);
- }
- /**
- * @return iterable<array{0: non-empty-string, 1?: non-empty-string}>
- */
- public static function provideFixPhp83Cases(): iterable
- {
- yield 'anonymous readonly class' => [
- '<?php
- function A()
- {
- return new readonly class {};
- }
- ',
- '<?php
- function A()
- {
- $a = new readonly class {};
- return $a;
- }
- ',
- ];
- yield 'attribute before anonymous `readonly class`' => [
- '<?php
- function A()
- {
- return new #[Foo] readonly class {};
- }
- ',
- '<?php
- function A()
- {
- $a = new #[Foo] readonly class {};
- return $a;
- }
- ',
- ];
- }
- }
|