FixerFactoryTest.php 28 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583
  1. <?php
  2. /*
  3. * This file is part of PHP CS Fixer.
  4. *
  5. * (c) Fabien Potencier <fabien@symfony.com>
  6. * Dariusz Rumiński <dariusz.ruminski@gmail.com>
  7. *
  8. * This source file is subject to the MIT license that is bundled
  9. * with this source code in the file LICENSE.
  10. */
  11. namespace PhpCsFixer\Tests\AutoReview;
  12. use PhpCsFixer\Fixer\FixerInterface;
  13. use PhpCsFixer\FixerFactory;
  14. use PhpCsFixer\Tests\Test\IntegrationCaseFactory;
  15. use PhpCsFixer\Tests\TestCase;
  16. use Symfony\Component\Finder\SplFileInfo;
  17. /**
  18. * @author Dariusz Rumiński <dariusz.ruminski@gmail.com>
  19. *
  20. * @internal
  21. *
  22. * @coversNothing
  23. * @group auto-review
  24. * @group covers-nothing
  25. */
  26. final class FixerFactoryTest extends TestCase
  27. {
  28. public function testFixersPriorityEdgeFixers()
  29. {
  30. $factory = new FixerFactory();
  31. $factory->registerBuiltInFixers();
  32. $fixers = $factory->getFixers();
  33. static::assertSame('encoding', $fixers[0]->getName(), 'Expected "encoding" fixer to have the highest priority.');
  34. static::assertSame('full_opening_tag', $fixers[1]->getName(), 'Expected "full_opening_tag" fixer has second highest priority.');
  35. static::assertSame('single_blank_line_at_eof', $fixers[\count($fixers) - 1]->getName(), 'Expected "single_blank_line_at_eof" to have the lowest priority.');
  36. }
  37. /**
  38. * @dataProvider provideFixersPriorityCases
  39. * @dataProvider provideFixersPrioritySpecialPhpdocCases
  40. */
  41. public function testFixersPriority(FixerInterface $first, FixerInterface $second)
  42. {
  43. static::assertLessThan($first->getPriority(), $second->getPriority(), sprintf('"%s" should have less priority than "%s"', \get_class($second), \get_class($first)));
  44. }
  45. public function provideFixersPriorityCases()
  46. {
  47. $factory = new FixerFactory();
  48. $factory->registerBuiltInFixers();
  49. $fixers = [];
  50. foreach ($factory->getFixers() as $fixer) {
  51. $fixers[$fixer->getName()] = $fixer;
  52. }
  53. return [
  54. [$fixers['array_indentation'], $fixers['align_multiline_comment']],
  55. [$fixers['array_indentation'], $fixers['binary_operator_spaces']],
  56. [$fixers['array_syntax'], $fixers['binary_operator_spaces']],
  57. [$fixers['array_syntax'], $fixers['ternary_operator_spaces']],
  58. [$fixers['backtick_to_shell_exec'], $fixers['escape_implicit_backslashes']],
  59. [$fixers['backtick_to_shell_exec'], $fixers['explicit_string_variable']],
  60. [$fixers['blank_line_after_opening_tag'], $fixers['no_blank_lines_before_namespace']],
  61. [$fixers['braces'], $fixers['array_indentation']],
  62. [$fixers['braces'], $fixers['method_argument_space']],
  63. [$fixers['braces'], $fixers['method_chaining_indentation']],
  64. [$fixers['class_attributes_separation'], $fixers['braces']],
  65. [$fixers['class_attributes_separation'], $fixers['indentation_type']],
  66. [$fixers['class_keyword_remove'], $fixers['no_unused_imports']],
  67. [$fixers['combine_consecutive_issets'], $fixers['multiline_whitespace_before_semicolons']],
  68. [$fixers['combine_consecutive_issets'], $fixers['no_singleline_whitespace_before_semicolons']],
  69. [$fixers['combine_consecutive_issets'], $fixers['no_spaces_inside_parenthesis']],
  70. [$fixers['combine_consecutive_issets'], $fixers['no_trailing_whitespace']],
  71. [$fixers['combine_consecutive_issets'], $fixers['no_whitespace_in_blank_line']],
  72. [$fixers['combine_consecutive_unsets'], $fixers['no_extra_blank_lines']],
  73. [$fixers['combine_consecutive_unsets'], $fixers['no_trailing_whitespace']],
  74. [$fixers['combine_consecutive_unsets'], $fixers['no_whitespace_in_blank_line']],
  75. [$fixers['combine_consecutive_unsets'], $fixers['space_after_semicolon']],
  76. [$fixers['combine_nested_dirname'], $fixers['method_argument_space']],
  77. [$fixers['combine_nested_dirname'], $fixers['no_spaces_inside_parenthesis']],
  78. [$fixers['declare_strict_types'], $fixers['blank_line_after_opening_tag']],
  79. [$fixers['declare_strict_types'], $fixers['declare_equal_normalize']],
  80. [$fixers['dir_constant'], $fixers['combine_nested_dirname']],
  81. [$fixers['doctrine_annotation_array_assignment'], $fixers['doctrine_annotation_spaces']],
  82. [$fixers['elseif'], $fixers['braces']],
  83. [$fixers['escape_implicit_backslashes'], $fixers['heredoc_to_nowdoc']],
  84. [$fixers['escape_implicit_backslashes'], $fixers['single_quote']],
  85. [$fixers['explicit_string_variable'], $fixers['simple_to_complex_string_variable']],
  86. [$fixers['fully_qualified_strict_types'], $fixers['no_superfluous_phpdoc_tags']],
  87. [$fixers['function_to_constant'], $fixers['native_function_casing']],
  88. [$fixers['function_to_constant'], $fixers['no_extra_blank_lines']],
  89. [$fixers['function_to_constant'], $fixers['no_singleline_whitespace_before_semicolons']],
  90. [$fixers['function_to_constant'], $fixers['no_trailing_whitespace']],
  91. [$fixers['function_to_constant'], $fixers['no_whitespace_in_blank_line']],
  92. [$fixers['general_phpdoc_annotation_remove'], $fixers['no_empty_phpdoc']],
  93. [$fixers['general_phpdoc_annotation_remove'], $fixers['phpdoc_separation']],
  94. [$fixers['general_phpdoc_annotation_remove'], $fixers['phpdoc_trim']],
  95. [$fixers['implode_call'], $fixers['method_argument_space']],
  96. [$fixers['indentation_type'], $fixers['phpdoc_indent']],
  97. [$fixers['is_null'], $fixers['yoda_style']],
  98. [$fixers['line_ending'], $fixers['braces']],
  99. [$fixers['list_syntax'], $fixers['binary_operator_spaces']],
  100. [$fixers['list_syntax'], $fixers['ternary_operator_spaces']],
  101. [$fixers['method_chaining_indentation'], $fixers['array_indentation']],
  102. [$fixers['method_separation'], $fixers['braces']],
  103. [$fixers['method_separation'], $fixers['indentation_type']],
  104. [$fixers['multiline_whitespace_before_semicolons'], $fixers['space_after_semicolon']],
  105. [$fixers['no_alias_functions'], $fixers['implode_call']],
  106. [$fixers['no_alias_functions'], $fixers['php_unit_dedicate_assert']],
  107. [$fixers['no_alternative_syntax'], $fixers['braces']],
  108. [$fixers['no_alternative_syntax'], $fixers['elseif']],
  109. [$fixers['no_alternative_syntax'], $fixers['no_superfluous_elseif']],
  110. [$fixers['no_alternative_syntax'], $fixers['no_useless_else']],
  111. [$fixers['no_blank_lines_after_phpdoc'], $fixers['header_comment']],
  112. [$fixers['no_blank_lines_after_phpdoc'], $fixers['single_blank_line_before_namespace']],
  113. [$fixers['no_empty_comment'], $fixers['no_extra_blank_lines']],
  114. [$fixers['no_empty_comment'], $fixers['no_trailing_whitespace']],
  115. [$fixers['no_empty_comment'], $fixers['no_whitespace_in_blank_line']],
  116. [$fixers['no_empty_phpdoc'], $fixers['no_extra_blank_lines']],
  117. [$fixers['no_empty_phpdoc'], $fixers['no_trailing_whitespace']],
  118. [$fixers['no_empty_phpdoc'], $fixers['no_whitespace_in_blank_line']],
  119. [$fixers['no_empty_statement'], $fixers['braces']],
  120. [$fixers['no_empty_statement'], $fixers['combine_consecutive_unsets']],
  121. [$fixers['no_empty_statement'], $fixers['multiline_whitespace_before_semicolons']],
  122. [$fixers['no_empty_statement'], $fixers['no_extra_blank_lines']],
  123. [$fixers['no_empty_statement'], $fixers['no_singleline_whitespace_before_semicolons']],
  124. [$fixers['no_empty_statement'], $fixers['no_trailing_whitespace']],
  125. [$fixers['no_empty_statement'], $fixers['no_useless_else']],
  126. [$fixers['no_empty_statement'], $fixers['no_useless_return']],
  127. [$fixers['no_empty_statement'], $fixers['no_whitespace_in_blank_line']],
  128. [$fixers['no_empty_statement'], $fixers['return_assignment']],
  129. [$fixers['no_empty_statement'], $fixers['space_after_semicolon']],
  130. [$fixers['no_empty_statement'], $fixers['switch_case_semicolon_to_colon']],
  131. [$fixers['no_extra_blank_lines'], $fixers['blank_line_before_statement']],
  132. [$fixers['no_leading_import_slash'], $fixers['ordered_imports']],
  133. [$fixers['no_multiline_whitespace_around_double_arrow'], $fixers['binary_operator_spaces']],
  134. [$fixers['no_multiline_whitespace_around_double_arrow'], $fixers['trailing_comma_in_multiline_array']],
  135. [$fixers['no_php4_constructor'], $fixers['ordered_class_elements']],
  136. [$fixers['no_short_bool_cast'], $fixers['cast_spaces']],
  137. [$fixers['no_short_echo_tag'], $fixers['no_mixed_echo_print']],
  138. [$fixers['no_spaces_after_function_name'], $fixers['function_to_constant']],
  139. [$fixers['no_spaces_inside_parenthesis'], $fixers['function_to_constant']],
  140. [$fixers['no_superfluous_phpdoc_tags'], $fixers['no_empty_phpdoc']],
  141. [$fixers['no_unneeded_control_parentheses'], $fixers['no_trailing_whitespace']],
  142. [$fixers['no_unneeded_curly_braces'], $fixers['no_useless_else']],
  143. [$fixers['no_unneeded_curly_braces'], $fixers['no_useless_return']],
  144. [$fixers['no_unset_on_property'], $fixers['combine_consecutive_unsets']],
  145. [$fixers['no_unused_imports'], $fixers['blank_line_after_namespace']],
  146. [$fixers['no_unused_imports'], $fixers['no_extra_blank_lines']],
  147. [$fixers['no_unused_imports'], $fixers['no_leading_import_slash']],
  148. [$fixers['no_unused_imports'], $fixers['single_line_after_imports']],
  149. [$fixers['no_useless_else'], $fixers['braces']],
  150. [$fixers['no_useless_else'], $fixers['combine_consecutive_unsets']],
  151. [$fixers['no_useless_else'], $fixers['no_extra_blank_lines']],
  152. [$fixers['no_useless_else'], $fixers['no_trailing_whitespace']],
  153. [$fixers['no_useless_else'], $fixers['no_useless_return']],
  154. [$fixers['no_useless_else'], $fixers['no_whitespace_in_blank_line']],
  155. [$fixers['no_useless_return'], $fixers['blank_line_before_return']],
  156. [$fixers['no_useless_return'], $fixers['blank_line_before_statement']],
  157. [$fixers['no_useless_return'], $fixers['no_extra_blank_lines']],
  158. [$fixers['no_useless_return'], $fixers['no_whitespace_in_blank_line']],
  159. [$fixers['ordered_class_elements'], $fixers['class_attributes_separation']],
  160. [$fixers['ordered_class_elements'], $fixers['method_separation']],
  161. [$fixers['ordered_class_elements'], $fixers['no_blank_lines_after_class_opening']],
  162. [$fixers['ordered_class_elements'], $fixers['space_after_semicolon']],
  163. [$fixers['php_unit_construct'], $fixers['php_unit_dedicate_assert']],
  164. [$fixers['php_unit_dedicate_assert'], $fixers['php_unit_dedicate_assert_internal_type']],
  165. [$fixers['php_unit_fqcn_annotation'], $fixers['no_unused_imports']],
  166. [$fixers['php_unit_fqcn_annotation'], $fixers['php_unit_ordered_covers']],
  167. [$fixers['php_unit_internal_class'], $fixers['final_internal_class']],
  168. [$fixers['php_unit_no_expectation_annotation'], $fixers['no_empty_phpdoc']],
  169. [$fixers['php_unit_no_expectation_annotation'], $fixers['php_unit_expectation']],
  170. [$fixers['php_unit_test_annotation'], $fixers['no_empty_phpdoc']],
  171. [$fixers['php_unit_test_annotation'], $fixers['php_unit_method_casing']],
  172. [$fixers['php_unit_test_annotation'], $fixers['phpdoc_trim']],
  173. [$fixers['phpdoc_add_missing_param_annotation'], $fixers['no_empty_phpdoc']],
  174. [$fixers['phpdoc_add_missing_param_annotation'], $fixers['no_superfluous_phpdoc_tags']],
  175. [$fixers['phpdoc_add_missing_param_annotation'], $fixers['phpdoc_align']],
  176. [$fixers['phpdoc_add_missing_param_annotation'], $fixers['phpdoc_order']],
  177. [$fixers['phpdoc_no_access'], $fixers['no_empty_phpdoc']],
  178. [$fixers['phpdoc_no_access'], $fixers['phpdoc_order']],
  179. [$fixers['phpdoc_no_access'], $fixers['phpdoc_separation']],
  180. [$fixers['phpdoc_no_access'], $fixers['phpdoc_trim']],
  181. [$fixers['phpdoc_no_alias_tag'], $fixers['phpdoc_add_missing_param_annotation']],
  182. [$fixers['phpdoc_no_alias_tag'], $fixers['phpdoc_single_line_var_spacing']],
  183. [$fixers['phpdoc_no_empty_return'], $fixers['no_empty_phpdoc']],
  184. [$fixers['phpdoc_no_empty_return'], $fixers['phpdoc_order']],
  185. [$fixers['phpdoc_no_empty_return'], $fixers['phpdoc_separation']],
  186. [$fixers['phpdoc_no_empty_return'], $fixers['phpdoc_trim']],
  187. [$fixers['phpdoc_no_package'], $fixers['no_empty_phpdoc']],
  188. [$fixers['phpdoc_no_package'], $fixers['phpdoc_order']],
  189. [$fixers['phpdoc_no_package'], $fixers['phpdoc_separation']],
  190. [$fixers['phpdoc_no_package'], $fixers['phpdoc_trim']],
  191. [$fixers['phpdoc_no_useless_inheritdoc'], $fixers['no_empty_phpdoc']],
  192. [$fixers['phpdoc_no_useless_inheritdoc'], $fixers['no_trailing_whitespace_in_comment']],
  193. [$fixers['phpdoc_order'], $fixers['phpdoc_separation']],
  194. [$fixers['phpdoc_order'], $fixers['phpdoc_trim']],
  195. [$fixers['phpdoc_return_self_reference'], $fixers['no_superfluous_phpdoc_tags']],
  196. [$fixers['phpdoc_scalar'], $fixers['phpdoc_to_return_type']],
  197. [$fixers['phpdoc_to_comment'], $fixers['no_empty_comment']],
  198. [$fixers['phpdoc_to_comment'], $fixers['phpdoc_no_useless_inheritdoc']],
  199. [$fixers['phpdoc_to_return_type'], $fixers['fully_qualified_strict_types']],
  200. [$fixers['phpdoc_to_return_type'], $fixers['no_superfluous_phpdoc_tags']],
  201. [$fixers['phpdoc_to_return_type'], $fixers['return_type_declaration']],
  202. [$fixers['phpdoc_types'], $fixers['phpdoc_to_return_type']],
  203. [$fixers['pow_to_exponentiation'], $fixers['binary_operator_spaces']],
  204. [$fixers['pow_to_exponentiation'], $fixers['method_argument_space']],
  205. [$fixers['pow_to_exponentiation'], $fixers['native_function_casing']],
  206. [$fixers['pow_to_exponentiation'], $fixers['no_spaces_after_function_name']],
  207. [$fixers['pow_to_exponentiation'], $fixers['no_spaces_inside_parenthesis']],
  208. [$fixers['protected_to_private'], $fixers['ordered_class_elements']],
  209. [$fixers['return_assignment'], $fixers['blank_line_before_statement']],
  210. [$fixers['simplified_null_return'], $fixers['no_useless_return']],
  211. [$fixers['single_import_per_statement'], $fixers['multiline_whitespace_before_semicolons']],
  212. [$fixers['single_import_per_statement'], $fixers['no_leading_import_slash']],
  213. [$fixers['single_import_per_statement'], $fixers['no_singleline_whitespace_before_semicolons']],
  214. [$fixers['single_import_per_statement'], $fixers['no_unused_imports']],
  215. [$fixers['single_import_per_statement'], $fixers['space_after_semicolon']],
  216. [$fixers['single_trait_insert_per_statement'], $fixers['braces']],
  217. [$fixers['single_trait_insert_per_statement'], $fixers['space_after_semicolon']],
  218. [$fixers['standardize_increment'], $fixers['increment_style']],
  219. [$fixers['standardize_not_equals'], $fixers['binary_operator_spaces']],
  220. [$fixers['strict_comparison'], $fixers['binary_operator_spaces']],
  221. [$fixers['unary_operator_spaces'], $fixers['not_operator_with_space']],
  222. [$fixers['unary_operator_spaces'], $fixers['not_operator_with_successor_space']],
  223. [$fixers['void_return'], $fixers['phpdoc_no_empty_return']],
  224. [$fixers['void_return'], $fixers['return_type_declaration']],
  225. ];
  226. }
  227. public function provideFixersPrioritySpecialPhpdocCases()
  228. {
  229. $factory = new FixerFactory();
  230. $factory->registerBuiltInFixers();
  231. $fixers = [];
  232. foreach ($factory->getFixers() as $fixer) {
  233. $fixers[$fixer->getName()] = $fixer;
  234. }
  235. $cases = [];
  236. // prepare bulk tests for phpdoc fixers to test that:
  237. // * `comment_to_phpdoc` is first
  238. // * `phpdoc_to_comment` is second
  239. // * `phpdoc_indent` is third
  240. // * `phpdoc_types` is fourth
  241. // * `phpdoc_scalar` is fifth
  242. // * `phpdoc_align` is last
  243. $cases[] = [$fixers['comment_to_phpdoc'], $fixers['phpdoc_to_comment']];
  244. $cases[] = [$fixers['phpdoc_indent'], $fixers['phpdoc_types']];
  245. $cases[] = [$fixers['phpdoc_to_comment'], $fixers['phpdoc_indent']];
  246. $cases[] = [$fixers['phpdoc_types'], $fixers['phpdoc_scalar']];
  247. $docFixerNames = array_filter(
  248. array_keys($fixers),
  249. static function ($name) {
  250. return false !== strpos($name, 'phpdoc');
  251. }
  252. );
  253. foreach ($docFixerNames as $docFixerName) {
  254. if (!\in_array($docFixerName, ['comment_to_phpdoc', 'phpdoc_to_comment', 'phpdoc_indent', 'phpdoc_types', 'phpdoc_scalar'], true)) {
  255. $cases[] = [$fixers['comment_to_phpdoc'], $fixers[$docFixerName]];
  256. $cases[] = [$fixers['phpdoc_indent'], $fixers[$docFixerName]];
  257. $cases[] = [$fixers['phpdoc_scalar'], $fixers[$docFixerName]];
  258. $cases[] = [$fixers['phpdoc_to_comment'], $fixers[$docFixerName]];
  259. $cases[] = [$fixers['phpdoc_types'], $fixers[$docFixerName]];
  260. }
  261. if ('phpdoc_align' !== $docFixerName) {
  262. $cases[] = [$fixers[$docFixerName], $fixers['phpdoc_align']];
  263. }
  264. }
  265. return $cases;
  266. }
  267. /**
  268. * @dataProvider provideFixersPriorityPairsHaveIntegrationTestCases
  269. */
  270. public function testFixersPriorityPairsHaveIntegrationTest(FixerInterface $first, FixerInterface $second)
  271. {
  272. // This structure contains older cases that are not yet covered by tests.
  273. // It may only shrink, never add anything to it.
  274. $casesWithoutTests = [
  275. 'indentation_type,phpdoc_indent.test',
  276. 'phpdoc_no_access,phpdoc_order.test',
  277. 'phpdoc_no_package,phpdoc_order.test',
  278. ];
  279. $integrationTestName = $this->generateIntegrationTestName($first, $second);
  280. $file = $this->getIntegrationPriorityDirectory().$integrationTestName;
  281. if (is_file($file)) {
  282. $description = sprintf('Integration of fixers: %s,%s.', $first->getName(), $second->getName());
  283. $integrationTestExists = true;
  284. } else {
  285. $file = $this->getIntegrationPriorityDirectory().$this->generateIntegrationTestName($second, $first);
  286. $description = sprintf('Integration of fixers: %s,%s.', $second->getName(), $first->getName());
  287. $integrationTestExists = is_file($file);
  288. }
  289. if (\in_array($integrationTestName, $casesWithoutTests, true)) {
  290. static::assertFalse($integrationTestExists, sprintf('Case "%s" already has an integration test, so it should be removed from "$casesWithoutTests".', $integrationTestName));
  291. static::markTestIncomplete(sprintf('Case "%s" has no integration test yet, please help and add it.', $integrationTestName));
  292. }
  293. static::assertTrue($integrationTestExists, sprintf('There shall be an integration test "%s". How do you know that priority set up is good, if there is no integration test to check it?', $integrationTestName));
  294. $file = realpath($file);
  295. $factory = new IntegrationCaseFactory();
  296. $test = $factory->create(new SplFileInfo($file, './', __DIR__));
  297. $rules = $test->getRuleset()->getRules();
  298. $expected = [$first->getName(), $second->getName()];
  299. $actual = array_keys($rules);
  300. sort($expected);
  301. sort($actual);
  302. static::assertSame($description, $test->getTitle(), sprintf('Please fix the title in "%s".', $file));
  303. static::assertCount(2, $rules, sprintf('Only the two rules that are tested for priority should be in the ruleset of "%s".', $file));
  304. foreach ($rules as $name => $config) {
  305. static::assertNotFalse($config, sprintf('The rule "%s" in "%s" may not be disabled for the test.', $name, $file));
  306. }
  307. static::assertSame($expected, $actual, sprintf('The ruleset of "%s" must contain the rules for the priority test.', $file));
  308. }
  309. public function provideFixersPriorityPairsHaveIntegrationTestCases()
  310. {
  311. return array_filter(
  312. $this->provideFixersPriorityCases(),
  313. // ignore speed-up only priorities set up
  314. function (array $case) {
  315. return !\in_array(
  316. $this->generateIntegrationTestName($case[0], $case[1]),
  317. [
  318. 'function_to_constant,native_function_casing.test',
  319. 'no_unused_imports,no_leading_import_slash.test',
  320. 'pow_to_exponentiation,method_argument_space.test',
  321. 'pow_to_exponentiation,native_function_casing.test',
  322. 'pow_to_exponentiation,no_spaces_after_function_name.test',
  323. 'pow_to_exponentiation,no_spaces_inside_parenthesis.test',
  324. ],
  325. true
  326. );
  327. }
  328. );
  329. }
  330. public function testPriorityIntegrationDirectoryOnlyContainsFiles()
  331. {
  332. foreach (new \DirectoryIterator($this->getIntegrationPriorityDirectory()) as $candidate) {
  333. if ($candidate->isDot()) {
  334. continue;
  335. }
  336. $fileName = $candidate->getFilename();
  337. static::assertTrue($candidate->isFile(), sprintf('Expected only files in the priority integration test directory, got "%s".', $fileName));
  338. static::assertFalse($candidate->isLink(), sprintf('No (sym)links expected the priority integration test directory, got "%s".', $fileName));
  339. }
  340. }
  341. /**
  342. * @dataProvider provideIntegrationTestFilesCases
  343. *
  344. * @param string $fileName
  345. */
  346. public function testPriorityIntegrationTestFilesAreListedPriorityCases($fileName)
  347. {
  348. static $priorityCases;
  349. if (null === $priorityCases) {
  350. $priorityCases = [];
  351. foreach ($this->provideFixersPriorityCases() as $priorityCase) {
  352. $fixerName = $priorityCase[0]->getName();
  353. if (!isset($priorityCases[$fixerName])) {
  354. $priorityCases[$fixerName] = [];
  355. }
  356. $priorityCases[$fixerName][$priorityCase[1]->getName()] = true;
  357. }
  358. ksort($priorityCases);
  359. }
  360. if (\in_array($fileName, [
  361. 'braces,indentation_type,no_break_comment.test',
  362. ], true)) {
  363. static::markTestIncomplete(sprintf('Case "%s" has unexpected name, please help fixing it.', $fileName));
  364. }
  365. static::assertSame(
  366. 1,
  367. preg_match('#^([a-z][a-z0-9_]*),([a-z][a-z_]*)(?:_\d{1,3})?\.test(-(in|out)\.php)?$#', $fileName, $matches),
  368. sprintf('File with unexpected name "%s" in the priority integration test directory.', $fileName)
  369. );
  370. $fixerName1 = $matches[1];
  371. $fixerName2 = $matches[2];
  372. static::assertTrue(
  373. isset($priorityCases[$fixerName1][$fixerName2]) || isset($priorityCases[$fixerName2][$fixerName1]),
  374. sprintf('Missing priority test entry for file "%s".', $fileName)
  375. );
  376. }
  377. public function provideIntegrationTestFilesCases()
  378. {
  379. $fileNames = [];
  380. foreach (new \DirectoryIterator($this->getIntegrationPriorityDirectory()) as $candidate) {
  381. if ($candidate->isDot()) {
  382. continue;
  383. }
  384. $fileNames[] = [$candidate->getFilename()];
  385. }
  386. sort($fileNames);
  387. return $fileNames;
  388. }
  389. public function testProvideFixersPriorityCasesAreSorted()
  390. {
  391. $cases = $this->provideFixersPriorityCases();
  392. $sorted = $cases;
  393. usort(
  394. $sorted,
  395. static function (array $priorityPair1, array $priorityPair2) {
  396. /** @var FixerInterface $fixer */
  397. $fixer1 = $priorityPair1[0];
  398. /** @var FixerInterface $fixer */
  399. $fixer2 = $priorityPair2[0];
  400. if ($fixer1->getName() === $fixer2->getName()) {
  401. /** @var FixerInterface $fixer */
  402. $fixer1 = $priorityPair1[1];
  403. /** @var FixerInterface $fixer */
  404. $fixer2 = $priorityPair2[1];
  405. }
  406. return strcmp($fixer1->getName(), $fixer2->getName());
  407. }
  408. );
  409. if ($sorted !== $cases) { // PHPUnit takes a very long time creating a diff view on the arrays
  410. $casesDescription = '';
  411. foreach ($cases as $pair) {
  412. $casesDescription .= sprintf("\n%s/%s", $pair[0]->getName(), $pair[1]->getName());
  413. }
  414. $sortedDescription = '';
  415. foreach ($sorted as $pair) {
  416. $sortedDescription .= sprintf("\n%s/%s", $pair[0]->getName(), $pair[1]->getName());
  417. }
  418. static::assertSame($sortedDescription, $casesDescription);
  419. } else {
  420. $this->addToAssertionCount(1);
  421. }
  422. }
  423. public function testFixerPriorityComment()
  424. {
  425. $cases = array_merge(
  426. $this->provideFixersPriorityCases(),
  427. $this->provideFixersPrioritySpecialPhpdocCases()
  428. );
  429. $map = [];
  430. foreach ($cases as $beforeAfter) {
  431. list($before, $after) = $beforeAfter;
  432. $beforeClass = \get_class($before);
  433. $afterClass = \get_class($after);
  434. $beforeName = substr($beforeClass, strrpos($beforeClass, '\\') + 1);
  435. $afterName = substr($afterClass, strrpos($afterClass, '\\') + 1);
  436. if (!isset($map[$beforeName])) {
  437. $map[$beforeName] = [
  438. 'before' => [],
  439. 'after' => [],
  440. 'class' => $beforeClass,
  441. ];
  442. }
  443. $map[$beforeName]['before'][] = $afterName;
  444. if (!isset($map[$afterName])) {
  445. $map[$afterName] = [
  446. 'before' => [],
  447. 'after' => [],
  448. 'class' => $afterClass,
  449. ];
  450. }
  451. $map[$afterName]['after'][] = $beforeName;
  452. }
  453. $fixersPhpDocIssues = [];
  454. foreach ($map as $fixerName => $priorityMap) {
  455. $expectedMessage = "/**\n * {@inheritdoc}\n *";
  456. if (\count($priorityMap['before']) > 0) {
  457. sort($priorityMap['before']);
  458. $expectedMessage .= sprintf("\n * Must run before %s.", implode(', ', $priorityMap['before']));
  459. }
  460. if (\count($priorityMap['after']) > 0) {
  461. sort($priorityMap['after']);
  462. $expectedMessage .= sprintf("\n * Must run after %s.", implode(', ', $priorityMap['after']));
  463. }
  464. $expectedMessage .= "\n */";
  465. $reflection = new \ReflectionClass($priorityMap['class']);
  466. $method = $reflection->getMethod('getPriority');
  467. $phpDoc = $method->getDocComment();
  468. if (false === $phpDoc) {
  469. $fixersPhpDocIssues[$fixerName] = sprintf("PHPDoc for %s::getPriority is missing.\nExpected:\n%s", $fixerName, $expectedMessage);
  470. continue;
  471. }
  472. if ($expectedMessage !== $phpDoc) {
  473. $fixersPhpDocIssues[$fixerName] = sprintf("PHPDoc for %s::getPriority is not as expected.\nExpected:\n%s", $fixerName, $expectedMessage);
  474. continue;
  475. }
  476. }
  477. if (0 === \count($fixersPhpDocIssues)) {
  478. $this->addToAssertionCount(1);
  479. } else {
  480. $message = sprintf("There are %d priority PHPDoc issues found.\n", \count($fixersPhpDocIssues));
  481. ksort($fixersPhpDocIssues);
  482. foreach ($fixersPhpDocIssues as $fixerName => $issue) {
  483. $message .= sprintf("\n--------------------------------------------------\n%s\n%s", $fixerName, $issue);
  484. }
  485. static::fail($message);
  486. }
  487. }
  488. /**
  489. * @return string
  490. */
  491. private function generateIntegrationTestName(FixerInterface $first, FixerInterface $second)
  492. {
  493. return "{$first->getName()},{$second->getName()}.test";
  494. }
  495. /**
  496. * @return string
  497. */
  498. private function getIntegrationPriorityDirectory()
  499. {
  500. return __DIR__.'/../Fixtures/Integration/priority/';
  501. }
  502. }