12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268 |
- <?php
- declare(strict_types=1);
- /*
- * This file is part of PHP CS Fixer.
- *
- * (c) Fabien Potencier <fabien@symfony.com>
- * Dariusz Rumiński <dariusz.ruminski@gmail.com>
- *
- * This source file is subject to the MIT license that is bundled
- * with this source code in the file LICENSE.
- */
- namespace PhpCsFixer\Tests\Console;
- use PhpCsFixer\Cache\NullCacheManager;
- use PhpCsFixer\Config;
- use PhpCsFixer\ConfigurationException\InvalidConfigurationException;
- use PhpCsFixer\Console\Command\FixCommand;
- use PhpCsFixer\Console\ConfigurationResolver;
- use PhpCsFixer\Console\Output\Progress\ProgressOutputType;
- use PhpCsFixer\Finder;
- use PhpCsFixer\Linter\LinterInterface;
- use PhpCsFixer\Tests\Fixtures\DeprecatedFixer;
- use PhpCsFixer\Tests\TestCase;
- use PhpCsFixer\ToolInfo;
- use Symfony\Component\Console\Output\OutputInterface;
- /**
- * @author Katsuhiro Ogawa <ko.fivestar@gmail.com>
- * @author Dariusz Rumiński <dariusz.ruminski@gmail.com>
- *
- * @internal
- *
- * @covers \PhpCsFixer\Console\ConfigurationResolver
- */
- final class ConfigurationResolverTest extends TestCase
- {
- public function testSetOptionWithUndefinedOption(): void
- {
- $this->expectException(InvalidConfigurationException::class);
- $this->expectExceptionMessageMatches('/^Unknown option name: "foo"\.$/');
- $this->createConfigurationResolver(['foo' => 'bar']);
- }
- public function testResolveProgressWithPositiveConfigAndPositiveOption(): void
- {
- $config = new Config();
- $config->setHideProgress(true);
- $resolver = $this->createConfigurationResolver([
- 'format' => 'txt',
- 'verbosity' => OutputInterface::VERBOSITY_VERBOSE,
- ], $config);
- self::assertSame('none', $resolver->getProgressType());
- }
- public function testResolveProgressWithPositiveConfigAndNegativeOption(): void
- {
- $config = new Config();
- $config->setHideProgress(true);
- $resolver = $this->createConfigurationResolver([
- 'format' => 'txt',
- 'verbosity' => OutputInterface::VERBOSITY_NORMAL,
- ], $config);
- self::assertSame('none', $resolver->getProgressType());
- }
- public function testResolveProgressWithNegativeConfigAndPositiveOption(): void
- {
- $config = new Config();
- $config->setHideProgress(false);
- $resolver = $this->createConfigurationResolver([
- 'format' => 'txt',
- 'verbosity' => OutputInterface::VERBOSITY_VERBOSE,
- ], $config);
- self::assertSame('dots', $resolver->getProgressType());
- }
- public function testResolveProgressWithNegativeConfigAndNegativeOption(): void
- {
- $config = new Config();
- $config->setHideProgress(false);
- $resolver = $this->createConfigurationResolver([
- 'format' => 'txt',
- 'verbosity' => OutputInterface::VERBOSITY_NORMAL,
- ], $config);
- self::assertSame('none', $resolver->getProgressType());
- }
- /**
- * @dataProvider provideProgressTypeCases
- */
- public function testResolveProgressWithPositiveConfigAndExplicitProgress(string $progressType): void
- {
- $config = new Config();
- $config->setHideProgress(true);
- $resolver = $this->createConfigurationResolver([
- 'format' => 'txt',
- 'verbosity' => OutputInterface::VERBOSITY_VERBOSE,
- 'show-progress' => $progressType,
- ], $config);
- self::assertSame($progressType, $resolver->getProgressType());
- }
- /**
- * @dataProvider provideProgressTypeCases
- */
- public function testResolveProgressWithNegativeConfigAndExplicitProgress(string $progressType): void
- {
- $config = new Config();
- $config->setHideProgress(false);
- $resolver = $this->createConfigurationResolver([
- 'format' => 'txt',
- 'verbosity' => OutputInterface::VERBOSITY_VERBOSE,
- 'show-progress' => $progressType,
- ], $config);
- self::assertSame($progressType, $resolver->getProgressType());
- }
- public static function provideProgressTypeCases(): iterable
- {
- foreach (ProgressOutputType::AVAILABLE as $outputType) {
- yield $outputType => [$outputType];
- }
- }
- public function testResolveProgressWithInvalidExplicitProgress(): void
- {
- $resolver = $this->createConfigurationResolver([
- 'format' => 'txt',
- 'verbosity' => OutputInterface::VERBOSITY_VERBOSE,
- 'show-progress' => 'foo',
- ]);
- $this->expectException(InvalidConfigurationException::class);
- $this->expectExceptionMessage('The progress type "foo" is not defined, supported are "none" and "dots".');
- $resolver->getProgressType();
- }
- public function testResolveConfigFileDefault(): void
- {
- $resolver = $this->createConfigurationResolver([]);
- self::assertNull($resolver->getConfigFile());
- self::assertInstanceOf(\PhpCsFixer\ConfigInterface::class, $resolver->getConfig());
- }
- public function testResolveConfigFileByPathOfFile(): void
- {
- $dir = __DIR__.'/../Fixtures/ConfigurationResolverConfigFile/case_1';
- $resolver = $this->createConfigurationResolver(['path' => [$dir.\DIRECTORY_SEPARATOR.'foo.php']]);
- self::assertSame($dir.\DIRECTORY_SEPARATOR.'.php-cs-fixer.dist.php', $resolver->getConfigFile());
- self::assertInstanceOf(\Test1Config::class, $resolver->getConfig()); // @phpstan-ignore-line to avoid `Class Test1Config not found.`
- }
- public function testResolveConfigFileSpecified(): void
- {
- $file = __DIR__.'/../Fixtures/ConfigurationResolverConfigFile/case_4/my.php-cs-fixer.php';
- $resolver = $this->createConfigurationResolver(['config' => $file]);
- self::assertSame($file, $resolver->getConfigFile());
- self::assertInstanceOf(\Test4Config::class, $resolver->getConfig()); // @phpstan-ignore-line to avoid `Class Test4Config not found.`
- }
- /**
- * @dataProvider provideResolveConfigFileChooseFileCases
- */
- public function testResolveConfigFileChooseFile(string $expectedFile, string $expectedClass, string $path, ?string $cwdPath = null): void
- {
- $resolver = $this->createConfigurationResolver(
- ['path' => [$path]],
- null,
- $cwdPath ?? ''
- );
- self::assertSame($expectedFile, $resolver->getConfigFile());
- self::assertInstanceOf($expectedClass, $resolver->getConfig());
- }
- public static function provideResolveConfigFileChooseFileCases(): iterable
- {
- $dirBase = self::getFixtureDir();
- yield [
- $dirBase.'case_1'.\DIRECTORY_SEPARATOR.'.php-cs-fixer.dist.php',
- 'Test1Config',
- $dirBase.'case_1',
- ];
- yield [
- $dirBase.'case_2'.\DIRECTORY_SEPARATOR.'.php-cs-fixer.php',
- 'Test2Config',
- $dirBase.'case_2',
- ];
- yield [
- $dirBase.'case_3'.\DIRECTORY_SEPARATOR.'.php-cs-fixer.php',
- 'Test3Config',
- $dirBase.'case_3',
- ];
- yield [
- $dirBase.'case_6'.\DIRECTORY_SEPARATOR.'.php-cs-fixer.dist.php',
- 'Test6Config',
- $dirBase.'case_6'.\DIRECTORY_SEPARATOR.'subdir',
- $dirBase.'case_6',
- ];
- yield [
- $dirBase.'case_6'.\DIRECTORY_SEPARATOR.'.php-cs-fixer.dist.php',
- 'Test6Config',
- $dirBase.'case_6'.\DIRECTORY_SEPARATOR.'subdir/empty_file.php',
- $dirBase.'case_6',
- ];
- }
- public function testResolveConfigFileChooseFileWithInvalidFile(): void
- {
- $this->expectException(InvalidConfigurationException::class);
- $this->expectExceptionMessageMatches(
- '#^The config file: ".+[\/\\\]Fixtures[\/\\\]ConfigurationResolverConfigFile[\/\\\]case_5[\/\\\]\.php-cs-fixer\.dist\.php" does not return a "PhpCsFixer\\\ConfigInterface" instance\. Got: "string"\.$#'
- );
- $dirBase = self::getFixtureDir();
- $resolver = $this->createConfigurationResolver(['path' => [$dirBase.'case_5']]);
- $resolver->getConfig();
- }
- public function testResolveConfigFileChooseFileWithInvalidFormat(): void
- {
- $this->expectException(InvalidConfigurationException::class);
- $this->expectExceptionMessageMatches('/^The format "xls" is not defined, supported are "checkstyle", "gitlab", "json", "junit", "txt" and "xml"\.$/');
- $dirBase = self::getFixtureDir();
- $resolver = $this->createConfigurationResolver(['path' => [$dirBase.'case_7']]);
- $resolver->getReporter();
- }
- public function testResolveConfigFileChooseFileWithPathArrayWithoutConfig(): void
- {
- $this->expectException(InvalidConfigurationException::class);
- $this->expectExceptionMessageMatches('/^For multiple paths config parameter is required\.$/');
- $dirBase = self::getFixtureDir();
- $resolver = $this->createConfigurationResolver(['path' => [$dirBase.'case_1/.php-cs-fixer.dist.php', $dirBase.'case_1/foo.php']]);
- $resolver->getConfig();
- }
- public function testResolveConfigFileChooseFileWithPathArrayAndConfig(): void
- {
- $dirBase = self::getFixtureDir();
- $configFile = $dirBase.'case_1/.php-cs-fixer.dist.php';
- $resolver = $this->createConfigurationResolver([
- 'config' => $configFile,
- 'path' => [$configFile, $dirBase.'case_1/foo.php'],
- ]);
- self::assertSame($configFile, $resolver->getConfigFile());
- }
- /**
- * @param array<int, string> $paths
- * @param array<int, string> $expectedPaths
- *
- * @dataProvider provideResolvePathCases
- */
- public function testResolvePath(array $paths, string $cwd, array $expectedPaths): void
- {
- $resolver = $this->createConfigurationResolver(
- ['path' => $paths],
- null,
- $cwd
- );
- self::assertSame($expectedPaths, $resolver->getPath());
- }
- public static function provideResolvePathCases(): iterable
- {
- yield [
- ['Command'],
- __DIR__,
- [__DIR__.\DIRECTORY_SEPARATOR.'Command'],
- ];
- yield [
- [basename(__DIR__)],
- \dirname(__DIR__),
- [__DIR__],
- ];
- yield [
- [' Command'],
- __DIR__,
- [__DIR__.\DIRECTORY_SEPARATOR.'Command'],
- ];
- yield [
- ['Command '],
- __DIR__,
- [__DIR__.\DIRECTORY_SEPARATOR.'Command'],
- ];
- }
- /**
- * @param array<string> $paths
- *
- * @dataProvider provideRejectInvalidPathCases
- */
- public function testRejectInvalidPath(array $paths, string $expectedMessage): void
- {
- $resolver = $this->createConfigurationResolver(
- ['path' => $paths],
- null,
- \dirname(__DIR__)
- );
- $this->expectException(InvalidConfigurationException::class);
- $this->expectExceptionMessage($expectedMessage);
- $resolver->getPath();
- }
- public static function provideRejectInvalidPathCases(): iterable
- {
- yield [
- [''],
- 'Invalid path: "".',
- ];
- yield [
- [__DIR__, ''],
- 'Invalid path: "".',
- ];
- yield [
- ['', __DIR__],
- 'Invalid path: "".',
- ];
- yield [
- [' '],
- 'Invalid path: " ".',
- ];
- yield [
- [__DIR__, ' '],
- 'Invalid path: " ".',
- ];
- yield [
- [' ', __DIR__],
- 'Invalid path: " ".',
- ];
- }
- public function testResolvePathWithFileThatIsExcludedDirectlyOverridePathMode(): void
- {
- $config = new Config();
- $config->getFinder()
- ->in(__DIR__)
- ->notPath(basename(__FILE__))
- ;
- $resolver = $this->createConfigurationResolver(
- ['path' => [__FILE__]],
- $config
- );
- self::assertCount(1, $resolver->getFinder());
- }
- public function testResolvePathWithFileThatIsExcludedDirectlyIntersectionPathMode(): void
- {
- $config = new Config();
- $config->getFinder()
- ->in(__DIR__)
- ->notPath(basename(__FILE__))
- ;
- $resolver = $this->createConfigurationResolver([
- 'path' => [__FILE__],
- 'path-mode' => 'intersection',
- ], $config);
- self::assertCount(0, $resolver->getFinder());
- }
- public function testResolvePathWithFileThatIsExcludedByDirOverridePathMode(): void
- {
- $dir = \dirname(__DIR__);
- $config = new Config();
- $config->getFinder()
- ->in($dir)
- ->exclude(basename(__DIR__))
- ;
- $resolver = $this->createConfigurationResolver(
- ['path' => [__FILE__]],
- $config
- );
- self::assertCount(1, $resolver->getFinder());
- }
- public function testResolvePathWithFileThatIsExcludedByDirIntersectionPathMode(): void
- {
- $dir = \dirname(__DIR__);
- $config = new Config();
- $config->getFinder()
- ->in($dir)
- ->exclude(basename(__DIR__))
- ;
- $resolver = $this->createConfigurationResolver([
- 'path-mode' => 'intersection',
- 'path' => [__FILE__],
- ], $config);
- self::assertCount(0, $resolver->getFinder());
- }
- public function testResolvePathWithFileThatIsNotExcluded(): void
- {
- $dir = __DIR__;
- $config = new Config();
- $config->getFinder()
- ->in($dir)
- ->notPath('foo-'.basename(__FILE__))
- ;
- $resolver = $this->createConfigurationResolver(
- ['path' => [__FILE__]],
- $config
- );
- self::assertCount(1, $resolver->getFinder());
- }
- /**
- * @param \Exception|list<string> $expected
- * @param list<string> $path
- *
- * @dataProvider provideResolveIntersectionOfPathsCases
- */
- public function testResolveIntersectionOfPaths($expected, ?Finder $configFinder, array $path, string $pathMode, ?string $configOption = null): void
- {
- if ($expected instanceof \Exception) {
- $this->expectException(\get_class($expected));
- }
- if (null !== $configFinder) {
- $config = new Config();
- $config->setFinder($configFinder);
- } else {
- $config = null;
- }
- $resolver = $this->createConfigurationResolver([
- 'config' => $configOption,
- 'path' => $path,
- 'path-mode' => $pathMode,
- ], $config);
- $intersectionItems = array_map(
- static fn (\SplFileInfo $file): string => $file->getRealPath(),
- iterator_to_array($resolver->getFinder(), false)
- );
- sort($expected);
- sort($intersectionItems);
- self::assertSame($expected, $intersectionItems);
- }
- public static function provideResolveIntersectionOfPathsCases(): iterable
- {
- $dir = __DIR__.'/../Fixtures/ConfigurationResolverPathsIntersection';
- $cb = static fn (array $items): array => array_map(
- static fn (string $item): string => realpath($dir.'/'.$item),
- $items
- );
- yield 'no path at all' => [
- new \LogicException(),
- Finder::create(),
- [],
- 'override',
- ];
- yield 'configured only by finder' => [
- // don't override if the argument is empty
- $cb(['a1.php', 'a2.php', 'b/b1.php', 'b/b2.php', 'b_b/b_b1.php', 'c/c1.php', 'c/d/cd1.php', 'd/d1.php', 'd/d2.php', 'd/e/de1.php', 'd/f/df1.php']),
- Finder::create()
- ->in($dir),
- [],
- 'override',
- ];
- yield 'configured only by argument' => [
- $cb(['a1.php', 'a2.php', 'b/b1.php', 'b/b2.php', 'b_b/b_b1.php', 'c/c1.php', 'c/d/cd1.php', 'd/d1.php', 'd/d2.php', 'd/e/de1.php', 'd/f/df1.php']),
- Finder::create(),
- [$dir],
- 'override',
- ];
- yield 'configured by finder, intersected with empty argument' => [
- [],
- Finder::create()
- ->in($dir),
- [],
- 'intersection',
- ];
- yield 'configured by finder, intersected with dir' => [
- $cb(['c/c1.php', 'c/d/cd1.php']),
- Finder::create()
- ->in($dir),
- [$dir.'/c'],
- 'intersection',
- ];
- yield 'configured by finder, intersected with file' => [
- $cb(['c/c1.php']),
- Finder::create()
- ->in($dir),
- [$dir.'/c/c1.php'],
- 'intersection',
- ];
- yield 'finder points to one dir while argument to another, not connected' => [
- [],
- Finder::create()
- ->in($dir.'/b'),
- [$dir.'/c'],
- 'intersection',
- ];
- yield 'finder with excluded dir, intersected with excluded file' => [
- [],
- Finder::create()
- ->in($dir)
- ->exclude('c'),
- [$dir.'/c/d/cd1.php'],
- 'intersection',
- ];
- yield 'finder with excluded dir, intersected with dir containing excluded one' => [
- $cb(['c/c1.php']),
- Finder::create()
- ->in($dir)
- ->exclude('c/d'),
- [$dir.'/c'],
- 'intersection',
- ];
- yield 'finder with excluded file, intersected with dir containing excluded one' => [
- $cb(['c/d/cd1.php']),
- Finder::create()
- ->in($dir)
- ->notPath('c/c1.php'),
- [$dir.'/c'],
- 'intersection',
- ];
- yield 'configured by finder, intersected with non-existing path' => [
- new \LogicException(),
- Finder::create()
- ->in($dir),
- ['non_existing_dir'],
- 'intersection',
- ];
- yield 'configured by config file, overridden by multiple files' => [
- $cb(['d/d1.php', 'd/d2.php']),
- null,
- [$dir.'/d/d1.php', $dir.'/d/d2.php'],
- 'override',
- $dir.'/d/.php-cs-fixer.php',
- ];
- yield 'configured by config file, intersected with multiple files' => [
- $cb(['d/d1.php', 'd/d2.php']),
- null,
- [$dir.'/d/d1.php', $dir.'/d/d2.php'],
- 'intersection',
- $dir.'/d/.php-cs-fixer.php',
- ];
- yield 'configured by config file, overridden by non-existing dir' => [
- new \LogicException(),
- null,
- [$dir.'/d/fff'],
- 'override',
- $dir.'/d/.php-cs-fixer.php',
- ];
- yield 'configured by config file, intersected with non-existing dir' => [
- new \LogicException(),
- null,
- [$dir.'/d/fff'],
- 'intersection',
- $dir.'/d/.php-cs-fixer.php',
- ];
- yield 'configured by config file, overridden by non-existing file' => [
- new \LogicException(),
- null,
- [$dir.'/d/fff.php'],
- 'override',
- $dir.'/d/.php-cs-fixer.php',
- ];
- yield 'configured by config file, intersected with non-existing file' => [
- new \LogicException(),
- null,
- [$dir.'/d/fff.php'],
- 'intersection',
- $dir.'/d/.php-cs-fixer.php',
- ];
- yield 'configured by config file, overridden by multiple files and dirs' => [
- $cb(['d/d1.php', 'd/e/de1.php', 'd/f/df1.php']),
- null,
- [$dir.'/d/d1.php', $dir.'/d/e', $dir.'/d/f/'],
- 'override',
- $dir.'/d/.php-cs-fixer.php',
- ];
- yield 'configured by config file, intersected with multiple files and dirs' => [
- $cb(['d/d1.php', 'd/e/de1.php', 'd/f/df1.php']),
- null,
- [$dir.'/d/d1.php', $dir.'/d/e', $dir.'/d/f/'],
- 'intersection',
- $dir.'/d/.php-cs-fixer.php',
- ];
- }
- /**
- * @param array<string, mixed> $options
- *
- * @dataProvider provideConfigFinderIsOverriddenCases
- */
- public function testConfigFinderIsOverridden(array $options, bool $expectedResult): void
- {
- $resolver = $this->createConfigurationResolver($options);
- self::assertSame($expectedResult, $resolver->configFinderIsOverridden());
- $resolver = $this->createConfigurationResolver($options);
- $resolver->getFinder();
- self::assertSame($expectedResult, $resolver->configFinderIsOverridden());
- }
- public static function provideConfigFinderIsOverriddenCases(): iterable
- {
- $root = __DIR__.'/../..';
- yield [
- [
- 'config' => $root.'/.php-cs-fixer.dist.php',
- ],
- false,
- ];
- yield [
- [
- 'config' => $root.'/.php-cs-fixer.dist.php',
- 'path' => [$root.'/src'],
- ],
- true,
- ];
- yield [
- [],
- false,
- ];
- yield [
- [
- 'path' => [$root.'/src'],
- ],
- false,
- ];
- yield [
- [
- 'config' => $root.'/.php-cs-fixer.dist.php',
- 'path' => [$root.'/src'],
- 'path-mode' => ConfigurationResolver::PATH_MODE_INTERSECTION,
- ],
- false,
- ];
- // scenario when loaded config is not setting custom finder
- yield [
- [
- 'config' => $root.'/tests/Fixtures/ConfigurationResolverConfigFile/case_3/.php-cs-fixer.dist.php',
- 'path' => [$root.'/src'],
- ],
- false,
- ];
- // scenario when loaded config contains not fully defined finder
- yield [
- [
- 'config' => $root.'/tests/Fixtures/ConfigurationResolverConfigFile/case_9/.php-cs-fixer.php',
- 'path' => [$root.'/src'],
- ],
- false,
- ];
- }
- public function testResolveIsDryRunViaStdIn(): void
- {
- $resolver = $this->createConfigurationResolver([
- 'dry-run' => false,
- 'path' => ['-'],
- ]);
- self::assertTrue($resolver->isDryRun());
- }
- public function testResolveIsDryRunViaNegativeOption(): void
- {
- $resolver = $this->createConfigurationResolver(['dry-run' => false]);
- self::assertFalse($resolver->isDryRun());
- }
- public function testResolveIsDryRunViaPositiveOption(): void
- {
- $resolver = $this->createConfigurationResolver(['dry-run' => true]);
- self::assertTrue($resolver->isDryRun());
- }
- /**
- * @dataProvider provideResolveBooleanOptionCases
- */
- public function testResolveUsingCacheWithConfigOption(bool $expected, bool $configValue, ?string $passed): void
- {
- $config = new Config();
- $config->setUsingCache($configValue);
- $resolver = $this->createConfigurationResolver(
- ['using-cache' => $passed],
- $config
- );
- self::assertSame($expected, $resolver->getUsingCache());
- }
- public function testResolveUsingCacheWithPositiveConfigAndNoOption(): void
- {
- $config = new Config();
- $config->setUsingCache(true);
- $resolver = $this->createConfigurationResolver(
- [],
- $config
- );
- self::assertTrue($resolver->getUsingCache());
- }
- public function testResolveUsingCacheWithNegativeConfigAndNoOption(): void
- {
- $config = new Config();
- $config->setUsingCache(false);
- $resolver = $this->createConfigurationResolver(
- [],
- $config
- );
- self::assertFalse($resolver->getUsingCache());
- }
- public function testResolveCacheFileWithoutConfigAndOption(): void
- {
- $config = new Config();
- $default = $config->getCacheFile();
- $resolver = $this->createConfigurationResolver(
- [],
- $config
- );
- self::assertSame($default, $resolver->getCacheFile());
- }
- public function testResolveCacheFileWithConfig(): void
- {
- $cacheFile = 'foo/bar.baz';
- $config = new Config();
- $config
- ->setUsingCache(false)
- ->setCacheFile($cacheFile)
- ;
- $resolver = $this->createConfigurationResolver(
- [],
- $config
- );
- self::assertNull($resolver->getCacheFile());
- $cacheManager = $resolver->getCacheManager();
- self::assertInstanceOf(NullCacheManager::class, $cacheManager);
- $linter = $resolver->getLinter();
- self::assertInstanceOf(LinterInterface::class, $linter);
- }
- public function testResolveCacheFileWithOption(): void
- {
- $cacheFile = 'bar.baz';
- $config = new Config();
- $config->setCacheFile($cacheFile);
- $resolver = $this->createConfigurationResolver(
- ['cache-file' => $cacheFile],
- $config
- );
- self::assertSame($cacheFile, $resolver->getCacheFile());
- }
- public function testResolveCacheFileWithConfigAndOption(): void
- {
- $configCacheFile = 'foo/bar.baz';
- $optionCacheFile = 'bar.baz';
- $config = new Config();
- $config->setCacheFile($configCacheFile);
- $resolver = $this->createConfigurationResolver(
- ['cache-file' => $optionCacheFile],
- $config
- );
- self::assertSame($optionCacheFile, $resolver->getCacheFile());
- }
- /**
- * @dataProvider provideResolveBooleanOptionCases
- */
- public function testResolveAllowRiskyWithConfigOption(bool $expected, bool $configValue, ?string $passed): void
- {
- $config = new Config();
- $config->setRiskyAllowed($configValue);
- $resolver = $this->createConfigurationResolver(
- ['allow-risky' => $passed],
- $config
- );
- self::assertSame($expected, $resolver->getRiskyAllowed());
- }
- public function testResolveAllowRiskyWithNegativeConfigAndPositiveOption(): void
- {
- $config = new Config();
- $config->setRiskyAllowed(false);
- $resolver = $this->createConfigurationResolver(
- ['allow-risky' => 'yes'],
- $config
- );
- self::assertTrue($resolver->getRiskyAllowed());
- }
- public function testResolveAllowRiskyWithNegativeConfigAndNegativeOption(): void
- {
- $config = new Config();
- $config->setRiskyAllowed(false);
- $resolver = $this->createConfigurationResolver(
- ['allow-risky' => 'no'],
- $config
- );
- self::assertFalse($resolver->getRiskyAllowed());
- }
- public function testResolveAllowRiskyWithPositiveConfigAndNoOption(): void
- {
- $config = new Config();
- $config->setRiskyAllowed(true);
- $resolver = $this->createConfigurationResolver(
- [],
- $config
- );
- self::assertTrue($resolver->getRiskyAllowed());
- }
- public function testResolveAllowRiskyWithNegativeConfigAndNoOption(): void
- {
- $config = new Config();
- $config->setRiskyAllowed(false);
- $resolver = $this->createConfigurationResolver(
- [],
- $config
- );
- self::assertFalse($resolver->getRiskyAllowed());
- }
- public function testResolveRulesWithConfig(): void
- {
- $config = new Config();
- $config->setRules([
- 'statement_indentation' => true,
- 'strict_comparison' => false,
- ]);
- $resolver = $this->createConfigurationResolver(
- [],
- $config
- );
- self::assertSameRules(
- [
- 'statement_indentation' => true,
- ],
- $resolver->getRules()
- );
- }
- public function testResolveRulesWithOption(): void
- {
- $resolver = $this->createConfigurationResolver(['rules' => 'statement_indentation,-strict_comparison']);
- self::assertSameRules(
- [
- 'statement_indentation' => true,
- ],
- $resolver->getRules()
- );
- }
- /**
- * @param string[] $rules
- *
- * @dataProvider provideResolveRenamedRulesWithUnknownRulesCases
- */
- public function testResolveRenamedRulesWithUnknownRules(string $expectedMessage, array $rules): void
- {
- $this->expectException(InvalidConfigurationException::class);
- $this->expectExceptionMessage($expectedMessage);
- $resolver = $this->createConfigurationResolver(['rules' => implode(',', $rules)]);
- $resolver->getRules();
- }
- public static function provideResolveRenamedRulesWithUnknownRulesCases(): iterable
- {
- yield 'with config' => [
- 'The rules contain unknown fixers: "blank_line_before_return" is renamed (did you mean "blank_line_before_statement"? (note: use configuration "[\'statements\' => [\'return\']]")).
- For more info about updating see: https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/v3.0.0/UPGRADE-v3.md#renamed-ruless.',
- ['blank_line_before_return'],
- ];
- yield 'without config' => [
- 'The rules contain unknown fixers: "final_static_access" is renamed (did you mean "self_static_accessor"?).
- For more info about updating see: https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/v3.0.0/UPGRADE-v3.md#renamed-ruless.',
- ['final_static_access'],
- ];
- yield [
- 'The rules contain unknown fixers: "hash_to_slash_comment" is renamed (did you mean "single_line_comment_style"? (note: use configuration "[\'comment_types\' => [\'hash\']]")).
- For more info about updating see: https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/v3.0.0/UPGRADE-v3.md#renamed-ruless.',
- ['hash_to_slash_comment'],
- ];
- yield 'both renamed and unknown' => [
- 'The rules contain unknown fixers: "final_static_access" is renamed (did you mean "self_static_accessor"?), "binary_operator_space" (did you mean "binary_operator_spaces"?).
- For more info about updating see: https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/v3.0.0/UPGRADE-v3.md#renamed-ruless.',
- ['final_static_access', 'binary_operator_space'],
- ];
- }
- public function testResolveRulesWithUnknownRules(): void
- {
- $this->expectException(InvalidConfigurationException::class);
- $this->expectExceptionMessage('The rules contain unknown fixers: "bar", "binary_operator_space" (did you mean "binary_operator_spaces"?).');
- $resolver = $this->createConfigurationResolver(['rules' => 'statement_indentation,-bar,binary_operator_space']);
- $resolver->getRules();
- }
- public function testResolveRulesWithConfigAndOption(): void
- {
- $config = new Config();
- $config->setRules([
- 'statement_indentation' => true,
- 'strict_comparison' => false,
- ]);
- $resolver = $this->createConfigurationResolver(
- ['rules' => 'blank_line_before_statement'],
- $config
- );
- self::assertSameRules(
- [
- 'blank_line_before_statement' => true,
- ],
- $resolver->getRules()
- );
- }
- public function testResolveCommandLineInputOverridesDefault(): void
- {
- $command = new FixCommand(new ToolInfo());
- $definition = $command->getDefinition();
- $arguments = $definition->getArguments();
- self::assertCount(1, $arguments, 'Expected one argument, possibly test needs updating.');
- self::assertArrayHasKey('path', $arguments);
- $options = $definition->getOptions();
- self::assertSame(
- ['path-mode', 'allow-risky', 'config', 'dry-run', 'rules', 'using-cache', 'cache-file', 'diff', 'format', 'stop-on-violation', 'show-progress'],
- array_keys($options),
- 'Expected options mismatch, possibly test needs updating.'
- );
- $resolver = $this->createConfigurationResolver([
- 'path-mode' => 'intersection',
- 'allow-risky' => 'yes',
- 'config' => null,
- 'dry-run' => true,
- 'rules' => 'php_unit_construct',
- 'using-cache' => 'no',
- 'diff' => true,
- 'format' => 'json',
- 'stop-on-violation' => true,
- ]);
- self::assertTrue($resolver->shouldStopOnViolation());
- self::assertTrue($resolver->getRiskyAllowed());
- self::assertTrue($resolver->isDryRun());
- self::assertSame(['php_unit_construct' => true], $resolver->getRules());
- self::assertFalse($resolver->getUsingCache());
- self::assertNull($resolver->getCacheFile());
- self::assertInstanceOf(\PhpCsFixer\Differ\UnifiedDiffer::class, $resolver->getDiffer());
- self::assertSame('json', $resolver->getReporter()->getFormat());
- }
- /**
- * @param null|bool|string $diffConfig
- *
- * @dataProvider provideResolveDifferCases
- */
- public function testResolveDiffer(string $expected, $diffConfig): void
- {
- $resolver = $this->createConfigurationResolver([
- 'diff' => $diffConfig,
- ]);
- self::assertInstanceOf($expected, $resolver->getDiffer());
- }
- public static function provideResolveDifferCases(): iterable
- {
- yield [
- \PhpCsFixer\Differ\NullDiffer::class,
- false,
- ];
- yield [
- \PhpCsFixer\Differ\NullDiffer::class,
- null,
- ];
- yield [
- \PhpCsFixer\Differ\UnifiedDiffer::class,
- true,
- ];
- }
- public function testResolveConfigFileOverridesDefault(): void
- {
- $dir = __DIR__.'/../Fixtures/ConfigurationResolverConfigFile/case_8';
- $resolver = $this->createConfigurationResolver(['path' => [$dir.\DIRECTORY_SEPARATOR.'.php-cs-fixer.php']]);
- self::assertTrue($resolver->getRiskyAllowed());
- self::assertSame(['php_unit_construct' => true], $resolver->getRules());
- self::assertFalse($resolver->getUsingCache());
- self::assertNull($resolver->getCacheFile());
- self::assertSame('xml', $resolver->getReporter()->getFormat());
- }
- public function testDeprecationOfPassingOtherThanNoOrYes(): void
- {
- $this->expectException(InvalidConfigurationException::class);
- $this->expectExceptionMessage('Expected "yes" or "no" for option "allow-risky", got "yes please".');
- $resolver = $this->createConfigurationResolver(['allow-risky' => 'yes please']);
- $resolver->getRiskyAllowed();
- }
- public static function provideResolveBooleanOptionCases(): iterable
- {
- yield [true, true, 'yes'];
- yield [true, false, 'yes'];
- yield [false, true, 'no'];
- yield [false, false, 'no'];
- yield [true, true, null];
- yield [false, false, null];
- }
- public function testWithEmptyRules(): void
- {
- $resolver = $this->createConfigurationResolver(['rules' => '']);
- $this->expectException(InvalidConfigurationException::class);
- $this->expectExceptionMessageMatches('/^Empty rules value is not allowed\.$/');
- $resolver->getRules();
- }
- /**
- * @param array<string, mixed>|bool $ruleConfig
- *
- * @dataProvider provideDeprecatedFixerConfiguredCases
- *
- * @group legacy
- */
- public function testDeprecatedFixerConfigured($ruleConfig): void
- {
- $this->expectDeprecation('Rule "Vendor4/foo" is deprecated. Use "testA" and "testB" instead.');
- $fixer = new DeprecatedFixer();
- $config = new Config();
- $config->registerCustomFixers([$fixer]);
- $config->setRules([$fixer->getName() => $ruleConfig]);
- $resolver = $this->createConfigurationResolver([], $config);
- $resolver->getFixers();
- }
- public static function provideDeprecatedFixerConfiguredCases(): iterable
- {
- yield [true];
- yield [['foo' => true]];
- yield [false];
- }
- public static function provideGetDirectoryCases(): iterable
- {
- yield [null, '/my/path/my/file', 'my/file'];
- yield ['/my/path/.php-cs-fixer.cache', '/my/path/my/file', 'my/file'];
- yield ['/my/path2/dir/.php-cs-fixer.cache', '/my/path2/dir/dir2/file', 'dir2/file'];
- yield ['dir/.php-cs-fixer.cache', '/my/path/dir/dir3/file', 'dir3/file'];
- }
- /**
- * @dataProvider provideGetDirectoryCases
- */
- public function testGetDirectory(?string $cacheFile, string $file, string $expectedPathRelativeToFile): void
- {
- if (null !== $cacheFile) {
- $cacheFile = $this->normalizePath($cacheFile);
- }
- $file = $this->normalizePath($file);
- $expectedPathRelativeToFile = $this->normalizePath($expectedPathRelativeToFile);
- $config = new Config();
- if (null === $cacheFile) {
- $config->setUsingCache(false);
- } else {
- $config->setCacheFile($cacheFile);
- }
- $resolver = new ConfigurationResolver($config, [], $this->normalizePath('/my/path'), new TestToolInfo());
- $directory = $resolver->getDirectory();
- self::assertSame($expectedPathRelativeToFile, $directory->getRelativePathTo($file));
- }
- private function normalizePath(string $path): string
- {
- return str_replace('/', \DIRECTORY_SEPARATOR, $path);
- }
- /**
- * @param array<string, array<string, mixed>|bool> $expected
- * @param array<string, array<string, mixed>|bool> $actual
- */
- private static function assertSameRules(array $expected, array $actual): void
- {
- ksort($expected);
- ksort($actual);
- self::assertSame($expected, $actual);
- }
- private static function getFixtureDir(): string
- {
- return realpath(__DIR__.\DIRECTORY_SEPARATOR.'..'.\DIRECTORY_SEPARATOR.'Fixtures'.\DIRECTORY_SEPARATOR.'ConfigurationResolverConfigFile'.\DIRECTORY_SEPARATOR).'/';
- }
- /**
- * @param array<string, mixed> $options
- */
- private function createConfigurationResolver(array $options, Config $config = null, string $cwdPath = ''): ConfigurationResolver
- {
- if (null === $config) {
- $config = new Config();
- }
- return new ConfigurationResolver(
- $config,
- $options,
- $cwdPath,
- new TestToolInfo()
- );
- }
- }
|