PhpUnitMockShortWillReturnFixerTest.php 9.2 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311
  1. <?php
  2. declare(strict_types=1);
  3. /*
  4. * This file is part of PHP CS Fixer.
  5. *
  6. * (c) Fabien Potencier <fabien@symfony.com>
  7. * Dariusz Rumiński <dariusz.ruminski@gmail.com>
  8. *
  9. * This source file is subject to the MIT license that is bundled
  10. * with this source code in the file LICENSE.
  11. */
  12. namespace PhpCsFixer\Tests\Fixer\PhpUnit;
  13. use PhpCsFixer\Tests\Test\AbstractFixerTestCase;
  14. /**
  15. * @author Michał Adamski <michal.adamski@gmail.com>
  16. *
  17. * @internal
  18. *
  19. * @covers \PhpCsFixer\Fixer\PhpUnit\PhpUnitMockShortWillReturnFixer
  20. */
  21. final class PhpUnitMockShortWillReturnFixerTest extends AbstractFixerTestCase
  22. {
  23. /**
  24. * @dataProvider provideFixCases
  25. */
  26. public function testFix(string $expected, ?string $input = null): void
  27. {
  28. $this->doTest($expected, $input);
  29. }
  30. public function provideFixCases(): array
  31. {
  32. return [
  33. 'do not fix' => [
  34. '<?php
  35. class FooTest extends TestCase {
  36. public function testFoo() {
  37. $someMock->method("someMethod")->will;
  38. $someMock->method("someMethod")->will("Smith");
  39. $someMock->method("someMethod")->will($this->returnSelf);
  40. $someMock->method("someMethod")->will($this->doSomething(7));
  41. }
  42. }',
  43. ],
  44. 'will return simple scenarios' => [
  45. '<?php
  46. class FooTest extends TestCase {
  47. public function testFoo() {
  48. $someMock->method("someMethod")->willReturn(10);
  49. $someMock->method("someMethod")->willReturn(20);
  50. $someMock->method("someMethod")->willReturn(30);
  51. $someMock->method("someMethod")->willReturn(40);
  52. $someMock->method("someMethod")->willReturn(50);
  53. $someMock->method("someMethod")->willReturn(60);
  54. $someMock->method("someMethod")->willReturn(-10);
  55. $someMock->method("someMethod")->willReturn(10.10);
  56. $someMock->method("someMethod")->willReturn(-10.10);
  57. $someMock->method("someMethod")->willReturn("myValue");
  58. $someMock->method("someMethod")->willReturn($myValue);
  59. $testMock->method("test_method")->willReturn(DEFAULT_VALUE);
  60. $testMock->method("test_method")->willReturn(self::DEFAULT_VALUE);
  61. $someMock->method("someMethod")->willReturn([]);
  62. $someMock->method("someMethod")->willReturn([[]]);
  63. $someMock->method("someMethod")->willReturn(array());
  64. $someMock->method("someMethod")->willReturn(new stdClass());
  65. $someMock->method("someMethod")->willReturn(new \DateTime());
  66. $someMock->method("someMethod")->willReturnSelf();
  67. $someMock->method("someMethod")->willReturnArgument(2);
  68. $someMock->method("someMethod")->willReturnCallback("str_rot13");
  69. $someMock->method("someMethod")->willReturnMap(["a", "b", "c", "d"]);
  70. $someMock->method("someMethod")->willReturn(1);
  71. $someMock->method("someMethod")->willReturn(2);
  72. }
  73. }',
  74. '<?php
  75. class FooTest extends TestCase {
  76. public function testFoo() {
  77. $someMock->method("someMethod")->will($this->returnValue(10));
  78. $someMock->method("someMethod")->will($THIS->returnValue(20));
  79. $someMock->method("someMethod")->will(self::returnValue(30));
  80. $someMock->method("someMethod")->will(Self::returnValue(40));
  81. $someMock->method("someMethod")->will(static::returnValue(50));
  82. $someMock->method("someMethod")->will(STATIC::returnValue(60));
  83. $someMock->method("someMethod")->will($this->returnValue(-10));
  84. $someMock->method("someMethod")->will($this->returnValue(10.10));
  85. $someMock->method("someMethod")->will($this->returnValue(-10.10));
  86. $someMock->method("someMethod")->will($this->returnValue("myValue"));
  87. $someMock->method("someMethod")->will($this->returnValue($myValue));
  88. $testMock->method("test_method")->will($this->returnValue(DEFAULT_VALUE));
  89. $testMock->method("test_method")->will($this->returnValue(self::DEFAULT_VALUE));
  90. $someMock->method("someMethod")->will($this->returnValue([]));
  91. $someMock->method("someMethod")->will($this->returnValue([[]]));
  92. $someMock->method("someMethod")->will($this->returnValue(array()));
  93. $someMock->method("someMethod")->will($this->returnValue(new stdClass()));
  94. $someMock->method("someMethod")->will($this->returnValue(new \DateTime()));
  95. $someMock->method("someMethod")->will($this->returnSelf());
  96. $someMock->method("someMethod")->will($this->returnArgument(2));
  97. $someMock->method("someMethod")->will($this->returnCallback("str_rot13"));
  98. $someMock->method("someMethod")->will($this->returnValueMap(["a", "b", "c", "d"]));
  99. $someMock->method("someMethod")->WILL($this->returnValue(1));
  100. $someMock->method("someMethod")->will($this->ReturnVALUE(2));
  101. }
  102. }',
  103. ],
  104. 'will return with multi lines and messy indents' => [
  105. '<?php
  106. class FooTest extends TestCase {
  107. public function testFoo() {
  108. $someMock
  109. ->method("someMethod")
  110. ->willReturn(
  111. 10
  112. );
  113. }
  114. }',
  115. '<?php
  116. class FooTest extends TestCase {
  117. public function testFoo() {
  118. $someMock
  119. ->method("someMethod")
  120. ->will(
  121. $this->returnValue(10)
  122. );
  123. }
  124. }',
  125. ],
  126. 'will return with multi lines, messy indents and comments inside' => [
  127. '<?php
  128. class FooTest extends TestCase {
  129. public function testFoo() {
  130. $someMock
  131. ->method("someMethod")
  132. ->willReturn(
  133. // foo
  134. 10
  135. // bar
  136. );
  137. }
  138. }',
  139. '<?php
  140. class FooTest extends TestCase {
  141. public function testFoo() {
  142. $someMock
  143. ->method("someMethod")
  144. ->will(
  145. // foo
  146. $this->returnValue(10)
  147. // bar
  148. );
  149. }
  150. }',
  151. ],
  152. 'will return with block comments in weird places' => [
  153. '<?php
  154. class FooTest extends TestCase {
  155. public function testFoo() {
  156. $someMock->method("someMethod")->/* a */willReturn/* b */(/* c */ 10 /* d */);
  157. }
  158. }',
  159. '<?php
  160. class FooTest extends TestCase {
  161. public function testFoo() {
  162. $someMock->method("someMethod")->/* a */will/* b */(/* c */ $this->returnValue(10) /* d */);
  163. }
  164. }',
  165. ],
  166. 'will return with comments persisted not touched even if put in unexpected places' => [
  167. '<?php
  168. class FooTest extends TestCase {
  169. public function testFoo() {
  170. $someMock->method("someMethod")// a
  171. ->/* b */willReturn/* c */(/* d */ /** e */
  172. // f
  173. '.'
  174. // g
  175. '.'
  176. /* h */
  177. 10 /* i */);
  178. }
  179. }',
  180. '<?php
  181. class FooTest extends TestCase {
  182. public function testFoo() {
  183. $someMock->method("someMethod")// a
  184. ->/* b */will/* c */(/* d */ $this/** e */
  185. -> // f
  186. returnValue
  187. // g
  188. (
  189. /* h */
  190. 10) /* i */);
  191. }
  192. }',
  193. ],
  194. 'will return with multi lines, messy indents and comments in weird places' => [
  195. '<?php
  196. class FooTest extends TestCase {
  197. public function testFoo() {
  198. $someMock
  199. ->method(
  200. "someMethod"
  201. )
  202. ->
  203. /* a */
  204. willReturn
  205. /*
  206. b
  207. c
  208. d
  209. e
  210. */ (
  211. // f g h i
  212. /* j */ '.'
  213. '.'
  214. 10
  215. /* k */
  216. /* l */);
  217. }
  218. }',
  219. '<?php
  220. class FooTest extends TestCase {
  221. public function testFoo() {
  222. $someMock
  223. ->method(
  224. "someMethod"
  225. )
  226. ->
  227. /* a */
  228. will
  229. /*
  230. b
  231. c
  232. d
  233. e
  234. */ (
  235. // f g h i
  236. /* j */ $this
  237. ->returnValue
  238. (10)
  239. /* k */
  240. /* l */);
  241. }
  242. }',
  243. ],
  244. ];
  245. }
  246. /**
  247. * @requires PHP 7.3
  248. */
  249. public function testFix73(): void
  250. {
  251. $this->doTest(
  252. '<?php
  253. class FooTest extends TestCase {
  254. public function testFoo() {
  255. $someMock->method("someMethod")->willReturn( 10 , );
  256. }
  257. }',
  258. '<?php
  259. class FooTest extends TestCase {
  260. public function testFoo() {
  261. $someMock->method("someMethod")->will($this->returnValue( 10 , ));
  262. }
  263. }'
  264. );
  265. }
  266. /**
  267. * @requires PHP 8.0
  268. */
  269. public function testFix80(): void
  270. {
  271. $this->doTest(
  272. '<?php
  273. class FooTest extends TestCase {
  274. public function testFoo() {
  275. $someMock?->method("someMethod")?->willReturn(10);
  276. }
  277. }',
  278. '<?php
  279. class FooTest extends TestCase {
  280. public function testFoo() {
  281. $someMock?->method("someMethod")?->will($this?->returnValue(10));
  282. }
  283. }'
  284. );
  285. }
  286. /**
  287. * @requires PHP 8.1
  288. */
  289. public function testFix81(): void
  290. {
  291. $this->doTest(
  292. '<?php
  293. class FooTest extends TestCase {
  294. public function testFoo() {
  295. $a = $someMock?->method("someMethod")->will($this?->returnValue(...));
  296. }
  297. }'
  298. );
  299. }
  300. }