1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291 |
- <?php
- declare(strict_types=1);
- /*
- * This file is part of PHP CS Fixer.
- *
- * (c) Fabien Potencier <fabien@symfony.com>
- * Dariusz Rumiński <dariusz.ruminski@gmail.com>
- *
- * This source file is subject to the MIT license that is bundled
- * with this source code in the file LICENSE.
- */
- namespace PhpCsFixer\Tests\Fixer\FunctionNotation;
- use PhpCsFixer\Tests\Test\AbstractFixerTestCase;
- use PhpCsFixer\WhitespacesFixerConfig;
- /**
- * @author Kuanhung Chen <ericj.tw@gmail.com>
- *
- * @internal
- *
- * @covers \PhpCsFixer\Fixer\FunctionNotation\MethodArgumentSpaceFixer
- */
- final class MethodArgumentSpaceFixerTest extends AbstractFixerTestCase
- {
- /**
- * @param array<string, mixed> $configuration
- *
- * @dataProvider provideFixCases
- */
- public function testFix(string $expected, ?string $input = null, array $configuration = []): void
- {
- $indent = ' ';
- $lineEnding = "\n";
- if (str_contains($expected, "\t")) {
- $indent = "\t";
- } elseif (preg_match('/\n \S/', $expected)) {
- $indent = ' ';
- }
- if (str_contains($expected, "\r")) {
- $lineEnding = "\r\n";
- }
- $this->fixer->configure($configuration);
- $this->fixer->setWhitespacesConfig(new WhitespacesFixerConfig(
- $indent,
- $lineEnding
- ));
- $this->doTest($expected, $input);
- }
- /**
- * @param array<string, mixed> $configuration
- *
- * @dataProvider provideFixCases
- */
- public function testFixWithDifferentLineEndings(string $expected, ?string $input = null, array $configuration = []): void
- {
- if (null !== $input) {
- $input = str_replace("\n", "\r\n", $input);
- }
- $this->testFix(
- str_replace("\n", "\r\n", $expected),
- $input,
- $configuration
- );
- }
- public static function provideFixCases(): iterable
- {
- yield [
- '<?php
- // space '.'
- $var1 = $a->some_method(
- $var2
- );
- // space '.'
- $var2 = some_function(
- $var2
- );
- // space '.'
- $var2a = $z[1](
- $var2a
- );
- '.'
- $var3 = function( $a, $b ) { };
- ',
- '<?php
- // space '.'
- $var1 = $a->some_method(
- $var2);
- // space '.'
- $var2 = some_function(
- $var2);
- // space '.'
- $var2a = $z[1](
- $var2a
- );
- '.'
- $var3 = function( $a , $b ) { };
- ',
- [
- 'on_multiline' => 'ensure_fully_multiline',
- ],
- ];
- yield 'default' => [
- '<?php xyz("", "", "", "");',
- '<?php xyz("","","","");',
- ];
- yield 'test method arguments' => [
- '<?php function xyz($a=10, $b=20, $c=30) {}',
- '<?php function xyz($a=10,$b=20,$c=30) {}',
- ];
- yield 'test method arguments with multiple spaces' => [
- '<?php function xyz($a=10, $b=20, $c=30) {}',
- '<?php function xyz($a=10, $b=20 , $c=30) {}',
- ];
- yield 'test method arguments with multiple spaces (kmsac)' => [
- '<?php function xyz($a=10, $b=20, $c=30) {}',
- '<?php function xyz($a=10, $b=20 , $c=30) {}',
- ['keep_multiple_spaces_after_comma' => true],
- ];
- yield 'test method call (I)' => [
- '<?php xyz($a=10, $b=20, $c=30);',
- '<?php xyz($a=10 ,$b=20,$c=30);',
- ];
- yield 'test method call (II)' => [
- '<?php xyz($a=10, $b=20, $this->foo(), $c=30);',
- '<?php xyz($a=10,$b=20 ,$this->foo() ,$c=30);',
- ];
- yield 'test method call with multiple spaces (I)' => [
- '<?php xyz($a=10, $b=20, $c=30);',
- '<?php xyz($a=10 , $b=20 , $c=30);',
- ];
- yield 'test method call with multiple spaces (I) (kmsac)' => [
- '<?php xyz($a=10, $b=20, $c=30);',
- '<?php xyz($a=10 , $b=20 , $c=30);',
- ['keep_multiple_spaces_after_comma' => true],
- ];
- yield 'test method call with tab' => [
- '<?php xyz($a=10, $b=20, $c=30);',
- "<?php xyz(\$a=10 , \$b=20 ,\t \$c=30);",
- ];
- yield 'test method call with tab (kmsac)' => [
- "<?php xyz(\$a=10, \$b=20,\t \$c=30);",
- "<?php xyz(\$a=10 , \$b=20 ,\t \$c=30);",
- ['keep_multiple_spaces_after_comma' => true],
- ];
- yield 'test method call with multiple spaces (II)' => [
- '<?php xyz($a=10, $b=20, $this->foo(), $c=30);',
- '<?php xyz($a=10,$b=20 , $this->foo() ,$c=30);',
- ];
- yield 'test method call with multiple spaces (II) (kmsac)' => [
- '<?php xyz($a=10, $b=20, $this->foo(), $c=30);',
- '<?php xyz($a=10,$b=20 , $this->foo() ,$c=30);',
- ['keep_multiple_spaces_after_comma' => true],
- ];
- yield 'test named class constructor call' => [
- '<?php new Foo($a=10, $b=20, $this->foo(), $c=30);',
- '<?php new Foo($a=10,$b=20 ,$this->foo() ,$c=30);',
- ];
- yield 'test named class constructor call with multiple spaces' => [
- '<?php new Foo($a=10, $b=20, $c=30);',
- '<?php new Foo($a=10 , $b=20 , $c=30);',
- ];
- yield 'test named class constructor call with multiple spaces (kmsac)' => [
- '<?php new Foo($a=10, $b=20, $c=30);',
- '<?php new Foo($a=10 , $b=20 , $c=30);',
- ['keep_multiple_spaces_after_comma' => true],
- ];
- yield 'test anonymous class constructor call' => [
- '<?php new class ($a=10, $b=20, $this->foo(), $c=30) {};',
- '<?php new class ($a=10,$b=20 ,$this->foo() ,$c=30) {};',
- ];
- yield 'test anonymous class constructor call with multiple spaces' => [
- '<?php new class ($a=10, $b=20, $c=30) extends Foo {};',
- '<?php new class ($a=10 , $b=20 , $c=30) extends Foo {};',
- ];
- yield 'test anonymous class constructor call with multiple spaces (kmsac)' => [
- '<?php new class ($a=10, $b=20, $c=30) {};',
- '<?php new class ($a=10 , $b=20 , $c=30) {};',
- ['keep_multiple_spaces_after_comma' => true],
- ];
- yield 'test receiving data in list context with omitted values' => [
- '<?php list($a, $b, , , $c) = foo();',
- '<?php list($a, $b,, ,$c) = foo();',
- ];
- yield 'test receiving data in list context with omitted values and multiple spaces' => [
- '<?php list($a, $b, , , $c) = foo();',
- '<?php list($a, $b,, ,$c) = foo();',
- ];
- yield 'test receiving data in list context with omitted values and multiple spaces (kmsac)' => [
- '<?php list($a, $b, , , $c) = foo();',
- '<?php list($a, $b,, ,$c) = foo();',
- ['keep_multiple_spaces_after_comma' => true],
- ];
- yield 'skip array' => [
- '<?php array(10 , 20 ,30); $foo = [ 10,50 , 60 ] ?>',
- ];
- yield 'list call with trailing comma' => [
- '<?php list($path, $mode, ) = foo();',
- '<?php list($path, $mode,) = foo();',
- ];
- yield 'list call with trailing comma multi line' => [
- '<?php
- list(
- $a,
- $b,
- ) = foo();
- ',
- '<?php
- list(
- $a ,
- $b ,
- ) = foo();
- ',
- ];
- yield 'inline comments with spaces' => [
- '<?php xyz($a=10, /*comment1*/ $b=2000, /*comment2*/ $c=30);',
- '<?php xyz($a=10, /*comment1*/ $b=2000,/*comment2*/ $c=30);',
- ];
- yield 'inline comments with spaces (kmsac)' => [
- '<?php xyz($a=10, /*comment1*/ $b=2000, /*comment2*/ $c=30);',
- '<?php xyz($a=10, /*comment1*/ $b=2000,/*comment2*/ $c=30);',
- ['keep_multiple_spaces_after_comma' => true],
- ];
- yield 'multi line testing method call' => [
- '<?php if (1) {
- xyz(
- $a=10,
- $b=20,
- $c=30
- );
- }',
- '<?php if (1) {
- xyz(
- $a=10 ,
- $b=20,
- $c=30
- );
- }',
- ];
- yield 'multi line anonymous class constructor call' => [
- '<?php if (1) {
- new class (
- $a=10,
- $b=20,
- $c=30
- ) {};
- }',
- '<?php if (1) {
- new class (
- $a=10 ,
- $b=20,$c=30) {};
- }',
- ];
- yield 'skip arrays but replace arg methods' => [
- '<?php fnc(1, array(2, func2(6, 7) ,4), 5);',
- '<?php fnc(1,array(2, func2(6, 7) ,4), 5);',
- ];
- yield 'skip arrays but replace arg methods (kmsac)' => [
- '<?php fnc(1, array(2, func2(6, 7) ,4), 5);',
- '<?php fnc(1,array(2, func2(6, 7) ,4), 5);',
- ['keep_multiple_spaces_after_comma' => true],
- ];
- yield 'ignore commas inside call argument' => [
- '<?php fnc(1, array(2, 3 ,4), 5);',
- ];
- yield 'skip multi line array' => [
- '<?php
- array(
- 10 ,
- 20,
- 30
- );',
- ];
- yield 'skip short array' => [
- '<?php
- $foo = ["a"=>"apple", "b"=>"bed" ,"c"=>"car"];
- $bar = ["a" ,"b" ,"c"];
- ',
- ];
- yield 'don\'t change HEREDOC and NOWDOC' => [
- "<?php if (1) {
- \$this->foo(
- <<<EOTXTa
- heredoc
- EOTXTa
- ,
- <<<'EOTXTb'
- nowdoc
- EOTXTb
- ,
- 'foo'
- );
- }",
- ];
- yield 'with_random_comments on_multiline:ignore' => [
- '<?php xyz#
- (#
- ""#
- ,#
- $a#
- );',
- null,
- ['on_multiline' => 'ignore'],
- ];
- yield 'with_random_comments on_multiline:ensure_single_line' => [
- '<?php xyz#
- (#
- ""#
- ,#
- $a#
- );',
- null,
- ['on_multiline' => 'ensure_single_line'],
- ];
- yield 'with_random_comments on_multiline:ensure_fully_multiline' => [
- '<?php xyz#
- (#
- ""#
- ,#
- $a#
- );',
- '<?php xyz#
- (#
- ""#
- ,#
- $a#
- );',
- ['on_multiline' => 'ensure_fully_multiline'],
- ];
- yield 'test half-multiline function becomes fully-multiline' => [
- <<<'EXPECTED'
- <?php
- functionCall(
- 'a',
- 'b',
- 'c'
- );
- EXPECTED
- ,
- <<<'INPUT'
- <?php
- functionCall(
- 'a', 'b',
- 'c'
- );
- INPUT
- ,
- ];
- yield 'test wrongly formatted half-multiline function becomes fully-multiline' => [
- '<?php
- f(
- 1,
- 2,
- 3
- );',
- '<?php
- f(1,2,
- 3);',
- ];
- yield 'function calls with here doc cannot be anything but multiline' => [
- <<<'EXPECTED'
- <?php
- str_replace(
- "\n",
- PHP_EOL,
- <<<'TEXT'
- 1) someFile.php
- TEXT
- );
- EXPECTED
- ,
- <<<'INPUT'
- <?php
- str_replace("\n", PHP_EOL, <<<'TEXT'
- 1) someFile.php
- TEXT
- );
- INPUT
- ,
- ];
- yield 'test barely multiline function with blank lines becomes fully-multiline' => [
- <<<'EXPECTED'
- <?php
- functionCall(
- 'a',
- 'b',
- 'c'
- );
- EXPECTED
- ,
- <<<'INPUT'
- <?php
- functionCall('a', 'b',
- 'c');
- INPUT
- ,
- ];
- yield 'test indentation is preserved' => [
- <<<'EXPECTED'
- <?php
- if (true) {
- functionCall(
- 'a',
- 'b',
- 'c'
- );
- }
- EXPECTED
- ,
- <<<'INPUT'
- <?php
- if (true) {
- functionCall(
- 'a', 'b',
- 'c'
- );
- }
- INPUT
- ,
- ];
- yield 'test multiline array arguments do not trigger multiline' => [
- <<<'EXPECTED'
- <?php
- defraculate(1, array(
- 'a',
- 'b',
- 'c',
- ), 42);
- EXPECTED
- ,
- ];
- yield 'test multiline function arguments do not trigger multiline' => [
- <<<'EXPECTED'
- <?php
- defraculate(1, function () {
- $a = 42;
- }, 42);
- EXPECTED
- ,
- ];
- yield 'test violation after opening parenthesis' => [
- <<<'EXPECTED'
- <?php
- defraculate(
- 1,
- 2,
- 3
- );
- EXPECTED
- ,
- <<<'INPUT'
- <?php
- defraculate(
- 1, 2, 3);
- INPUT
- ,
- ];
- yield 'test violation after opening parenthesis, indented with two spaces' => [
- <<<'EXPECTED'
- <?php
- defraculate(
- 1,
- 2,
- 3
- );
- EXPECTED
- ,
- <<<'INPUT'
- <?php
- defraculate(
- 1, 2, 3);
- INPUT
- ,
- ];
- yield 'test violation after opening parenthesis, indented with tabs' => [
- <<<'EXPECTED'
- <?php
- defraculate(
- 1,
- 2,
- 3
- );
- EXPECTED
- ,
- <<<'INPUT'
- <?php
- defraculate(
- 1, 2, 3);
- INPUT
- ,
- ];
- yield 'test violation before closing parenthesis' => [
- <<<'EXPECTED'
- <?php
- defraculate(
- 1,
- 2,
- 3
- );
- EXPECTED
- ,
- <<<'INPUT'
- <?php
- defraculate(1, 2, 3
- );
- INPUT
- ,
- ];
- yield 'test violation before closing parenthesis in nested call' => [
- <<<'EXPECTED'
- <?php
- getSchwifty('rick', defraculate(
- 1,
- 2,
- 3
- ), 'morty');
- EXPECTED
- ,
- <<<'INPUT'
- <?php
- getSchwifty('rick', defraculate(1, 2, 3
- ), 'morty');
- INPUT
- ,
- ];
- yield 'test with comment between arguments' => [
- <<<'EXPECTED'
- <?php
- functionCall(
- 'a', /* comment */
- 'b',
- 'c'
- );
- EXPECTED
- ,
- <<<'INPUT'
- <?php
- functionCall(
- 'a',/* comment */'b',
- 'c'
- );
- INPUT
- ,
- ];
- yield 'test with deeply nested arguments' => [
- <<<'EXPECTED'
- <?php
- foo(
- 'a',
- 'b',
- [
- 'c',
- 'd', bar('e', 'f'),
- baz(
- 'g',
- ['h',
- 'i',
- ]
- ),
- ]
- );
- EXPECTED
- ,
- <<<'INPUT'
- <?php
- foo('a',
- 'b',
- [
- 'c',
- 'd', bar('e', 'f'),
- baz('g',
- ['h',
- 'i',
- ]),
- ]);
- INPUT
- ,
- ];
- yield 'multiline string argument' => [
- <<<'UNAFFECTED'
- <?php
- $this->with('<?php
- %s
- class FooClass
- {
- }', $comment, false);
- UNAFFECTED
- ,
- ];
- yield 'arrays with whitespace inside' => [
- <<<'UNAFFECTED'
- <?php
- $a = array/**/( 1);
- $a = array/**/( 12,
- 7);
- $a = array/***/(123, 7);
- $a = array ( 1,
- 2);
- UNAFFECTED
- ,
- ];
- yield 'test code that should not be affected (because not a function nor a method)' => [
- <<<'UNAFFECTED'
- <?php
- if (true &&
- true
- ) {
- // do whatever
- }
- UNAFFECTED
- ,
- ];
- yield 'test ungodly code' => [
- <<<'EXPECTED'
- <?php
- $a = function#
- (#
- #
- $a#
- #
- ,#
- #
- $b,
- $c#
- #
- )#
- use (
- $b1,
- $c1,
- $d1
- ) {
- };
- EXPECTED
- ,
- <<<'INPUT'
- <?php
- $a = function#
- (#
- #
- $a#
- #
- ,#
- #
- $b,$c#
- #
- )#
- use ($b1,
- $c1,$d1) {
- };
- INPUT
- ,
- ];
- yield 'test list' => [
- <<<'UNAFFECTED'
- <?php
- // no fix
- list($a,
- $b, $c) = $a;
- isset($a,
- $b, $c);
- unset($a,
- $b, $c);
- array(1,
- 2,3
- );
- UNAFFECTED
- ,
- ];
- yield 'test function argument with multiline echo in it' => [
- <<<'UNAFFECTED'
- <?php
- call_user_func(function ($arguments) {
- echo 'a',
- 'b';
- }, $argv);
- UNAFFECTED
- ,
- ];
- yield 'test function argument with oneline echo in it' => [
- <<<'EXPECTED'
- <?php
- call_user_func(
- function ($arguments) {
- echo 'a', 'b';
- },
- $argv
- );
- EXPECTED
- ,
- <<<'INPUT'
- <?php
- call_user_func(function ($arguments) {
- echo 'a', 'b';
- },
- $argv);
- INPUT
- ,
- ];
- yield 'ensure_single_line' => [
- <<<'EXPECTED'
- <?php
- function foo($a, $b) {
- // foo
- }
- foo($a, $b);
- EXPECTED
- ,
- <<<'INPUT'
- <?php
- function foo(
- $a,
- $b
- ) {
- // foo
- }
- foo(
- $a,
- $b
- );
- INPUT
- ,
- ['on_multiline' => 'ensure_single_line'],
- ];
- yield 'ensure_single_line_with_random_comments' => [
- <<<'EXPECTED'
- <?php
- function foo(/* foo */// bar
- $a, /* foo */// bar
- $b#foo
- ) {
- // foo
- }
- foo(/* foo */// bar
- $a, /* foo */// bar
- $b#foo
- );
- EXPECTED
- ,
- null,
- ['on_multiline' => 'ensure_single_line'],
- ];
- yield 'ensure_single_line_with_consecutive_newlines' => [
- <<<'EXPECTED'
- <?php
- function foo($a, $b) {
- // foo
- }
- foo($a, $b);
- EXPECTED
- ,
- <<<'INPUT'
- <?php
- function foo(
- $a,
- $b
- ) {
- // foo
- }
- foo(
- $a,
- $b
- );
- INPUT
- ,
- ['on_multiline' => 'ensure_single_line'],
- ];
- yield 'ensure_single_line_methods' => [
- <<<'EXPECTED'
- <?php
- class Foo {
- public static function foo1($a, $b, $c) {}
- private function foo2($a, $b, $c) {}
- }
- EXPECTED
- ,
- <<<'INPUT'
- <?php
- class Foo {
- public static function foo1(
- $a,
- $b,
- $c
- ) {}
- private function foo2(
- $a,
- $b,
- $c
- ) {}
- }
- INPUT
- ,
- ['on_multiline' => 'ensure_single_line'],
- ];
- yield 'ensure_single_line_methods_in_anonymous_class' => [
- <<<'EXPECTED'
- <?php
- new class {
- public static function foo1($a, $b, $c) {}
- private function foo2($a, $b, $c) {}
- };
- EXPECTED
- ,
- <<<'INPUT'
- <?php
- new class {
- public static function foo1(
- $a,
- $b,
- $c
- ) {}
- private function foo2(
- $a,
- $b,
- $c
- ) {}
- };
- INPUT
- ,
- ['on_multiline' => 'ensure_single_line'],
- ];
- yield 'ensure_single_line_keep_spaces_after_comma' => [
- <<<'EXPECTED'
- <?php
- function foo($a, $b) {
- // foo
- }
- foo($a, $b);
- EXPECTED
- ,
- <<<'INPUT'
- <?php
- function foo(
- $a,
- $b
- ) {
- // foo
- }
- foo(
- $a,
- $b
- );
- INPUT
- ,
- [
- 'on_multiline' => 'ensure_single_line',
- 'keep_multiple_spaces_after_comma' => true,
- ],
- ];
- yield 'fix closing parenthesis (without trailing comma)' => [
- '<?php
- if (true) {
- execute(
- $foo,
- $bar
- );
- }',
- '<?php
- if (true) {
- execute(
- $foo,
- $bar
- );
- }',
- [
- 'on_multiline' => 'ensure_fully_multiline',
- ],
- ];
- yield 'test anonymous functions' => [
- '<?php
- $example = function () use ($message1, $message2) {
- };',
- '<?php
- $example = function () use ($message1,$message2) {
- };',
- ];
- yield 'test first element in same line, space before comma and inconsistent indent' => [
- '<?php foo(
- "aaa
- bbb",
- $c,
- $d,
- $e,
- $f
- );
- ',
- '<?php foo("aaa
- bbb",
- $c, $d ,
- $e,
- $f);
- ',
- ];
- yield 'test first element in same line, space before comma and inconsistent indent with comments' => [
- '<?php foo(
- "aaa
- bbb", // comment1
- $c, /** comment2 */
- $d,
- $e/* comment3 */,
- $f
- );# comment4
- ',
- '<?php foo("aaa
- bbb", // comment1
- $c, /** comment2 */$d ,
- $e/* comment3 */,
- $f);# comment4
- ',
- ];
- yield [
- '<?php
- foo(
- /* bar */
- "baz"
- );
- ',
- '<?php
- foo(
- /* bar */ "baz"
- );
- ',
- ];
- }
- /**
- * @param array<string, mixed> $config
- *
- * @dataProvider provideFix2Cases
- */
- public function testFix2(string $expected, ?string $input = null, array $config = []): void
- {
- $this->fixer->configure($config);
- $this->doTest($expected, $input);
- }
- public static function provideFix2Cases(): iterable
- {
- yield [
- '<?php function A($c, ...$a){}',
- '<?php function A($c ,...$a){}',
- ];
- yield [
- <<<'EXPECTED'
- <?php
- foo(
- <<<'EOD'
- bar
- EOD,
- 'baz'
- );
- EXPECTED
- ,
- <<<'INPUT'
- <?php
- foo(
- <<<'EOD'
- bar
- EOD
- ,
- 'baz'
- );
- INPUT
- ,
- ['after_heredoc' => true],
- ];
- yield [
- <<<'EXPECTED'
- <?php
- foo(
- $bar,
- $baz,
- );
- EXPECTED
- ,
- null,
- ['on_multiline' => 'ensure_fully_multiline'],
- ];
- yield [
- '<?php
- functionCall(
- 1,
- 2,
- 3,
- );',
- '<?php
- functionCall(
- 1, 2,
- 3,
- );',
- [
- 'on_multiline' => 'ensure_fully_multiline',
- ],
- ];
- yield [
- '<?php foo(1, 2, 3, );',
- '<?php foo(1,2,3,);',
- ];
- yield [
- '<?php
- $fn = fn(
- $test1,
- $test2
- ) => null;',
- '<?php
- $fn = fn(
- $test1, $test2
- ) => null;',
- [
- 'on_multiline' => 'ensure_fully_multiline',
- ],
- ];
- }
- /**
- * @param array<string, mixed> $config
- *
- * @dataProvider provideFix80Cases
- *
- * @requires PHP 8.0
- */
- public function testFix80(string $expected, ?string $input = null, array $config = []): void
- {
- $this->fixer->configure($config);
- $this->doTest($expected, $input);
- }
- public static function provideFix80Cases(): iterable
- {
- yield 'multiple attributes' => [
- '<?php
- class MyClass
- {
- public function __construct(
- private string $id,
- #[Foo]
- #[Bar]
- private ?string $name = null,
- ) {}
- }',
- '<?php
- class MyClass
- {
- public function __construct(
- private string $id,
- #[Foo] #[Bar] private ?string $name = null,
- ) {}
- }',
- ];
- yield 'keep attributes as-is' => [
- '<?php
- class MyClass
- {
- public function __construct(
- private string $id,
- #[Foo] #[Bar] private ?string $name = null,
- ) {}
- }',
- null,
- [
- 'attribute_placement' => 'ignore',
- ],
- ];
- yield 'multiple attributes on the same line as argument' => [
- '<?php
- class MyClass
- {
- public function __construct(
- private string $id,
- #[Foo] #[Bar] private ?string $name = null,
- ) {}
- }',
- '<?php
- class MyClass
- {
- public function __construct(
- private string $id,
- #[Foo]
- #[Bar]
- private ?string $name = null,
- ) {}
- }',
- [
- 'attribute_placement' => 'same_line',
- ],
- ];
- yield 'single attribute markup with comma separated list' => [
- '<?php
- class MyClass
- {
- public function __construct(
- private string $id,
- #[Foo, Bar]
- private ?string $name = null,
- ) {}
- }',
- '<?php
- class MyClass
- {
- public function __construct(
- private string $id,
- #[Foo, Bar] private ?string $name = null,
- ) {}
- }',
- ];
- yield 'attributes with arguments' => [
- '<?php
- class MyClass
- {
- public function __construct(
- private string $id,
- #[Foo(value: 1234, otherValue: [1, 2, 3])]
- #[Bar(Bar::BAZ, array(\'[\',\']\'))]
- private ?string $name = null,
- ) {}
- }',
- '<?php
- class MyClass
- {
- public function __construct(
- private string $id,
- #[Foo(value: 1234, otherValue: [1, 2, 3])] #[Bar(Bar::BAZ, array(\'[\',\']\'))] private ?string $name = null,
- ) {}
- }',
- ];
- yield 'fully qualified attributes' => [
- '<?php
- function foo(
- #[\Foo\Bar]
- $bar,
- #[\Foo\Baz]
- $baz,
- #[\Foo\Buzz]
- $buzz
- ) {}',
- '<?php
- function foo(
- #[\Foo\Bar] $bar, #[\Foo\Baz] $baz, #[\Foo\Buzz] $buzz
- ) {}',
- ];
- yield 'multiline attributes' => [
- '<?php
- function foo(
- $foo,
- #[
- Foo\Bar,
- Foo\Baz,
- Foo\Buzz(a: \'astral\', b: 1234),
- ]
- $bar
- ) {}',
- '<?php
- function foo($foo, #[
- Foo\Bar,
- Foo\Baz,
- Foo\Buzz(a: \'astral\', b: 1234),
- ] $bar) {}',
- ];
- }
- /**
- * @dataProvider provideFix81Cases
- *
- * @requires PHP 8.1
- */
- public function testFix81(string $expected, ?string $input = null): void
- {
- $this->doTest($expected, $input);
- }
- public static function provideFix81Cases(): iterable
- {
- yield [
- '<?php
- [Foo::class, \'method\'](
- ...
- ) ?>',
- '<?php
- [Foo::class, \'method\']( ...
- ) ?>',
- ];
- }
- }
|