123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582 |
- <?php
- /*
- * This file is part of PHP CS Fixer.
- *
- * (c) Fabien Potencier <fabien@symfony.com>
- * Dariusz Rumiński <dariusz.ruminski@gmail.com>
- *
- * This source file is subject to the MIT license that is bundled
- * with this source code in the file LICENSE.
- */
- namespace PhpCsFixer\Tests\AutoReview;
- use PhpCsFixer\Fixer\FixerInterface;
- use PhpCsFixer\FixerFactory;
- use PhpCsFixer\Tests\Test\IntegrationCaseFactory;
- use PhpCsFixer\Tests\TestCase;
- use Symfony\Component\Finder\SplFileInfo;
- /**
- * @author Dariusz Rumiński <dariusz.ruminski@gmail.com>
- *
- * @internal
- *
- * @coversNothing
- * @group auto-review
- * @group covers-nothing
- */
- final class FixerFactoryTest extends TestCase
- {
- public function testFixersPriorityEdgeFixers()
- {
- $factory = new FixerFactory();
- $factory->registerBuiltInFixers();
- $fixers = $factory->getFixers();
- static::assertSame('encoding', $fixers[0]->getName(), 'Expected "encoding" fixer to have the highest priority.');
- static::assertSame('full_opening_tag', $fixers[1]->getName(), 'Expected "full_opening_tag" fixer has second highest priority.');
- static::assertSame('single_blank_line_at_eof', $fixers[\count($fixers) - 1]->getName(), 'Expected "single_blank_line_at_eof" to have the lowest priority.');
- }
- /**
- * @dataProvider provideFixersPriorityCases
- * @dataProvider provideFixersPrioritySpecialPhpdocCases
- */
- public function testFixersPriority(FixerInterface $first, FixerInterface $second)
- {
- static::assertLessThan($first->getPriority(), $second->getPriority(), sprintf('"%s" should have less priority than "%s"', \get_class($second), \get_class($first)));
- }
- public function provideFixersPriorityCases()
- {
- $factory = new FixerFactory();
- $factory->registerBuiltInFixers();
- $fixers = [];
- foreach ($factory->getFixers() as $fixer) {
- $fixers[$fixer->getName()] = $fixer;
- }
- return [
- [$fixers['array_indentation'], $fixers['align_multiline_comment']],
- [$fixers['array_indentation'], $fixers['binary_operator_spaces']],
- [$fixers['array_syntax'], $fixers['binary_operator_spaces']],
- [$fixers['array_syntax'], $fixers['ternary_operator_spaces']],
- [$fixers['backtick_to_shell_exec'], $fixers['escape_implicit_backslashes']],
- [$fixers['backtick_to_shell_exec'], $fixers['explicit_string_variable']],
- [$fixers['blank_line_after_opening_tag'], $fixers['no_blank_lines_before_namespace']],
- [$fixers['braces'], $fixers['array_indentation']],
- [$fixers['braces'], $fixers['method_argument_space']],
- [$fixers['braces'], $fixers['method_chaining_indentation']],
- [$fixers['class_attributes_separation'], $fixers['braces']],
- [$fixers['class_attributes_separation'], $fixers['indentation_type']],
- [$fixers['class_keyword_remove'], $fixers['no_unused_imports']],
- [$fixers['combine_consecutive_issets'], $fixers['multiline_whitespace_before_semicolons']],
- [$fixers['combine_consecutive_issets'], $fixers['no_singleline_whitespace_before_semicolons']],
- [$fixers['combine_consecutive_issets'], $fixers['no_spaces_inside_parenthesis']],
- [$fixers['combine_consecutive_issets'], $fixers['no_trailing_whitespace']],
- [$fixers['combine_consecutive_issets'], $fixers['no_whitespace_in_blank_line']],
- [$fixers['combine_consecutive_unsets'], $fixers['no_extra_blank_lines']],
- [$fixers['combine_consecutive_unsets'], $fixers['no_trailing_whitespace']],
- [$fixers['combine_consecutive_unsets'], $fixers['no_whitespace_in_blank_line']],
- [$fixers['combine_consecutive_unsets'], $fixers['space_after_semicolon']],
- [$fixers['combine_nested_dirname'], $fixers['method_argument_space']],
- [$fixers['combine_nested_dirname'], $fixers['no_spaces_inside_parenthesis']],
- [$fixers['declare_strict_types'], $fixers['blank_line_after_opening_tag']],
- [$fixers['declare_strict_types'], $fixers['declare_equal_normalize']],
- [$fixers['dir_constant'], $fixers['combine_nested_dirname']],
- [$fixers['doctrine_annotation_array_assignment'], $fixers['doctrine_annotation_spaces']],
- [$fixers['elseif'], $fixers['braces']],
- [$fixers['escape_implicit_backslashes'], $fixers['heredoc_to_nowdoc']],
- [$fixers['escape_implicit_backslashes'], $fixers['single_quote']],
- [$fixers['explicit_string_variable'], $fixers['simple_to_complex_string_variable']],
- [$fixers['fully_qualified_strict_types'], $fixers['no_superfluous_phpdoc_tags']],
- [$fixers['function_to_constant'], $fixers['native_function_casing']],
- [$fixers['function_to_constant'], $fixers['no_extra_blank_lines']],
- [$fixers['function_to_constant'], $fixers['no_singleline_whitespace_before_semicolons']],
- [$fixers['function_to_constant'], $fixers['no_trailing_whitespace']],
- [$fixers['function_to_constant'], $fixers['no_whitespace_in_blank_line']],
- [$fixers['general_phpdoc_annotation_remove'], $fixers['no_empty_phpdoc']],
- [$fixers['general_phpdoc_annotation_remove'], $fixers['phpdoc_separation']],
- [$fixers['general_phpdoc_annotation_remove'], $fixers['phpdoc_trim']],
- [$fixers['implode_call'], $fixers['method_argument_space']],
- [$fixers['indentation_type'], $fixers['phpdoc_indent']],
- [$fixers['is_null'], $fixers['yoda_style']],
- [$fixers['line_ending'], $fixers['braces']],
- [$fixers['list_syntax'], $fixers['binary_operator_spaces']],
- [$fixers['list_syntax'], $fixers['ternary_operator_spaces']],
- [$fixers['method_chaining_indentation'], $fixers['array_indentation']],
- [$fixers['method_separation'], $fixers['braces']],
- [$fixers['method_separation'], $fixers['indentation_type']],
- [$fixers['multiline_whitespace_before_semicolons'], $fixers['space_after_semicolon']],
- [$fixers['no_alias_functions'], $fixers['implode_call']],
- [$fixers['no_alias_functions'], $fixers['php_unit_dedicate_assert']],
- [$fixers['no_alternative_syntax'], $fixers['braces']],
- [$fixers['no_alternative_syntax'], $fixers['elseif']],
- [$fixers['no_alternative_syntax'], $fixers['no_superfluous_elseif']],
- [$fixers['no_alternative_syntax'], $fixers['no_useless_else']],
- [$fixers['no_blank_lines_after_phpdoc'], $fixers['header_comment']],
- [$fixers['no_blank_lines_after_phpdoc'], $fixers['single_blank_line_before_namespace']],
- [$fixers['no_empty_comment'], $fixers['no_extra_blank_lines']],
- [$fixers['no_empty_comment'], $fixers['no_trailing_whitespace']],
- [$fixers['no_empty_comment'], $fixers['no_whitespace_in_blank_line']],
- [$fixers['no_empty_phpdoc'], $fixers['no_extra_blank_lines']],
- [$fixers['no_empty_phpdoc'], $fixers['no_trailing_whitespace']],
- [$fixers['no_empty_phpdoc'], $fixers['no_whitespace_in_blank_line']],
- [$fixers['no_empty_statement'], $fixers['braces']],
- [$fixers['no_empty_statement'], $fixers['combine_consecutive_unsets']],
- [$fixers['no_empty_statement'], $fixers['multiline_whitespace_before_semicolons']],
- [$fixers['no_empty_statement'], $fixers['no_extra_blank_lines']],
- [$fixers['no_empty_statement'], $fixers['no_singleline_whitespace_before_semicolons']],
- [$fixers['no_empty_statement'], $fixers['no_trailing_whitespace']],
- [$fixers['no_empty_statement'], $fixers['no_useless_else']],
- [$fixers['no_empty_statement'], $fixers['no_useless_return']],
- [$fixers['no_empty_statement'], $fixers['no_whitespace_in_blank_line']],
- [$fixers['no_empty_statement'], $fixers['return_assignment']],
- [$fixers['no_empty_statement'], $fixers['space_after_semicolon']],
- [$fixers['no_empty_statement'], $fixers['switch_case_semicolon_to_colon']],
- [$fixers['no_extra_blank_lines'], $fixers['blank_line_before_statement']],
- [$fixers['no_leading_import_slash'], $fixers['ordered_imports']],
- [$fixers['no_multiline_whitespace_around_double_arrow'], $fixers['binary_operator_spaces']],
- [$fixers['no_multiline_whitespace_around_double_arrow'], $fixers['trailing_comma_in_multiline_array']],
- [$fixers['no_php4_constructor'], $fixers['ordered_class_elements']],
- [$fixers['no_short_bool_cast'], $fixers['cast_spaces']],
- [$fixers['no_short_echo_tag'], $fixers['no_mixed_echo_print']],
- [$fixers['no_spaces_after_function_name'], $fixers['function_to_constant']],
- [$fixers['no_spaces_inside_parenthesis'], $fixers['function_to_constant']],
- [$fixers['no_superfluous_phpdoc_tags'], $fixers['no_empty_phpdoc']],
- [$fixers['no_unneeded_control_parentheses'], $fixers['no_trailing_whitespace']],
- [$fixers['no_unneeded_curly_braces'], $fixers['no_useless_else']],
- [$fixers['no_unneeded_curly_braces'], $fixers['no_useless_return']],
- [$fixers['no_unneeded_curly_braces'], $fixers['return_assignment']],
- [$fixers['no_unset_on_property'], $fixers['combine_consecutive_unsets']],
- [$fixers['no_unused_imports'], $fixers['blank_line_after_namespace']],
- [$fixers['no_unused_imports'], $fixers['no_extra_blank_lines']],
- [$fixers['no_unused_imports'], $fixers['no_leading_import_slash']],
- [$fixers['no_unused_imports'], $fixers['single_line_after_imports']],
- [$fixers['no_useless_else'], $fixers['braces']],
- [$fixers['no_useless_else'], $fixers['combine_consecutive_unsets']],
- [$fixers['no_useless_else'], $fixers['no_extra_blank_lines']],
- [$fixers['no_useless_else'], $fixers['no_trailing_whitespace']],
- [$fixers['no_useless_else'], $fixers['no_useless_return']],
- [$fixers['no_useless_else'], $fixers['no_whitespace_in_blank_line']],
- [$fixers['no_useless_return'], $fixers['blank_line_before_return']],
- [$fixers['no_useless_return'], $fixers['blank_line_before_statement']],
- [$fixers['no_useless_return'], $fixers['no_extra_blank_lines']],
- [$fixers['no_useless_return'], $fixers['no_whitespace_in_blank_line']],
- [$fixers['ordered_class_elements'], $fixers['class_attributes_separation']],
- [$fixers['ordered_class_elements'], $fixers['method_separation']],
- [$fixers['ordered_class_elements'], $fixers['no_blank_lines_after_class_opening']],
- [$fixers['ordered_class_elements'], $fixers['space_after_semicolon']],
- [$fixers['php_unit_construct'], $fixers['php_unit_dedicate_assert']],
- [$fixers['php_unit_dedicate_assert'], $fixers['php_unit_dedicate_assert_internal_type']],
- [$fixers['php_unit_fqcn_annotation'], $fixers['no_unused_imports']],
- [$fixers['php_unit_fqcn_annotation'], $fixers['php_unit_ordered_covers']],
- [$fixers['php_unit_internal_class'], $fixers['final_internal_class']],
- [$fixers['php_unit_no_expectation_annotation'], $fixers['no_empty_phpdoc']],
- [$fixers['php_unit_no_expectation_annotation'], $fixers['php_unit_expectation']],
- [$fixers['php_unit_test_annotation'], $fixers['no_empty_phpdoc']],
- [$fixers['php_unit_test_annotation'], $fixers['php_unit_method_casing']],
- [$fixers['php_unit_test_annotation'], $fixers['phpdoc_trim']],
- [$fixers['phpdoc_add_missing_param_annotation'], $fixers['no_empty_phpdoc']],
- [$fixers['phpdoc_add_missing_param_annotation'], $fixers['no_superfluous_phpdoc_tags']],
- [$fixers['phpdoc_add_missing_param_annotation'], $fixers['phpdoc_align']],
- [$fixers['phpdoc_add_missing_param_annotation'], $fixers['phpdoc_order']],
- [$fixers['phpdoc_no_access'], $fixers['no_empty_phpdoc']],
- [$fixers['phpdoc_no_access'], $fixers['phpdoc_order']],
- [$fixers['phpdoc_no_access'], $fixers['phpdoc_separation']],
- [$fixers['phpdoc_no_access'], $fixers['phpdoc_trim']],
- [$fixers['phpdoc_no_alias_tag'], $fixers['phpdoc_add_missing_param_annotation']],
- [$fixers['phpdoc_no_alias_tag'], $fixers['phpdoc_single_line_var_spacing']],
- [$fixers['phpdoc_no_empty_return'], $fixers['no_empty_phpdoc']],
- [$fixers['phpdoc_no_empty_return'], $fixers['phpdoc_order']],
- [$fixers['phpdoc_no_empty_return'], $fixers['phpdoc_separation']],
- [$fixers['phpdoc_no_empty_return'], $fixers['phpdoc_trim']],
- [$fixers['phpdoc_no_package'], $fixers['no_empty_phpdoc']],
- [$fixers['phpdoc_no_package'], $fixers['phpdoc_order']],
- [$fixers['phpdoc_no_package'], $fixers['phpdoc_separation']],
- [$fixers['phpdoc_no_package'], $fixers['phpdoc_trim']],
- [$fixers['phpdoc_no_useless_inheritdoc'], $fixers['no_empty_phpdoc']],
- [$fixers['phpdoc_no_useless_inheritdoc'], $fixers['no_trailing_whitespace_in_comment']],
- [$fixers['phpdoc_order'], $fixers['phpdoc_separation']],
- [$fixers['phpdoc_order'], $fixers['phpdoc_trim']],
- [$fixers['phpdoc_return_self_reference'], $fixers['no_superfluous_phpdoc_tags']],
- [$fixers['phpdoc_scalar'], $fixers['phpdoc_to_return_type']],
- [$fixers['phpdoc_to_comment'], $fixers['no_empty_comment']],
- [$fixers['phpdoc_to_comment'], $fixers['phpdoc_no_useless_inheritdoc']],
- [$fixers['phpdoc_to_return_type'], $fixers['fully_qualified_strict_types']],
- [$fixers['phpdoc_to_return_type'], $fixers['no_superfluous_phpdoc_tags']],
- [$fixers['phpdoc_to_return_type'], $fixers['return_type_declaration']],
- [$fixers['phpdoc_types'], $fixers['phpdoc_to_return_type']],
- [$fixers['pow_to_exponentiation'], $fixers['binary_operator_spaces']],
- [$fixers['pow_to_exponentiation'], $fixers['method_argument_space']],
- [$fixers['pow_to_exponentiation'], $fixers['native_function_casing']],
- [$fixers['pow_to_exponentiation'], $fixers['no_spaces_after_function_name']],
- [$fixers['pow_to_exponentiation'], $fixers['no_spaces_inside_parenthesis']],
- [$fixers['protected_to_private'], $fixers['ordered_class_elements']],
- [$fixers['return_assignment'], $fixers['blank_line_before_statement']],
- [$fixers['simplified_null_return'], $fixers['no_useless_return']],
- [$fixers['single_import_per_statement'], $fixers['multiline_whitespace_before_semicolons']],
- [$fixers['single_import_per_statement'], $fixers['no_leading_import_slash']],
- [$fixers['single_import_per_statement'], $fixers['no_singleline_whitespace_before_semicolons']],
- [$fixers['single_import_per_statement'], $fixers['no_unused_imports']],
- [$fixers['single_import_per_statement'], $fixers['space_after_semicolon']],
- [$fixers['single_trait_insert_per_statement'], $fixers['braces']],
- [$fixers['single_trait_insert_per_statement'], $fixers['space_after_semicolon']],
- [$fixers['standardize_increment'], $fixers['increment_style']],
- [$fixers['standardize_not_equals'], $fixers['binary_operator_spaces']],
- [$fixers['strict_comparison'], $fixers['binary_operator_spaces']],
- [$fixers['unary_operator_spaces'], $fixers['not_operator_with_space']],
- [$fixers['unary_operator_spaces'], $fixers['not_operator_with_successor_space']],
- [$fixers['void_return'], $fixers['phpdoc_no_empty_return']],
- [$fixers['void_return'], $fixers['return_type_declaration']],
- ];
- }
- public function provideFixersPrioritySpecialPhpdocCases()
- {
- $factory = new FixerFactory();
- $factory->registerBuiltInFixers();
- $fixers = [];
- foreach ($factory->getFixers() as $fixer) {
- $fixers[$fixer->getName()] = $fixer;
- }
- $cases = [];
- // prepare bulk tests for phpdoc fixers to test that:
- // * `comment_to_phpdoc` is first
- // * `phpdoc_to_comment` is second
- // * `phpdoc_indent` is third
- // * `phpdoc_types` is fourth
- // * `phpdoc_scalar` is fifth
- // * `phpdoc_align` is last
- $cases[] = [$fixers['comment_to_phpdoc'], $fixers['phpdoc_to_comment']];
- $cases[] = [$fixers['phpdoc_indent'], $fixers['phpdoc_types']];
- $cases[] = [$fixers['phpdoc_to_comment'], $fixers['phpdoc_indent']];
- $cases[] = [$fixers['phpdoc_types'], $fixers['phpdoc_scalar']];
- $docFixerNames = array_filter(
- array_keys($fixers),
- static function ($name) {
- return false !== strpos($name, 'phpdoc');
- }
- );
- foreach ($docFixerNames as $docFixerName) {
- if (!\in_array($docFixerName, ['comment_to_phpdoc', 'phpdoc_to_comment', 'phpdoc_indent', 'phpdoc_types', 'phpdoc_scalar'], true)) {
- $cases[] = [$fixers['comment_to_phpdoc'], $fixers[$docFixerName]];
- $cases[] = [$fixers['phpdoc_indent'], $fixers[$docFixerName]];
- $cases[] = [$fixers['phpdoc_scalar'], $fixers[$docFixerName]];
- $cases[] = [$fixers['phpdoc_to_comment'], $fixers[$docFixerName]];
- $cases[] = [$fixers['phpdoc_types'], $fixers[$docFixerName]];
- }
- if ('phpdoc_align' !== $docFixerName) {
- $cases[] = [$fixers[$docFixerName], $fixers['phpdoc_align']];
- }
- }
- return $cases;
- }
- /**
- * @dataProvider provideFixersPriorityPairsHaveIntegrationTestCases
- */
- public function testFixersPriorityPairsHaveIntegrationTest(FixerInterface $first, FixerInterface $second)
- {
- // This structure contains older cases that are not yet covered by tests.
- // It may only shrink, never add anything to it.
- $casesWithoutTests = [
- 'indentation_type,phpdoc_indent.test',
- 'phpdoc_no_access,phpdoc_order.test',
- 'phpdoc_no_package,phpdoc_order.test',
- ];
- $integrationTestName = $this->generateIntegrationTestName($first, $second);
- $file = $this->getIntegrationPriorityDirectory().$integrationTestName;
- if (is_file($file)) {
- $description = sprintf('Integration of fixers: %s,%s.', $first->getName(), $second->getName());
- $integrationTestExists = true;
- } else {
- $file = $this->getIntegrationPriorityDirectory().$this->generateIntegrationTestName($second, $first);
- $description = sprintf('Integration of fixers: %s,%s.', $second->getName(), $first->getName());
- $integrationTestExists = is_file($file);
- }
- if (\in_array($integrationTestName, $casesWithoutTests, true)) {
- static::assertFalse($integrationTestExists, sprintf('Case "%s" already has an integration test, so it should be removed from "$casesWithoutTests".', $integrationTestName));
- static::markTestIncomplete(sprintf('Case "%s" has no integration test yet, please help and add it.', $integrationTestName));
- }
- static::assertTrue($integrationTestExists, sprintf('There shall be an integration test "%s". How do you know that priority set up is good, if there is no integration test to check it?', $integrationTestName));
- $file = realpath($file);
- $factory = new IntegrationCaseFactory();
- $test = $factory->create(new SplFileInfo($file, './', __DIR__));
- $rules = $test->getRuleset()->getRules();
- $expected = [$first->getName(), $second->getName()];
- $actual = array_keys($rules);
- sort($expected);
- sort($actual);
- static::assertSame($description, $test->getTitle(), sprintf('Please fix the title in "%s".', $file));
- static::assertCount(2, $rules, sprintf('Only the two rules that are tested for priority should be in the ruleset of "%s".', $file));
- foreach ($rules as $name => $config) {
- static::assertNotFalse($config, sprintf('The rule "%s" in "%s" may not be disabled for the test.', $name, $file));
- }
- static::assertSame($expected, $actual, sprintf('The ruleset of "%s" must contain the rules for the priority test.', $file));
- }
- public function provideFixersPriorityPairsHaveIntegrationTestCases()
- {
- return array_filter(
- $this->provideFixersPriorityCases(),
- // ignore speed-up only priorities set up
- function (array $case) {
- return !\in_array(
- $this->generateIntegrationTestName($case[0], $case[1]),
- [
- 'function_to_constant,native_function_casing.test',
- 'no_unused_imports,no_leading_import_slash.test',
- 'pow_to_exponentiation,method_argument_space.test',
- 'pow_to_exponentiation,native_function_casing.test',
- 'pow_to_exponentiation,no_spaces_after_function_name.test',
- 'pow_to_exponentiation,no_spaces_inside_parenthesis.test',
- ],
- true
- );
- }
- );
- }
- public function testPriorityIntegrationDirectoryOnlyContainsFiles()
- {
- foreach (new \DirectoryIterator($this->getIntegrationPriorityDirectory()) as $candidate) {
- if ($candidate->isDot()) {
- continue;
- }
- $fileName = $candidate->getFilename();
- static::assertTrue($candidate->isFile(), sprintf('Expected only files in the priority integration test directory, got "%s".', $fileName));
- static::assertFalse($candidate->isLink(), sprintf('No (sym)links expected the priority integration test directory, got "%s".', $fileName));
- }
- }
- /**
- * @dataProvider provideIntegrationTestFilesCases
- *
- * @param string $fileName
- */
- public function testPriorityIntegrationTestFilesAreListedPriorityCases($fileName)
- {
- static $priorityCases;
- if (null === $priorityCases) {
- $priorityCases = [];
- foreach ($this->provideFixersPriorityCases() as $priorityCase) {
- $fixerName = $priorityCase[0]->getName();
- if (!isset($priorityCases[$fixerName])) {
- $priorityCases[$fixerName] = [];
- }
- $priorityCases[$fixerName][$priorityCase[1]->getName()] = true;
- }
- ksort($priorityCases);
- }
- if (\in_array($fileName, [
- 'braces,indentation_type,no_break_comment.test',
- ], true)) {
- static::markTestIncomplete(sprintf('Case "%s" has unexpected name, please help fixing it.', $fileName));
- }
- static::assertSame(
- 1,
- preg_match('#^([a-z][a-z0-9_]*),([a-z][a-z_]*)(?:_\d{1,3})?\.test(-(in|out)\.php)?$#', $fileName, $matches),
- sprintf('File with unexpected name "%s" in the priority integration test directory.', $fileName)
- );
- $fixerName1 = $matches[1];
- $fixerName2 = $matches[2];
- static::assertTrue(
- isset($priorityCases[$fixerName1][$fixerName2]) || isset($priorityCases[$fixerName2][$fixerName1]),
- sprintf('Missing priority test entry for file "%s".', $fileName)
- );
- }
- public function provideIntegrationTestFilesCases()
- {
- $fileNames = [];
- foreach (new \DirectoryIterator($this->getIntegrationPriorityDirectory()) as $candidate) {
- if ($candidate->isDot()) {
- continue;
- }
- $fileNames[] = [$candidate->getFilename()];
- }
- sort($fileNames);
- return $fileNames;
- }
- public function testProvideFixersPriorityCasesAreSorted()
- {
- $cases = $this->provideFixersPriorityCases();
- $sorted = $cases;
- usort(
- $sorted,
- /**
- * @param array<FixerInterface> $priorityPair1
- * @param array<FixerInterface> $priorityPair2
- */
- static function (array $priorityPair1, array $priorityPair2) {
- $fixer1 = $priorityPair1[0];
- $fixer2 = $priorityPair2[0];
- if ($fixer1->getName() === $fixer2->getName()) {
- $fixer1 = $priorityPair1[1];
- $fixer2 = $priorityPair2[1];
- }
- return strcmp($fixer1->getName(), $fixer2->getName());
- }
- );
- if ($sorted !== $cases) { // PHPUnit takes a very long time creating a diff view on the arrays
- $casesDescription = '';
- foreach ($cases as $pair) {
- $casesDescription .= sprintf("\n%s/%s", $pair[0]->getName(), $pair[1]->getName());
- }
- $sortedDescription = '';
- foreach ($sorted as $pair) {
- $sortedDescription .= sprintf("\n%s/%s", $pair[0]->getName(), $pair[1]->getName());
- }
- static::assertSame($sortedDescription, $casesDescription);
- } else {
- $this->addToAssertionCount(1);
- }
- }
- public function testFixerPriorityComment()
- {
- $cases = array_merge(
- $this->provideFixersPriorityCases(),
- $this->provideFixersPrioritySpecialPhpdocCases()
- );
- $map = [];
- foreach ($cases as $beforeAfter) {
- list($before, $after) = $beforeAfter;
- $beforeClass = \get_class($before);
- $afterClass = \get_class($after);
- $beforeName = substr($beforeClass, strrpos($beforeClass, '\\') + 1);
- $afterName = substr($afterClass, strrpos($afterClass, '\\') + 1);
- if (!isset($map[$beforeName])) {
- $map[$beforeName] = [
- 'before' => [],
- 'after' => [],
- 'class' => $beforeClass,
- ];
- }
- $map[$beforeName]['before'][] = $afterName;
- if (!isset($map[$afterName])) {
- $map[$afterName] = [
- 'before' => [],
- 'after' => [],
- 'class' => $afterClass,
- ];
- }
- $map[$afterName]['after'][] = $beforeName;
- }
- $fixersPhpDocIssues = [];
- foreach ($map as $fixerName => $priorityMap) {
- $expectedMessage = "/**\n * {@inheritdoc}\n *";
- if (\count($priorityMap['before']) > 0) {
- sort($priorityMap['before']);
- $expectedMessage .= sprintf("\n * Must run before %s.", implode(', ', $priorityMap['before']));
- }
- if (\count($priorityMap['after']) > 0) {
- sort($priorityMap['after']);
- $expectedMessage .= sprintf("\n * Must run after %s.", implode(', ', $priorityMap['after']));
- }
- $expectedMessage .= "\n */";
- $reflection = new \ReflectionClass($priorityMap['class']);
- $method = $reflection->getMethod('getPriority');
- $phpDoc = $method->getDocComment();
- if (false === $phpDoc) {
- $fixersPhpDocIssues[$fixerName] = sprintf("PHPDoc for %s::getPriority is missing.\nExpected:\n%s", $fixerName, $expectedMessage);
- continue;
- }
- if ($expectedMessage !== $phpDoc) {
- $fixersPhpDocIssues[$fixerName] = sprintf("PHPDoc for %s::getPriority is not as expected.\nExpected:\n%s", $fixerName, $expectedMessage);
- continue;
- }
- }
- if (0 === \count($fixersPhpDocIssues)) {
- $this->addToAssertionCount(1);
- } else {
- $message = sprintf("There are %d priority PHPDoc issues found.\n", \count($fixersPhpDocIssues));
- ksort($fixersPhpDocIssues);
- foreach ($fixersPhpDocIssues as $fixerName => $issue) {
- $message .= sprintf("\n--------------------------------------------------\n%s\n%s", $fixerName, $issue);
- }
- static::fail($message);
- }
- }
- /**
- * @return string
- */
- private function generateIntegrationTestName(FixerInterface $first, FixerInterface $second)
- {
- return "{$first->getName()},{$second->getName()}.test";
- }
- /**
- * @return string
- */
- private function getIntegrationPriorityDirectory()
- {
- return __DIR__.'/../Fixtures/Integration/priority/';
- }
- }
|