1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471 |
- <?php
- declare(strict_types=1);
- /*
- * This file is part of PHP CS Fixer.
- *
- * (c) Fabien Potencier <fabien@symfony.com>
- * Dariusz Rumiński <dariusz.ruminski@gmail.com>
- *
- * This source file is subject to the MIT license that is bundled
- * with this source code in the file LICENSE.
- */
- namespace PhpCsFixer\Tests\Console;
- use PhpCsFixer\AbstractFixer;
- use PhpCsFixer\Cache\NullCacheManager;
- use PhpCsFixer\Config;
- use PhpCsFixer\ConfigInterface;
- use PhpCsFixer\ConfigurationException\InvalidConfigurationException;
- use PhpCsFixer\Console\Command\FixCommand;
- use PhpCsFixer\Console\ConfigurationResolver;
- use PhpCsFixer\Console\Output\Progress\ProgressOutputType;
- use PhpCsFixer\Differ\NullDiffer;
- use PhpCsFixer\Differ\UnifiedDiffer;
- use PhpCsFixer\Finder;
- use PhpCsFixer\Fixer\ConfigurableFixerInterface;
- use PhpCsFixer\Fixer\DeprecatedFixerInterface;
- use PhpCsFixer\FixerConfiguration\FixerConfigurationResolver;
- use PhpCsFixer\FixerConfiguration\FixerConfigurationResolverInterface;
- use PhpCsFixer\FixerConfiguration\FixerOptionBuilder;
- use PhpCsFixer\FixerDefinition\FixerDefinitionInterface;
- use PhpCsFixer\Linter\LinterInterface;
- use PhpCsFixer\Tests\TestCase;
- use PhpCsFixer\Tokenizer\Tokens;
- use PhpCsFixer\ToolInfoInterface;
- use PhpCsFixer\Utils;
- use Symfony\Component\Console\Output\OutputInterface;
- /**
- * @author Katsuhiro Ogawa <ko.fivestar@gmail.com>
- * @author Dariusz Rumiński <dariusz.ruminski@gmail.com>
- *
- * @internal
- *
- * @covers \PhpCsFixer\Console\ConfigurationResolver
- */
- final class ConfigurationResolverTest extends TestCase
- {
- public function testSetOptionWithUndefinedOption(): void
- {
- $this->expectException(InvalidConfigurationException::class);
- $this->expectExceptionMessageMatches('/^Unknown option name: "foo"\.$/');
- $this->createConfigurationResolver(['foo' => 'bar']);
- }
- public function testResolveProgressWithPositiveConfigAndPositiveOption(): void
- {
- $config = new Config();
- $config->setHideProgress(true);
- $resolver = $this->createConfigurationResolver([
- 'format' => 'txt',
- 'verbosity' => OutputInterface::VERBOSITY_VERBOSE,
- ], $config);
- self::assertSame('none', $resolver->getProgressType());
- }
- public function testResolveProgressWithPositiveConfigAndNegativeOption(): void
- {
- $config = new Config();
- $config->setHideProgress(true);
- $resolver = $this->createConfigurationResolver([
- 'format' => 'txt',
- 'verbosity' => OutputInterface::VERBOSITY_NORMAL,
- ], $config);
- self::assertSame('none', $resolver->getProgressType());
- }
- public function testResolveProgressWithNegativeConfigAndPositiveOption(): void
- {
- $config = new Config();
- $config->setHideProgress(false);
- $resolver = $this->createConfigurationResolver([
- 'format' => 'txt',
- 'verbosity' => OutputInterface::VERBOSITY_VERBOSE,
- ], $config);
- self::assertSame('bar', $resolver->getProgressType());
- }
- public function testResolveProgressWithNegativeConfigAndNegativeOption(): void
- {
- $config = new Config();
- $config->setHideProgress(false);
- $resolver = $this->createConfigurationResolver([
- 'format' => 'txt',
- 'verbosity' => OutputInterface::VERBOSITY_NORMAL,
- ], $config);
- self::assertSame('bar', $resolver->getProgressType());
- }
- /**
- * @dataProvider provideProgressTypeCases
- */
- public function testResolveProgressWithPositiveConfigAndExplicitProgress(string $progressType): void
- {
- $config = new Config();
- $config->setHideProgress(true);
- $resolver = $this->createConfigurationResolver([
- 'format' => 'txt',
- 'verbosity' => OutputInterface::VERBOSITY_VERBOSE,
- 'show-progress' => $progressType,
- ], $config);
- self::assertSame($progressType, $resolver->getProgressType());
- }
- /**
- * @dataProvider provideProgressTypeCases
- */
- public function testResolveProgressWithNegativeConfigAndExplicitProgress(string $progressType): void
- {
- $config = new Config();
- $config->setHideProgress(false);
- $resolver = $this->createConfigurationResolver([
- 'format' => 'txt',
- 'verbosity' => OutputInterface::VERBOSITY_VERBOSE,
- 'show-progress' => $progressType,
- ], $config);
- self::assertSame($progressType, $resolver->getProgressType());
- }
- /**
- * @return iterable<string, array{0: ProgressOutputType::*}>
- */
- public static function provideProgressTypeCases(): iterable
- {
- foreach (ProgressOutputType::all() as $outputType) {
- yield $outputType => [$outputType];
- }
- }
- public function testResolveProgressWithInvalidExplicitProgress(): void
- {
- $resolver = $this->createConfigurationResolver([
- 'format' => 'txt',
- 'verbosity' => OutputInterface::VERBOSITY_VERBOSE,
- 'show-progress' => 'foo',
- ]);
- $this->expectException(InvalidConfigurationException::class);
- $this->expectExceptionMessage('The progress type "foo" is not defined, supported are "bar", "dots" and "none".');
- $resolver->getProgressType();
- }
- public function testResolveConfigFileDefault(): void
- {
- $resolver = $this->createConfigurationResolver([]);
- self::assertNull($resolver->getConfigFile());
- self::assertInstanceOf(ConfigInterface::class, $resolver->getConfig());
- }
- public function testResolveConfigFileByPathOfFile(): void
- {
- $dir = __DIR__.'/../Fixtures/ConfigurationResolverConfigFile/case_1';
- $resolver = $this->createConfigurationResolver(['path' => [$dir.\DIRECTORY_SEPARATOR.'foo.php']]);
- self::assertSame($dir.\DIRECTORY_SEPARATOR.'.php-cs-fixer.dist.php', $resolver->getConfigFile());
- self::assertInstanceOf(\Test1Config::class, $resolver->getConfig()); // @phpstan-ignore-line to avoid `Class Test1Config not found.`
- }
- public function testResolveConfigFileSpecified(): void
- {
- $file = __DIR__.'/../Fixtures/ConfigurationResolverConfigFile/case_4/my.php-cs-fixer.php';
- $resolver = $this->createConfigurationResolver(['config' => $file]);
- self::assertSame($file, $resolver->getConfigFile());
- self::assertInstanceOf(\Test4Config::class, $resolver->getConfig()); // @phpstan-ignore-line to avoid `Class Test4Config not found.`
- }
- /**
- * @dataProvider provideResolveConfigFileChooseFileCases
- */
- public function testResolveConfigFileChooseFile(string $expectedFile, string $expectedClass, string $path, ?string $cwdPath = null): void
- {
- $resolver = $this->createConfigurationResolver(
- ['path' => [$path]],
- null,
- $cwdPath ?? ''
- );
- self::assertSame($expectedFile, $resolver->getConfigFile());
- self::assertInstanceOf($expectedClass, $resolver->getConfig());
- }
- public static function provideResolveConfigFileChooseFileCases(): iterable
- {
- $dirBase = self::getFixtureDir();
- yield [
- $dirBase.'case_1'.\DIRECTORY_SEPARATOR.'.php-cs-fixer.dist.php',
- 'Test1Config',
- $dirBase.'case_1',
- ];
- yield [
- $dirBase.'case_2'.\DIRECTORY_SEPARATOR.'.php-cs-fixer.php',
- 'Test2Config',
- $dirBase.'case_2',
- ];
- yield [
- $dirBase.'case_3'.\DIRECTORY_SEPARATOR.'.php-cs-fixer.php',
- 'Test3Config',
- $dirBase.'case_3',
- ];
- yield [
- $dirBase.'case_6'.\DIRECTORY_SEPARATOR.'.php-cs-fixer.dist.php',
- 'Test6Config',
- $dirBase.'case_6'.\DIRECTORY_SEPARATOR.'subdir',
- $dirBase.'case_6',
- ];
- yield [
- $dirBase.'case_6'.\DIRECTORY_SEPARATOR.'.php-cs-fixer.dist.php',
- 'Test6Config',
- $dirBase.'case_6'.\DIRECTORY_SEPARATOR.'subdir/empty_file.php',
- $dirBase.'case_6',
- ];
- }
- public function testResolveConfigFileChooseFileWithInvalidFile(): void
- {
- $this->expectException(InvalidConfigurationException::class);
- $this->expectExceptionMessageMatches(
- '#^The config file: ".+[\/\\\]Fixtures[\/\\\]ConfigurationResolverConfigFile[\/\\\]case_5[\/\\\]\.php-cs-fixer\.dist\.php" does not return a "PhpCsFixer\\\ConfigInterface" instance\. Got: "string"\.$#'
- );
- $dirBase = self::getFixtureDir();
- $resolver = $this->createConfigurationResolver(['path' => [$dirBase.'case_5']]);
- $resolver->getConfig();
- }
- public function testResolveConfigFileChooseFileWithInvalidFormat(): void
- {
- $this->expectException(InvalidConfigurationException::class);
- $this->expectExceptionMessageMatches('/^The format "xls" is not defined, supported are "checkstyle", "gitlab", "json", "junit", "txt" and "xml"\.$/');
- $dirBase = self::getFixtureDir();
- $resolver = $this->createConfigurationResolver(['path' => [$dirBase.'case_7']]);
- $resolver->getReporter();
- }
- public function testResolveConfigFileChooseFileWithPathArrayWithoutConfig(): void
- {
- $this->expectException(InvalidConfigurationException::class);
- $this->expectExceptionMessageMatches('/^For multiple paths config parameter is required\.$/');
- $dirBase = self::getFixtureDir();
- $resolver = $this->createConfigurationResolver(['path' => [$dirBase.'case_1/.php-cs-fixer.dist.php', $dirBase.'case_1/foo.php']]);
- $resolver->getConfig();
- }
- public function testResolveConfigFileChooseFileWithPathArrayAndConfig(): void
- {
- $dirBase = self::getFixtureDir();
- $configFile = $dirBase.'case_1/.php-cs-fixer.dist.php';
- $resolver = $this->createConfigurationResolver([
- 'config' => $configFile,
- 'path' => [$configFile, $dirBase.'case_1/foo.php'],
- ]);
- self::assertSame($configFile, $resolver->getConfigFile());
- }
- /**
- * @param array<int, string> $paths
- * @param array<int, string> $expectedPaths
- *
- * @dataProvider provideResolvePathCases
- */
- public function testResolvePath(array $paths, string $cwd, array $expectedPaths): void
- {
- $resolver = $this->createConfigurationResolver(
- ['path' => $paths],
- null,
- $cwd
- );
- self::assertSame($expectedPaths, $resolver->getPath());
- }
- public static function provideResolvePathCases(): iterable
- {
- yield [
- ['Command'],
- __DIR__,
- [__DIR__.\DIRECTORY_SEPARATOR.'Command'],
- ];
- yield [
- [basename(__DIR__)],
- \dirname(__DIR__),
- [__DIR__],
- ];
- yield [
- [' Command'],
- __DIR__,
- [__DIR__.\DIRECTORY_SEPARATOR.'Command'],
- ];
- yield [
- ['Command '],
- __DIR__,
- [__DIR__.\DIRECTORY_SEPARATOR.'Command'],
- ];
- }
- /**
- * @param array<string> $paths
- *
- * @dataProvider provideRejectInvalidPathCases
- */
- public function testRejectInvalidPath(array $paths, string $expectedMessage): void
- {
- $resolver = $this->createConfigurationResolver(
- ['path' => $paths],
- null,
- \dirname(__DIR__)
- );
- $this->expectException(InvalidConfigurationException::class);
- $this->expectExceptionMessage($expectedMessage);
- $resolver->getPath();
- }
- public static function provideRejectInvalidPathCases(): iterable
- {
- yield [
- [''],
- 'Invalid path: "".',
- ];
- yield [
- [__DIR__, ''],
- 'Invalid path: "".',
- ];
- yield [
- ['', __DIR__],
- 'Invalid path: "".',
- ];
- yield [
- [' '],
- 'Invalid path: " ".',
- ];
- yield [
- [__DIR__, ' '],
- 'Invalid path: " ".',
- ];
- yield [
- [' ', __DIR__],
- 'Invalid path: " ".',
- ];
- }
- public function testResolvePathWithFileThatIsExcludedDirectlyOverridePathMode(): void
- {
- $config = new Config();
- $config->getFinder()
- ->in(__DIR__)
- ->notPath(basename(__FILE__))
- ;
- $resolver = $this->createConfigurationResolver(
- ['path' => [__FILE__]],
- $config
- );
- self::assertCount(1, $resolver->getFinder());
- }
- public function testResolvePathWithFileThatIsExcludedDirectlyIntersectionPathMode(): void
- {
- $config = new Config();
- $config->getFinder()
- ->in(__DIR__)
- ->notPath(basename(__FILE__))
- ;
- $resolver = $this->createConfigurationResolver([
- 'path' => [__FILE__],
- 'path-mode' => 'intersection',
- ], $config);
- self::assertCount(0, $resolver->getFinder());
- }
- public function testResolvePathWithFileThatIsExcludedByDirOverridePathMode(): void
- {
- $dir = \dirname(__DIR__);
- $config = new Config();
- $config->getFinder()
- ->in($dir)
- ->exclude(basename(__DIR__))
- ;
- $resolver = $this->createConfigurationResolver(
- ['path' => [__FILE__]],
- $config
- );
- self::assertCount(1, $resolver->getFinder());
- }
- public function testResolvePathWithFileThatIsExcludedByDirIntersectionPathMode(): void
- {
- $dir = \dirname(__DIR__);
- $config = new Config();
- $config->getFinder()
- ->in($dir)
- ->exclude(basename(__DIR__))
- ;
- $resolver = $this->createConfigurationResolver([
- 'path-mode' => 'intersection',
- 'path' => [__FILE__],
- ], $config);
- self::assertCount(0, $resolver->getFinder());
- }
- public function testResolvePathWithFileThatIsNotExcluded(): void
- {
- $dir = __DIR__;
- $config = new Config();
- $config->getFinder()
- ->in($dir)
- ->notPath('foo-'.basename(__FILE__))
- ;
- $resolver = $this->createConfigurationResolver(
- ['path' => [__FILE__]],
- $config
- );
- self::assertCount(1, $resolver->getFinder());
- }
- /**
- * @param \Exception|list<string> $expected
- * @param list<string> $path
- *
- * @dataProvider provideResolveIntersectionOfPathsCases
- */
- public function testResolveIntersectionOfPaths($expected, ?Finder $configFinder, array $path, string $pathMode, ?string $configOption = null): void
- {
- if ($expected instanceof \Exception) {
- $this->expectException(\get_class($expected));
- }
- if (null !== $configFinder) {
- $config = new Config();
- $config->setFinder($configFinder);
- } else {
- $config = null;
- }
- $resolver = $this->createConfigurationResolver([
- 'config' => $configOption,
- 'path' => $path,
- 'path-mode' => $pathMode,
- ], $config);
- $intersectionItems = array_map(
- static fn (\SplFileInfo $file): string => $file->getRealPath(),
- iterator_to_array($resolver->getFinder(), false)
- );
- sort($expected);
- sort($intersectionItems);
- self::assertSame($expected, $intersectionItems);
- }
- public static function provideResolveIntersectionOfPathsCases(): iterable
- {
- $dir = __DIR__.'/../Fixtures/ConfigurationResolverPathsIntersection';
- $cb = static fn (array $items): array => array_map(
- static fn (string $item): string => realpath($dir.'/'.$item),
- $items
- );
- yield 'no path at all' => [
- new \LogicException(),
- Finder::create(),
- [],
- 'override',
- ];
- yield 'configured only by finder' => [
- // don't override if the argument is empty
- $cb(['a1.php', 'a2.php', 'b/b1.php', 'b/b2.php', 'b_b/b_b1.php', 'c/c1.php', 'c/d/cd1.php', 'd/d1.php', 'd/d2.php', 'd/e/de1.php', 'd/f/df1.php']),
- Finder::create()
- ->in($dir),
- [],
- 'override',
- ];
- yield 'configured only by argument' => [
- $cb(['a1.php', 'a2.php', 'b/b1.php', 'b/b2.php', 'b_b/b_b1.php', 'c/c1.php', 'c/d/cd1.php', 'd/d1.php', 'd/d2.php', 'd/e/de1.php', 'd/f/df1.php']),
- Finder::create(),
- [$dir],
- 'override',
- ];
- yield 'configured by finder, intersected with empty argument' => [
- [],
- Finder::create()
- ->in($dir),
- [],
- 'intersection',
- ];
- yield 'configured by finder, intersected with dir' => [
- $cb(['c/c1.php', 'c/d/cd1.php']),
- Finder::create()
- ->in($dir),
- [$dir.'/c'],
- 'intersection',
- ];
- yield 'configured by finder, intersected with file' => [
- $cb(['c/c1.php']),
- Finder::create()
- ->in($dir),
- [$dir.'/c/c1.php'],
- 'intersection',
- ];
- yield 'finder points to one dir while argument to another, not connected' => [
- [],
- Finder::create()
- ->in($dir.'/b'),
- [$dir.'/c'],
- 'intersection',
- ];
- yield 'finder with excluded dir, intersected with excluded file' => [
- [],
- Finder::create()
- ->in($dir)
- ->exclude('c'),
- [$dir.'/c/d/cd1.php'],
- 'intersection',
- ];
- yield 'finder with excluded dir, intersected with dir containing excluded one' => [
- $cb(['c/c1.php']),
- Finder::create()
- ->in($dir)
- ->exclude('c/d'),
- [$dir.'/c'],
- 'intersection',
- ];
- yield 'finder with excluded file, intersected with dir containing excluded one' => [
- $cb(['c/d/cd1.php']),
- Finder::create()
- ->in($dir)
- ->notPath('c/c1.php'),
- [$dir.'/c'],
- 'intersection',
- ];
- yield 'configured by finder, intersected with non-existing path' => [
- new \LogicException(),
- Finder::create()
- ->in($dir),
- ['non_existing_dir'],
- 'intersection',
- ];
- yield 'configured by config file, overridden by multiple files' => [
- $cb(['d/d1.php', 'd/d2.php']),
- null,
- [$dir.'/d/d1.php', $dir.'/d/d2.php'],
- 'override',
- $dir.'/d/.php-cs-fixer.php',
- ];
- yield 'configured by config file, intersected with multiple files' => [
- $cb(['d/d1.php', 'd/d2.php']),
- null,
- [$dir.'/d/d1.php', $dir.'/d/d2.php'],
- 'intersection',
- $dir.'/d/.php-cs-fixer.php',
- ];
- yield 'configured by config file, overridden by non-existing dir' => [
- new \LogicException(),
- null,
- [$dir.'/d/fff'],
- 'override',
- $dir.'/d/.php-cs-fixer.php',
- ];
- yield 'configured by config file, intersected with non-existing dir' => [
- new \LogicException(),
- null,
- [$dir.'/d/fff'],
- 'intersection',
- $dir.'/d/.php-cs-fixer.php',
- ];
- yield 'configured by config file, overridden by non-existing file' => [
- new \LogicException(),
- null,
- [$dir.'/d/fff.php'],
- 'override',
- $dir.'/d/.php-cs-fixer.php',
- ];
- yield 'configured by config file, intersected with non-existing file' => [
- new \LogicException(),
- null,
- [$dir.'/d/fff.php'],
- 'intersection',
- $dir.'/d/.php-cs-fixer.php',
- ];
- yield 'configured by config file, overridden by multiple files and dirs' => [
- $cb(['d/d1.php', 'd/e/de1.php', 'd/f/df1.php']),
- null,
- [$dir.'/d/d1.php', $dir.'/d/e', $dir.'/d/f/'],
- 'override',
- $dir.'/d/.php-cs-fixer.php',
- ];
- yield 'configured by config file, intersected with multiple files and dirs' => [
- $cb(['d/d1.php', 'd/e/de1.php', 'd/f/df1.php']),
- null,
- [$dir.'/d/d1.php', $dir.'/d/e', $dir.'/d/f/'],
- 'intersection',
- $dir.'/d/.php-cs-fixer.php',
- ];
- }
- /**
- * @param array<string, mixed> $options
- *
- * @dataProvider provideConfigFinderIsOverriddenCases
- */
- public function testConfigFinderIsOverridden(array $options, bool $expectedResult): void
- {
- $resolver = $this->createConfigurationResolver($options);
- self::assertSame($expectedResult, $resolver->configFinderIsOverridden());
- $resolver = $this->createConfigurationResolver($options);
- $resolver->getFinder();
- self::assertSame($expectedResult, $resolver->configFinderIsOverridden());
- }
- public static function provideConfigFinderIsOverriddenCases(): iterable
- {
- $root = __DIR__.'/../..';
- yield [
- [
- 'config' => $root.'/.php-cs-fixer.dist.php',
- ],
- false,
- ];
- yield [
- [
- 'config' => $root.'/.php-cs-fixer.dist.php',
- 'path' => [$root.'/src'],
- ],
- true,
- ];
- yield [
- [],
- false,
- ];
- yield [
- [
- 'path' => [$root.'/src'],
- ],
- false,
- ];
- yield [
- [
- 'config' => $root.'/.php-cs-fixer.dist.php',
- 'path' => [$root.'/src'],
- 'path-mode' => ConfigurationResolver::PATH_MODE_INTERSECTION,
- ],
- false,
- ];
- // scenario when loaded config is not setting custom finder
- yield [
- [
- 'config' => $root.'/tests/Fixtures/ConfigurationResolverConfigFile/case_3/.php-cs-fixer.dist.php',
- 'path' => [$root.'/src'],
- ],
- false,
- ];
- // scenario when loaded config contains not fully defined finder
- yield [
- [
- 'config' => $root.'/tests/Fixtures/ConfigurationResolverConfigFile/case_9/.php-cs-fixer.php',
- 'path' => [$root.'/src'],
- ],
- false,
- ];
- }
- public function testResolveIsDryRunViaStdIn(): void
- {
- $resolver = $this->createConfigurationResolver([
- 'dry-run' => false,
- 'path' => ['-'],
- ]);
- self::assertTrue($resolver->isDryRun());
- }
- public function testResolveIsDryRunViaNegativeOption(): void
- {
- $resolver = $this->createConfigurationResolver(['dry-run' => false]);
- self::assertFalse($resolver->isDryRun());
- }
- public function testResolveIsDryRunViaPositiveOption(): void
- {
- $resolver = $this->createConfigurationResolver(['dry-run' => true]);
- self::assertTrue($resolver->isDryRun());
- }
- /**
- * @dataProvider provideResolveBooleanOptionCases
- */
- public function testResolveUsingCacheWithConfigOption(bool $expected, bool $configValue, ?string $passed): void
- {
- $config = new Config();
- $config->setUsingCache($configValue);
- $resolver = $this->createConfigurationResolver(
- ['using-cache' => $passed],
- $config
- );
- self::assertSame($expected, $resolver->getUsingCache());
- }
- public function testResolveUsingCacheWithPositiveConfigAndNoOption(): void
- {
- $config = new Config();
- $config->setUsingCache(true);
- $resolver = $this->createConfigurationResolver(
- [],
- $config
- );
- self::assertTrue($resolver->getUsingCache());
- }
- public function testResolveUsingCacheWithNegativeConfigAndNoOption(): void
- {
- $config = new Config();
- $config->setUsingCache(false);
- $resolver = $this->createConfigurationResolver(
- [],
- $config
- );
- self::assertFalse($resolver->getUsingCache());
- }
- /**
- * @dataProvider provideResolveUsingCacheForRuntimesCases
- */
- public function testResolveUsingCacheForRuntimes(bool $cacheAllowed, bool $installedWithComposer, bool $asPhar, bool $inDocker): void
- {
- $config = new Config();
- $config->setUsingCache(true);
- $resolver = $this->createConfigurationResolver(
- [],
- $config,
- '',
- new class($installedWithComposer, $asPhar, $inDocker) implements ToolInfoInterface {
- private bool $installedWithComposer;
- private bool $asPhar;
- private bool $inDocker;
- public function __construct(bool $installedWithComposer, bool $asPhar, bool $inDocker)
- {
- $this->installedWithComposer = $installedWithComposer;
- $this->asPhar = $asPhar;
- $this->inDocker = $inDocker;
- }
- public function getComposerInstallationDetails(): array
- {
- throw new \BadMethodCallException();
- }
- public function getComposerVersion(): string
- {
- throw new \BadMethodCallException();
- }
- public function getVersion(): string
- {
- throw new \BadMethodCallException();
- }
- public function isInstalledAsPhar(): bool
- {
- return $this->asPhar;
- }
- public function isInstalledByComposer(): bool
- {
- return $this->installedWithComposer;
- }
- public function isRunInsideDocker(): bool
- {
- return $this->inDocker;
- }
- public function getPharDownloadUri(string $version): string
- {
- throw new \BadMethodCallException();
- }
- }
- );
- self::assertSame($cacheAllowed, $resolver->getUsingCache());
- }
- /**
- * @return iterable<array{0: bool, 1: bool, 2: bool, 3: bool}>
- */
- public static function provideResolveUsingCacheForRuntimesCases(): iterable
- {
- yield 'none of the allowed runtimes' => [false, false, false, false];
- yield 'composer installation' => [true, true, false, false];
- yield 'PHAR distribution' => [true, false, true, false];
- yield 'Docker runtime' => [true, false, false, true];
- }
- public function testResolveCacheFileWithoutConfigAndOption(): void
- {
- $config = new Config();
- $default = $config->getCacheFile();
- $resolver = $this->createConfigurationResolver(
- [],
- $config
- );
- self::assertSame($default, $resolver->getCacheFile());
- }
- public function testResolveCacheFileWithConfig(): void
- {
- $cacheFile = 'foo/bar.baz';
- $config = new Config();
- $config
- ->setUsingCache(false)
- ->setCacheFile($cacheFile)
- ;
- $resolver = $this->createConfigurationResolver(
- [],
- $config
- );
- self::assertNull($resolver->getCacheFile());
- $cacheManager = $resolver->getCacheManager();
- self::assertInstanceOf(NullCacheManager::class, $cacheManager);
- $linter = $resolver->getLinter();
- self::assertInstanceOf(LinterInterface::class, $linter);
- }
- public function testResolveCacheFileWithOption(): void
- {
- $cacheFile = 'bar.baz';
- $config = new Config();
- $config->setCacheFile($cacheFile);
- $resolver = $this->createConfigurationResolver(
- ['cache-file' => $cacheFile],
- $config
- );
- self::assertSame($cacheFile, $resolver->getCacheFile());
- }
- public function testResolveCacheFileWithConfigAndOption(): void
- {
- $configCacheFile = 'foo/bar.baz';
- $optionCacheFile = 'bar.baz';
- $config = new Config();
- $config->setCacheFile($configCacheFile);
- $resolver = $this->createConfigurationResolver(
- ['cache-file' => $optionCacheFile],
- $config
- );
- self::assertSame($optionCacheFile, $resolver->getCacheFile());
- }
- /**
- * @dataProvider provideResolveBooleanOptionCases
- */
- public function testResolveAllowRiskyWithConfigOption(bool $expected, bool $configValue, ?string $passed): void
- {
- $config = new Config();
- $config->setRiskyAllowed($configValue);
- $resolver = $this->createConfigurationResolver(
- ['allow-risky' => $passed],
- $config
- );
- self::assertSame($expected, $resolver->getRiskyAllowed());
- }
- public function testResolveAllowRiskyWithNegativeConfigAndPositiveOption(): void
- {
- $config = new Config();
- $config->setRiskyAllowed(false);
- $resolver = $this->createConfigurationResolver(
- ['allow-risky' => 'yes'],
- $config
- );
- self::assertTrue($resolver->getRiskyAllowed());
- }
- public function testResolveAllowRiskyWithNegativeConfigAndNegativeOption(): void
- {
- $config = new Config();
- $config->setRiskyAllowed(false);
- $resolver = $this->createConfigurationResolver(
- ['allow-risky' => 'no'],
- $config
- );
- self::assertFalse($resolver->getRiskyAllowed());
- }
- public function testResolveAllowRiskyWithPositiveConfigAndNoOption(): void
- {
- $config = new Config();
- $config->setRiskyAllowed(true);
- $resolver = $this->createConfigurationResolver(
- [],
- $config
- );
- self::assertTrue($resolver->getRiskyAllowed());
- }
- public function testResolveAllowRiskyWithNegativeConfigAndNoOption(): void
- {
- $config = new Config();
- $config->setRiskyAllowed(false);
- $resolver = $this->createConfigurationResolver(
- [],
- $config
- );
- self::assertFalse($resolver->getRiskyAllowed());
- }
- public function testResolveRulesWithConfig(): void
- {
- $config = new Config();
- $config->setRules([
- 'statement_indentation' => true,
- 'strict_comparison' => false,
- ]);
- $resolver = $this->createConfigurationResolver(
- [],
- $config
- );
- self::assertSameRules(
- [
- 'statement_indentation' => true,
- ],
- $resolver->getRules()
- );
- }
- public function testResolveRulesWithOption(): void
- {
- $resolver = $this->createConfigurationResolver(['rules' => 'statement_indentation,-strict_comparison']);
- self::assertSameRules(
- [
- 'statement_indentation' => true,
- ],
- $resolver->getRules()
- );
- }
- /**
- * @param string[] $rules
- *
- * @dataProvider provideResolveRenamedRulesWithUnknownRulesCases
- */
- public function testResolveRenamedRulesWithUnknownRules(string $expectedMessage, array $rules): void
- {
- $this->expectException(InvalidConfigurationException::class);
- $this->expectExceptionMessage($expectedMessage);
- $resolver = $this->createConfigurationResolver(['rules' => implode(',', $rules)]);
- $resolver->getRules();
- }
- public static function provideResolveRenamedRulesWithUnknownRulesCases(): iterable
- {
- yield 'with config' => [
- 'The rules contain unknown fixers: "blank_line_before_return" is renamed (did you mean "blank_line_before_statement"? (note: use configuration "[\'statements\' => [\'return\']]")).
- For more info about updating see: https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/v3.0.0/UPGRADE-v3.md#renamed-ruless.',
- ['blank_line_before_return'],
- ];
- yield 'without config' => [
- 'The rules contain unknown fixers: "final_static_access" is renamed (did you mean "self_static_accessor"?).
- For more info about updating see: https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/v3.0.0/UPGRADE-v3.md#renamed-ruless.',
- ['final_static_access'],
- ];
- yield [
- 'The rules contain unknown fixers: "hash_to_slash_comment" is renamed (did you mean "single_line_comment_style"? (note: use configuration "[\'comment_types\' => [\'hash\']]")).
- For more info about updating see: https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/v3.0.0/UPGRADE-v3.md#renamed-ruless.',
- ['hash_to_slash_comment'],
- ];
- yield 'both renamed and unknown' => [
- 'The rules contain unknown fixers: "final_static_access" is renamed (did you mean "self_static_accessor"?), "binary_operator_space" (did you mean "binary_operator_spaces"?).
- For more info about updating see: https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/v3.0.0/UPGRADE-v3.md#renamed-ruless.',
- ['final_static_access', 'binary_operator_space'],
- ];
- }
- public function testResolveRulesWithUnknownRules(): void
- {
- $this->expectException(InvalidConfigurationException::class);
- $this->expectExceptionMessage('The rules contain unknown fixers: "bar", "binary_operator_space" (did you mean "binary_operator_spaces"?).');
- $resolver = $this->createConfigurationResolver(['rules' => 'statement_indentation,-bar,binary_operator_space']);
- $resolver->getRules();
- }
- public function testResolveRulesWithConfigAndOption(): void
- {
- $config = new Config();
- $config->setRules([
- 'statement_indentation' => true,
- 'strict_comparison' => false,
- ]);
- $resolver = $this->createConfigurationResolver(
- ['rules' => 'blank_line_before_statement'],
- $config
- );
- self::assertSameRules(
- [
- 'blank_line_before_statement' => true,
- ],
- $resolver->getRules()
- );
- }
- public function testResolveCommandLineInputOverridesDefault(): void
- {
- $command = new FixCommand($this->createToolInfoDouble());
- $definition = $command->getDefinition();
- $arguments = $definition->getArguments();
- self::assertCount(1, $arguments, 'Expected one argument, possibly test needs updating.');
- self::assertArrayHasKey('path', $arguments);
- $options = $definition->getOptions();
- self::assertSame(
- ['path-mode', 'allow-risky', 'config', 'dry-run', 'rules', 'using-cache', 'cache-file', 'diff', 'format', 'stop-on-violation', 'show-progress'],
- array_keys($options),
- 'Expected options mismatch, possibly test needs updating.'
- );
- $resolver = $this->createConfigurationResolver([
- 'path-mode' => 'intersection',
- 'allow-risky' => 'yes',
- 'config' => null,
- 'dry-run' => true,
- 'rules' => 'php_unit_construct',
- 'using-cache' => 'no',
- 'diff' => true,
- 'format' => 'json',
- 'stop-on-violation' => true,
- ]);
- self::assertTrue($resolver->shouldStopOnViolation());
- self::assertTrue($resolver->getRiskyAllowed());
- self::assertTrue($resolver->isDryRun());
- self::assertSame(['php_unit_construct' => true], $resolver->getRules());
- self::assertFalse($resolver->getUsingCache());
- self::assertNull($resolver->getCacheFile());
- self::assertInstanceOf(UnifiedDiffer::class, $resolver->getDiffer());
- self::assertSame('json', $resolver->getReporter()->getFormat());
- self::assertSame('none', $resolver->getProgressType());
- }
- /**
- * @param null|bool|string $diffConfig
- *
- * @dataProvider provideResolveDifferCases
- */
- public function testResolveDiffer(string $expected, $diffConfig): void
- {
- $resolver = $this->createConfigurationResolver([
- 'diff' => $diffConfig,
- ]);
- self::assertInstanceOf($expected, $resolver->getDiffer());
- }
- public static function provideResolveDifferCases(): iterable
- {
- yield [
- NullDiffer::class,
- false,
- ];
- yield [
- NullDiffer::class,
- null,
- ];
- yield [
- UnifiedDiffer::class,
- true,
- ];
- }
- public function testResolveConfigFileOverridesDefault(): void
- {
- $dir = __DIR__.'/../Fixtures/ConfigurationResolverConfigFile/case_8';
- $resolver = $this->createConfigurationResolver(['path' => [$dir.\DIRECTORY_SEPARATOR.'.php-cs-fixer.php']]);
- self::assertTrue($resolver->getRiskyAllowed());
- self::assertSame(['php_unit_construct' => true], $resolver->getRules());
- self::assertFalse($resolver->getUsingCache());
- self::assertNull($resolver->getCacheFile());
- self::assertSame('xml', $resolver->getReporter()->getFormat());
- self::assertSame('none', $resolver->getProgressType());
- }
- public function testDeprecationOfPassingOtherThanNoOrYes(): void
- {
- $this->expectException(InvalidConfigurationException::class);
- $this->expectExceptionMessage('Expected "yes" or "no" for option "allow-risky", got "yes please".');
- $resolver = $this->createConfigurationResolver(['allow-risky' => 'yes please']);
- $resolver->getRiskyAllowed();
- }
- public static function provideResolveBooleanOptionCases(): iterable
- {
- yield [true, true, 'yes'];
- yield [true, false, 'yes'];
- yield [false, true, 'no'];
- yield [false, false, 'no'];
- yield [true, true, null];
- yield [false, false, null];
- }
- public function testWithEmptyRules(): void
- {
- $resolver = $this->createConfigurationResolver(['rules' => '']);
- $this->expectException(InvalidConfigurationException::class);
- $this->expectExceptionMessageMatches('/^Empty rules value is not allowed\.$/');
- $resolver->getRules();
- }
- /**
- * @param array<string, mixed>|bool $ruleConfig
- *
- * @dataProvider provideDeprecatedFixerConfiguredCases
- *
- * @group legacy
- */
- public function testDeprecatedFixerConfigured($ruleConfig): void
- {
- $this->expectDeprecation('Rule "Vendor4/foo" is deprecated. Use "testA" and "testB" instead.');
- $fixer = $this->createDeprecatedFixerDouble();
- $config = new Config();
- $config->registerCustomFixers([$fixer]);
- $config->setRules([$fixer->getName() => $ruleConfig]);
- $resolver = $this->createConfigurationResolver([], $config);
- $resolver->getFixers();
- }
- public static function provideDeprecatedFixerConfiguredCases(): iterable
- {
- yield [true];
- yield [['foo' => true]];
- yield [false];
- }
- /**
- * @dataProvider provideDeprecatedRuleSetConfiguredCases
- *
- * @group legacy
- *
- * @param array<string> $successors
- */
- public function testDeprecatedRuleSetConfigured(string $ruleSet, array $successors): void
- {
- $this->expectDeprecation(sprintf(
- 'Rule set "%s" is deprecated. %s.',
- $ruleSet,
- [] === $successors
- ? 'No replacement available'
- : sprintf('Use %s instead', Utils::naturalLanguageJoin($successors))
- ));
- $config = new Config();
- $config->setRules([$ruleSet => true]);
- $config->setRiskyAllowed(true);
- $resolver = $this->createConfigurationResolver([], $config);
- $resolver->getFixers();
- }
- /**
- * @return iterable<array{0: string, 1: list<string>}>
- */
- public static function provideDeprecatedRuleSetConfiguredCases(): iterable
- {
- yield ['@PER', ['@PER-CS']];
- yield ['@PER:risky', ['@PER-CS:risky']];
- }
- public static function provideGetDirectoryCases(): iterable
- {
- yield [null, '/my/path/my/file', 'my/file'];
- yield ['/my/path/.php-cs-fixer.cache', '/my/path/my/file', 'my/file'];
- yield ['/my/path2/dir/.php-cs-fixer.cache', '/my/path2/dir/dir2/file', 'dir2/file'];
- yield ['dir/.php-cs-fixer.cache', '/my/path/dir/dir3/file', 'dir3/file'];
- }
- /**
- * @dataProvider provideGetDirectoryCases
- */
- public function testGetDirectory(?string $cacheFile, string $file, string $expectedPathRelativeToFile): void
- {
- if (null !== $cacheFile) {
- $cacheFile = $this->normalizePath($cacheFile);
- }
- $file = $this->normalizePath($file);
- $expectedPathRelativeToFile = $this->normalizePath($expectedPathRelativeToFile);
- $config = new Config();
- if (null === $cacheFile) {
- $config->setUsingCache(false);
- } else {
- $config->setCacheFile($cacheFile);
- }
- $resolver = new ConfigurationResolver($config, [], $this->normalizePath('/my/path'), $this->createToolInfoDouble());
- $directory = $resolver->getDirectory();
- self::assertSame($expectedPathRelativeToFile, $directory->getRelativePathTo($file));
- }
- private function normalizePath(string $path): string
- {
- return str_replace('/', \DIRECTORY_SEPARATOR, $path);
- }
- /**
- * @param array<string, array<string, mixed>|bool> $expected
- * @param array<string, array<string, mixed>|bool> $actual
- */
- private static function assertSameRules(array $expected, array $actual): void
- {
- ksort($expected);
- ksort($actual);
- self::assertSame($expected, $actual);
- }
- private static function getFixtureDir(): string
- {
- return realpath(__DIR__.\DIRECTORY_SEPARATOR.'..'.\DIRECTORY_SEPARATOR.'Fixtures'.\DIRECTORY_SEPARATOR.'ConfigurationResolverConfigFile'.\DIRECTORY_SEPARATOR).'/';
- }
- /**
- * @param array<string, mixed> $options
- */
- private function createConfigurationResolver(
- array $options,
- Config $config = null,
- string $cwdPath = '',
- ToolInfoInterface $toolInfo = null
- ): ConfigurationResolver {
- return new ConfigurationResolver(
- $config ?? new Config(),
- $options,
- $cwdPath,
- $toolInfo ?? $this->createToolInfoDouble()
- );
- }
- private function createDeprecatedFixerDouble(): DeprecatedFixerInterface
- {
- return new class() extends AbstractFixer implements DeprecatedFixerInterface, ConfigurableFixerInterface {
- public function getDefinition(): FixerDefinitionInterface
- {
- throw new \LogicException('Not implemented.');
- }
- public function isCandidate(Tokens $tokens): bool
- {
- throw new \LogicException('Not implemented.');
- }
- public function getSuccessorsNames(): array
- {
- return ['testA', 'testB'];
- }
- public function getName(): string
- {
- return 'Vendor4/foo';
- }
- protected function applyFix(\SplFileInfo $file, Tokens $tokens): void {}
- protected function createConfigurationDefinition(): FixerConfigurationResolverInterface
- {
- return new FixerConfigurationResolver([
- (new FixerOptionBuilder('foo', 'Foo.'))->getOption(),
- ]);
- }
- };
- }
- private function createToolInfoDouble(): ToolInfoInterface
- {
- return new class() implements ToolInfoInterface {
- public function getComposerInstallationDetails(): array
- {
- throw new \BadMethodCallException();
- }
- public function getComposerVersion(): string
- {
- throw new \BadMethodCallException();
- }
- public function getVersion(): string
- {
- throw new \BadMethodCallException();
- }
- public function isInstalledAsPhar(): bool
- {
- return true;
- }
- public function isInstalledByComposer(): bool
- {
- throw new \BadMethodCallException();
- }
- public function isRunInsideDocker(): bool
- {
- return false;
- }
- public function getPharDownloadUri(string $version): string
- {
- throw new \BadMethodCallException();
- }
- };
- }
- }
|