RuleSetsTest.php 10.0 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321
  1. <?php
  2. declare(strict_types=1);
  3. /*
  4. * This file is part of PHP CS Fixer.
  5. *
  6. * (c) Fabien Potencier <fabien@symfony.com>
  7. * Dariusz Rumiński <dariusz.ruminski@gmail.com>
  8. *
  9. * This source file is subject to the MIT license that is bundled
  10. * with this source code in the file LICENSE.
  11. */
  12. namespace PhpCsFixer\Tests\RuleSet;
  13. use PhpCsFixer\AbstractFixer;
  14. use PhpCsFixer\Fixer\ConfigurableFixerInterface;
  15. use PhpCsFixer\Fixer\PhpUnit\PhpUnitTargetVersion;
  16. use PhpCsFixer\FixerFactory;
  17. use PhpCsFixer\RuleSet\RuleSet;
  18. use PhpCsFixer\RuleSet\RuleSets;
  19. use PhpCsFixer\Tests\TestCase;
  20. /**
  21. * @author Dariusz Rumiński <dariusz.ruminski@gmail.com>
  22. *
  23. * @internal
  24. *
  25. * @covers \PhpCsFixer\RuleSet\RuleSets
  26. */
  27. final class RuleSetsTest extends TestCase
  28. {
  29. public function testGetSetDefinitionNames(): void
  30. {
  31. self::assertSame(
  32. array_keys(RuleSets::getSetDefinitions()),
  33. RuleSets::getSetDefinitionNames()
  34. );
  35. }
  36. public function testGetSetDefinitions(): void
  37. {
  38. $sets = RuleSets::getSetDefinitions();
  39. foreach ($sets as $name => $set) {
  40. self::assertIsString($name);
  41. self::assertStringStartsWith('@', $name);
  42. self::assertIsArray($set->getRules());
  43. self::assertSame($set, RuleSets::getSetDefinition($name));
  44. }
  45. }
  46. public function testGetUnknownSetDefinition(): void
  47. {
  48. $name = 'Unknown';
  49. $this->expectException(\InvalidArgumentException::class);
  50. $this->expectExceptionMessageMatches(sprintf('#^Set "%s" does not exist\.$#', $name));
  51. RuleSets::getSetDefinition($name);
  52. }
  53. /**
  54. * @dataProvider provideSetDefinitionNameCases
  55. */
  56. public function testHasIntegrationTest(string $setDefinitionName): void
  57. {
  58. $setsWithoutTests = [
  59. '@PER',
  60. '@PER:risky',
  61. '@PER-CS',
  62. '@PER-CS:risky',
  63. '@PHP56Migration',
  64. '@PHP56Migration:risky',
  65. '@PHP70Migration',
  66. '@PHP70Migration:risky',
  67. '@PHP71Migration',
  68. '@PHP71Migration:risky',
  69. '@PHP73Migration',
  70. '@PHP80Migration',
  71. '@PhpCsFixer',
  72. '@PhpCsFixer:risky',
  73. '@PHPUnit48Migration',
  74. '@PHPUnit55Migration:risky',
  75. '@PHPUnit75Migration:risky',
  76. '@PHPUnit84Migration:risky',
  77. '@PHPUnit100Migration:risky',
  78. '@PSR1',
  79. ];
  80. if (\in_array($setDefinitionName, $setsWithoutTests, true)) {
  81. self::markTestIncomplete(sprintf('Set "%s" has no integration test.', $setDefinitionName));
  82. }
  83. $setDefinitionFileNamePrefix = str_replace(':', '-', $setDefinitionName);
  84. $dir = __DIR__.'/../../tests/Fixtures/Integration/set';
  85. $file = sprintf('%s/%s.test', $dir, $setDefinitionFileNamePrefix);
  86. self::assertFileExists($file);
  87. self::assertFileExists(sprintf('%s/%s.test-in.php', $dir, $setDefinitionFileNamePrefix));
  88. self::assertFileExists(sprintf('%s/%s.test-out.php', $dir, $setDefinitionFileNamePrefix));
  89. $template = '--TEST--
  90. Integration of %s.
  91. --RULESET--
  92. {"%s": true}
  93. ';
  94. self::assertStringStartsWith(
  95. sprintf($template, $setDefinitionName, $setDefinitionName),
  96. file_get_contents($file)
  97. );
  98. }
  99. /**
  100. * @dataProvider provideSetDefinitionNameCases
  101. */
  102. public function testBuildInSetDefinitionNames(string $setName): void
  103. {
  104. self::assertStringStartsWith('@', $setName);
  105. }
  106. /**
  107. * @dataProvider provideSetDefinitionNameCases
  108. */
  109. public function testSetDefinitionsAreSorted(string $setDefinitionName): void
  110. {
  111. $setDefinition = RuleSets::getSetDefinitions()[$setDefinitionName]->getRules();
  112. $sortedSetDefinition = $setDefinition;
  113. $this->sort($sortedSetDefinition);
  114. self::assertSame($sortedSetDefinition, $setDefinition, sprintf(
  115. 'Failed to assert that the set definition for "%s" is sorted by key.',
  116. $setDefinitionName
  117. ));
  118. }
  119. public function testSetDefinitionsItselfIsSorted(): void
  120. {
  121. $setDefinition = array_keys(RuleSets::getSetDefinitions());
  122. $sortedSetDefinition = $setDefinition;
  123. natsort($sortedSetDefinition);
  124. self::assertSame($sortedSetDefinition, $setDefinition);
  125. }
  126. public static function provideSetDefinitionNameCases(): iterable
  127. {
  128. $setDefinitionNames = RuleSets::getSetDefinitionNames();
  129. return array_map(static fn (string $setDefinitionName): array => [$setDefinitionName], $setDefinitionNames);
  130. }
  131. /**
  132. * @dataProvider providePHPUnitMigrationTargetVersionsCases
  133. */
  134. public function testPHPUnitMigrationTargetVersions(string $setName): void
  135. {
  136. $ruleSet = new RuleSet([$setName => true]);
  137. foreach ($ruleSet->getRules() as $ruleName => $ruleConfig) {
  138. $targetVersion = $ruleConfig['target'] ?? $this->getDefaultPHPUnitTargetOfRule($ruleName);
  139. if (null === $targetVersion) {
  140. // fixer does not have "target" option
  141. $this->addToAssertionCount(1);
  142. continue;
  143. }
  144. self::assertPHPUnitVersionIsLargestAllowed($setName, $ruleName, $targetVersion);
  145. }
  146. }
  147. /**
  148. * @return iterable<array{string}>
  149. */
  150. public static function providePHPUnitMigrationTargetVersionsCases(): iterable
  151. {
  152. $setDefinitionNames = RuleSets::getSetDefinitionNames();
  153. $setDefinitionPHPUnitMigrationNames = array_filter($setDefinitionNames, static fn (string $setDefinitionName): bool => 1 === preg_match('/^@PHPUnit\d+Migration:risky$/', $setDefinitionName));
  154. return array_map(static fn (string $setDefinitionName): array => [$setDefinitionName], $setDefinitionPHPUnitMigrationNames);
  155. }
  156. private static function assertPHPUnitVersionIsLargestAllowed(string $setName, string $ruleName, string $actualTargetVersion): void
  157. {
  158. $maximumVersionForRuleset = preg_replace('/^@PHPUnit(\d+)(\d)Migration:risky$/', '$1.$2', $setName);
  159. $fixer = self::getFixerByName($ruleName);
  160. foreach ($fixer->getConfigurationDefinition()->getOptions() as $option) {
  161. if ('target' === $option->getName()) {
  162. $allowedVersionsForFixer = array_diff($option->getAllowedValues(), [PhpUnitTargetVersion::VERSION_NEWEST]);
  163. break;
  164. }
  165. }
  166. if (!isset($allowedVersionsForFixer)) {
  167. throw new \Exception(sprintf('The fixer "%s" does not have option "target".', $fixer->getName()));
  168. }
  169. /** @var string[] $allowedVersionsForRuleset */
  170. $allowedVersionsForRuleset = array_filter(
  171. $allowedVersionsForFixer,
  172. static fn (string $version): bool => version_compare($maximumVersionForRuleset, $version) >= 0
  173. );
  174. self::assertTrue(\in_array($actualTargetVersion, $allowedVersionsForRuleset, true), sprintf(
  175. 'Rule "%s" (in rule set "%s") has target "%s", but the rule set is not allowing it (allowed are only "%s")',
  176. $fixer->getName(),
  177. $setName,
  178. $actualTargetVersion,
  179. implode('", "', $allowedVersionsForRuleset)
  180. ));
  181. rsort($allowedVersionsForRuleset);
  182. $maximumAllowedVersionForRuleset = reset($allowedVersionsForRuleset);
  183. self::assertSame($maximumAllowedVersionForRuleset, $actualTargetVersion, sprintf(
  184. 'Rule "%s" (in rule set "%s") has target "%s", but there is higher available target "%s"',
  185. $fixer->getName(),
  186. $setName,
  187. $actualTargetVersion,
  188. $maximumAllowedVersionForRuleset
  189. ));
  190. }
  191. /**
  192. * Sorts an array of rule set definitions recursively.
  193. *
  194. * Sometimes keys are all string, sometimes they are integers - we need to account for that.
  195. *
  196. * @param array<array-key, mixed> $data
  197. */
  198. private function sort(array &$data): void
  199. {
  200. $this->doSort($data, '');
  201. }
  202. /**
  203. * @param array<array-key, mixed> $data
  204. */
  205. private function doSort(array &$data, string $path): void
  206. {
  207. if ('ordered_imports.imports_order' === $path) { // order matters
  208. return;
  209. }
  210. $keys = array_keys($data);
  211. if ($this->allInteger($keys)) {
  212. sort($data);
  213. } else {
  214. ksort($data);
  215. }
  216. foreach ($data as $key => $value) {
  217. if (\is_array($value)) {
  218. $this->doSort(
  219. $data[$key],
  220. $path.('' !== $path ? '.' : '').$key
  221. );
  222. }
  223. }
  224. }
  225. /**
  226. * @param array<array-key, mixed> $values
  227. */
  228. private function allInteger(array $values): bool
  229. {
  230. foreach ($values as $value) {
  231. if (!\is_int($value)) {
  232. return false;
  233. }
  234. }
  235. return true;
  236. }
  237. private function getDefaultPHPUnitTargetOfRule(string $ruleName): ?string
  238. {
  239. $targetVersion = null;
  240. $fixer = self::getFixerByName($ruleName);
  241. if ($fixer instanceof ConfigurableFixerInterface) {
  242. foreach ($fixer->getConfigurationDefinition()->getOptions() as $option) {
  243. if ('target' === $option->getName()) {
  244. $targetVersion = $option->getDefault();
  245. break;
  246. }
  247. }
  248. }
  249. return $targetVersion;
  250. }
  251. private static function getFixerByName(string $name): AbstractFixer
  252. {
  253. $factory = new FixerFactory();
  254. $factory->registerBuiltInFixers();
  255. $factory->useRuleSet(new RuleSet([$name => true]));
  256. $fixers = $factory->getFixers();
  257. if (0 === \count($fixers)) {
  258. throw new \RuntimeException('FixerFactory unexpectedly returned empty array.');
  259. }
  260. $fixer = current($fixers);
  261. if (!$fixer instanceof AbstractFixer) {
  262. throw new \RuntimeException(sprintf('Fixer class for "%s" rule does not extend "%s".', $name, AbstractFixer::class));
  263. }
  264. return $fixer;
  265. }
  266. }