FixerFactoryTest.php 31 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610
  1. <?php
  2. /*
  3. * This file is part of PHP CS Fixer.
  4. *
  5. * (c) Fabien Potencier <fabien@symfony.com>
  6. * Dariusz Rumiński <dariusz.ruminski@gmail.com>
  7. *
  8. * This source file is subject to the MIT license that is bundled
  9. * with this source code in the file LICENSE.
  10. */
  11. namespace PhpCsFixer\Tests\AutoReview;
  12. use PhpCsFixer\Fixer\FixerInterface;
  13. use PhpCsFixer\FixerFactory;
  14. use PhpCsFixer\Tests\Test\IntegrationCaseFactory;
  15. use PhpCsFixer\Tests\TestCase;
  16. use Symfony\Component\Finder\SplFileInfo;
  17. /**
  18. * @author Dariusz Rumiński <dariusz.ruminski@gmail.com>
  19. *
  20. * @internal
  21. *
  22. * @coversNothing
  23. * @group auto-review
  24. * @group covers-nothing
  25. */
  26. final class FixerFactoryTest extends TestCase
  27. {
  28. public function testFixersPriorityEdgeFixers()
  29. {
  30. $factory = new FixerFactory();
  31. $factory->registerBuiltInFixers();
  32. $fixers = $factory->getFixers();
  33. static::assertSame('encoding', $fixers[0]->getName(), 'Expected "encoding" fixer to have the highest priority.');
  34. static::assertSame('full_opening_tag', $fixers[1]->getName(), 'Expected "full_opening_tag" fixer has second highest priority.');
  35. static::assertSame('single_blank_line_at_eof', $fixers[\count($fixers) - 1]->getName(), 'Expected "single_blank_line_at_eof" to have the lowest priority.');
  36. }
  37. /**
  38. * @dataProvider provideFixersPriorityCases
  39. * @dataProvider provideFixersPrioritySpecialPhpdocCases
  40. */
  41. public function testFixersPriority(FixerInterface $first, FixerInterface $second)
  42. {
  43. static::assertLessThan($first->getPriority(), $second->getPriority(), sprintf('"%s" should have less priority than "%s"', \get_class($second), \get_class($first)));
  44. }
  45. public function provideFixersPriorityCases()
  46. {
  47. $factory = new FixerFactory();
  48. $factory->registerBuiltInFixers();
  49. $fixers = [];
  50. foreach ($factory->getFixers() as $fixer) {
  51. $fixers[$fixer->getName()] = $fixer;
  52. }
  53. return [
  54. [$fixers['align_multiline_comment'], $fixers['phpdoc_trim_consecutive_blank_line_separation']],
  55. [$fixers['array_indentation'], $fixers['align_multiline_comment']],
  56. [$fixers['array_indentation'], $fixers['binary_operator_spaces']],
  57. [$fixers['array_syntax'], $fixers['binary_operator_spaces']],
  58. [$fixers['array_syntax'], $fixers['ternary_operator_spaces']],
  59. [$fixers['backtick_to_shell_exec'], $fixers['escape_implicit_backslashes']],
  60. [$fixers['backtick_to_shell_exec'], $fixers['explicit_string_variable']],
  61. [$fixers['backtick_to_shell_exec'], $fixers['native_function_invocation']],
  62. [$fixers['backtick_to_shell_exec'], $fixers['single_quote']],
  63. [$fixers['blank_line_after_opening_tag'], $fixers['no_blank_lines_before_namespace']],
  64. [$fixers['braces'], $fixers['array_indentation']],
  65. [$fixers['braces'], $fixers['method_argument_space']],
  66. [$fixers['braces'], $fixers['method_chaining_indentation']],
  67. [$fixers['class_attributes_separation'], $fixers['braces']],
  68. [$fixers['class_attributes_separation'], $fixers['indentation_type']],
  69. [$fixers['class_keyword_remove'], $fixers['no_unused_imports']],
  70. [$fixers['combine_consecutive_issets'], $fixers['multiline_whitespace_before_semicolons']],
  71. [$fixers['combine_consecutive_issets'], $fixers['no_singleline_whitespace_before_semicolons']],
  72. [$fixers['combine_consecutive_issets'], $fixers['no_spaces_inside_parenthesis']],
  73. [$fixers['combine_consecutive_issets'], $fixers['no_trailing_whitespace']],
  74. [$fixers['combine_consecutive_issets'], $fixers['no_whitespace_in_blank_line']],
  75. [$fixers['combine_consecutive_unsets'], $fixers['no_extra_blank_lines']],
  76. [$fixers['combine_consecutive_unsets'], $fixers['no_trailing_whitespace']],
  77. [$fixers['combine_consecutive_unsets'], $fixers['no_whitespace_in_blank_line']],
  78. [$fixers['combine_consecutive_unsets'], $fixers['space_after_semicolon']],
  79. [$fixers['combine_nested_dirname'], $fixers['method_argument_space']],
  80. [$fixers['combine_nested_dirname'], $fixers['no_spaces_inside_parenthesis']],
  81. [$fixers['declare_strict_types'], $fixers['blank_line_after_opening_tag']],
  82. [$fixers['declare_strict_types'], $fixers['declare_equal_normalize']],
  83. [$fixers['declare_strict_types'], $fixers['header_comment']],
  84. [$fixers['dir_constant'], $fixers['combine_nested_dirname']],
  85. [$fixers['doctrine_annotation_array_assignment'], $fixers['doctrine_annotation_spaces']],
  86. [$fixers['echo_tag_syntax'], $fixers['no_mixed_echo_print']],
  87. [$fixers['elseif'], $fixers['braces']],
  88. [$fixers['escape_implicit_backslashes'], $fixers['heredoc_to_nowdoc']],
  89. [$fixers['escape_implicit_backslashes'], $fixers['single_quote']],
  90. [$fixers['explicit_string_variable'], $fixers['simple_to_complex_string_variable']],
  91. [$fixers['final_internal_class'], $fixers['final_static_access']],
  92. [$fixers['final_internal_class'], $fixers['protected_to_private']],
  93. [$fixers['final_internal_class'], $fixers['self_static_accessor']],
  94. [$fixers['fully_qualified_strict_types'], $fixers['no_superfluous_phpdoc_tags']],
  95. [$fixers['function_to_constant'], $fixers['native_function_casing']],
  96. [$fixers['function_to_constant'], $fixers['no_extra_blank_lines']],
  97. [$fixers['function_to_constant'], $fixers['no_singleline_whitespace_before_semicolons']],
  98. [$fixers['function_to_constant'], $fixers['no_trailing_whitespace']],
  99. [$fixers['function_to_constant'], $fixers['no_whitespace_in_blank_line']],
  100. [$fixers['function_to_constant'], $fixers['self_static_accessor']],
  101. [$fixers['general_phpdoc_annotation_remove'], $fixers['no_empty_phpdoc']],
  102. [$fixers['general_phpdoc_annotation_remove'], $fixers['phpdoc_line_span']],
  103. [$fixers['general_phpdoc_annotation_remove'], $fixers['phpdoc_separation']],
  104. [$fixers['general_phpdoc_annotation_remove'], $fixers['phpdoc_trim']],
  105. [$fixers['general_phpdoc_tag_rename'], $fixers['phpdoc_add_missing_param_annotation']],
  106. [$fixers['global_namespace_import'], $fixers['no_unused_imports']],
  107. [$fixers['global_namespace_import'], $fixers['ordered_imports']],
  108. [$fixers['implode_call'], $fixers['method_argument_space']],
  109. [$fixers['indentation_type'], $fixers['phpdoc_indent']],
  110. [$fixers['is_null'], $fixers['yoda_style']],
  111. [$fixers['lambda_not_used_import'], $fixers['no_spaces_inside_parenthesis']],
  112. [$fixers['line_ending'], $fixers['braces']],
  113. [$fixers['list_syntax'], $fixers['binary_operator_spaces']],
  114. [$fixers['list_syntax'], $fixers['ternary_operator_spaces']],
  115. [$fixers['method_argument_space'], $fixers['array_indentation']],
  116. [$fixers['method_chaining_indentation'], $fixers['array_indentation']],
  117. [$fixers['method_chaining_indentation'], $fixers['method_argument_space']],
  118. [$fixers['method_separation'], $fixers['braces']],
  119. [$fixers['method_separation'], $fixers['indentation_type']],
  120. [$fixers['multiline_whitespace_before_semicolons'], $fixers['space_after_semicolon']],
  121. [$fixers['native_constant_invocation'], $fixers['global_namespace_import']],
  122. [$fixers['native_function_invocation'], $fixers['global_namespace_import']],
  123. [$fixers['no_alias_functions'], $fixers['implode_call']],
  124. [$fixers['no_alias_functions'], $fixers['php_unit_dedicate_assert']],
  125. [$fixers['no_alternative_syntax'], $fixers['braces']],
  126. [$fixers['no_alternative_syntax'], $fixers['elseif']],
  127. [$fixers['no_alternative_syntax'], $fixers['no_superfluous_elseif']],
  128. [$fixers['no_alternative_syntax'], $fixers['no_useless_else']],
  129. [$fixers['no_alternative_syntax'], $fixers['switch_continue_to_break']],
  130. [$fixers['no_blank_lines_after_phpdoc'], $fixers['header_comment']],
  131. [$fixers['no_blank_lines_after_phpdoc'], $fixers['single_blank_line_before_namespace']],
  132. [$fixers['no_empty_comment'], $fixers['no_extra_blank_lines']],
  133. [$fixers['no_empty_comment'], $fixers['no_trailing_whitespace']],
  134. [$fixers['no_empty_comment'], $fixers['no_whitespace_in_blank_line']],
  135. [$fixers['no_empty_phpdoc'], $fixers['no_extra_blank_lines']],
  136. [$fixers['no_empty_phpdoc'], $fixers['no_trailing_whitespace']],
  137. [$fixers['no_empty_phpdoc'], $fixers['no_whitespace_in_blank_line']],
  138. [$fixers['no_empty_statement'], $fixers['braces']],
  139. [$fixers['no_empty_statement'], $fixers['combine_consecutive_unsets']],
  140. [$fixers['no_empty_statement'], $fixers['multiline_whitespace_before_semicolons']],
  141. [$fixers['no_empty_statement'], $fixers['no_extra_blank_lines']],
  142. [$fixers['no_empty_statement'], $fixers['no_singleline_whitespace_before_semicolons']],
  143. [$fixers['no_empty_statement'], $fixers['no_trailing_whitespace']],
  144. [$fixers['no_empty_statement'], $fixers['no_useless_else']],
  145. [$fixers['no_empty_statement'], $fixers['no_useless_return']],
  146. [$fixers['no_empty_statement'], $fixers['no_whitespace_in_blank_line']],
  147. [$fixers['no_empty_statement'], $fixers['return_assignment']],
  148. [$fixers['no_empty_statement'], $fixers['space_after_semicolon']],
  149. [$fixers['no_empty_statement'], $fixers['switch_case_semicolon_to_colon']],
  150. [$fixers['no_extra_blank_lines'], $fixers['blank_line_before_statement']],
  151. [$fixers['no_leading_import_slash'], $fixers['ordered_imports']],
  152. [$fixers['no_multiline_whitespace_around_double_arrow'], $fixers['binary_operator_spaces']],
  153. [$fixers['no_multiline_whitespace_around_double_arrow'], $fixers['trailing_comma_in_multiline_array']],
  154. [$fixers['no_php4_constructor'], $fixers['ordered_class_elements']],
  155. [$fixers['no_short_bool_cast'], $fixers['cast_spaces']],
  156. [$fixers['no_short_echo_tag'], $fixers['no_mixed_echo_print']],
  157. [$fixers['no_spaces_after_function_name'], $fixers['function_to_constant']],
  158. [$fixers['no_spaces_inside_parenthesis'], $fixers['function_to_constant']],
  159. [$fixers['no_superfluous_elseif'], $fixers['simplified_if_return']],
  160. [$fixers['no_superfluous_phpdoc_tags'], $fixers['no_empty_phpdoc']],
  161. [$fixers['no_superfluous_phpdoc_tags'], $fixers['void_return']],
  162. [$fixers['no_unneeded_control_parentheses'], $fixers['no_trailing_whitespace']],
  163. [$fixers['no_unneeded_curly_braces'], $fixers['no_useless_else']],
  164. [$fixers['no_unneeded_curly_braces'], $fixers['no_useless_return']],
  165. [$fixers['no_unneeded_curly_braces'], $fixers['return_assignment']],
  166. [$fixers['no_unneeded_curly_braces'], $fixers['simplified_if_return']],
  167. [$fixers['no_unset_cast'], $fixers['binary_operator_spaces']],
  168. [$fixers['no_unset_on_property'], $fixers['combine_consecutive_unsets']],
  169. [$fixers['no_unused_imports'], $fixers['blank_line_after_namespace']],
  170. [$fixers['no_unused_imports'], $fixers['no_extra_blank_lines']],
  171. [$fixers['no_unused_imports'], $fixers['no_leading_import_slash']],
  172. [$fixers['no_unused_imports'], $fixers['single_line_after_imports']],
  173. [$fixers['no_useless_else'], $fixers['braces']],
  174. [$fixers['no_useless_else'], $fixers['combine_consecutive_unsets']],
  175. [$fixers['no_useless_else'], $fixers['no_break_comment']],
  176. [$fixers['no_useless_else'], $fixers['no_extra_blank_lines']],
  177. [$fixers['no_useless_else'], $fixers['no_trailing_whitespace']],
  178. [$fixers['no_useless_else'], $fixers['no_useless_return']],
  179. [$fixers['no_useless_else'], $fixers['no_whitespace_in_blank_line']],
  180. [$fixers['no_useless_else'], $fixers['simplified_if_return']],
  181. [$fixers['no_useless_return'], $fixers['blank_line_before_return']],
  182. [$fixers['no_useless_return'], $fixers['blank_line_before_statement']],
  183. [$fixers['no_useless_return'], $fixers['no_extra_blank_lines']],
  184. [$fixers['no_useless_return'], $fixers['no_whitespace_in_blank_line']],
  185. [$fixers['no_useless_sprintf'], $fixers['method_argument_space']],
  186. [$fixers['no_useless_sprintf'], $fixers['native_function_casing']],
  187. [$fixers['no_useless_sprintf'], $fixers['no_empty_statement']],
  188. [$fixers['no_useless_sprintf'], $fixers['no_extra_blank_lines']],
  189. [$fixers['no_useless_sprintf'], $fixers['no_spaces_inside_parenthesis']],
  190. [$fixers['nullable_type_declaration_for_default_null_value'], $fixers['no_unreachable_default_argument_value']],
  191. [$fixers['ordered_class_elements'], $fixers['class_attributes_separation']],
  192. [$fixers['ordered_class_elements'], $fixers['method_separation']],
  193. [$fixers['ordered_class_elements'], $fixers['no_blank_lines_after_class_opening']],
  194. [$fixers['ordered_class_elements'], $fixers['space_after_semicolon']],
  195. [$fixers['php_unit_construct'], $fixers['php_unit_dedicate_assert']],
  196. [$fixers['php_unit_dedicate_assert'], $fixers['php_unit_dedicate_assert_internal_type']],
  197. [$fixers['php_unit_fqcn_annotation'], $fixers['no_unused_imports']],
  198. [$fixers['php_unit_fqcn_annotation'], $fixers['phpdoc_order_by_value']],
  199. [$fixers['php_unit_internal_class'], $fixers['final_internal_class']],
  200. [$fixers['php_unit_no_expectation_annotation'], $fixers['no_empty_phpdoc']],
  201. [$fixers['php_unit_no_expectation_annotation'], $fixers['php_unit_expectation']],
  202. [$fixers['php_unit_test_annotation'], $fixers['no_empty_phpdoc']],
  203. [$fixers['php_unit_test_annotation'], $fixers['php_unit_method_casing']],
  204. [$fixers['php_unit_test_annotation'], $fixers['phpdoc_trim']],
  205. [$fixers['php_unit_test_case_static_method_calls'], $fixers['final_static_access']],
  206. [$fixers['php_unit_test_case_static_method_calls'], $fixers['self_static_accessor']],
  207. [$fixers['phpdoc_add_missing_param_annotation'], $fixers['no_empty_phpdoc']],
  208. [$fixers['phpdoc_add_missing_param_annotation'], $fixers['no_superfluous_phpdoc_tags']],
  209. [$fixers['phpdoc_add_missing_param_annotation'], $fixers['phpdoc_align']],
  210. [$fixers['phpdoc_add_missing_param_annotation'], $fixers['phpdoc_order']],
  211. [$fixers['phpdoc_annotation_without_dot'], $fixers['phpdoc_types']],
  212. [$fixers['phpdoc_annotation_without_dot'], $fixers['phpdoc_types_order']],
  213. [$fixers['phpdoc_no_access'], $fixers['no_empty_phpdoc']],
  214. [$fixers['phpdoc_no_access'], $fixers['phpdoc_separation']],
  215. [$fixers['phpdoc_no_access'], $fixers['phpdoc_trim']],
  216. [$fixers['phpdoc_no_alias_tag'], $fixers['phpdoc_add_missing_param_annotation']],
  217. [$fixers['phpdoc_no_alias_tag'], $fixers['phpdoc_single_line_var_spacing']],
  218. [$fixers['phpdoc_no_empty_return'], $fixers['no_empty_phpdoc']],
  219. [$fixers['phpdoc_no_empty_return'], $fixers['phpdoc_order']],
  220. [$fixers['phpdoc_no_empty_return'], $fixers['phpdoc_separation']],
  221. [$fixers['phpdoc_no_empty_return'], $fixers['phpdoc_trim']],
  222. [$fixers['phpdoc_no_package'], $fixers['no_empty_phpdoc']],
  223. [$fixers['phpdoc_no_package'], $fixers['phpdoc_separation']],
  224. [$fixers['phpdoc_no_package'], $fixers['phpdoc_trim']],
  225. [$fixers['phpdoc_no_useless_inheritdoc'], $fixers['no_empty_phpdoc']],
  226. [$fixers['phpdoc_no_useless_inheritdoc'], $fixers['no_trailing_whitespace_in_comment']],
  227. [$fixers['phpdoc_order'], $fixers['phpdoc_separation']],
  228. [$fixers['phpdoc_order'], $fixers['phpdoc_trim']],
  229. [$fixers['phpdoc_return_self_reference'], $fixers['no_superfluous_phpdoc_tags']],
  230. [$fixers['phpdoc_scalar'], $fixers['phpdoc_to_return_type']],
  231. [$fixers['phpdoc_to_comment'], $fixers['no_empty_comment']],
  232. [$fixers['phpdoc_to_comment'], $fixers['phpdoc_no_useless_inheritdoc']],
  233. [$fixers['phpdoc_to_param_type'], $fixers['no_superfluous_phpdoc_tags']],
  234. [$fixers['phpdoc_to_return_type'], $fixers['fully_qualified_strict_types']],
  235. [$fixers['phpdoc_to_return_type'], $fixers['no_superfluous_phpdoc_tags']],
  236. [$fixers['phpdoc_to_return_type'], $fixers['return_type_declaration']],
  237. [$fixers['phpdoc_types'], $fixers['phpdoc_to_return_type']],
  238. [$fixers['pow_to_exponentiation'], $fixers['binary_operator_spaces']],
  239. [$fixers['pow_to_exponentiation'], $fixers['method_argument_space']],
  240. [$fixers['pow_to_exponentiation'], $fixers['native_function_casing']],
  241. [$fixers['pow_to_exponentiation'], $fixers['no_spaces_after_function_name']],
  242. [$fixers['pow_to_exponentiation'], $fixers['no_spaces_inside_parenthesis']],
  243. [$fixers['protected_to_private'], $fixers['ordered_class_elements']],
  244. [$fixers['return_assignment'], $fixers['blank_line_before_statement']],
  245. [$fixers['semicolon_after_instruction'], $fixers['simplified_if_return']],
  246. [$fixers['simplified_if_return'], $fixers['no_multiline_whitespace_before_semicolons']],
  247. [$fixers['simplified_if_return'], $fixers['no_singleline_whitespace_before_semicolons']],
  248. [$fixers['simplified_null_return'], $fixers['no_useless_return']],
  249. [$fixers['simplified_null_return'], $fixers['void_return']],
  250. [$fixers['single_class_element_per_statement'], $fixers['class_attributes_separation']],
  251. [$fixers['single_import_per_statement'], $fixers['multiline_whitespace_before_semicolons']],
  252. [$fixers['single_import_per_statement'], $fixers['no_leading_import_slash']],
  253. [$fixers['single_import_per_statement'], $fixers['no_singleline_whitespace_before_semicolons']],
  254. [$fixers['single_import_per_statement'], $fixers['no_unused_imports']],
  255. [$fixers['single_import_per_statement'], $fixers['space_after_semicolon']],
  256. [$fixers['single_line_throw'], $fixers['concat_space']],
  257. [$fixers['single_trait_insert_per_statement'], $fixers['braces']],
  258. [$fixers['single_trait_insert_per_statement'], $fixers['space_after_semicolon']],
  259. [$fixers['standardize_increment'], $fixers['increment_style']],
  260. [$fixers['standardize_not_equals'], $fixers['binary_operator_spaces']],
  261. [$fixers['strict_comparison'], $fixers['binary_operator_spaces']],
  262. [$fixers['strict_param'], $fixers['native_function_invocation']],
  263. [$fixers['ternary_to_elvis_operator'], $fixers['no_trailing_whitespace']],
  264. [$fixers['ternary_to_elvis_operator'], $fixers['ternary_operator_spaces']],
  265. [$fixers['unary_operator_spaces'], $fixers['not_operator_with_space']],
  266. [$fixers['unary_operator_spaces'], $fixers['not_operator_with_successor_space']],
  267. [$fixers['void_return'], $fixers['phpdoc_no_empty_return']],
  268. [$fixers['void_return'], $fixers['return_type_declaration']],
  269. ];
  270. }
  271. public function provideFixersPrioritySpecialPhpdocCases()
  272. {
  273. $factory = new FixerFactory();
  274. $factory->registerBuiltInFixers();
  275. $fixers = [];
  276. foreach ($factory->getFixers() as $fixer) {
  277. $fixers[$fixer->getName()] = $fixer;
  278. }
  279. $cases = [];
  280. // prepare bulk tests for phpdoc fixers to test that:
  281. // * `comment_to_phpdoc` is first
  282. // * `phpdoc_to_comment` is second
  283. // * `phpdoc_indent` is third
  284. // * `phpdoc_types` is fourth
  285. // * `phpdoc_scalar` is fifth
  286. // * `phpdoc_align` is last
  287. $cases[] = [$fixers['comment_to_phpdoc'], $fixers['phpdoc_to_comment']];
  288. $cases[] = [$fixers['phpdoc_indent'], $fixers['phpdoc_types']];
  289. $cases[] = [$fixers['phpdoc_to_comment'], $fixers['phpdoc_indent']];
  290. $cases[] = [$fixers['phpdoc_types'], $fixers['phpdoc_scalar']];
  291. $docFixerNames = array_filter(
  292. array_keys($fixers),
  293. static function ($name) {
  294. return false !== strpos($name, 'phpdoc');
  295. }
  296. );
  297. foreach ($docFixerNames as $docFixerName) {
  298. if (!\in_array($docFixerName, ['comment_to_phpdoc', 'phpdoc_to_comment', 'phpdoc_indent', 'phpdoc_types', 'phpdoc_scalar'], true)) {
  299. $cases[] = [$fixers['comment_to_phpdoc'], $fixers[$docFixerName]];
  300. $cases[] = [$fixers['phpdoc_indent'], $fixers[$docFixerName]];
  301. $cases[] = [$fixers['phpdoc_to_comment'], $fixers[$docFixerName]];
  302. if ('phpdoc_annotation_without_dot' !== $docFixerName) {
  303. $cases[] = [$fixers['phpdoc_scalar'], $fixers[$docFixerName]];
  304. $cases[] = [$fixers['phpdoc_types'], $fixers[$docFixerName]];
  305. }
  306. }
  307. if ('phpdoc_align' !== $docFixerName) {
  308. $cases[] = [$fixers[$docFixerName], $fixers['phpdoc_align']];
  309. }
  310. }
  311. return $cases;
  312. }
  313. /**
  314. * @dataProvider provideFixersPriorityPairsHaveIntegrationTestCases
  315. */
  316. public function testFixersPriorityPairsHaveIntegrationTest(FixerInterface $first, FixerInterface $second)
  317. {
  318. $integrationTestName = $this->generateIntegrationTestName($first, $second);
  319. $file = $this->getIntegrationPriorityDirectory().$integrationTestName;
  320. if (is_file($file)) {
  321. $description = sprintf('Integration of fixers: %s,%s.', $first->getName(), $second->getName());
  322. $integrationTestExists = true;
  323. } else {
  324. $file = $this->getIntegrationPriorityDirectory().$this->generateIntegrationTestName($second, $first);
  325. $description = sprintf('Integration of fixers: %s,%s.', $second->getName(), $first->getName());
  326. $integrationTestExists = is_file($file);
  327. }
  328. static::assertTrue($integrationTestExists, sprintf('There shall be an integration test "%s". How do you know that priority set up is good, if there is no integration test to check it?', $integrationTestName));
  329. $file = realpath($file);
  330. $factory = new IntegrationCaseFactory();
  331. $test = $factory->create(new SplFileInfo($file, './', __DIR__));
  332. $rules = $test->getRuleset()->getRules();
  333. $expected = [$first->getName(), $second->getName()];
  334. $actual = array_keys($rules);
  335. sort($expected);
  336. sort($actual);
  337. static::assertSame($description, $test->getTitle(), sprintf('Please fix the title in "%s".', $file));
  338. static::assertCount(2, $rules, sprintf('Only the two rules that are tested for priority should be in the ruleset of "%s".', $file));
  339. foreach ($rules as $name => $config) {
  340. static::assertNotFalse($config, sprintf('The rule "%s" in "%s" may not be disabled for the test.', $name, $file));
  341. }
  342. static::assertSame($expected, $actual, sprintf('The ruleset of "%s" must contain the rules for the priority test.', $file));
  343. }
  344. public function provideFixersPriorityPairsHaveIntegrationTestCases()
  345. {
  346. return array_filter(
  347. $this->provideFixersPriorityCases(),
  348. // ignore speed-up only priorities set up
  349. function (array $case) {
  350. return !\in_array(
  351. $this->generateIntegrationTestName($case[0], $case[1]),
  352. [
  353. 'function_to_constant,native_function_casing.test',
  354. 'no_unused_imports,no_leading_import_slash.test',
  355. 'pow_to_exponentiation,method_argument_space.test',
  356. 'pow_to_exponentiation,native_function_casing.test',
  357. 'pow_to_exponentiation,no_spaces_after_function_name.test',
  358. 'pow_to_exponentiation,no_spaces_inside_parenthesis.test',
  359. 'no_useless_sprintf,native_function_casing.test',
  360. ],
  361. true
  362. );
  363. }
  364. );
  365. }
  366. public function testPriorityIntegrationDirectoryOnlyContainsFiles()
  367. {
  368. foreach (new \DirectoryIterator($this->getIntegrationPriorityDirectory()) as $candidate) {
  369. if ($candidate->isDot()) {
  370. continue;
  371. }
  372. $fileName = $candidate->getFilename();
  373. static::assertTrue($candidate->isFile(), sprintf('Expected only files in the priority integration test directory, got "%s".', $fileName));
  374. static::assertFalse($candidate->isLink(), sprintf('No (sym)links expected the priority integration test directory, got "%s".', $fileName));
  375. }
  376. }
  377. /**
  378. * @dataProvider provideIntegrationTestFilesCases
  379. *
  380. * @param string $fileName
  381. */
  382. public function testPriorityIntegrationTestFilesAreListedPriorityCases($fileName)
  383. {
  384. static $priorityCases;
  385. if (null === $priorityCases) {
  386. $priorityCases = [];
  387. foreach ($this->provideFixersPriorityCases() as $priorityCase) {
  388. $fixerName = $priorityCase[0]->getName();
  389. if (!isset($priorityCases[$fixerName])) {
  390. $priorityCases[$fixerName] = [];
  391. }
  392. $priorityCases[$fixerName][$priorityCase[1]->getName()] = true;
  393. }
  394. ksort($priorityCases);
  395. }
  396. static::assertSame(
  397. 1,
  398. preg_match('#^([a-z][a-z0-9_]*),([a-z][a-z_]*)(?:_\d{1,3})?\.test(-(in|out)\.php)?$#', $fileName, $matches),
  399. sprintf('File with unexpected name "%s" in the priority integration test directory.', $fileName)
  400. );
  401. $fixerName1 = $matches[1];
  402. $fixerName2 = $matches[2];
  403. static::assertTrue(
  404. isset($priorityCases[$fixerName1][$fixerName2]) || isset($priorityCases[$fixerName2][$fixerName1]),
  405. sprintf('Missing priority test entry for file "%s".', $fileName)
  406. );
  407. }
  408. public function provideIntegrationTestFilesCases()
  409. {
  410. $fileNames = [];
  411. foreach (new \DirectoryIterator($this->getIntegrationPriorityDirectory()) as $candidate) {
  412. if ($candidate->isDot()) {
  413. continue;
  414. }
  415. $fileNames[] = [$candidate->getFilename()];
  416. }
  417. sort($fileNames);
  418. return $fileNames;
  419. }
  420. public function testProvideFixersPriorityCasesAreSorted()
  421. {
  422. $cases = $this->provideFixersPriorityCases();
  423. $sorted = $cases;
  424. usort(
  425. $sorted,
  426. /**
  427. * @param array<FixerInterface> $priorityPair1
  428. * @param array<FixerInterface> $priorityPair2
  429. */
  430. static function (array $priorityPair1, array $priorityPair2) {
  431. $fixer1 = $priorityPair1[0];
  432. $fixer2 = $priorityPair2[0];
  433. if ($fixer1->getName() === $fixer2->getName()) {
  434. $fixer1 = $priorityPair1[1];
  435. $fixer2 = $priorityPair2[1];
  436. }
  437. return strcmp($fixer1->getName(), $fixer2->getName());
  438. }
  439. );
  440. if ($sorted !== $cases) { // PHPUnit takes a very long time creating a diff view on the arrays
  441. $casesDescription = '';
  442. foreach ($cases as $pair) {
  443. $casesDescription .= sprintf("\n%s/%s", $pair[0]->getName(), $pair[1]->getName());
  444. }
  445. $sortedDescription = '';
  446. foreach ($sorted as $pair) {
  447. $sortedDescription .= sprintf("\n%s/%s", $pair[0]->getName(), $pair[1]->getName());
  448. }
  449. static::assertSame($sortedDescription, $casesDescription);
  450. } else {
  451. $this->addToAssertionCount(1);
  452. }
  453. }
  454. public function testFixerPriorityComment()
  455. {
  456. $cases = array_merge(
  457. $this->provideFixersPriorityCases(),
  458. $this->provideFixersPrioritySpecialPhpdocCases()
  459. );
  460. $map = [];
  461. foreach ($cases as $beforeAfter) {
  462. list($before, $after) = $beforeAfter;
  463. $beforeClass = \get_class($before);
  464. $afterClass = \get_class($after);
  465. $beforeName = substr($beforeClass, strrpos($beforeClass, '\\') + 1);
  466. $afterName = substr($afterClass, strrpos($afterClass, '\\') + 1);
  467. if (!isset($map[$beforeName])) {
  468. $map[$beforeName] = [
  469. 'before' => [],
  470. 'after' => [],
  471. 'class' => $beforeClass,
  472. ];
  473. }
  474. $map[$beforeName]['before'][] = $afterName;
  475. if (!isset($map[$afterName])) {
  476. $map[$afterName] = [
  477. 'before' => [],
  478. 'after' => [],
  479. 'class' => $afterClass,
  480. ];
  481. }
  482. $map[$afterName]['after'][] = $beforeName;
  483. }
  484. $fixersPhpDocIssues = [];
  485. foreach ($map as $fixerName => $priorityMap) {
  486. $expectedMessage = "/**\n * {@inheritdoc}\n *";
  487. if (\count($priorityMap['before']) > 0) {
  488. sort($priorityMap['before']);
  489. $expectedMessage .= sprintf("\n * Must run before %s.", implode(', ', $priorityMap['before']));
  490. }
  491. if (\count($priorityMap['after']) > 0) {
  492. sort($priorityMap['after']);
  493. $expectedMessage .= sprintf("\n * Must run after %s.", implode(', ', $priorityMap['after']));
  494. }
  495. $expectedMessage .= "\n */";
  496. $reflection = new \ReflectionClass($priorityMap['class']);
  497. $method = $reflection->getMethod('getPriority');
  498. $phpDoc = $method->getDocComment();
  499. if (false === $phpDoc) {
  500. $fixersPhpDocIssues[$fixerName] = sprintf("PHPDoc for %s::getPriority is missing.\nExpected:\n%s", $fixerName, $expectedMessage);
  501. continue;
  502. }
  503. if ($expectedMessage !== $phpDoc) {
  504. $fixersPhpDocIssues[$fixerName] = sprintf("PHPDoc for %s::getPriority is not as expected.\nExpected:\n%s", $fixerName, $expectedMessage);
  505. continue;
  506. }
  507. }
  508. if (0 === \count($fixersPhpDocIssues)) {
  509. $this->addToAssertionCount(1);
  510. } else {
  511. $message = sprintf("There are %d priority PHPDoc issues found.\n", \count($fixersPhpDocIssues));
  512. ksort($fixersPhpDocIssues);
  513. foreach ($fixersPhpDocIssues as $fixerName => $issue) {
  514. $message .= sprintf("\n--------------------------------------------------\n%s\n%s", $fixerName, $issue);
  515. }
  516. static::fail($message);
  517. }
  518. }
  519. /**
  520. * @return string
  521. */
  522. private function generateIntegrationTestName(FixerInterface $first, FixerInterface $second)
  523. {
  524. return "{$first->getName()},{$second->getName()}.test";
  525. }
  526. /**
  527. * @return string
  528. */
  529. private function getIntegrationPriorityDirectory()
  530. {
  531. return __DIR__.'/../Fixtures/Integration/priority/';
  532. }
  533. }