PhpUnitMockShortWillReturnFixerTest.php 9.4 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324
  1. <?php
  2. declare(strict_types=1);
  3. /*
  4. * This file is part of PHP CS Fixer.
  5. *
  6. * (c) Fabien Potencier <fabien@symfony.com>
  7. * Dariusz Rumiński <dariusz.ruminski@gmail.com>
  8. *
  9. * This source file is subject to the MIT license that is bundled
  10. * with this source code in the file LICENSE.
  11. */
  12. namespace PhpCsFixer\Tests\Fixer\PhpUnit;
  13. use PhpCsFixer\Tests\Test\AbstractFixerTestCase;
  14. /**
  15. * @author Michał Adamski <michal.adamski@gmail.com>
  16. *
  17. * @internal
  18. *
  19. * @covers \PhpCsFixer\Fixer\PhpUnit\PhpUnitMockShortWillReturnFixer
  20. */
  21. final class PhpUnitMockShortWillReturnFixerTest extends AbstractFixerTestCase
  22. {
  23. /**
  24. * @dataProvider provideFixCases
  25. */
  26. public function testFix(string $expected, ?string $input = null): void
  27. {
  28. $this->doTest($expected, $input);
  29. }
  30. public static function provideFixCases(): iterable
  31. {
  32. yield 'do not fix' => [
  33. '<?php
  34. class FooTest extends TestCase {
  35. public function testFoo() {
  36. $someMock->method("someMethod")->will;
  37. $someMock->method("someMethod")->will("Smith");
  38. $someMock->method("someMethod")->will($this->returnSelf);
  39. $someMock->method("someMethod")->will($this->doSomething(7));
  40. }
  41. }',
  42. ];
  43. yield 'will return simple scenarios' => [
  44. '<?php
  45. class FooTest extends TestCase {
  46. public function testFoo() {
  47. $someMock->method("someMethod")->willReturn(10);
  48. $someMock->method("someMethod")->willReturn(20);
  49. $someMock->method("someMethod")->willReturn(30);
  50. $someMock->method("someMethod")->willReturn(40);
  51. $someMock->method("someMethod")->willReturn(50);
  52. $someMock->method("someMethod")->willReturn(60);
  53. $someMock->method("someMethod")->willReturn(-10);
  54. $someMock->method("someMethod")->willReturn(10.10);
  55. $someMock->method("someMethod")->willReturn(-10.10);
  56. $someMock->method("someMethod")->willReturn("myValue");
  57. $someMock->method("someMethod")->willReturn($myValue);
  58. $testMock->method("test_method")->willReturn(DEFAULT_VALUE);
  59. $testMock->method("test_method")->willReturn(self::DEFAULT_VALUE);
  60. $someMock->method("someMethod")->willReturn([]);
  61. $someMock->method("someMethod")->willReturn([[]]);
  62. $someMock->method("someMethod")->willReturn(array());
  63. $someMock->method("someMethod")->willReturn(new stdClass());
  64. $someMock->method("someMethod")->willReturn(new \DateTime());
  65. $someMock->method("someMethod")->willReturnSelf();
  66. $someMock->method("someMethod")->willReturnArgument(2);
  67. $someMock->method("someMethod")->willReturnCallback("str_rot13");
  68. $someMock->method("someMethod")->willReturnMap(["a", "b", "c", "d"]);
  69. $someMock->method("someMethod")->willReturn(1);
  70. $someMock->method("someMethod")->willReturn(2);
  71. }
  72. }',
  73. '<?php
  74. class FooTest extends TestCase {
  75. public function testFoo() {
  76. $someMock->method("someMethod")->will($this->returnValue(10));
  77. $someMock->method("someMethod")->will($THIS->returnValue(20));
  78. $someMock->method("someMethod")->will(self::returnValue(30));
  79. $someMock->method("someMethod")->will(Self::returnValue(40));
  80. $someMock->method("someMethod")->will(static::returnValue(50));
  81. $someMock->method("someMethod")->will(STATIC::returnValue(60));
  82. $someMock->method("someMethod")->will($this->returnValue(-10));
  83. $someMock->method("someMethod")->will($this->returnValue(10.10));
  84. $someMock->method("someMethod")->will($this->returnValue(-10.10));
  85. $someMock->method("someMethod")->will($this->returnValue("myValue"));
  86. $someMock->method("someMethod")->will($this->returnValue($myValue));
  87. $testMock->method("test_method")->will($this->returnValue(DEFAULT_VALUE));
  88. $testMock->method("test_method")->will($this->returnValue(self::DEFAULT_VALUE));
  89. $someMock->method("someMethod")->will($this->returnValue([]));
  90. $someMock->method("someMethod")->will($this->returnValue([[]]));
  91. $someMock->method("someMethod")->will($this->returnValue(array()));
  92. $someMock->method("someMethod")->will($this->returnValue(new stdClass()));
  93. $someMock->method("someMethod")->will($this->returnValue(new \DateTime()));
  94. $someMock->method("someMethod")->will($this->returnSelf());
  95. $someMock->method("someMethod")->will($this->returnArgument(2));
  96. $someMock->method("someMethod")->will($this->returnCallback("str_rot13"));
  97. $someMock->method("someMethod")->will($this->returnValueMap(["a", "b", "c", "d"]));
  98. $someMock->method("someMethod")->WILL($this->returnValue(1));
  99. $someMock->method("someMethod")->will($this->ReturnVALUE(2));
  100. }
  101. }',
  102. ];
  103. yield 'will return with multi lines and messy indents' => [
  104. '<?php
  105. class FooTest extends TestCase {
  106. public function testFoo() {
  107. $someMock
  108. ->method("someMethod")
  109. ->willReturn(
  110. 10
  111. );
  112. }
  113. }',
  114. '<?php
  115. class FooTest extends TestCase {
  116. public function testFoo() {
  117. $someMock
  118. ->method("someMethod")
  119. ->will(
  120. $this->returnValue(10)
  121. );
  122. }
  123. }',
  124. ];
  125. yield 'will return with multi lines, messy indents and comments inside' => [
  126. '<?php
  127. class FooTest extends TestCase {
  128. public function testFoo() {
  129. $someMock
  130. ->method("someMethod")
  131. ->willReturn(
  132. // foo
  133. 10
  134. // bar
  135. );
  136. }
  137. }',
  138. '<?php
  139. class FooTest extends TestCase {
  140. public function testFoo() {
  141. $someMock
  142. ->method("someMethod")
  143. ->will(
  144. // foo
  145. $this->returnValue(10)
  146. // bar
  147. );
  148. }
  149. }',
  150. ];
  151. yield 'will return with block comments in weird places' => [
  152. '<?php
  153. class FooTest extends TestCase {
  154. public function testFoo() {
  155. $someMock->method("someMethod")->/* a */willReturn/* b */(/* c */ 10 /* d */);
  156. }
  157. }',
  158. '<?php
  159. class FooTest extends TestCase {
  160. public function testFoo() {
  161. $someMock->method("someMethod")->/* a */will/* b */(/* c */ $this->returnValue(10) /* d */);
  162. }
  163. }',
  164. ];
  165. yield 'will return with comments persisted not touched even if put in unexpected places' => [
  166. '<?php
  167. class FooTest extends TestCase {
  168. public function testFoo() {
  169. $someMock->method("someMethod")// a
  170. ->/* b */willReturn/* c */(/* d */ /** e */
  171. // f
  172. '.'
  173. // g
  174. '.'
  175. /* h */
  176. 10 /* i */);
  177. }
  178. }',
  179. '<?php
  180. class FooTest extends TestCase {
  181. public function testFoo() {
  182. $someMock->method("someMethod")// a
  183. ->/* b */will/* c */(/* d */ $this/** e */
  184. -> // f
  185. returnValue
  186. // g
  187. (
  188. /* h */
  189. 10) /* i */);
  190. }
  191. }',
  192. ];
  193. yield 'will return with multi lines, messy indents and comments in weird places' => [
  194. '<?php
  195. class FooTest extends TestCase {
  196. public function testFoo() {
  197. $someMock
  198. ->method(
  199. "someMethod"
  200. )
  201. ->
  202. /* a */
  203. willReturn
  204. /*
  205. b
  206. c
  207. d
  208. e
  209. */ (
  210. // f g h i
  211. /* j */ '.'
  212. '.'
  213. 10
  214. /* k */
  215. /* l */);
  216. }
  217. }',
  218. '<?php
  219. class FooTest extends TestCase {
  220. public function testFoo() {
  221. $someMock
  222. ->method(
  223. "someMethod"
  224. )
  225. ->
  226. /* a */
  227. will
  228. /*
  229. b
  230. c
  231. d
  232. e
  233. */ (
  234. // f g h i
  235. /* j */ $this
  236. ->returnValue
  237. (10)
  238. /* k */
  239. /* l */);
  240. }
  241. }',
  242. ];
  243. yield [
  244. '<?php
  245. class FooTest extends TestCase {
  246. public function testFoo() {
  247. $someMock->method("someMethod")->willReturn( 10 , );
  248. }
  249. }',
  250. '<?php
  251. class FooTest extends TestCase {
  252. public function testFoo() {
  253. $someMock->method("someMethod")->will($this->returnValue( 10 , ));
  254. }
  255. }',
  256. ];
  257. yield 'with trailing commas' => [
  258. '<?php
  259. class FooTest extends TestCase {
  260. public function testFoo() {
  261. $someMock->method("someMethod")->willReturn( 10 , );
  262. }
  263. }',
  264. '<?php
  265. class FooTest extends TestCase {
  266. public function testFoo() {
  267. $someMock->method("someMethod")->will($this->returnValue( 10 , ) , );
  268. }
  269. }',
  270. ];
  271. }
  272. /**
  273. * @requires PHP 8.0
  274. */
  275. public function testFix80(): void
  276. {
  277. $this->doTest(
  278. '<?php
  279. class FooTest extends TestCase {
  280. public function testFoo() {
  281. $someMock?->method("someMethod")?->willReturn(10);
  282. }
  283. }',
  284. '<?php
  285. class FooTest extends TestCase {
  286. public function testFoo() {
  287. $someMock?->method("someMethod")?->will($this?->returnValue(10));
  288. }
  289. }'
  290. );
  291. }
  292. /**
  293. * @requires PHP 8.1
  294. */
  295. public function testFix81(): void
  296. {
  297. $this->doTest(
  298. '<?php
  299. class FooTest extends TestCase {
  300. public function testFoo() {
  301. $a = $someMock?->method("someMethod")->will($this?->returnValue(...));
  302. }
  303. }'
  304. );
  305. }
  306. }