NullableTypeDeclarationFixerTest.php 6.1 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278
  1. <?php
  2. declare(strict_types=1);
  3. /*
  4. * This file is part of PHP CS Fixer.
  5. *
  6. * (c) Fabien Potencier <fabien@symfony.com>
  7. * Dariusz Rumiński <dariusz.ruminski@gmail.com>
  8. *
  9. * This source file is subject to the MIT license that is bundled
  10. * with this source code in the file LICENSE.
  11. */
  12. namespace PhpCsFixer\Tests\Fixer\LanguageConstruct;
  13. use PhpCsFixer\Tests\Test\AbstractFixerTestCase;
  14. /**
  15. * @author John Paul E. Balandan, CPA <paulbalandan@gmail.com>
  16. *
  17. * @internal
  18. *
  19. * @covers \PhpCsFixer\Fixer\LanguageConstruct\NullableTypeDeclarationFixer
  20. */
  21. final class NullableTypeDeclarationFixerTest extends AbstractFixerTestCase
  22. {
  23. /**
  24. * @dataProvider provideDefaultFixCases
  25. *
  26. * @requires PHP 8.0
  27. */
  28. public function testDefaultFix(string $expected, ?string $input = null): void
  29. {
  30. $this->doTest($expected, $input);
  31. }
  32. /**
  33. * @return iterable<string, array<int, null|string>>
  34. */
  35. public static function provideDefaultFixCases(): iterable
  36. {
  37. yield 'scalar with null' => [
  38. "<?php\nfunction foo(?int \$bar): void {}\n",
  39. "<?php\nfunction foo(int|null \$bar): void {}\n",
  40. ];
  41. yield 'class with null' => [
  42. "<?php\nfunction bar(?\\stdClass \$crate): int {}\n",
  43. "<?php\nfunction bar(null | \\stdClass \$crate): int {}\n",
  44. ];
  45. yield 'static null' => [
  46. '<?php
  47. class Foo
  48. {
  49. public function bar(?array $config = null): ?static {}
  50. }
  51. ',
  52. '<?php
  53. class Foo
  54. {
  55. public function bar(null|array $config = null): null|static {}
  56. }
  57. ',
  58. ];
  59. yield 'multiple parameters' => [
  60. "<?php\nfunction baz(?Foo \$foo, int|string \$value, ?array \$config = null): ?int {}\n",
  61. "<?php\nfunction baz(null|Foo \$foo, int|string \$value, null|array \$config = null): int|null {}\n",
  62. ];
  63. yield 'class properties' => [
  64. '<?php
  65. class Dto
  66. {
  67. public ?string $name;
  68. public ?array $parameters;
  69. public ?int $count;
  70. public ?Closure $callable;
  71. }
  72. ',
  73. '<?php
  74. class Dto
  75. {
  76. public null|string $name;
  77. public array|null $parameters;
  78. public int|null $count;
  79. public null|Closure $callable;
  80. }
  81. ',
  82. ];
  83. yield 'skips more than two atomic types' => [
  84. "<?php\nstatic fn (int|null|string \$bar): bool => true;\n",
  85. ];
  86. yield 'skips already fixed' => [
  87. "<?php\n\$bar = function (?string \$input): int {};\n",
  88. ];
  89. }
  90. /**
  91. * @dataProvider provideFixWithUnionSyntaxCases
  92. *
  93. * @requires PHP 8.0
  94. */
  95. public function testFixWithUnionSyntax(string $expected, ?string $input = null): void
  96. {
  97. $this->fixer->configure(['syntax' => 'union']);
  98. $this->doTest($expected, $input);
  99. }
  100. /**
  101. * @return iterable<string, array<int, null|string>>
  102. */
  103. public static function provideFixWithUnionSyntaxCases(): iterable
  104. {
  105. yield 'scalar with null' => [
  106. "<?php\nfunction foo(null|int \$bar): void {}\n",
  107. "<?php\nfunction foo(?int \$bar): void {}\n",
  108. ];
  109. yield 'class with null' => [
  110. "<?php\nfunction bar(null|\\stdClass \$crate): int {}\n",
  111. "<?php\nfunction bar(?\\stdClass \$crate): int {}\n",
  112. ];
  113. yield 'static null' => [
  114. '<?php
  115. class Foo
  116. {
  117. public function bar(null|array $config = null): null|static {}
  118. }
  119. ',
  120. '<?php
  121. class Foo
  122. {
  123. public function bar(?array $config = null): ?static {}
  124. }
  125. ',
  126. ];
  127. yield 'multiple parameters' => [
  128. "<?php\nfunction baz(null|Foo \$foo, int|string \$value, null|array \$config = null): null|int {}\n",
  129. "<?php\nfunction baz(?Foo \$foo, int|string \$value, ?array \$config = null): ?int {}\n",
  130. ];
  131. yield 'class properties' => [
  132. '<?php
  133. class Dto
  134. {
  135. public null|\Closure $callable;
  136. public null|string $name;
  137. public null|array $parameters;
  138. public null|int $count;
  139. }
  140. ',
  141. '<?php
  142. class Dto
  143. {
  144. public ?\Closure $callable;
  145. public ?string $name;
  146. public ?array $parameters;
  147. public ?int $count;
  148. }
  149. ',
  150. ];
  151. yield 'space after ?' => [
  152. '<?php
  153. class Foo
  154. {
  155. private null|int $x;
  156. public static function from(null|int $x): null|static {}
  157. }
  158. ',
  159. '<?php
  160. class Foo
  161. {
  162. private ? int $x;
  163. public static function from(? int $x): ? static {}
  164. }
  165. ',
  166. ];
  167. yield 'skips already fixed' => [
  168. "<?php\n\$bar = function (null | string \$input): int {};\n",
  169. ];
  170. }
  171. /**
  172. * @param null|array<string, string> $config
  173. *
  174. * @dataProvider provideFixPhp81Cases
  175. *
  176. * @requires PHP 8.1
  177. */
  178. public function testFixPhp81(string $expected, ?string $input = null, ?array $config = null): void
  179. {
  180. if (null !== $config) {
  181. $this->fixer->configure($config);
  182. }
  183. $this->doTest($expected, $input);
  184. }
  185. /**
  186. * @return iterable<string, array<int, null|array<string, string>|string>>
  187. */
  188. public static function provideFixPhp81Cases(): iterable
  189. {
  190. yield 'readonly property' => [
  191. '<?php
  192. class Qux
  193. {
  194. public readonly ?int $baz;
  195. }
  196. ',
  197. '<?php
  198. class Qux
  199. {
  200. public readonly int|null $baz;
  201. }
  202. ',
  203. ];
  204. yield 'readonly property with union syntax expected' => [
  205. '<?php
  206. class Qux
  207. {
  208. public readonly null|int $baz;
  209. }
  210. ',
  211. '<?php
  212. class Qux
  213. {
  214. public readonly ?int $baz;
  215. }
  216. ',
  217. ['syntax' => 'union'],
  218. ];
  219. }
  220. /**
  221. * @param null|array<string, string> $config
  222. *
  223. * @dataProvider provideFixPhp82Cases
  224. *
  225. * @requires PHP 8.2
  226. */
  227. public function testFixPhp82(string $expected, ?string $input = null, ?array $config = null): void
  228. {
  229. if (null !== $config) {
  230. $this->fixer->configure($config);
  231. }
  232. $this->doTest($expected, $input);
  233. }
  234. /**
  235. * @return iterable<string, array<int, null|array<string, string>|string>>
  236. */
  237. public static function provideFixPhp82Cases(): iterable
  238. {
  239. yield 'skips DNF types' => [
  240. '<?php
  241. class Infinite
  242. {
  243. private static (A&B)|null $dft;
  244. }
  245. ',
  246. ];
  247. }
  248. }