OrderedClassElementsFixerTest.php 54 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543154415451546154715481549155015511552155315541555155615571558155915601561156215631564156515661567156815691570157115721573157415751576157715781579158015811582158315841585158615871588158915901591159215931594159515961597159815991600160116021603160416051606160716081609161016111612161316141615161616171618161916201621162216231624162516261627162816291630163116321633163416351636163716381639164016411642164316441645164616471648164916501651165216531654165516561657165816591660166116621663166416651666166716681669167016711672167316741675167616771678167916801681
  1. <?php
  2. declare(strict_types=1);
  3. /*
  4. * This file is part of PHP CS Fixer.
  5. *
  6. * (c) Fabien Potencier <fabien@symfony.com>
  7. * Dariusz Rumiński <dariusz.ruminski@gmail.com>
  8. *
  9. * This source file is subject to the MIT license that is bundled
  10. * with this source code in the file LICENSE.
  11. */
  12. namespace PhpCsFixer\Tests\Fixer\ClassNotation;
  13. use PhpCsFixer\ConfigurationException\InvalidFixerConfigurationException;
  14. use PhpCsFixer\Fixer\ClassNotation\OrderedClassElementsFixer;
  15. use PhpCsFixer\Tests\Test\AbstractFixerTestCase;
  16. /**
  17. * @author Gregor Harlan <gharlan@web.de>
  18. *
  19. * @internal
  20. *
  21. * @covers \PhpCsFixer\Fixer\ClassNotation\OrderedClassElementsFixer
  22. */
  23. final class OrderedClassElementsFixerTest extends AbstractFixerTestCase
  24. {
  25. /**
  26. * @dataProvider provideFixCases
  27. */
  28. public function testFix(string $expected, ?string $input = null): void
  29. {
  30. $this->doTest($expected, $input);
  31. }
  32. public static function provideFixCases(): iterable
  33. {
  34. yield [
  35. <<<'EOT'
  36. <?php
  37. class Foo {}
  38. class Bar
  39. {
  40. }
  41. EOT
  42. ];
  43. yield [
  44. <<<'EOT'
  45. <?php
  46. class Foo { const C1 = 1; protected $abc = 'abc'; public function baz($y, $z) {} private function bar1($x) { return 1; } }
  47. EOT
  48. , <<<'EOT'
  49. <?php
  50. class Foo { private function bar1($x) { return 1; } protected $abc = 'abc'; const C1 = 1; public function baz($y, $z) {} }
  51. EOT
  52. ];
  53. yield [
  54. <<<'EOT'
  55. <?php
  56. interface FooInterface
  57. {
  58. /** const 1 */
  59. const CONST1 = 'const1';
  60. // foo
  61. // const 2
  62. const CONST2 = 'const2';
  63. public function xyz($x, $y, $z); // comment
  64. /**
  65. * @param array $a
  66. *
  67. * @return string
  68. */
  69. function abc(array &$a = null);
  70. public function def();
  71. }
  72. EOT
  73. , <<<'EOT'
  74. <?php
  75. interface FooInterface
  76. {
  77. public function xyz($x, $y, $z); // comment
  78. /** const 1 */
  79. const CONST1 = 'const1';
  80. /**
  81. * @param array $a
  82. *
  83. * @return string
  84. */
  85. function abc(array &$a = null);
  86. // foo
  87. // const 2
  88. const CONST2 = 'const2';
  89. public function def();
  90. }
  91. EOT
  92. ];
  93. yield [
  94. <<<'EOT'
  95. <?php
  96. abstract class Foo extends FooParent implements FooInterface1, FooInterface2
  97. {
  98. use Bar;
  99. use Baz {
  100. abc as private;
  101. }
  102. const C1 = 1;
  103. /* comment for C2 */
  104. const C2 = 2;
  105. public $fooPublic;
  106. // comment 3
  107. protected $fooProtected = array(1, 2);
  108. // comment 1
  109. private $fooPrivate;
  110. protected function __construct()
  111. {
  112. }
  113. public function __destruct() {}
  114. public function __clone() {}
  115. public static function setUpBeforeClass() {}
  116. public static function tearDownAfterclass() {
  117. } /* multiline
  118. comment */
  119. protected function setUp() {}
  120. protected function assertPreConditions() {}
  121. protected function assertPostConditions() {}
  122. protected function tearDown() {}
  123. abstract public function foo1($a, $b = 1);
  124. // foo2
  125. function foo2()
  126. {
  127. return $this->foo1(1);
  128. }
  129. public static function foo3(self $foo)
  130. {
  131. return $foo->foo2();
  132. } /* comment 1 */ /* comment 2 */
  133. // comment
  134. /**
  135. * Docblock
  136. */
  137. protected function foo4(\ArrayObject $object, array $array, $a = null)
  138. {
  139. bar();
  140. if (!$a) {
  141. $a = function ($x) {
  142. var_dump($x);
  143. };
  144. }
  145. }
  146. private function foo5()
  147. {
  148. } // end foo5
  149. }
  150. EOT
  151. , <<<'EOT'
  152. <?php
  153. abstract class Foo extends FooParent implements FooInterface1, FooInterface2
  154. {
  155. // comment 1
  156. private $fooPrivate;
  157. abstract public function foo1($a, $b = 1);
  158. protected function setUp() {}
  159. protected function tearDown() {}
  160. public function __clone() {}
  161. const C1 = 1;
  162. // foo2
  163. function foo2()
  164. {
  165. return $this->foo1(1);
  166. }
  167. public static function setUpBeforeClass() {}
  168. public function __destruct() {}
  169. use Bar;
  170. public static function foo3(self $foo)
  171. {
  172. return $foo->foo2();
  173. } /* comment 1 */ /* comment 2 */
  174. // comment 3
  175. protected $fooProtected = array(1, 2);
  176. public $fooPublic;
  177. /* comment for C2 */
  178. const C2 = 2;
  179. public static function tearDownAfterclass() {
  180. } /* multiline
  181. comment */
  182. protected function assertPostConditions() {}
  183. use Baz {
  184. abc as private;
  185. }
  186. protected function assertPreConditions() {}
  187. private function foo5()
  188. {
  189. } // end foo5
  190. protected function __construct()
  191. {
  192. }
  193. // comment
  194. /**
  195. * Docblock
  196. */
  197. protected function foo4(\ArrayObject $object, array $array, $a = null)
  198. {
  199. bar();
  200. if (!$a) {
  201. $a = function ($x) {
  202. var_dump($x);
  203. };
  204. }
  205. }
  206. }
  207. EOT
  208. ];
  209. yield [
  210. <<<'EOT'
  211. <?php
  212. class Foo
  213. {
  214. const C = 'C';
  215. public function abc() {}
  216. protected function xyz() {}
  217. }
  218. class Bar
  219. {
  220. const C = 1;
  221. public function foo($a) { return 1; }
  222. public function baz() {}
  223. }
  224. EOT
  225. , <<<'EOT'
  226. <?php
  227. class Foo
  228. {
  229. protected function xyz() {}
  230. const C = 'C';
  231. public function abc() {}
  232. }
  233. class Bar
  234. {
  235. public function foo($a) { return 1; }
  236. const C = 1;
  237. public function baz() {}
  238. }
  239. EOT
  240. ];
  241. yield [
  242. <<<'EOT'
  243. <?php
  244. trait FooTrait
  245. {
  246. use BarTrait;
  247. use BazTrait;
  248. protected function abc() {
  249. }
  250. }
  251. EOT
  252. , <<<'EOT'
  253. <?php
  254. trait FooTrait
  255. {
  256. protected function abc() {
  257. }
  258. use BarTrait;
  259. use BazTrait;
  260. }
  261. EOT
  262. ];
  263. yield [
  264. <<<'EOT'
  265. <?php
  266. /**
  267. * @see #4086
  268. */
  269. class ComplexStringVariableAndUseTrait
  270. {
  271. use FooTrait;
  272. public function sayHello($name)
  273. {
  274. echo "Hello, {$name}!";
  275. }
  276. }
  277. EOT
  278. ,
  279. <<<'EOT'
  280. <?php
  281. /**
  282. * @see #4086
  283. */
  284. class ComplexStringVariableAndUseTrait
  285. {
  286. public function sayHello($name)
  287. {
  288. echo "Hello, {$name}!";
  289. }
  290. use FooTrait;
  291. }
  292. EOT
  293. ];
  294. }
  295. /**
  296. * @param array<string, mixed> $configuration
  297. *
  298. * @dataProvider provideFixWithConfigurationCases
  299. */
  300. public function testFixWithConfiguration(array $configuration, string $expected, string $input): void
  301. {
  302. $this->fixer->configure(['order' => $configuration]);
  303. $this->doTest($expected, $input);
  304. }
  305. public static function provideFixWithConfigurationCases(): iterable
  306. {
  307. yield [
  308. ['use_trait', 'constant', 'property', 'construct', 'method', 'destruct'],
  309. <<<'EOT'
  310. <?php
  311. class Foo
  312. {
  313. use BarTrait;
  314. use BazTrait;
  315. const C1 = 1;
  316. const C2 = 2;
  317. protected static $protStatProp;
  318. public static $pubStatProp1;
  319. public $pubProp1;
  320. protected $protProp;
  321. var $pubProp2;
  322. private static $privStatProp;
  323. private $privProp;
  324. public static $pubStatProp2;
  325. public $pubProp3;
  326. protected function __construct() {}
  327. private static function privStatFunc() {}
  328. public function pubFunc1() {}
  329. public function __toString() {}
  330. protected function protFunc() {}
  331. function pubFunc2() {}
  332. public static function pubStatFunc1() {}
  333. public function pubFunc3() {}
  334. static function pubStatFunc2() {}
  335. private function privFunc() {}
  336. public static function pubStatFunc3() {}
  337. protected static function protStatFunc() {}
  338. public function __destruct() {}
  339. }
  340. EOT
  341. ,
  342. <<<'EOT'
  343. <?php
  344. class Foo
  345. {
  346. private static function privStatFunc() {}
  347. protected static $protStatProp;
  348. public static $pubStatProp1;
  349. public function pubFunc1() {}
  350. use BarTrait;
  351. public $pubProp1;
  352. public function __toString() {}
  353. protected function protFunc() {}
  354. protected $protProp;
  355. function pubFunc2() {}
  356. public function __destruct() {}
  357. var $pubProp2;
  358. private static $privStatProp;
  359. use BazTrait;
  360. public static function pubStatFunc1() {}
  361. public function pubFunc3() {}
  362. private $privProp;
  363. const C1 = 1;
  364. static function pubStatFunc2() {}
  365. private function privFunc() {}
  366. public static $pubStatProp2;
  367. protected function __construct() {}
  368. const C2 = 2;
  369. public static function pubStatFunc3() {}
  370. public $pubProp3;
  371. protected static function protStatFunc() {}
  372. }
  373. EOT
  374. ,
  375. ];
  376. yield [
  377. ['public', 'protected', 'private'],
  378. <<<'EOT'
  379. <?php
  380. class Foo
  381. {
  382. public static $pubStatProp1;
  383. public function pubFunc1() {}
  384. public $pubProp1;
  385. public function __toString() {}
  386. function pubFunc2() {}
  387. public function __destruct() {}
  388. var $pubProp2;
  389. public static function pubStatFunc1() {}
  390. public function pubFunc3() {}
  391. const C1 = 1;
  392. static function pubStatFunc2() {}
  393. public static $pubStatProp2;
  394. const C2 = 2;
  395. public static function pubStatFunc3() {}
  396. public $pubProp3;
  397. protected static $protStatProp;
  398. protected function protFunc() {}
  399. protected $protProp;
  400. protected function __construct() {}
  401. protected static function protStatFunc() {}
  402. private static function privStatFunc() {}
  403. private static $privStatProp;
  404. private $privProp;
  405. private function privFunc() {}
  406. use BarTrait;
  407. use BazTrait;
  408. }
  409. EOT
  410. ,
  411. <<<'EOT'
  412. <?php
  413. class Foo
  414. {
  415. private static function privStatFunc() {}
  416. protected static $protStatProp;
  417. public static $pubStatProp1;
  418. public function pubFunc1() {}
  419. use BarTrait;
  420. public $pubProp1;
  421. public function __toString() {}
  422. protected function protFunc() {}
  423. protected $protProp;
  424. function pubFunc2() {}
  425. public function __destruct() {}
  426. var $pubProp2;
  427. private static $privStatProp;
  428. use BazTrait;
  429. public static function pubStatFunc1() {}
  430. public function pubFunc3() {}
  431. private $privProp;
  432. const C1 = 1;
  433. static function pubStatFunc2() {}
  434. private function privFunc() {}
  435. public static $pubStatProp2;
  436. protected function __construct() {}
  437. const C2 = 2;
  438. public static function pubStatFunc3() {}
  439. public $pubProp3;
  440. protected static function protStatFunc() {}
  441. }
  442. EOT
  443. ,
  444. ];
  445. yield [
  446. [
  447. 'use_trait',
  448. 'constant',
  449. 'property_public_static',
  450. 'property_protected_static',
  451. 'property_private_static',
  452. 'property_public',
  453. 'property_protected',
  454. 'property_private',
  455. 'construct',
  456. 'destruct',
  457. 'magic',
  458. 'method_public_static',
  459. 'method_protected_static',
  460. 'method_private_static',
  461. 'method_public',
  462. 'method_protected',
  463. 'method_private',
  464. ],
  465. <<<'EOT'
  466. <?php
  467. class Foo
  468. {
  469. use BarTrait;
  470. use BazTrait;
  471. const C1 = 1;
  472. const C2 = 2;
  473. public static $pubStatProp1;
  474. public static $pubStatProp2;
  475. protected static $protStatProp;
  476. private static $privStatProp;
  477. public $pubProp1;
  478. var $pubProp2;
  479. public $pubProp3;
  480. protected $protProp;
  481. private $privProp;
  482. protected function __construct() {}
  483. public function __destruct() {}
  484. public function __toString() {}
  485. public static function pubStatFunc1() {}
  486. static function pubStatFunc2() {}
  487. public static function pubStatFunc3() {}
  488. protected static function protStatFunc() {}
  489. private static function privStatFunc() {}
  490. public function pubFunc1() {}
  491. function pubFunc2() {}
  492. public function pubFunc3() {}
  493. protected function protFunc() {}
  494. private function privFunc() {}
  495. }
  496. EOT
  497. ,
  498. <<<'EOT'
  499. <?php
  500. class Foo
  501. {
  502. private static function privStatFunc() {}
  503. protected static $protStatProp;
  504. public static $pubStatProp1;
  505. public function pubFunc1() {}
  506. use BarTrait;
  507. public $pubProp1;
  508. public function __toString() {}
  509. protected function protFunc() {}
  510. protected $protProp;
  511. function pubFunc2() {}
  512. public function __destruct() {}
  513. var $pubProp2;
  514. private static $privStatProp;
  515. use BazTrait;
  516. public static function pubStatFunc1() {}
  517. public function pubFunc3() {}
  518. private $privProp;
  519. const C1 = 1;
  520. static function pubStatFunc2() {}
  521. private function privFunc() {}
  522. public static $pubStatProp2;
  523. protected function __construct() {}
  524. const C2 = 2;
  525. public static function pubStatFunc3() {}
  526. public $pubProp3;
  527. protected static function protStatFunc() {}
  528. }
  529. EOT
  530. ,
  531. ];
  532. yield [
  533. ['use_trait', 'constant', 'property', 'construct', 'method', 'destruct'],
  534. <<<'EOT'
  535. <?php
  536. abstract class Foo
  537. {
  538. use BarTrait;
  539. use BazTrait;
  540. const C1 = 1;
  541. const C2 = 2;
  542. protected static $protStatProp;
  543. public static $pubStatProp1;
  544. public $pubProp1;
  545. protected $protProp;
  546. var $pubProp2;
  547. private static $privStatProp;
  548. private $privProp;
  549. public static $pubStatProp2;
  550. public $pubProp3;
  551. protected function __construct() {}
  552. abstract public function absPubFunc();
  553. private static function privStatFunc() {}
  554. public function pubFunc1() {}
  555. abstract protected function absProtFunc();
  556. public function __toString() {}
  557. protected function protFunc() {}
  558. function pubFunc2() {}
  559. abstract protected static function absProtStatFunc();
  560. public static function pubStatFunc1() {}
  561. public function pubFunc3() {}
  562. static function pubStatFunc2() {}
  563. private function privFunc() {}
  564. abstract public static function absPubStatFunc();
  565. public static function pubStatFunc3() {}
  566. protected static function protStatFunc() {}
  567. public function __destruct() {}
  568. }
  569. EOT
  570. ,
  571. <<<'EOT'
  572. <?php
  573. abstract class Foo
  574. {
  575. abstract public function absPubFunc();
  576. private static function privStatFunc() {}
  577. protected static $protStatProp;
  578. public static $pubStatProp1;
  579. public function pubFunc1() {}
  580. abstract protected function absProtFunc();
  581. use BarTrait;
  582. public $pubProp1;
  583. public function __toString() {}
  584. protected function protFunc() {}
  585. protected $protProp;
  586. function pubFunc2() {}
  587. abstract protected static function absProtStatFunc();
  588. public function __destruct() {}
  589. var $pubProp2;
  590. private static $privStatProp;
  591. use BazTrait;
  592. public static function pubStatFunc1() {}
  593. public function pubFunc3() {}
  594. private $privProp;
  595. const C1 = 1;
  596. static function pubStatFunc2() {}
  597. private function privFunc() {}
  598. public static $pubStatProp2;
  599. abstract public static function absPubStatFunc();
  600. protected function __construct() {}
  601. const C2 = 2;
  602. public static function pubStatFunc3() {}
  603. public $pubProp3;
  604. protected static function protStatFunc() {}
  605. }
  606. EOT
  607. ,
  608. ];
  609. yield [
  610. ['public', 'protected', 'private'],
  611. <<<'EOT'
  612. <?php
  613. abstract class Foo
  614. {
  615. abstract public function absPubFunc();
  616. public static $pubStatProp1;
  617. public function pubFunc1() {}
  618. public $pubProp1;
  619. public function __toString() {}
  620. function pubFunc2() {}
  621. public function __destruct() {}
  622. var $pubProp2;
  623. public static function pubStatFunc1() {}
  624. public function pubFunc3() {}
  625. const C1 = 1;
  626. static function pubStatFunc2() {}
  627. public static $pubStatProp2;
  628. abstract public static function absPubStatFunc();
  629. const C2 = 2;
  630. public static function pubStatFunc3() {}
  631. public $pubProp3;
  632. protected static $protStatProp;
  633. abstract protected function absProtFunc();
  634. protected function protFunc() {}
  635. protected $protProp;
  636. abstract protected static function absProtStatFunc();
  637. protected function __construct() {}
  638. protected static function protStatFunc() {}
  639. private static function privStatFunc() {}
  640. private static $privStatProp;
  641. private $privProp;
  642. private function privFunc() {}
  643. use BarTrait;
  644. use BazTrait;
  645. }
  646. EOT
  647. ,
  648. <<<'EOT'
  649. <?php
  650. abstract class Foo
  651. {
  652. abstract public function absPubFunc();
  653. private static function privStatFunc() {}
  654. protected static $protStatProp;
  655. public static $pubStatProp1;
  656. public function pubFunc1() {}
  657. abstract protected function absProtFunc();
  658. use BarTrait;
  659. public $pubProp1;
  660. public function __toString() {}
  661. protected function protFunc() {}
  662. protected $protProp;
  663. function pubFunc2() {}
  664. abstract protected static function absProtStatFunc();
  665. public function __destruct() {}
  666. var $pubProp2;
  667. private static $privStatProp;
  668. use BazTrait;
  669. public static function pubStatFunc1() {}
  670. public function pubFunc3() {}
  671. private $privProp;
  672. const C1 = 1;
  673. static function pubStatFunc2() {}
  674. private function privFunc() {}
  675. public static $pubStatProp2;
  676. abstract public static function absPubStatFunc();
  677. protected function __construct() {}
  678. const C2 = 2;
  679. public static function pubStatFunc3() {}
  680. public $pubProp3;
  681. protected static function protStatFunc() {}
  682. }
  683. EOT
  684. ,
  685. ];
  686. yield [
  687. [
  688. 'use_trait',
  689. 'constant',
  690. 'property_public_static',
  691. 'property_protected_static',
  692. 'property_private_static',
  693. 'property_public',
  694. 'property_protected',
  695. 'property_private',
  696. 'construct',
  697. 'destruct',
  698. 'magic',
  699. 'method_public_static',
  700. 'method_public_abstract_static',
  701. 'method_protected_static',
  702. 'method_protected_abstract_static',
  703. 'method_private_static',
  704. 'method_public',
  705. 'method_public_abstract',
  706. 'method_protected',
  707. 'method_protected_abstract',
  708. 'method_private',
  709. ],
  710. <<<'EOT'
  711. <?php
  712. abstract class Foo
  713. {
  714. use BarTrait;
  715. use BazTrait;
  716. const C1 = 1;
  717. const C2 = 2;
  718. public static $pubStatProp1;
  719. public static $pubStatProp2;
  720. protected static $protStatProp;
  721. private static $privStatProp;
  722. public $pubProp1;
  723. var $pubProp2;
  724. public $pubProp3;
  725. protected $protProp;
  726. private $privProp;
  727. protected function __construct() {}
  728. public function __destruct() {}
  729. public function __toString() {}
  730. public static function pubStatFunc1() {}
  731. static function pubStatFunc2() {}
  732. public static function pubStatFunc3() {}
  733. abstract public static function absPubStatFunc();
  734. protected static function protStatFunc() {}
  735. abstract protected static function absProtStatFunc();
  736. private static function privStatFunc() {}
  737. public function pubFunc1() {}
  738. function pubFunc2() {}
  739. public function pubFunc3() {}
  740. abstract public function absPubFunc();
  741. protected function protFunc() {}
  742. abstract protected function absProtFunc();
  743. private function privFunc() {}
  744. }
  745. EOT
  746. ,
  747. <<<'EOT'
  748. <?php
  749. abstract class Foo
  750. {
  751. abstract public function absPubFunc();
  752. private static function privStatFunc() {}
  753. protected static $protStatProp;
  754. public static $pubStatProp1;
  755. public function pubFunc1() {}
  756. abstract protected function absProtFunc();
  757. use BarTrait;
  758. public $pubProp1;
  759. public function __toString() {}
  760. protected function protFunc() {}
  761. protected $protProp;
  762. function pubFunc2() {}
  763. abstract protected static function absProtStatFunc();
  764. public function __destruct() {}
  765. var $pubProp2;
  766. private static $privStatProp;
  767. use BazTrait;
  768. public static function pubStatFunc1() {}
  769. public function pubFunc3() {}
  770. private $privProp;
  771. const C1 = 1;
  772. static function pubStatFunc2() {}
  773. private function privFunc() {}
  774. public static $pubStatProp2;
  775. abstract public static function absPubStatFunc();
  776. protected function __construct() {}
  777. const C2 = 2;
  778. public static function pubStatFunc3() {}
  779. public $pubProp3;
  780. protected static function protStatFunc() {}
  781. }
  782. EOT
  783. ,
  784. ];
  785. yield [
  786. [
  787. 'method_public',
  788. 'method_abstract',
  789. ],
  790. <<<'EOT'
  791. <?php
  792. abstract class Foo
  793. {
  794. public function test2(){}
  795. public abstract function test1();
  796. }
  797. EOT
  798. ,
  799. <<<'EOT'
  800. <?php
  801. abstract class Foo
  802. {
  803. public abstract function test1();
  804. public function test2(){}
  805. }
  806. EOT
  807. ,
  808. ];
  809. yield [
  810. [
  811. 'construct',
  812. 'method:__invoke',
  813. 'destruct',
  814. 'method_public_static',
  815. 'method:custom1',
  816. 'method_public_abstract_static',
  817. 'method_protected_static',
  818. 'method_protected_abstract_static',
  819. 'method_private_static',
  820. 'method_public',
  821. 'method:custom3',
  822. 'method_public_abstract',
  823. 'method_protected',
  824. 'method_protected_abstract',
  825. 'method_private',
  826. 'method:custom2',
  827. 'magic',
  828. ],
  829. <<<'EOT'
  830. <?php
  831. abstract class Foo
  832. {
  833. protected function __construct() {}
  834. public function __invoke() {}
  835. public function __destruct() {}
  836. public static function pubStatFunc1() {}
  837. static function pubStatFunc2() {}
  838. public static function pubStatFunc3() {}
  839. private function custom1() {}
  840. abstract public static function absPubStatFunc();
  841. protected static function protStatFunc() {}
  842. abstract protected static function absProtStatFunc();
  843. private static function privStatFunc() {}
  844. public function pubFunc1() {}
  845. function pubFunc2() {}
  846. public function pubFunc3() {}
  847. abstract public function custom3();
  848. abstract public function absPubFunc();
  849. protected function protFunc() {}
  850. abstract protected function absProtFunc();
  851. private function privFunc() {}
  852. protected static function custom2() {}
  853. public function __get($prop) {}
  854. public function __toString() {}
  855. }
  856. EOT
  857. ,
  858. <<<'EOT'
  859. <?php
  860. abstract class Foo
  861. {
  862. public function __get($prop) {}
  863. private function custom1() {}
  864. abstract public function absPubFunc();
  865. private static function privStatFunc() {}
  866. public function pubFunc1() {}
  867. abstract protected function absProtFunc();
  868. public function __toString() {}
  869. protected function protFunc() {}
  870. function pubFunc2() {}
  871. abstract protected static function absProtStatFunc();
  872. public function __destruct() {}
  873. public static function pubStatFunc1() {}
  874. public function __invoke() {}
  875. public function pubFunc3() {}
  876. static function pubStatFunc2() {}
  877. private function privFunc() {}
  878. abstract public static function absPubStatFunc();
  879. protected function __construct() {}
  880. public static function pubStatFunc3() {}
  881. protected static function protStatFunc() {}
  882. abstract public function custom3();
  883. protected static function custom2() {}
  884. }
  885. EOT
  886. ,
  887. ];
  888. yield [
  889. [
  890. 'method:foo',
  891. 'method_public',
  892. 'method:bar',
  893. 'method:baz',
  894. 'magic',
  895. ],
  896. <<<'EOT'
  897. <?php
  898. abstract class Foo
  899. {
  900. public function pub() {}
  901. public function bar() {}
  902. public function __toString() {}
  903. }
  904. EOT
  905. ,
  906. <<<'EOT'
  907. <?php
  908. abstract class Foo
  909. {
  910. public function __toString() {}
  911. public function pub() {}
  912. public function bar() {}
  913. }
  914. EOT
  915. ,
  916. ];
  917. }
  918. /**
  919. * @param array<string, mixed> $configuration
  920. *
  921. * @dataProvider provideFixWithSortingAlgorithmCases
  922. */
  923. public function testFixWithSortingAlgorithm(array $configuration, string $expected, string $input): void
  924. {
  925. $this->fixer->configure($configuration);
  926. $this->doTest($expected, $input);
  927. }
  928. public static function provideFixWithSortingAlgorithmCases(): iterable
  929. {
  930. yield [
  931. [
  932. 'order' => [
  933. 'property_public_static',
  934. 'method_public',
  935. 'method_private',
  936. ],
  937. 'sort_algorithm' => OrderedClassElementsFixer::SORT_ALPHA,
  938. ],
  939. <<<'EOT'
  940. <?php
  941. class Example
  942. {
  943. public static $pubStatProp1;
  944. public static $pubStatProp2;
  945. public function A(){}
  946. public function B1(){}
  947. public function B2(){}
  948. public function C(){}
  949. public function C1(){}
  950. public function D(){}
  951. private function E(){}
  952. }
  953. EOT
  954. ,
  955. <<<'EOT'
  956. <?php
  957. class Example
  958. {
  959. public function D(){}
  960. public static $pubStatProp2;
  961. public function B1(){}
  962. public function B2(){}
  963. private function E(){}
  964. public static $pubStatProp1;
  965. public function A(){}
  966. public function C(){}
  967. public function C1(){}
  968. }
  969. EOT
  970. ,
  971. ];
  972. yield [
  973. [
  974. 'order' => [
  975. 'use_trait',
  976. 'constant',
  977. 'property_public_static',
  978. 'property_protected_static',
  979. 'property_private_static',
  980. 'property_public',
  981. 'property_protected',
  982. 'property_private',
  983. 'construct',
  984. 'destruct',
  985. 'magic',
  986. 'method_public_static',
  987. 'method_protected_static',
  988. 'method_private_static',
  989. 'method_public',
  990. 'method_protected',
  991. 'method_private',
  992. ],
  993. 'sort_algorithm' => OrderedClassElementsFixer::SORT_ALPHA,
  994. ],
  995. <<<'EOT'
  996. <?php
  997. class Foo
  998. {
  999. use BarTrait;
  1000. use BazTrait;
  1001. const C1 = 1;
  1002. const C2 = 2;
  1003. public static $pubStatProp1;
  1004. public static $pubStatProp2;
  1005. protected static $protStatProp;
  1006. private static $privStatProp;
  1007. public $pubProp1;
  1008. var $pubProp2;
  1009. public $pubProp3;
  1010. protected $protProp;
  1011. private $privProp;
  1012. protected function __construct() {}
  1013. public function __destruct() {}
  1014. public function __magicA() {}
  1015. public function __magicB() {}
  1016. public function __toString() {}
  1017. public static function pubStatFunc1() {}
  1018. static function pubStatFunc2() {}
  1019. public static function pubStatFunc3() {
  1020. return $this->privFunc();
  1021. }
  1022. protected static function protStatFunc() {}
  1023. private static function privStatFunc() {}
  1024. public function pubFunc1() {}
  1025. function pubFunc2() {}
  1026. public function pubFunc3(int $b, int $c) {
  1027. $a = $b*$c;
  1028. return $a % 4;
  1029. }
  1030. protected function protFunc() {}
  1031. private function privFunc() {}
  1032. }
  1033. EOT
  1034. ,
  1035. <<<'EOT'
  1036. <?php
  1037. class Foo
  1038. {
  1039. private static function privStatFunc() {}
  1040. protected static $protStatProp;
  1041. use BazTrait;
  1042. public static $pubStatProp2;
  1043. public $pubProp3;
  1044. use BarTrait;
  1045. public function __toString() {}
  1046. protected function protFunc() {}
  1047. protected $protProp;
  1048. function pubFunc2() {}
  1049. public $pubProp1;
  1050. public function __destruct() {}
  1051. var $pubProp2;
  1052. public function __magicB() {}
  1053. const C2 = 2;
  1054. public static $pubStatProp1;
  1055. public function __magicA() {}
  1056. private static $privStatProp;
  1057. static function pubStatFunc2() {}
  1058. public function pubFunc3(int $b, int $c) {
  1059. $a = $b*$c;
  1060. return $a % 4;
  1061. }
  1062. private $privProp;
  1063. const C1 = 1;
  1064. public static function pubStatFunc3() {
  1065. return $this->privFunc();
  1066. }
  1067. public function pubFunc1() {}
  1068. public static function pubStatFunc1() {}
  1069. private function privFunc() {}
  1070. protected function __construct() {}
  1071. protected static function protStatFunc() {}
  1072. }
  1073. EOT
  1074. ,
  1075. ];
  1076. yield [
  1077. [
  1078. 'order' => [
  1079. 'use_trait',
  1080. 'constant',
  1081. 'property_public_static',
  1082. 'property_protected_static',
  1083. 'property_private_static',
  1084. 'property_public',
  1085. 'property_protected',
  1086. 'property_private',
  1087. 'construct',
  1088. 'destruct',
  1089. 'magic',
  1090. 'method_public_static',
  1091. 'method_public_abstract_static',
  1092. 'method_protected_static',
  1093. 'method_protected_abstract_static',
  1094. 'method_private_static',
  1095. 'method_public',
  1096. 'method_public_abstract',
  1097. 'method_protected',
  1098. 'method_protected_abstract',
  1099. 'method_private',
  1100. ],
  1101. 'sort_algorithm' => OrderedClassElementsFixer::SORT_ALPHA,
  1102. ],
  1103. <<<'EOT'
  1104. <?php
  1105. abstract class Foo
  1106. {
  1107. use BarTrait;
  1108. use BazTrait;
  1109. const C1 = 1;
  1110. const C2 = 2;
  1111. public static $pubStatProp1;
  1112. public static $pubStatProp2;
  1113. protected static $protStatProp;
  1114. private static $privStatProp;
  1115. public $pubProp1;
  1116. var $pubProp2;
  1117. public $pubProp3;
  1118. protected $protProp;
  1119. private $privProp;
  1120. protected function __construct() {}
  1121. public function __destruct() {}
  1122. public function __magicA() {}
  1123. public function __magicB() {}
  1124. public function __toString() {}
  1125. public static function pubStatFunc1() {}
  1126. static function pubStatFunc2() {}
  1127. public static function pubStatFunc3() {
  1128. return $this->privFunc();
  1129. }
  1130. abstract public static function absPubStatFunc1();
  1131. protected static function protStatFunc() {}
  1132. abstract protected static function absProtStatFunc();
  1133. private static function privStatFunc() {}
  1134. public function pubFunc1() {}
  1135. function pubFunc2() {}
  1136. public function pubFunc3(int $b, int $c) {
  1137. $a = $b*$c;
  1138. return $a % 4;
  1139. }
  1140. abstract public function absPubFunc();
  1141. protected function protFunc() {}
  1142. abstract protected function absProtFunc();
  1143. private function privFunc() {}
  1144. }
  1145. EOT
  1146. ,
  1147. <<<'EOT'
  1148. <?php
  1149. abstract class Foo
  1150. {
  1151. private static function privStatFunc() {}
  1152. protected static $protStatProp;
  1153. use BazTrait;
  1154. abstract public function absPubFunc();
  1155. public static $pubStatProp2;
  1156. public $pubProp3;
  1157. use BarTrait;
  1158. public function __toString() {}
  1159. protected function protFunc() {}
  1160. protected $protProp;
  1161. function pubFunc2() {}
  1162. public $pubProp1;
  1163. abstract protected static function absProtStatFunc();
  1164. public function __destruct() {}
  1165. var $pubProp2;
  1166. public function __magicB() {}
  1167. const C2 = 2;
  1168. public static $pubStatProp1;
  1169. public function __magicA() {}
  1170. private static $privStatProp;
  1171. static function pubStatFunc2() {}
  1172. public function pubFunc3(int $b, int $c) {
  1173. $a = $b*$c;
  1174. return $a % 4;
  1175. }
  1176. private $privProp;
  1177. const C1 = 1;
  1178. abstract protected function absProtFunc();
  1179. public static function pubStatFunc3() {
  1180. return $this->privFunc();
  1181. }
  1182. public function pubFunc1() {}
  1183. public static function pubStatFunc1() {}
  1184. private function privFunc() {}
  1185. protected function __construct() {}
  1186. protected static function protStatFunc() {}
  1187. abstract public static function absPubStatFunc1();
  1188. }
  1189. EOT
  1190. ,
  1191. ];
  1192. yield [
  1193. [],
  1194. <<<'EOT'
  1195. <?php
  1196. class Foo
  1197. {
  1198. const C2 = 2;
  1199. public const C1 = 1;
  1200. public const C3 = 3;
  1201. protected const C4 = 4;
  1202. private const C5 = 5;
  1203. }
  1204. EOT
  1205. , <<<'EOT'
  1206. <?php
  1207. class Foo
  1208. {
  1209. private const C5 = 5;
  1210. const C2 = 2;
  1211. public const C1 = 1;
  1212. protected const C4 = 4;
  1213. public const C3 = 3;
  1214. }
  1215. EOT
  1216. ];
  1217. yield [
  1218. ['sort_algorithm' => OrderedClassElementsFixer::SORT_ALPHA],
  1219. <<<'EOT'
  1220. <?php
  1221. class Foo
  1222. {
  1223. public const C1 = 1;
  1224. const C2 = 2;
  1225. public const C3b = 3;
  1226. protected const C4a = 4;
  1227. private const C5 = 5;
  1228. }
  1229. EOT
  1230. , <<<'EOT'
  1231. <?php
  1232. class Foo
  1233. {
  1234. private const C5 = 5;
  1235. const C2 = 2;
  1236. public const C1 = 1;
  1237. protected const C4a = 4;
  1238. public const C3b = 3;
  1239. }
  1240. EOT
  1241. ];
  1242. yield [
  1243. ['sort_algorithm' => OrderedClassElementsFixer::SORT_ALPHA],
  1244. <<<'EOT'
  1245. <?php
  1246. class Foo
  1247. {
  1248. const A_ = 1;
  1249. const AA = 2;
  1250. const Ab = 3;
  1251. }
  1252. EOT
  1253. , <<<'EOT'
  1254. <?php
  1255. class Foo
  1256. {
  1257. const AA = 2;
  1258. const Ab = 3;
  1259. const A_ = 1;
  1260. }
  1261. EOT
  1262. ];
  1263. yield [
  1264. ['sort_algorithm' => OrderedClassElementsFixer::SORT_ALPHA, 'case_sensitive' => true],
  1265. <<<'EOT'
  1266. <?php
  1267. class Foo
  1268. {
  1269. const AA = 2;
  1270. const A_ = 1;
  1271. const Ab = 3;
  1272. }
  1273. EOT
  1274. , <<<'EOT'
  1275. <?php
  1276. class Foo
  1277. {
  1278. const AA = 2;
  1279. const Ab = 3;
  1280. const A_ = 1;
  1281. }
  1282. EOT
  1283. ];
  1284. }
  1285. /**
  1286. * @param array<string, mixed> $configuration
  1287. *
  1288. * @dataProvider provideFix74Cases
  1289. */
  1290. public function testFix74(string $expected, ?string $input = null, array $configuration = []): void
  1291. {
  1292. $this->fixer->configure($configuration);
  1293. $this->doTest($expected, $input);
  1294. }
  1295. public static function provideFix74Cases(): iterable
  1296. {
  1297. yield [
  1298. '<?php
  1299. class Foo {
  1300. public iterable $baz;
  1301. var ? Foo\Bar $qux;
  1302. protected string $bar;
  1303. private ?int $foo;
  1304. }',
  1305. '<?php
  1306. class Foo {
  1307. private ?int $foo;
  1308. protected string $bar;
  1309. public iterable $baz;
  1310. var ? Foo\Bar $qux;
  1311. }',
  1312. ];
  1313. yield [
  1314. '<?php
  1315. class Foo {
  1316. public string $bar;
  1317. public array $baz;
  1318. public ?int $foo;
  1319. public ? Foo\Bar $qux;
  1320. }',
  1321. '<?php
  1322. class Foo {
  1323. public array $baz;
  1324. public ? Foo\Bar $qux;
  1325. public string $bar;
  1326. public ?int $foo;
  1327. }',
  1328. [
  1329. 'sort_algorithm' => OrderedClassElementsFixer::SORT_ALPHA,
  1330. ],
  1331. ];
  1332. }
  1333. public function testWrongConfig(): void
  1334. {
  1335. $this->expectException(InvalidFixerConfigurationException::class);
  1336. $this->expectExceptionMessageMatches('/^\[ordered_class_elements\] Invalid configuration: The option "order" .*\.$/');
  1337. $this->fixer->configure(['order' => ['foo']]);
  1338. }
  1339. /**
  1340. * @dataProvider provideWithConfigWithNoCandidateCases
  1341. */
  1342. public function testWithConfigWithNoCandidate(string $methodName1, string $methodName2): void
  1343. {
  1344. $template = '<?php
  1345. class TestClass
  1346. {
  1347. public function %s(){}
  1348. public function %s(){}
  1349. }';
  1350. $this->fixer->configure(['order' => ['use_trait'], 'sort_algorithm' => OrderedClassElementsFixer::SORT_ALPHA]);
  1351. $this->doTest(
  1352. sprintf($template, $methodName2, $methodName1),
  1353. sprintf($template, $methodName1, $methodName2)
  1354. );
  1355. }
  1356. public static function provideWithConfigWithNoCandidateCases(): iterable
  1357. {
  1358. yield ['z', '__construct'];
  1359. yield ['z', '__destruct'];
  1360. yield ['z', '__sleep'];
  1361. yield ['z', 'abc'];
  1362. }
  1363. /**
  1364. * @dataProvider provideFix80Cases
  1365. *
  1366. * @requires PHP 8.0
  1367. */
  1368. public function testFix80(string $expected, string $input): void
  1369. {
  1370. $this->doTest($expected, $input);
  1371. }
  1372. public static function provideFix80Cases(): iterable
  1373. {
  1374. yield [
  1375. '<?php
  1376. trait TestTrait
  1377. {
  1378. abstract static public function abstractStaticPublic();
  1379. abstract private function abstractPrivate();
  1380. abstract static private function abstractStaticPrivate();
  1381. }
  1382. ',
  1383. '<?php
  1384. trait TestTrait
  1385. {
  1386. abstract private function abstractPrivate();
  1387. abstract static private function abstractStaticPrivate();
  1388. abstract static public function abstractStaticPublic();
  1389. }
  1390. ',
  1391. ];
  1392. yield [
  1393. '<?php class Foo
  1394. {
  1395. #[PublicBarAttribute0]
  1396. public int $bar = 1;
  1397. #[PublicAttribute0]
  1398. #[PublicAttribute1]
  1399. #[PublicAttribute2]
  1400. public function fooPublic()
  1401. {
  1402. }
  1403. #[PrivateAttribute0]
  1404. private function fooPrivate()
  1405. {
  1406. }
  1407. }',
  1408. '<?php class Foo
  1409. {
  1410. #[PrivateAttribute0]
  1411. private function fooPrivate()
  1412. {
  1413. }
  1414. #[PublicBarAttribute0]
  1415. public int $bar = 1;
  1416. #[PublicAttribute0]
  1417. #[PublicAttribute1]
  1418. #[PublicAttribute2]
  1419. public function fooPublic()
  1420. {
  1421. }
  1422. }',
  1423. ];
  1424. }
  1425. /**
  1426. * @param array<string, mixed> $configuration
  1427. *
  1428. * @dataProvider provideFix81Cases
  1429. *
  1430. * @requires PHP 8.1
  1431. */
  1432. public function testFix81(string $expected, ?string $input = null, array $configuration = []): void
  1433. {
  1434. $this->fixer->configure($configuration);
  1435. $this->doTest($expected, $input);
  1436. }
  1437. public static function provideFix81Cases(): iterable
  1438. {
  1439. yield [
  1440. '<?php
  1441. class A
  1442. {
  1443. readonly public string $publicProp0;
  1444. public readonly string $publicProp1;
  1445. public string $pubProp2;
  1446. protected readonly string $protectedProp0;
  1447. readonly protected string $protectedProp1;
  1448. readonly private string $privateProp0;
  1449. private readonly string $privateProp1;
  1450. }
  1451. ',
  1452. '<?php
  1453. class A
  1454. {
  1455. public string $pubProp2;
  1456. readonly public string $publicProp0;
  1457. public readonly string $publicProp1;
  1458. private readonly string $privateProp1;
  1459. readonly private string $privateProp0;
  1460. protected readonly string $protectedProp0;
  1461. readonly protected string $protectedProp1;
  1462. }
  1463. ',
  1464. ['order' => ['property_public_readonly', 'property_public', 'property_protected_readonly', 'property_private_readonly'], 'sort_algorithm' => 'alpha'],
  1465. ];
  1466. yield [
  1467. '<?php
  1468. enum A: int
  1469. {
  1470. case Foo = 1;
  1471. case Bar = 2;
  1472. private const C1 = 1;
  1473. function qux() {
  1474. switch (true) {
  1475. case 1: break;
  1476. }
  1477. }
  1478. }
  1479. ',
  1480. '<?php
  1481. enum A: int
  1482. {
  1483. private const C1 = 1;
  1484. case Foo = 1;
  1485. function qux() {
  1486. switch (true) {
  1487. case 1: break;
  1488. }
  1489. }
  1490. case Bar = 2;
  1491. }
  1492. ',
  1493. ];
  1494. }
  1495. /**
  1496. * @dataProvider provideFix82Cases
  1497. *
  1498. * @requires PHP 8.2
  1499. */
  1500. public function testFix82(string $expected, ?string $input = null): void
  1501. {
  1502. $this->doTest($expected, $input);
  1503. }
  1504. public static function provideFix82Cases(): iterable
  1505. {
  1506. yield [
  1507. '<?php trait Foo { const C1 = 1; protected $abc = "abc"; }',
  1508. '<?php trait Foo { protected $abc = "abc"; const C1 = 1; }',
  1509. ];
  1510. }
  1511. }