ArrayPushFixerTest.php 8.4 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331
  1. <?php
  2. declare(strict_types=1);
  3. /*
  4. * This file is part of PHP CS Fixer.
  5. *
  6. * (c) Fabien Potencier <fabien@symfony.com>
  7. * Dariusz Rumiński <dariusz.ruminski@gmail.com>
  8. *
  9. * This source file is subject to the MIT license that is bundled
  10. * with this source code in the file LICENSE.
  11. */
  12. namespace PhpCsFixer\Tests\Fixer\Alias;
  13. use PhpCsFixer\Tests\Test\AbstractFixerTestCase;
  14. /**
  15. * @internal
  16. *
  17. * @covers \PhpCsFixer\Fixer\Alias\ArrayPushFixer
  18. */
  19. final class ArrayPushFixerTest extends AbstractFixerTestCase
  20. {
  21. /**
  22. * @dataProvider provideFixCases
  23. */
  24. public function testFix(string $expected, ?string $input = null): void
  25. {
  26. $this->doTest($expected, $input);
  27. }
  28. public static function provideFixCases(): iterable
  29. {
  30. yield 'minimal' => [
  31. '<?php $a[] =$b;',
  32. '<?php array_push($a,$b);',
  33. ];
  34. yield 'simple' => [
  35. '<?php $a[] = $b;',
  36. '<?php array_push($a, $b);',
  37. ];
  38. yield 'simple, spaces' => [
  39. '<?php $a [] =$b ;',
  40. '<?php array_push( $a , $b );',
  41. ];
  42. yield 'simple 25x times' => [
  43. '<?php '.str_repeat('$a[] = $b;', 25),
  44. '<?php '.str_repeat('array_push($a, $b);', 25),
  45. ];
  46. yield 'simple namespaced' => [
  47. '<?php $a[] = $b1;',
  48. '<?php \array_push($a, $b1);',
  49. ];
  50. yield '; before' => [
  51. '<?php ; $a1[] = $b2 ?>',
  52. '<?php ; array_push($a1, $b2) ?>',
  53. ];
  54. yield ') before' => [
  55. '<?php
  56. if ($c) $a[] = $b;
  57. while (--$c > 0) $a[] = $c;
  58. ',
  59. '<?php
  60. if ($c) array_push($a, $b);
  61. while (--$c > 0) array_push($a, $c);
  62. ',
  63. ];
  64. yield '} before' => [
  65. '<?php $b3 = []; { $a = 1; } $b5[] = 1;',
  66. '<?php $b3 = []; { $a = 1; } \array_push($b5, 1);',
  67. ];
  68. yield '{ before' => [
  69. '<?php { $a[] = $b8; }',
  70. '<?php { array_push($a, $b8); }',
  71. ];
  72. yield 'comments and PHPDoc' => [
  73. '<?php /* */ $a2[] = $b3 /** */;',
  74. '<?php /* */ array_push($a2, $b3) /** */;',
  75. ];
  76. yield [
  77. '<?php $a4[1][] = $b6[2];',
  78. '<?php array_push($a4[1], $b6[2]);',
  79. ];
  80. yield 'case insensitive and precedence' => [
  81. '<?php
  82. $a[] = $b--;
  83. $a[] = ++$b;
  84. $a[] = !$b;
  85. $a[] = $b + $c;
  86. $a[] = 1 ** $c / 2 || !b && c(1,2,3) ^ $a[1];
  87. ',
  88. '<?php
  89. array_push($a, $b--);
  90. ARRAY_push($a, ++$b);
  91. array_PUSH($a, !$b);
  92. ARRAY_PUSH($a, $b + $c);
  93. \array_push($a, 1 ** $c / 2 || !b && c(1,2,3) ^ $a[1]);
  94. ',
  95. ];
  96. yield 'simple traditional array' => [
  97. '<?php $a[] = array($b, $c);',
  98. '<?php array_push($a, array($b, $c));',
  99. ];
  100. yield 'simple short array' => [
  101. '<?php $a[] = [$b];',
  102. '<?php array_push($a, [$b]);',
  103. ];
  104. yield 'multiple element short array' => [
  105. '<?php $a[] = [[], [], $b, $c];',
  106. '<?php array_push($a, [[], [], $b, $c]);',
  107. ];
  108. yield 'second argument wrapped in `(` `)`' => [
  109. '<?php $a::$c[] = ($b);',
  110. '<?php array_push($a::$c, ($b));',
  111. ];
  112. yield [
  113. '<?php $a::$c[] = $b;',
  114. '<?php array_push($a::$c, $b);',
  115. ];
  116. yield [
  117. '<?php $a[foo(1,2,3)][] = $b[foo(1,2,3)];',
  118. '<?php array_push($a[foo(1,2,3)], $b[foo(1,2,3)]);',
  119. ];
  120. yield [
  121. '<?php \A\B::$foo[] = 1;',
  122. '<?php array_push(\A\B::$foo, 1);',
  123. ];
  124. yield [
  125. '<?php static::$foo[] = 1;',
  126. '<?php array_push(static::$foo, 1);',
  127. ];
  128. yield [
  129. '<?php namespace\A::$foo[] = 1;',
  130. '<?php array_push(namespace\A::$foo, 1);',
  131. ];
  132. yield [
  133. '<?php foo()->bar[] = 1;',
  134. '<?php array_push(foo()->bar, 1);',
  135. ];
  136. yield [
  137. '<?php foo()[] = 1;',
  138. '<?php array_push(foo(), 1);',
  139. ];
  140. yield [
  141. '<?php $a->$c[] = $b;',
  142. '<?php array_push($a->$c, $b);',
  143. ];
  144. yield [
  145. '<?php $a->$c[1]->$d{$a--}->$a[7][] = $b;',
  146. '<?php array_push($a->$c[1]->$d{$a--}->$a[7], $b);',
  147. ];
  148. yield 'push multiple' => [
  149. '<?php array_push($a6, $b9, $c);',
  150. ];
  151. yield 'push multiple II' => [
  152. '<?php ; array_push($a6a, $b9->$a(1,2), $c);',
  153. ];
  154. yield 'push multiple short' => [
  155. '<?php array_push($a6, [$b,$c], []);',
  156. ];
  157. yield 'returns number of elements in the array I' => [
  158. '<?php foo(array_push($a7, $b10)); // ;array_push($a, $b);',
  159. ];
  160. yield 'returns number of elements in the array II' => [
  161. '<?php $a = 3 * array_push($a8, $b11);',
  162. ];
  163. yield 'returns number of elements in the array III' => [
  164. '<?php $a = foo($z, array_push($a9, $b12));',
  165. ];
  166. yield 'returns number of elements in the array IV' => [
  167. '<?php $z = array_push($a00, $b13);',
  168. ];
  169. yield 'function declare in different namespace' => [
  170. '<?php namespace Foo; function array_push($a11, $b14){};',
  171. ];
  172. yield 'overridden detect I' => [
  173. '<?php namespace Foo; array_push(1, $a15);',
  174. ];
  175. yield 'overridden detect II' => [
  176. '<?php namespace Foo; array_push($a + 1, $a16);',
  177. ];
  178. yield 'different namespace and not a function call' => [
  179. '<?php
  180. A\array_push($a, $b17);
  181. A::array_push($a, $b18);
  182. $a->array_push($a, $b19);
  183. ',
  184. ];
  185. yield 'open echo' => [
  186. '<?= array_push($a, $b20) ?> <?= array_push($a, $b20); ?>',
  187. ];
  188. yield 'ellipsis' => [
  189. '<?php array_push($a, ...$b21);',
  190. ];
  191. $precedenceCases = [
  192. '$b and $c',
  193. '$b or $c',
  194. '$b xor $c',
  195. ];
  196. foreach ($precedenceCases as $precedenceCase) {
  197. yield [
  198. sprintf(
  199. '<?php array_push($a, %s);',
  200. $precedenceCase
  201. ),
  202. ];
  203. }
  204. yield [
  205. '<?php
  206. while (foo()) $a[] = $b;
  207. foreach (foo() as $C) $a[] = $b;
  208. if (foo()) $a[] = $b;
  209. if ($b) {} elseif (foo()) $a[] = $b;
  210. ',
  211. '<?php
  212. while (foo()) array_push($a, $b);
  213. foreach (foo() as $C) array_push($a, $b);
  214. if (foo()) array_push($a, $b);
  215. if ($b) {} elseif (foo()) array_push($a, $b);
  216. ',
  217. ];
  218. }
  219. /**
  220. * @dataProvider provideFixPre80Cases
  221. *
  222. * @requires PHP <8.0
  223. */
  224. public function testFixPre80(string $expected, string $input = null): void
  225. {
  226. $this->doTest($expected, $input);
  227. }
  228. public static function provideFixPre80Cases(): iterable
  229. {
  230. yield [
  231. '<?php $a5{1*3}[2+1][] = $b4{2+1};',
  232. '<?php array_push($a5{1*3}[2+1], $b4{2+1});',
  233. ];
  234. yield [
  235. '<?php $a5{1*3}[2+1][] = $b7{2+1};',
  236. '<?php array_push($a5{1*3}[2+1], $b7{2+1});',
  237. ];
  238. }
  239. /**
  240. * @dataProvider provideFix80Cases
  241. *
  242. * @requires PHP 8.0
  243. */
  244. public function testFix80(string $expected, string $input = null): void
  245. {
  246. $this->doTest($expected, $input);
  247. }
  248. public static function provideFix80Cases(): iterable
  249. {
  250. yield [
  251. '<?php array_push($b?->c[2], $b19);',
  252. ];
  253. }
  254. /**
  255. * @dataProvider provideFix81Cases
  256. *
  257. * @requires PHP 8.1
  258. */
  259. public function testFix81(string $expected, string $input): void
  260. {
  261. $this->doTest($expected, $input);
  262. }
  263. public static function provideFix81Cases(): iterable
  264. {
  265. yield 'simple 8.1' => [
  266. '<?php
  267. $a[] = $b;
  268. $a = array_push(...);
  269. ',
  270. '<?php
  271. array_push($a, $b);
  272. $a = array_push(...);
  273. ',
  274. ];
  275. }
  276. }