FixerFactoryTest.php 28 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586
  1. <?php
  2. /*
  3. * This file is part of PHP CS Fixer.
  4. *
  5. * (c) Fabien Potencier <fabien@symfony.com>
  6. * Dariusz Rumiński <dariusz.ruminski@gmail.com>
  7. *
  8. * This source file is subject to the MIT license that is bundled
  9. * with this source code in the file LICENSE.
  10. */
  11. namespace PhpCsFixer\Tests\AutoReview;
  12. use PhpCsFixer\Fixer\FixerInterface;
  13. use PhpCsFixer\FixerFactory;
  14. use PhpCsFixer\Tests\Test\IntegrationCaseFactory;
  15. use PhpCsFixer\Tests\TestCase;
  16. use Symfony\Component\Finder\SplFileInfo;
  17. /**
  18. * @author Dariusz Rumiński <dariusz.ruminski@gmail.com>
  19. *
  20. * @internal
  21. *
  22. * @coversNothing
  23. * @group auto-review
  24. * @group covers-nothing
  25. */
  26. final class FixerFactoryTest extends TestCase
  27. {
  28. public function testFixersPriorityEdgeFixers()
  29. {
  30. $factory = new FixerFactory();
  31. $factory->registerBuiltInFixers();
  32. $fixers = $factory->getFixers();
  33. static::assertSame('encoding', $fixers[0]->getName(), 'Expected "encoding" fixer to have the highest priority.');
  34. static::assertSame('full_opening_tag', $fixers[1]->getName(), 'Expected "full_opening_tag" fixer has second highest priority.');
  35. static::assertSame('single_blank_line_at_eof', $fixers[\count($fixers) - 1]->getName(), 'Expected "single_blank_line_at_eof" to have the lowest priority.');
  36. }
  37. /**
  38. * @dataProvider provideFixersPriorityCases
  39. * @dataProvider provideFixersPrioritySpecialPhpdocCases
  40. */
  41. public function testFixersPriority(FixerInterface $first, FixerInterface $second)
  42. {
  43. static::assertLessThan($first->getPriority(), $second->getPriority(), sprintf('"%s" should have less priority than "%s"', \get_class($second), \get_class($first)));
  44. }
  45. public function provideFixersPriorityCases()
  46. {
  47. $factory = new FixerFactory();
  48. $factory->registerBuiltInFixers();
  49. $fixers = [];
  50. foreach ($factory->getFixers() as $fixer) {
  51. $fixers[$fixer->getName()] = $fixer;
  52. }
  53. return [
  54. [$fixers['array_indentation'], $fixers['align_multiline_comment']],
  55. [$fixers['array_indentation'], $fixers['binary_operator_spaces']],
  56. [$fixers['array_syntax'], $fixers['binary_operator_spaces']],
  57. [$fixers['array_syntax'], $fixers['ternary_operator_spaces']],
  58. [$fixers['backtick_to_shell_exec'], $fixers['escape_implicit_backslashes']],
  59. [$fixers['backtick_to_shell_exec'], $fixers['explicit_string_variable']],
  60. [$fixers['blank_line_after_opening_tag'], $fixers['no_blank_lines_before_namespace']],
  61. [$fixers['braces'], $fixers['array_indentation']],
  62. [$fixers['braces'], $fixers['method_chaining_indentation']],
  63. [$fixers['class_attributes_separation'], $fixers['braces']],
  64. [$fixers['class_attributes_separation'], $fixers['indentation_type']],
  65. [$fixers['class_keyword_remove'], $fixers['no_unused_imports']],
  66. [$fixers['combine_consecutive_issets'], $fixers['multiline_whitespace_before_semicolons']],
  67. [$fixers['combine_consecutive_issets'], $fixers['no_spaces_inside_parenthesis']],
  68. [$fixers['combine_consecutive_issets'], $fixers['no_trailing_whitespace']],
  69. [$fixers['combine_consecutive_issets'], $fixers['no_whitespace_in_blank_line']],
  70. [$fixers['combine_consecutive_unsets'], $fixers['no_extra_blank_lines']],
  71. [$fixers['combine_consecutive_unsets'], $fixers['no_trailing_whitespace']],
  72. [$fixers['combine_consecutive_unsets'], $fixers['no_whitespace_in_blank_line']],
  73. [$fixers['combine_consecutive_unsets'], $fixers['space_after_semicolon']],
  74. [$fixers['combine_nested_dirname'], $fixers['method_argument_space']],
  75. [$fixers['combine_nested_dirname'], $fixers['no_spaces_inside_parenthesis']],
  76. [$fixers['declare_strict_types'], $fixers['blank_line_after_opening_tag']],
  77. [$fixers['declare_strict_types'], $fixers['declare_equal_normalize']],
  78. [$fixers['dir_constant'], $fixers['combine_nested_dirname']],
  79. [$fixers['doctrine_annotation_array_assignment'], $fixers['doctrine_annotation_spaces']],
  80. [$fixers['elseif'], $fixers['braces']],
  81. [$fixers['escape_implicit_backslashes'], $fixers['heredoc_to_nowdoc']],
  82. [$fixers['escape_implicit_backslashes'], $fixers['single_quote']],
  83. [$fixers['explicit_string_variable'], $fixers['simple_to_complex_string_variable']],
  84. [$fixers['fully_qualified_strict_types'], $fixers['no_superfluous_phpdoc_tags']],
  85. [$fixers['function_to_constant'], $fixers['native_function_casing']],
  86. [$fixers['function_to_constant'], $fixers['no_extra_blank_lines']],
  87. [$fixers['function_to_constant'], $fixers['no_singleline_whitespace_before_semicolons']],
  88. [$fixers['function_to_constant'], $fixers['no_trailing_whitespace']],
  89. [$fixers['function_to_constant'], $fixers['no_whitespace_in_blank_line']],
  90. [$fixers['general_phpdoc_annotation_remove'], $fixers['no_empty_phpdoc']],
  91. [$fixers['general_phpdoc_annotation_remove'], $fixers['phpdoc_separation']],
  92. [$fixers['general_phpdoc_annotation_remove'], $fixers['phpdoc_trim']],
  93. [$fixers['implode_call'], $fixers['method_argument_space']],
  94. [$fixers['indentation_type'], $fixers['phpdoc_indent']],
  95. [$fixers['is_null'], $fixers['yoda_style']],
  96. [$fixers['line_ending'], $fixers['braces']],
  97. [$fixers['list_syntax'], $fixers['binary_operator_spaces']],
  98. [$fixers['list_syntax'], $fixers['ternary_operator_spaces']],
  99. [$fixers['method_chaining_indentation'], $fixers['array_indentation']],
  100. [$fixers['method_separation'], $fixers['braces']],
  101. [$fixers['method_separation'], $fixers['indentation_type']],
  102. [$fixers['multiline_whitespace_before_semicolons'], $fixers['space_after_semicolon']],
  103. [$fixers['no_alias_functions'], $fixers['implode_call']],
  104. [$fixers['no_alias_functions'], $fixers['php_unit_dedicate_assert']],
  105. [$fixers['no_alternative_syntax'], $fixers['braces']],
  106. [$fixers['no_alternative_syntax'], $fixers['elseif']],
  107. [$fixers['no_alternative_syntax'], $fixers['no_superfluous_elseif']],
  108. [$fixers['no_alternative_syntax'], $fixers['no_useless_else']],
  109. [$fixers['no_blank_lines_after_phpdoc'], $fixers['header_comment']],
  110. [$fixers['no_blank_lines_after_phpdoc'], $fixers['single_blank_line_before_namespace']],
  111. [$fixers['no_empty_comment'], $fixers['no_extra_blank_lines']],
  112. [$fixers['no_empty_comment'], $fixers['no_trailing_whitespace']],
  113. [$fixers['no_empty_comment'], $fixers['no_whitespace_in_blank_line']],
  114. [$fixers['no_empty_phpdoc'], $fixers['no_extra_blank_lines']],
  115. [$fixers['no_empty_phpdoc'], $fixers['no_trailing_whitespace']],
  116. [$fixers['no_empty_phpdoc'], $fixers['no_whitespace_in_blank_line']],
  117. [$fixers['no_empty_statement'], $fixers['braces']],
  118. [$fixers['no_empty_statement'], $fixers['combine_consecutive_unsets']],
  119. [$fixers['no_empty_statement'], $fixers['multiline_whitespace_before_semicolons']],
  120. [$fixers['no_empty_statement'], $fixers['no_extra_blank_lines']],
  121. [$fixers['no_empty_statement'], $fixers['no_singleline_whitespace_before_semicolons']],
  122. [$fixers['no_empty_statement'], $fixers['no_trailing_whitespace']],
  123. [$fixers['no_empty_statement'], $fixers['no_useless_else']],
  124. [$fixers['no_empty_statement'], $fixers['no_useless_return']],
  125. [$fixers['no_empty_statement'], $fixers['no_whitespace_in_blank_line']],
  126. [$fixers['no_empty_statement'], $fixers['return_assignment']],
  127. [$fixers['no_empty_statement'], $fixers['space_after_semicolon']],
  128. [$fixers['no_empty_statement'], $fixers['switch_case_semicolon_to_colon']],
  129. [$fixers['no_extra_blank_lines'], $fixers['blank_line_before_statement']],
  130. [$fixers['no_leading_import_slash'], $fixers['ordered_imports']],
  131. [$fixers['no_multiline_whitespace_around_double_arrow'], $fixers['binary_operator_spaces']],
  132. [$fixers['no_multiline_whitespace_around_double_arrow'], $fixers['trailing_comma_in_multiline_array']],
  133. [$fixers['no_php4_constructor'], $fixers['ordered_class_elements']],
  134. [$fixers['no_short_bool_cast'], $fixers['cast_spaces']],
  135. [$fixers['no_short_echo_tag'], $fixers['no_mixed_echo_print']],
  136. [$fixers['no_spaces_after_function_name'], $fixers['function_to_constant']],
  137. [$fixers['no_spaces_inside_parenthesis'], $fixers['function_to_constant']],
  138. [$fixers['no_superfluous_phpdoc_tags'], $fixers['no_empty_phpdoc']],
  139. [$fixers['no_unneeded_control_parentheses'], $fixers['no_trailing_whitespace']],
  140. [$fixers['no_unneeded_curly_braces'], $fixers['no_useless_else']],
  141. [$fixers['no_unneeded_curly_braces'], $fixers['no_useless_return']],
  142. [$fixers['no_unset_on_property'], $fixers['combine_consecutive_unsets']],
  143. [$fixers['no_unused_imports'], $fixers['blank_line_after_namespace']],
  144. [$fixers['no_unused_imports'], $fixers['no_extra_blank_lines']],
  145. [$fixers['no_unused_imports'], $fixers['no_leading_import_slash']],
  146. [$fixers['no_useless_else'], $fixers['braces']],
  147. [$fixers['no_useless_else'], $fixers['combine_consecutive_unsets']],
  148. [$fixers['no_useless_else'], $fixers['no_extra_blank_lines']],
  149. [$fixers['no_useless_else'], $fixers['no_trailing_whitespace']],
  150. [$fixers['no_useless_else'], $fixers['no_useless_return']],
  151. [$fixers['no_useless_else'], $fixers['no_whitespace_in_blank_line']],
  152. [$fixers['no_useless_return'], $fixers['blank_line_before_return']],
  153. [$fixers['no_useless_return'], $fixers['blank_line_before_statement']],
  154. [$fixers['no_useless_return'], $fixers['no_extra_blank_lines']],
  155. [$fixers['no_useless_return'], $fixers['no_whitespace_in_blank_line']],
  156. [$fixers['ordered_class_elements'], $fixers['class_attributes_separation']],
  157. [$fixers['ordered_class_elements'], $fixers['method_separation']],
  158. [$fixers['ordered_class_elements'], $fixers['no_blank_lines_after_class_opening']],
  159. [$fixers['ordered_class_elements'], $fixers['space_after_semicolon']],
  160. [$fixers['php_unit_construct'], $fixers['php_unit_dedicate_assert']],
  161. [$fixers['php_unit_dedicate_assert'], $fixers['php_unit_dedicate_assert_internal_type']],
  162. [$fixers['php_unit_fqcn_annotation'], $fixers['no_unused_imports']],
  163. [$fixers['php_unit_fqcn_annotation'], $fixers['php_unit_ordered_covers']],
  164. [$fixers['php_unit_internal_class'], $fixers['final_internal_class']],
  165. [$fixers['php_unit_no_expectation_annotation'], $fixers['no_empty_phpdoc']],
  166. [$fixers['php_unit_no_expectation_annotation'], $fixers['php_unit_expectation']],
  167. [$fixers['php_unit_test_annotation'], $fixers['no_empty_phpdoc']],
  168. [$fixers['php_unit_test_annotation'], $fixers['php_unit_method_casing']],
  169. [$fixers['php_unit_test_annotation'], $fixers['phpdoc_trim']],
  170. [$fixers['phpdoc_add_missing_param_annotation'], $fixers['no_empty_phpdoc']],
  171. [$fixers['phpdoc_add_missing_param_annotation'], $fixers['no_superfluous_phpdoc_tags']],
  172. [$fixers['phpdoc_add_missing_param_annotation'], $fixers['phpdoc_align']],
  173. [$fixers['phpdoc_add_missing_param_annotation'], $fixers['phpdoc_order']],
  174. [$fixers['phpdoc_no_access'], $fixers['no_empty_phpdoc']],
  175. [$fixers['phpdoc_no_access'], $fixers['phpdoc_order']],
  176. [$fixers['phpdoc_no_access'], $fixers['phpdoc_separation']],
  177. [$fixers['phpdoc_no_access'], $fixers['phpdoc_trim']],
  178. [$fixers['phpdoc_no_alias_tag'], $fixers['phpdoc_add_missing_param_annotation']],
  179. [$fixers['phpdoc_no_alias_tag'], $fixers['phpdoc_single_line_var_spacing']],
  180. [$fixers['phpdoc_no_empty_return'], $fixers['no_empty_phpdoc']],
  181. [$fixers['phpdoc_no_empty_return'], $fixers['phpdoc_order']],
  182. [$fixers['phpdoc_no_empty_return'], $fixers['phpdoc_separation']],
  183. [$fixers['phpdoc_no_empty_return'], $fixers['phpdoc_trim']],
  184. [$fixers['phpdoc_no_package'], $fixers['no_empty_phpdoc']],
  185. [$fixers['phpdoc_no_package'], $fixers['phpdoc_order']],
  186. [$fixers['phpdoc_no_package'], $fixers['phpdoc_separation']],
  187. [$fixers['phpdoc_no_package'], $fixers['phpdoc_trim']],
  188. [$fixers['phpdoc_no_useless_inheritdoc'], $fixers['no_empty_phpdoc']],
  189. [$fixers['phpdoc_no_useless_inheritdoc'], $fixers['no_trailing_whitespace_in_comment']],
  190. [$fixers['phpdoc_order'], $fixers['phpdoc_separation']],
  191. [$fixers['phpdoc_order'], $fixers['phpdoc_trim']],
  192. [$fixers['phpdoc_return_self_reference'], $fixers['no_superfluous_phpdoc_tags']],
  193. [$fixers['phpdoc_scalar'], $fixers['phpdoc_to_return_type']],
  194. [$fixers['phpdoc_to_comment'], $fixers['no_empty_comment']],
  195. [$fixers['phpdoc_to_comment'], $fixers['phpdoc_no_useless_inheritdoc']],
  196. [$fixers['phpdoc_to_return_type'], $fixers['fully_qualified_strict_types']],
  197. [$fixers['phpdoc_to_return_type'], $fixers['no_superfluous_phpdoc_tags']],
  198. [$fixers['phpdoc_to_return_type'], $fixers['return_type_declaration']],
  199. [$fixers['phpdoc_types'], $fixers['phpdoc_to_return_type']],
  200. [$fixers['pow_to_exponentiation'], $fixers['binary_operator_spaces']],
  201. [$fixers['pow_to_exponentiation'], $fixers['method_argument_space']],
  202. [$fixers['pow_to_exponentiation'], $fixers['native_function_casing']],
  203. [$fixers['pow_to_exponentiation'], $fixers['no_spaces_after_function_name']],
  204. [$fixers['pow_to_exponentiation'], $fixers['no_spaces_inside_parenthesis']],
  205. [$fixers['protected_to_private'], $fixers['ordered_class_elements']],
  206. [$fixers['return_assignment'], $fixers['blank_line_before_statement']],
  207. [$fixers['simplified_null_return'], $fixers['no_useless_return']],
  208. [$fixers['single_import_per_statement'], $fixers['multiline_whitespace_before_semicolons']],
  209. [$fixers['single_import_per_statement'], $fixers['no_leading_import_slash']],
  210. [$fixers['single_import_per_statement'], $fixers['no_singleline_whitespace_before_semicolons']],
  211. [$fixers['single_import_per_statement'], $fixers['no_unused_imports']],
  212. [$fixers['single_import_per_statement'], $fixers['space_after_semicolon']],
  213. [$fixers['single_trait_insert_per_statement'], $fixers['braces']],
  214. [$fixers['single_trait_insert_per_statement'], $fixers['space_after_semicolon']],
  215. [$fixers['standardize_increment'], $fixers['increment_style']],
  216. [$fixers['standardize_not_equals'], $fixers['binary_operator_spaces']],
  217. [$fixers['strict_comparison'], $fixers['binary_operator_spaces']],
  218. [$fixers['unary_operator_spaces'], $fixers['not_operator_with_space']],
  219. [$fixers['unary_operator_spaces'], $fixers['not_operator_with_successor_space']],
  220. [$fixers['void_return'], $fixers['phpdoc_no_empty_return']],
  221. [$fixers['void_return'], $fixers['return_type_declaration']],
  222. ];
  223. }
  224. public function provideFixersPrioritySpecialPhpdocCases()
  225. {
  226. $factory = new FixerFactory();
  227. $factory->registerBuiltInFixers();
  228. $fixers = [];
  229. foreach ($factory->getFixers() as $fixer) {
  230. $fixers[$fixer->getName()] = $fixer;
  231. }
  232. $cases = [];
  233. // prepare bulk tests for phpdoc fixers to test that:
  234. // * `comment_to_phpdoc` is first
  235. // * `phpdoc_to_comment` is second
  236. // * `phpdoc_indent` is third
  237. // * `phpdoc_types` is fourth
  238. // * `phpdoc_scalar` is fifth
  239. // * `phpdoc_align` is last
  240. $cases[] = [$fixers['comment_to_phpdoc'], $fixers['phpdoc_to_comment']];
  241. $cases[] = [$fixers['phpdoc_indent'], $fixers['phpdoc_types']];
  242. $cases[] = [$fixers['phpdoc_to_comment'], $fixers['phpdoc_indent']];
  243. $cases[] = [$fixers['phpdoc_types'], $fixers['phpdoc_scalar']];
  244. $docFixerNames = array_filter(
  245. array_keys($fixers),
  246. static function ($name) {
  247. return false !== strpos($name, 'phpdoc');
  248. }
  249. );
  250. foreach ($docFixerNames as $docFixerName) {
  251. if (!\in_array($docFixerName, ['comment_to_phpdoc', 'phpdoc_to_comment', 'phpdoc_indent', 'phpdoc_types', 'phpdoc_scalar'], true)) {
  252. $cases[] = [$fixers['comment_to_phpdoc'], $fixers[$docFixerName]];
  253. $cases[] = [$fixers['phpdoc_indent'], $fixers[$docFixerName]];
  254. $cases[] = [$fixers['phpdoc_scalar'], $fixers[$docFixerName]];
  255. $cases[] = [$fixers['phpdoc_to_comment'], $fixers[$docFixerName]];
  256. $cases[] = [$fixers['phpdoc_types'], $fixers[$docFixerName]];
  257. }
  258. if ('phpdoc_align' !== $docFixerName) {
  259. $cases[] = [$fixers[$docFixerName], $fixers['phpdoc_align']];
  260. }
  261. }
  262. return $cases;
  263. }
  264. /**
  265. * @dataProvider provideFixersPriorityPairsHaveIntegrationTestCases
  266. */
  267. public function testFixersPriorityPairsHaveIntegrationTest(FixerInterface $first, FixerInterface $second)
  268. {
  269. // This structure contains older cases that are not yet covered by tests.
  270. // It may only shrink, never add anything to it.
  271. $casesWithoutTests = [
  272. 'indentation_type,phpdoc_indent.test',
  273. 'phpdoc_no_access,phpdoc_order.test',
  274. 'phpdoc_no_package,phpdoc_order.test',
  275. ];
  276. $integrationTestName = $this->generateIntegrationTestName($first, $second);
  277. $file = $this->getIntegrationPriorityDirectory().$integrationTestName;
  278. if (is_file($file)) {
  279. $description = sprintf('Integration of fixers: %s,%s.', $first->getName(), $second->getName());
  280. $integrationTestExists = true;
  281. } else {
  282. $file = $this->getIntegrationPriorityDirectory().$this->generateIntegrationTestName($second, $first);
  283. $description = sprintf('Integration of fixers: %s,%s.', $second->getName(), $first->getName());
  284. $integrationTestExists = is_file($file);
  285. }
  286. if (\in_array($integrationTestName, $casesWithoutTests, true)) {
  287. static::assertFalse($integrationTestExists, sprintf('Case "%s" already has an integration test, so it should be removed from "$casesWithoutTests".', $integrationTestName));
  288. static::markTestIncomplete(sprintf('Case "%s" has no integration test yet, please help and add it.', $integrationTestName));
  289. }
  290. static::assertTrue($integrationTestExists, sprintf('There shall be an integration test "%s". How do you know that priority set up is good, if there is no integration test to check it?', $integrationTestName));
  291. $file = realpath($file);
  292. $factory = new IntegrationCaseFactory();
  293. $test = $factory->create(new SplFileInfo($file, './', __DIR__));
  294. $rules = $test->getRuleset()->getRules();
  295. $expected = [$first->getName(), $second->getName()];
  296. $actual = array_keys($rules);
  297. sort($expected);
  298. sort($actual);
  299. static::assertSame($description, $test->getTitle(), sprintf('Please fix the title in "%s".', $file));
  300. static::assertCount(2, $rules, sprintf('Only the two rules that are tested for priority should be in the ruleset of "%s".', $file));
  301. foreach ($rules as $name => $config) {
  302. static::assertNotFalse($config, sprintf('The rule "%s" in "%s" may not be disabled for the test.', $name, $file));
  303. }
  304. static::assertSame($expected, $actual, sprintf('The ruleset of "%s" must contain the rules for the priority test.', $file));
  305. }
  306. public function provideFixersPriorityPairsHaveIntegrationTestCases()
  307. {
  308. return array_filter(
  309. $this->provideFixersPriorityCases(),
  310. // ignore speed-up only priorities set up
  311. function (array $case) {
  312. return !\in_array(
  313. $this->generateIntegrationTestName($case[0], $case[1]),
  314. [
  315. 'function_to_constant,native_function_casing.test',
  316. 'no_unused_imports,no_leading_import_slash.test',
  317. 'pow_to_exponentiation,method_argument_space.test',
  318. 'pow_to_exponentiation,native_function_casing.test',
  319. 'pow_to_exponentiation,no_spaces_after_function_name.test',
  320. 'pow_to_exponentiation,no_spaces_inside_parenthesis.test',
  321. ],
  322. true
  323. );
  324. }
  325. );
  326. }
  327. public function testPriorityIntegrationDirectoryOnlyContainsFiles()
  328. {
  329. foreach (new \DirectoryIterator($this->getIntegrationPriorityDirectory()) as $candidate) {
  330. if ($candidate->isDot()) {
  331. continue;
  332. }
  333. $fileName = $candidate->getFilename();
  334. static::assertTrue($candidate->isFile(), sprintf('Expected only files in the priority integration test directory, got "%s".', $fileName));
  335. static::assertFalse($candidate->isLink(), sprintf('No (sym)links expected the priority integration test directory, got "%s".', $fileName));
  336. }
  337. }
  338. /**
  339. * @dataProvider provideIntegrationTestFilesCases
  340. *
  341. * @param string $fileName
  342. */
  343. public function testPriorityIntegrationTestFilesAreListedPriorityCases($fileName)
  344. {
  345. static $priorityCases;
  346. if (null === $priorityCases) {
  347. $priorityCases = [];
  348. foreach ($this->provideFixersPriorityCases() as $priorityCase) {
  349. $fixerName = $priorityCase[0]->getName();
  350. if (!isset($priorityCases[$fixerName])) {
  351. $priorityCases[$fixerName] = [];
  352. }
  353. $priorityCases[$fixerName][$priorityCase[1]->getName()] = true;
  354. }
  355. ksort($priorityCases);
  356. }
  357. if (\in_array($fileName, [
  358. 'braces,indentation_type,no_break_comment.test',
  359. ], true)) {
  360. static::markTestIncomplete(sprintf('Case "%s" has unexpected name, please help fixing it.', $fileName));
  361. }
  362. if (\in_array($fileName, [
  363. 'combine_consecutive_issets,no_singleline_whitespace_before_semicolons.test',
  364. ], true)) {
  365. static::markTestIncomplete(sprintf('Case "%s" is not fully handled, please help fixing it.', $fileName));
  366. }
  367. static::assertSame(
  368. 1,
  369. preg_match('#^([a-z][a-z0-9_]*),([a-z][a-z_]*)(?:_\d{1,3})?\.test(-(in|out)\.php)?$#', $fileName, $matches),
  370. sprintf('File with unexpected name "%s" in the priority integration test directory.', $fileName)
  371. );
  372. $fixerName1 = $matches[1];
  373. $fixerName2 = $matches[2];
  374. static::assertTrue(
  375. isset($priorityCases[$fixerName1][$fixerName2]) || isset($priorityCases[$fixerName2][$fixerName1]),
  376. sprintf('Missing priority test entry for file "%s".', $fileName)
  377. );
  378. }
  379. public function provideIntegrationTestFilesCases()
  380. {
  381. $fileNames = [];
  382. foreach (new \DirectoryIterator($this->getIntegrationPriorityDirectory()) as $candidate) {
  383. if ($candidate->isDot()) {
  384. continue;
  385. }
  386. $fileNames[] = [$candidate->getFilename()];
  387. }
  388. sort($fileNames);
  389. return $fileNames;
  390. }
  391. public function testProvideFixersPriorityCasesAreSorted()
  392. {
  393. $cases = $this->provideFixersPriorityCases();
  394. $sorted = $cases;
  395. usort(
  396. $sorted,
  397. static function (array $priorityPair1, array $priorityPair2) {
  398. /** @var FixerInterface $fixer */
  399. $fixer1 = $priorityPair1[0];
  400. /** @var FixerInterface $fixer */
  401. $fixer2 = $priorityPair2[0];
  402. if ($fixer1->getName() === $fixer2->getName()) {
  403. /** @var FixerInterface $fixer */
  404. $fixer1 = $priorityPair1[1];
  405. /** @var FixerInterface $fixer */
  406. $fixer2 = $priorityPair2[1];
  407. }
  408. return strcmp($fixer1->getName(), $fixer2->getName());
  409. }
  410. );
  411. if ($sorted !== $cases) { // PHPUnit takes a very long time creating a diff view on the arrays
  412. $casesDescription = '';
  413. foreach ($cases as $pair) {
  414. $casesDescription .= sprintf("\n%s/%s", $pair[0]->getName(), $pair[1]->getName());
  415. }
  416. $sortedDescription = '';
  417. foreach ($sorted as $pair) {
  418. $sortedDescription .= sprintf("\n%s/%s", $pair[0]->getName(), $pair[1]->getName());
  419. }
  420. static::assertSame($sortedDescription, $casesDescription);
  421. } else {
  422. $this->addToAssertionCount(1);
  423. }
  424. }
  425. public function testFixerPriorityComment()
  426. {
  427. $cases = array_merge(
  428. $this->provideFixersPriorityCases(),
  429. $this->provideFixersPrioritySpecialPhpdocCases()
  430. );
  431. $map = [];
  432. foreach ($cases as $beforeAfter) {
  433. list($before, $after) = $beforeAfter;
  434. $beforeClass = \get_class($before);
  435. $afterClass = \get_class($after);
  436. $beforeName = substr($beforeClass, strrpos($beforeClass, '\\') + 1);
  437. $afterName = substr($afterClass, strrpos($afterClass, '\\') + 1);
  438. if (!isset($map[$beforeName])) {
  439. $map[$beforeName] = [
  440. 'before' => [],
  441. 'after' => [],
  442. 'class' => $beforeClass,
  443. ];
  444. }
  445. $map[$beforeName]['before'][] = $afterName;
  446. if (!isset($map[$afterName])) {
  447. $map[$afterName] = [
  448. 'before' => [],
  449. 'after' => [],
  450. 'class' => $afterClass,
  451. ];
  452. }
  453. $map[$afterName]['after'][] = $beforeName;
  454. }
  455. $fixersPhpDocIssues = [];
  456. foreach ($map as $fixerName => $priorityMap) {
  457. $expectedMessage = "/**\n * {@inheritdoc}\n *";
  458. if (\count($priorityMap['before']) > 0) {
  459. sort($priorityMap['before']);
  460. $expectedMessage .= sprintf("\n * Must run before %s.", implode(', ', $priorityMap['before']));
  461. }
  462. if (\count($priorityMap['after']) > 0) {
  463. sort($priorityMap['after']);
  464. $expectedMessage .= sprintf("\n * Must run after %s.", implode(', ', $priorityMap['after']));
  465. }
  466. $expectedMessage .= "\n */";
  467. $reflection = new \ReflectionClass($priorityMap['class']);
  468. $method = $reflection->getMethod('getPriority');
  469. $phpDoc = $method->getDocComment();
  470. if (false === $phpDoc) {
  471. $fixersPhpDocIssues[$fixerName] = sprintf("PHPDoc for %s::getPriority is missing.\nExpected:\n%s", $fixerName, $expectedMessage);
  472. continue;
  473. }
  474. if ($expectedMessage !== $phpDoc) {
  475. $fixersPhpDocIssues[$fixerName] = sprintf("PHPDoc for %s::getPriority is not as expected.\nExpected:\n%s", $fixerName, $expectedMessage);
  476. continue;
  477. }
  478. }
  479. if (0 === \count($fixersPhpDocIssues)) {
  480. $this->addToAssertionCount(1);
  481. } else {
  482. $message = sprintf("There are %d priority PHPDoc issues found.\n", \count($fixersPhpDocIssues));
  483. ksort($fixersPhpDocIssues);
  484. foreach ($fixersPhpDocIssues as $fixerName => $issue) {
  485. $message .= sprintf("\n--------------------------------------------------\n%s\n%s", $fixerName, $issue);
  486. }
  487. static::fail($message);
  488. }
  489. }
  490. /**
  491. * @return string
  492. */
  493. private function generateIntegrationTestName(FixerInterface $first, FixerInterface $second)
  494. {
  495. return "{$first->getName()},{$second->getName()}.test";
  496. }
  497. /**
  498. * @return string
  499. */
  500. private function getIntegrationPriorityDirectory()
  501. {
  502. return __DIR__.'/../Fixtures/Integration/priority/';
  503. }
  504. }