Browse Source

NoMultilineWhitespaceBeforeSemicolonsFixer - SpaceAfterSemicolonFixer - priority fix

SpacePossum 7 years ago
parent
commit
e4595bebf6

+ 8 - 0
src/Fixer/Semicolon/SpaceAfterSemicolonFixer.php

@@ -41,6 +41,14 @@ final class SpaceAfterSemicolonFixer extends AbstractFixer
         );
     }
 
+    /**
+     * {@inheritdoc}
+     */
+    public function getPriority()
+    {
+        return -1; // Must run after NoMultilineWhitespaceBeforeSemicolonsFixer
+    }
+
     /**
      * {@inheritdoc}
      */

+ 1 - 0
tests/AutoReview/FixerFactoryTest.php

@@ -164,6 +164,7 @@ final class FixerFactoryTest extends TestCase
             array($fixers['function_to_constant'], $fixers['no_singleline_whitespace_before_semicolons']), // tested also in: function_to_constant,no_singleline_whitespace_before_semicolons.test
             array($fixers['function_to_constant'], $fixers['no_trailing_whitespace']), // tested also in: function_to_constant,no_trailing_whitespace.test
             array($fixers['function_to_constant'], $fixers['no_whitespace_in_blank_line']), // tested also in: function_to_constant,no_whitespace_in_blank_line.test
+            array($fixers['no_multiline_whitespace_before_semicolons'], $fixers['space_after_semicolon']), // tested also in: tests/Fixtures/Integration/priority/no_multiline_whitespace_before_semicolons,space_after_semicolon.test
         );
 
         // prepare bulk tests for phpdoc fixers to test that:

+ 16 - 0
tests/Fixtures/Integration/priority/no_multiline_whitespace_before_semicolons,space_after_semicolon.test

@@ -0,0 +1,16 @@
+--TEST--
+Integration of fixers: no_multiline_whitespace_before_semicolons,space_after_semicolon.
+--RULESET--
+{"no_multiline_whitespace_before_semicolons": true, "space_after_semicolon": true}
+--EXPECT--
+<?php
+
+for ($i = 0; ; ++$i) {
+}
+
+--INPUT--
+<?php
+
+for ($i = 0;
+; ++$i) {
+}