Browse Source

minor #3550 AutoReview\FixerFactoryTest - fix missing priority test, mark not fully valid test as incomplete (keradus)

This PR was merged into the 2.10 branch.

Discussion
----------

AutoReview\FixerFactoryTest - fix missing priority test, mark not fully valid test as incomplete

Broken after #3518

For now, I'm fixing what's super easy to fix and marking incomplete what need to be rethinked.

Commits
-------

bbe20463 AutoReview\FixerFactoryTest - fix missing priority test, mark not fully valid test as incomplete
Dariusz Ruminski 7 years ago
parent
commit
dd2c5c229f
1 changed files with 8 additions and 0 deletions
  1. 8 0
      tests/AutoReview/FixerFactoryTest.php

+ 8 - 0
tests/AutoReview/FixerFactoryTest.php

@@ -76,6 +76,7 @@ final class FixerFactoryTest extends TestCase
             [$fixers['declare_strict_types'], $fixers['blank_line_after_opening_tag']],
             [$fixers['declare_strict_types'], $fixers['declare_equal_normalize']],
             [$fixers['declare_strict_types'], $fixers['single_blank_line_before_namespace']],
+            [$fixers['doctrine_annotation_array_assignment'], $fixers['doctrine_annotation_spaces']],
             [$fixers['elseif'], $fixers['braces']],
             [$fixers['escape_implicit_backslashes'], $fixers['heredoc_to_nowdoc']],
             [$fixers['escape_implicit_backslashes'], $fixers['single_quote']],
@@ -326,6 +327,13 @@ final class FixerFactoryTest extends TestCase
             $fileName = $candidate->getFilename();
             $this->assertTrue($candidate->isFile(), sprintf('Expected only files in the priority integration test directory, got "%s".', $fileName));
             $this->assertFalse($candidate->isLink(), sprintf('No (sym)links expected the priority integration test directory, got "%s".', $fileName));
+
+            if (in_array($fileName, [
+                'braces,indentation_type,no_break_comment.test',
+            ], true)) {
+                $this->markTestIncomplete(sprintf('Case "%s" has unexpected name, please help fixing it.', $fileName));
+            }
+
             $this->assertSame(
                 1,
                 preg_match('#^([a-z][a-z0-9_]*),([a-z][a-z_]*)(?:_\d{1,3})?\.test$#', $fileName, $matches),