Browse Source

minor #2413 Update Symfony ruleset (fabpot)

This PR was merged into the 2.0-dev branch.

Discussion
----------

Update Symfony ruleset

We've just upgraded PHP-CS-Fixer to 2.0 and we now have a lot of recommendations that we don't want to get on Symfony. The `heredoc` one being one of them.

Another rule we don't want, but I didn't find where this is enabled, is the conversion of one-line anonymous functions to multiline ones. Anyone knowns which rule we should disable to avoid that (http://fabbot.io/report/symfony/symfony/20907/a2c7e0634dc7052562b0d42bff5b141b638b7d18 has an example)? Thanks.

Commits
-------

750335da removed from the Symfony ruleset rules that we don't want on Symfony
Dariusz Ruminski 8 years ago
parent
commit
da4576d689
2 changed files with 2 additions and 4 deletions
  1. 2 2
      README.rst
  2. 0 2
      src/RuleSet.php

+ 2 - 2
README.rst

@@ -259,7 +259,7 @@ Choose from the list of available rules:
    | Add, replace or remove header comment.
    | *Rule is: configurable.*
 
-* **heredoc_to_nowdoc** [@Symfony]
+* **heredoc_to_nowdoc**
    | Convert ``heredoc`` to ``nowdoc`` where possible.
 
 * **include** [@Symfony]
@@ -393,7 +393,7 @@ Choose from the list of available rules:
    | Removes unneeded parentheses around control statements.
    | *Rule is: configurable.*
 
-* **no_unreachable_default_argument_value** [@Symfony]
+* **no_unreachable_default_argument_value**
    | In method arguments there must not be arguments with default values
    | before non-default ones.
 

+ 0 - 2
src/RuleSet.php

@@ -65,7 +65,6 @@ final class RuleSet implements RuleSetInterface
             'declare_equal_normalize' => true,
             'function_typehint_space' => true,
             'hash_to_slash_comment' => true,
-            'heredoc_to_nowdoc' => true,
             'include' => true,
             'lowercase_cast' => true,
             'method_separation' => true,
@@ -95,7 +94,6 @@ final class RuleSet implements RuleSetInterface
             'no_trailing_comma_in_list_call' => true,
             'no_trailing_comma_in_singleline_array' => true,
             'no_unneeded_control_parentheses' => true,
-            'no_unreachable_default_argument_value' => true,
             'no_unused_imports' => true,
             'no_whitespace_before_comma_in_array' => true,
             'no_whitespace_in_blank_line' => true,