Browse Source

DX: remove unused FixerFileProcessedEvent::STATUS_UNKNOWN (#6516)

Dariusz Rumiński 2 years ago
parent
commit
22804e8295

+ 2 - 3
src/Console/Output/ProcessOutput.php

@@ -29,11 +29,10 @@ final class ProcessOutput implements ProcessOutputInterface
      * File statuses map.
      */
     private static array $eventStatusMap = [
-        FixerFileProcessedEvent::STATUS_UNKNOWN => ['symbol' => '?', 'format' => '%s', 'description' => 'unknown'],
-        FixerFileProcessedEvent::STATUS_INVALID => ['symbol' => 'I', 'format' => '<bg=red>%s</bg=red>', 'description' => 'invalid file syntax (file ignored)'],
-        FixerFileProcessedEvent::STATUS_SKIPPED => ['symbol' => 'S', 'format' => '<fg=cyan>%s</fg=cyan>', 'description' => 'skipped (cached or empty file)'],
         FixerFileProcessedEvent::STATUS_NO_CHANGES => ['symbol' => '.', 'format' => '%s', 'description' => 'no changes'],
         FixerFileProcessedEvent::STATUS_FIXED => ['symbol' => 'F', 'format' => '<fg=green>%s</fg=green>', 'description' => 'fixed'],
+        FixerFileProcessedEvent::STATUS_SKIPPED => ['symbol' => 'S', 'format' => '<fg=cyan>%s</fg=cyan>', 'description' => 'skipped (cached or empty file)'],
+        FixerFileProcessedEvent::STATUS_INVALID => ['symbol' => 'I', 'format' => '<bg=red>%s</bg=red>', 'description' => 'invalid file syntax (file ignored)'],
         FixerFileProcessedEvent::STATUS_EXCEPTION => ['symbol' => 'E', 'format' => '<bg=red>%s</bg=red>', 'description' => 'error'],
         FixerFileProcessedEvent::STATUS_LINT => ['symbol' => 'E', 'format' => '<bg=red>%s</bg=red>', 'description' => 'error'],
     ];

+ 0 - 1
src/FixerFileProcessedEvent.php

@@ -30,7 +30,6 @@ final class FixerFileProcessedEvent extends Event
      */
     public const NAME = 'fixer.file_processed';
 
-    public const STATUS_UNKNOWN = 0;
     public const STATUS_INVALID = 1;
     public const STATUS_SKIPPED = 2;
     public const STATUS_NO_CHANGES = 3;

+ 6 - 6
tests/Console/Output/ProcessOutputTest.php

@@ -125,12 +125,12 @@ final class ProcessOutputTest extends TestCase
                     [FixerFileProcessedEvent::STATUS_NO_CHANGES],
                     [FixerFileProcessedEvent::STATUS_INVALID],
                     [FixerFileProcessedEvent::STATUS_NO_CHANGES, 40],
-                    [FixerFileProcessedEvent::STATUS_UNKNOWN],
+                    [FixerFileProcessedEvent::STATUS_INVALID],
                     [FixerFileProcessedEvent::STATUS_NO_CHANGES, 15],
                 ],
                 '...................E......EFFF.................................  63 / 189 ( 33%)'.PHP_EOL.
                 '.................S............................................. 126 / 189 ( 67%)'.PHP_EOL.
-                '....I.I........................................?............... 189 / 189 (100%)',
+                '....I.I........................................I............... 189 / 189 (100%)',
                 80,
             ],
             [
@@ -147,12 +147,12 @@ final class ProcessOutputTest extends TestCase
                     [FixerFileProcessedEvent::STATUS_NO_CHANGES],
                     [FixerFileProcessedEvent::STATUS_INVALID],
                     [FixerFileProcessedEvent::STATUS_NO_CHANGES, 40],
-                    [FixerFileProcessedEvent::STATUS_UNKNOWN],
+                    [FixerFileProcessedEvent::STATUS_INVALID],
                     [FixerFileProcessedEvent::STATUS_NO_CHANGES, 15],
                 ],
                 '...................E......EFFF.................................  63 / 189 ( 33%)'.PHP_EOL.
                 '.................S............................................. 126 / 189 ( 67%)'.PHP_EOL.
-                '....I.I........................................?............... 189 / 189 (100%)',
+                '....I.I........................................I............... 189 / 189 (100%)',
                 80,
             ],
             [
@@ -169,11 +169,11 @@ final class ProcessOutputTest extends TestCase
                     [FixerFileProcessedEvent::STATUS_NO_CHANGES],
                     [FixerFileProcessedEvent::STATUS_INVALID],
                     [FixerFileProcessedEvent::STATUS_NO_CHANGES, 40],
-                    [FixerFileProcessedEvent::STATUS_UNKNOWN],
+                    [FixerFileProcessedEvent::STATUS_INVALID],
                     [FixerFileProcessedEvent::STATUS_NO_CHANGES, 15],
                 ],
                 '...................E......EFFF..................................................S...................... 103 / 189 ( 54%)'.PHP_EOL.
-                '...........................I.I........................................?...............                  189 / 189 (100%)',
+                '...........................I.I........................................I...............                  189 / 189 (100%)',
                 120,
             ],
         ];

+ 1 - 1
tests/Smoke/CiIntegrationTest.php

@@ -179,7 +179,7 @@ Ignoring environment requirements because `PHP_CS_FIXER_IGNORE_ENV` is set. Exec
             preg_quote('Loaded config default from ".php-cs-fixer.dist.php".', '/'),
             \strlen($expectedResult3FilesDots),
             preg_quote($expectedResult3FilesPercentage, '/'),
-            preg_quote('Legend: ?-unknown, I-invalid file syntax (file ignored), S-skipped (cached or empty file), .-no changes, F-fixed, E-error', '/')
+            preg_quote('Legend: .-no changes, F-fixed, S-skipped (cached or empty file), I-invalid file syntax (file ignored), E-error', '/')
         );
 
         static::assertMatchesRegularExpression($pattern, $result3->getError());