Browse Source

chore: use ::class more (#7545)

Dariusz Rumiński 1 year ago
parent
commit
1dc9c052c0

+ 1 - 1
src/AbstractPhpdocToTypeDeclarationFixer.php

@@ -236,7 +236,7 @@ abstract class AbstractPhpdocToTypeDeclarationFixer extends AbstractFixer implem
             $typeExpression = new TypeExpression($type, null, []);
             $commonType = $typeExpression->getCommonType();
 
-            if (!$containsOtherThanIterableType && !\in_array($commonType, ['array', 'Traversable', 'iterable'], true)) {
+            if (!$containsOtherThanIterableType && !\in_array($commonType, ['array', \Traversable::class, 'iterable'], true)) {
                 $containsOtherThanIterableType = true;
             }
             if ($isReturnType && !$containsOtherThanEmptyType && !\in_array($commonType, ['null', 'void', 'never'], true)) {

+ 1 - 1
src/Fixer/FunctionNotation/DateTimeCreateFromFormatCallFixer.php

@@ -87,7 +87,7 @@ final class DateTimeCreateFromFormatCallFixer extends AbstractFixer
 
                 $classNameIndex = $tokens->getPrevMeaningfulToken($index);
 
-                if (!$tokens[$classNameIndex]->equalsAny([[T_STRING, 'DateTime'], [T_STRING, 'DateTimeImmutable']], false)) {
+                if (!$tokens[$classNameIndex]->equalsAny([[T_STRING, \DateTime::class], [T_STRING, \DateTimeImmutable::class]], false)) {
                     continue;
                 }
 

+ 1 - 1
tests/AutoReview/ProjectCodeTest.php

@@ -653,7 +653,7 @@ final class ProjectCodeTest extends TestCase
                 if (1 === $interfacesCount) {
                     $interface = reset($interfaces);
 
-                    if ('Stringable' === $interface->getName()) {
+                    if (\Stringable::class === $interface->getName()) {
                         return false;
                     }
                 }

+ 1 - 1
tests/DocBlock/AnnotationTest.php

@@ -619,7 +619,7 @@ final class AnnotationTest extends TestCase
     public static function provideGetTypeExpressionCases(): iterable
     {
         $appNamespace = new NamespaceAnalysis('App', 'App', 0, 999, 0, 999);
-        $useTraversable = new NamespaceUseAnalysis('Traversable', 'Traversable', false, 0, 999, NamespaceUseAnalysis::TYPE_CLASS);
+        $useTraversable = new NamespaceUseAnalysis(\Traversable::class, \Traversable::class, false, 0, 999, NamespaceUseAnalysis::TYPE_CLASS);
 
         yield ['* @param array|Traversable $foo', null, [], 'iterable'];
 

+ 4 - 4
tests/DocBlock/TypeExpressionTest.php

@@ -191,7 +191,7 @@ final class TypeExpressionTest extends TestCase
 
         yield ['\\closure(string): void'];
 
-        yield ['\\Closure'];
+        yield [\Closure::class];
 
         yield ['\\Closure()'];
 
@@ -456,8 +456,8 @@ final class TypeExpressionTest extends TestCase
         $globalNamespace = new NamespaceAnalysis('', '', 0, 999, 0, 999);
         $appNamespace = new NamespaceAnalysis('App', 'App', 0, 999, 0, 999);
 
-        $useTraversable = new NamespaceUseAnalysis('Traversable', 'Traversable', false, 0, 0, NamespaceUseAnalysis::TYPE_CLASS);
-        $useObjectAsTraversable = new NamespaceUseAnalysis('Foo', 'Traversable', false, 0, 0, NamespaceUseAnalysis::TYPE_CLASS);
+        $useTraversable = new NamespaceUseAnalysis(\Traversable::class, \Traversable::class, false, 0, 0, NamespaceUseAnalysis::TYPE_CLASS);
+        $useObjectAsTraversable = new NamespaceUseAnalysis('Foo', \Traversable::class, false, 0, 0, NamespaceUseAnalysis::TYPE_CLASS);
 
         yield ['true', 'bool'];
 
@@ -539,7 +539,7 @@ final class TypeExpressionTest extends TestCase
 
         yield ['array { 1: string, \Closure(): void }', 'array'];
 
-        yield ['Closure(): void', 'Closure'];
+        yield ['Closure(): void', \Closure::class];
 
         yield ['array<int, string>|iterable<int, string>', 'iterable'];
 

+ 1 - 1
tests/Fixer/FunctionNotation/DateTimeCreateFromFormatCallFixerTest.php

@@ -33,7 +33,7 @@ final class DateTimeCreateFromFormatCallFixerTest extends AbstractFixerTestCase
 
     public static function provideFixCases(): iterable
     {
-        foreach (['DateTime', 'DateTimeImmutable'] as $class) {
+        foreach ([\DateTime::class, \DateTimeImmutable::class] as $class) {
             $lowerCaseClass = strtolower($class);
             $upperCaseClass = strtoupper($class);