conanfile.py 23 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442
  1. import os
  2. from pathlib import Path
  3. from jinja2 import Template
  4. from conans import tools
  5. from conan import ConanFile
  6. from conan.tools import files
  7. from conan.tools.env import VirtualRunEnv, Environment
  8. from conan.errors import ConanInvalidConfiguration
  9. required_conan_version = ">=1.48.0"
  10. class CuraConan(ConanFile):
  11. name = "cura"
  12. license = "LGPL-3.0"
  13. author = "Ultimaker B.V."
  14. url = "https://github.com/Ultimaker/cura"
  15. description = "3D printer / slicing GUI built on top of the Uranium framework"
  16. topics = ("conan", "python", "pyqt5", "qt", "qml", "3d-printing", "slicer")
  17. build_policy = "missing"
  18. exports = "LICENSE*", "Ultimaker-Cura.spec.jinja", "CuraVersion.py.jinja"
  19. settings = "os", "compiler", "build_type", "arch"
  20. no_copy_source = True # We won't build so no need to copy sources to the build folder
  21. # FIXME: Remove specific branch once merged to main
  22. # Extending the conanfile with the UMBaseConanfile https://github.com/Ultimaker/conan-ultimaker-index/tree/CURA-9177_Fix_CI_CD/recipes/umbase
  23. python_requires = "umbase/0.1.5@ultimaker/testing"
  24. python_requires_extend = "umbase.UMBaseConanfile"
  25. options = {
  26. "enterprise": ["True", "False", "true", "false"], # Workaround for GH Action passing boolean as lowercase string
  27. "staging": ["True", "False", "true", "false"], # Workaround for GH Action passing boolean as lowercase string
  28. "devtools": [True, False], # FIXME: Split this up in testing and (development / build (pyinstaller) / system installer) tools
  29. "cloud_api_version": "ANY",
  30. "display_name": "ANY", # TODO: should this be an option??
  31. "cura_debug_mode": [True, False], # FIXME: Use profiles
  32. "internal": [True, False]
  33. }
  34. default_options = {
  35. "enterprise": "False",
  36. "staging": "False",
  37. "devtools": False,
  38. "cloud_api_version": "1",
  39. "display_name": "Ultimaker Cura",
  40. "cura_debug_mode": False, # Not yet implemented
  41. "internal": False,
  42. }
  43. scm = {
  44. "type": "git",
  45. "subfolder": ".",
  46. "url": "auto",
  47. "revision": "auto"
  48. }
  49. @property
  50. def _pycharm_targets(self):
  51. return self.conan_data["pycharm_targets"]
  52. # FIXME: These env vars should be defined in the runenv.
  53. _cura_env = None
  54. @property
  55. def _cura_run_env(self):
  56. if self._cura_env:
  57. return self._cura_env
  58. self._cura_env = Environment()
  59. self._cura_env.define("QML2_IMPORT_PATH", str(self._site_packages.joinpath("PyQt6", "Qt6", "qml")))
  60. self._cura_env.define("QT_PLUGIN_PATH", str(self._site_packages.joinpath("PyQt6", "Qt6", "plugins")))
  61. if self.settings.os == "Linux":
  62. self._cura_env.define("QT_QPA_FONTDIR", "/usr/share/fonts")
  63. self._cura_env.define("QT_QPA_PLATFORMTHEME", "xdgdesktopportal")
  64. self._cura_env.define("QT_XKB_CONFIG_ROOT", "/usr/share/X11/xkb")
  65. return self._cura_env
  66. @property
  67. def _staging(self):
  68. return self.options.staging in ["True", 'true']
  69. @property
  70. def _enterprise(self):
  71. return self.options.enterprise in ["True", 'true']
  72. @property
  73. def _cloud_api_root(self):
  74. return "https://api-staging.ultimaker.com" if self._staging else "https://api.ultimaker.com"
  75. @property
  76. def _cloud_account_api_root(self):
  77. return "https://account-staging.ultimaker.com" if self._staging else "https://account.ultimaker.com"
  78. @property
  79. def _marketplace_root(self):
  80. return "https://marketplace-staging.ultimaker.com" if self._staging else "https://marketplace.ultimaker.com"
  81. @property
  82. def _digital_factory_url(self):
  83. return "https://digitalfactory-staging.ultimaker.com" if self._staging else "https://digitalfactory.ultimaker.com"
  84. @property
  85. def _cura_latest_url(self):
  86. return "https://software.ultimaker.com/latest.json"
  87. @property
  88. def requirements_txts(self):
  89. if self.options.devtools:
  90. return ["requirements.txt", "requirements-ultimaker.txt", "requirements-dev.txt"]
  91. return ["requirements.txt", "requirements-ultimaker.txt"]
  92. @property
  93. def _base_dir(self):
  94. if self.install_folder is None:
  95. if self.build_folder is not None:
  96. return Path(self.build_folder)
  97. return Path(os.getcwd(), "venv")
  98. if self.in_local_cache:
  99. return Path(self.install_folder)
  100. else:
  101. return Path(self.source_folder, "venv")
  102. @property
  103. def _share_dir(self):
  104. return self._base_dir.joinpath("share")
  105. @property
  106. def _script_dir(self):
  107. if self.settings.os == "Windows":
  108. return self._base_dir.joinpath("Scripts")
  109. return self._base_dir.joinpath("bin")
  110. @property
  111. def _site_packages(self):
  112. if self.settings.os == "Windows":
  113. return self._base_dir.joinpath("Lib", "site-packages")
  114. py_version = tools.Version(self.deps_cpp_info["cpython"].version)
  115. return self._base_dir.joinpath("lib", f"python{py_version.major}.{py_version.minor}", "site-packages")
  116. @property
  117. def _py_interp(self):
  118. py_interp = self._script_dir.joinpath(Path(self.deps_user_info["cpython"].python).name)
  119. if self.settings.os == "Windows":
  120. py_interp = Path(*[f'"{p}"' if " " in p else p for p in py_interp.parts])
  121. return py_interp
  122. def _generate_cura_version(self, location):
  123. with open(Path(__file__).parent.joinpath("CuraVersion.py.jinja"), "r") as f:
  124. cura_version_py = Template(f.read())
  125. cura_version = self.version
  126. if self.options.internal:
  127. version = tools.Version(self.version)
  128. cura_version = f"{version.major}.{version.minor}.{version.patch}-{version.prerelease.replace('+', '+internal_')}"
  129. with open(Path(location, "CuraVersion.py"), "w") as f:
  130. f.write(cura_version_py.render(
  131. cura_app_name = self.name,
  132. cura_app_display_name = self.options.display_name,
  133. cura_version = cura_version,
  134. cura_build_type = "Enterprise" if self._enterprise else "",
  135. cura_debug_mode = self.options.cura_debug_mode,
  136. cura_cloud_api_root = self._cloud_api_root,
  137. cura_cloud_api_version = self.options.cloud_api_version,
  138. cura_cloud_account_api_root = self._cloud_account_api_root,
  139. cura_marketplace_root = self._marketplace_root,
  140. cura_digital_factory_url = self._digital_factory_url,
  141. cura_latest_url = self._cura_latest_url))
  142. def _generate_pyinstaller_spec(self, location, entrypoint_location, icon_path, entitlements_file):
  143. pyinstaller_metadata = self._um_data()["pyinstaller"]
  144. datas = [(str(self._base_dir.joinpath("conan_install_info.json")), ".")]
  145. for data in pyinstaller_metadata["datas"].values():
  146. if not self.options.internal and data.get("internal", False):
  147. continue
  148. if "package" in data: # get the paths from conan package
  149. if data["package"] == self.name:
  150. if self.in_local_cache:
  151. src_path = Path(self.package_folder, data["src"])
  152. else:
  153. src_path = Path(self.source_folder, data["src"])
  154. else:
  155. src_path = Path(self.deps_cpp_info[data["package"]].rootpath, data["src"])
  156. elif "root" in data: # get the paths relative from the sourcefolder
  157. src_path = Path(self.source_folder, data["root"], data["src"])
  158. else:
  159. continue
  160. if src_path.exists():
  161. datas.append((str(src_path), data["dst"]))
  162. binaries = []
  163. for binary in pyinstaller_metadata["binaries"].values():
  164. if "package" in binary: # get the paths from conan package
  165. src_path = Path(self.deps_cpp_info[binary["package"]].rootpath, binary["src"])
  166. elif "root" in binary: # get the paths relative from the sourcefolder
  167. src_path = Path(self.source_folder, binary["root"], binary["src"])
  168. else:
  169. continue
  170. if not src_path.exists():
  171. continue
  172. for bin in src_path.glob(binary["binary"] + ".*[exe|dll|so|dylib]"):
  173. binaries.append((str(bin), binary["dst"]))
  174. for bin in src_path.glob(binary["binary"]):
  175. binaries.append((str(bin), binary["dst"]))
  176. for _, dependency in self.dependencies.items():
  177. for bin_paths in dependency.cpp_info.bindirs:
  178. binaries.extend([(f"{p}", ".") for p in Path(bin_paths).glob("**/*.dll")])
  179. binaries.extend([(f"{p}", ".") for p in Path(bin_paths).glob("**/*.dylib")])
  180. binaries.extend([(f"{p}", ".") for p in Path(bin_paths).glob("**/*.so")])
  181. # Copy dynamic libs from lib path
  182. binaries.extend([(f"{p}", ".") for p in Path(self._base_dir.joinpath("lib")).glob("**/*.dylib")])
  183. # Collect all dll's from PyQt6 and place them in the root
  184. binaries.extend([(f"{p}", ".") for p in Path(self._site_packages, "PyQt6", "Qt6").glob("**/*.dll")])
  185. with open(Path(__file__).parent.joinpath("Ultimaker-Cura.spec.jinja"), "r") as f:
  186. pyinstaller = Template(f.read())
  187. cura_version = tools.Version(self.version) if self.version else tools.Version("0.0.0")
  188. with open(Path(location, "Ultimaker-Cura.spec"), "w") as f:
  189. f.write(pyinstaller.render(
  190. name = str(self.options.display_name).replace(" ", "-"),
  191. display_name = self.options.display_name,
  192. entrypoint = entrypoint_location,
  193. datas = datas,
  194. binaries = binaries,
  195. venv_script_path = str(self._script_dir),
  196. hiddenimports = pyinstaller_metadata["hiddenimports"],
  197. collect_all = pyinstaller_metadata["collect_all"],
  198. icon = icon_path,
  199. entitlements_file = entitlements_file,
  200. osx_bundle_identifier = "'nl.ultimaker.cura'" if self.settings.os == "Macos" else "None",
  201. upx = str(self.settings.os == "Windows"),
  202. strip = False, # This should be possible on Linux and MacOS but, it can also cause issues on some distributions. Safest is to disable it for now
  203. target_arch = "'x86_64'" if self.settings.os == "Macos" else "None", # FIXME: Make this dependent on the settings.arch_target
  204. macos = self.settings.os == "Macos",
  205. version = f"'{self.version}'",
  206. short_version = f"'{cura_version.major}.{cura_version.minor}.{cura_version.patch}'",
  207. ))
  208. def configure(self):
  209. self.options["pyarcus"].shared = True
  210. self.options["pysavitar"].shared = True
  211. self.options["pynest2d"].shared = True
  212. self.options["cpython"].shared = True
  213. def validate(self):
  214. if self.version and tools.Version(self.version) <= tools.Version("4"):
  215. raise ConanInvalidConfiguration("Only versions 5+ are support")
  216. def requirements(self):
  217. for req in self._um_data()["requirements"]:
  218. self.requires(req)
  219. if self.options.internal:
  220. for req in self._um_data()["internal_requirements"]:
  221. self.requires(req)
  222. def layout(self):
  223. self.folders.source = "."
  224. self.folders.build = "venv"
  225. self.folders.generators = Path(self.folders.build, "conan")
  226. self.cpp.package.libdirs = [os.path.join("site-packages", "cura")]
  227. self.cpp.package.bindirs = ["bin"]
  228. self.cpp.package.resdirs = ["resources", "plugins", "packaging", "pip_requirements"] # pip_requirements should be the last item in the list
  229. def build(self):
  230. pass
  231. def generate(self):
  232. cura_run_envvars = self._cura_run_env.vars(self, scope = "run")
  233. ext = ".ps1" if self.settings.os == "Windows" else ".sh"
  234. cura_run_envvars.save_script(self.folders.generators.joinpath(f"cura_run_environment{ext}"))
  235. vr = VirtualRunEnv(self)
  236. vr.generate()
  237. self._generate_cura_version(Path(self.source_folder, "cura"))
  238. if self.options.devtools:
  239. entitlements_file = "'{}'".format(Path(self.source_folder, "packaging", "dmg", "cura.entitlements"))
  240. self._generate_pyinstaller_spec(location = self.generators_folder,
  241. entrypoint_location = "'{}'".format(Path(self.source_folder, self._um_data()["runinfo"]["entrypoint"])).replace("\\", "\\\\"),
  242. icon_path = "'{}'".format(Path(self.source_folder, "packaging", self._um_data()["pyinstaller"]["icon"][str(self.settings.os)])).replace("\\", "\\\\"),
  243. entitlements_file = entitlements_file if self.settings.os == "Macos" else "None")
  244. def imports(self):
  245. self.copy("CuraEngine.exe", root_package = "curaengine", src = "@bindirs", dst = "", keep_path = False)
  246. self.copy("CuraEngine", root_package = "curaengine", src = "@bindirs", dst = "", keep_path = False)
  247. files.rmdir(self, "resources/materials")
  248. self.copy("*.fdm_material", root_package = "fdm_materials", src = "@resdirs", dst = "resources/materials", keep_path = False)
  249. self.copy("*.sig", root_package = "fdm_materials", src = "@resdirs", dst = "resources/materials", keep_path = False)
  250. if self.options.internal:
  251. self.copy("*.fdm_material", root_package = "fdm_materials_private", src = "@resdirs", dst = "resources/materials", keep_path = False)
  252. self.copy("*.sig", root_package = "fdm_materials_private", src = "@resdirs", dst = "resources/materials", keep_path = False)
  253. self.copy("*", root_package = "cura_private_data", src = self.deps_cpp_info["cura_private_data"].resdirs[0],
  254. dst = self._share_dir.joinpath("cura", "resources"), keep_path = True)
  255. # Copy resources of cura_binary_data
  256. self.copy("*", root_package = "cura_binary_data", src = self.deps_cpp_info["cura_binary_data"].resdirs[0],
  257. dst = self._share_dir.joinpath("cura", "resources"), keep_path = True)
  258. self.copy("*", root_package = "cura_binary_data", src = self.deps_cpp_info["cura_binary_data"].resdirs[1],
  259. dst =self._share_dir.joinpath("uranium", "resources"), keep_path = True)
  260. self.copy("*.dll", src = "@bindirs", dst = self._site_packages)
  261. self.copy("*.pyd", src = "@libdirs", dst = self._site_packages)
  262. self.copy("*.pyi", src = "@libdirs", dst = self._site_packages)
  263. self.copy("*.dylib", src = "@libdirs", dst = self._script_dir)
  264. def deploy(self):
  265. # Copy CuraEngine.exe to bindirs of Virtual Python Environment
  266. # TODO: Fix source such that it will get the curaengine relative from the executable (Python bindir in this case)
  267. self.copy_deps("CuraEngine.exe", root_package = "curaengine", src = self.deps_cpp_info["curaengine"].bindirs[0],
  268. dst = self._base_dir,
  269. keep_path = False)
  270. self.copy_deps("CuraEngine", root_package = "curaengine", src = self.deps_cpp_info["curaengine"].bindirs[0], dst = self._base_dir,
  271. keep_path = False)
  272. # Copy resources of Cura (keep folder structure)
  273. self.copy("*", src = self.cpp_info.bindirs[0], dst = self._base_dir, keep_path = False)
  274. self.copy("*", src = self.cpp_info.libdirs[0], dst = self._site_packages.joinpath("cura"), keep_path = True)
  275. self.copy("*", src = self.cpp_info.resdirs[0], dst = self._share_dir.joinpath("cura", "resources"), keep_path = True)
  276. self.copy("*", src = self.cpp_info.resdirs[1], dst = self._share_dir.joinpath("cura", "plugins"), keep_path = True)
  277. # Copy materials (flat)
  278. self.copy_deps("*.fdm_material", root_package = "fdm_materials", src = self.deps_cpp_info["fdm_materials"].resdirs[0],
  279. dst = self._share_dir.joinpath("cura", "resources", "materials"), keep_path = False)
  280. self.copy_deps("*.sig", root_package = "fdm_materials", src = self.deps_cpp_info["fdm_materials"].resdirs[0],
  281. dst = self._share_dir.joinpath("cura", "resources", "materials"), keep_path = False)
  282. # Copy internal resources
  283. if self.options.internal:
  284. self.copy_deps("*.fdm_material", root_package = "fdm_materials_private", src = self.deps_cpp_info["fdm_materials_private"].resdirs[0],
  285. dst = self._share_dir.joinpath("cura", "resources", "materials"), keep_path = False)
  286. self.copy_deps("*.sig", root_package = "fdm_materials_private", src = self.deps_cpp_info["fdm_materials_private"].resdirs[0],
  287. dst = self._share_dir.joinpath("cura", "resources", "materials"), keep_path = False)
  288. self.copy_deps("*", root_package = "cura_private_data", src = self.deps_cpp_info["cura_private_data"].resdirs[0],
  289. dst = self._share_dir.joinpath("cura", "resources"), keep_path = True)
  290. # Copy resources of Uranium (keep folder structure)
  291. self.copy_deps("*", root_package = "uranium", src = self.deps_cpp_info["uranium"].resdirs[0],
  292. dst = self._share_dir.joinpath("uranium", "resources"), keep_path = True)
  293. self.copy_deps("*", root_package = "uranium", src = self.deps_cpp_info["uranium"].resdirs[1],
  294. dst = self._share_dir.joinpath("uranium", "plugins"), keep_path = True)
  295. self.copy_deps("*", root_package = "uranium", src = self.deps_cpp_info["uranium"].libdirs[0],
  296. dst = self._site_packages.joinpath("UM"),
  297. keep_path = True)
  298. self.copy_deps("*", root_package = "uranium", src = str(Path(self.deps_cpp_info["uranium"].libdirs[0], "Qt", "qml", "UM")),
  299. dst = self._site_packages.joinpath("PyQt6", "Qt6", "qml", "UM"),
  300. keep_path = True)
  301. # Copy resources of cura_binary_data
  302. self.copy_deps("*", root_package = "cura_binary_data", src = self.deps_cpp_info["cura_binary_data"].resdirs[0],
  303. dst = self._share_dir.joinpath("cura"), keep_path = True)
  304. self.copy_deps("*", root_package = "cura_binary_data", src = self.deps_cpp_info["cura_binary_data"].resdirs[1],
  305. dst = self._share_dir.joinpath("uranium"), keep_path = True)
  306. if self.settings.os == "Windows":
  307. self.copy_deps("*", root_package = "cura_binary_data", src = self.deps_cpp_info["cura_binary_data"].resdirs[2],
  308. dst = self._share_dir.joinpath("windows"), keep_path = True)
  309. self.copy_deps("*.dll", src = "@bindirs", dst = self._site_packages)
  310. self.copy_deps("*.pyd", src = "@libdirs", dst = self._site_packages)
  311. self.copy_deps("*.pyi", src = "@libdirs", dst = self._site_packages)
  312. self.copy_deps("*.dylib", src = "@libdirs", dst = self._base_dir.joinpath("lib"))
  313. # Copy packaging scripts
  314. self.copy("*", src = self.cpp_info.resdirs[2], dst = self._base_dir.joinpath("packaging"))
  315. # Copy requirements.txt's
  316. self.copy("*.txt", src = self.cpp_info.resdirs[-1], dst = self._base_dir.joinpath("pip_requirements"))
  317. # Generate the GitHub Action version info Environment
  318. cura_version = tools.Version(self.version)
  319. env_prefix = "Env:" if self.settings.os == "Windows" else ""
  320. activate_github_actions_version_env = Template(r"""echo "CURA_VERSION_MAJOR={{ cura_version_major }}" >> ${{ env_prefix }}GITHUB_ENV
  321. echo "CURA_VERSION_MINOR={{ cura_version_minor }}" >> ${{ env_prefix }}GITHUB_ENV
  322. echo "CURA_VERSION_PATCH={{ cura_version_patch }}" >> ${{ env_prefix }}GITHUB_ENV
  323. echo "CURA_VERSION_BUILD={{ cura_version_build }}" >> ${{ env_prefix }}GITHUB_ENV
  324. echo "CURA_VERSION_FULL={{ cura_version_full }}" >> ${{ env_prefix }}GITHUB_ENV
  325. """).render(cura_version_major = cura_version.major,
  326. cura_version_minor = cura_version.minor,
  327. cura_version_patch = cura_version.patch,
  328. cura_version_build = cura_version.build if cura_version.build != "" else "0",
  329. cura_version_full = self.version,
  330. env_prefix = env_prefix)
  331. ext = ".sh" if self.settings.os != "Windows" else ".ps1"
  332. files.save(self, self._script_dir.joinpath(f"activate_github_actions_version_env{ext}"), activate_github_actions_version_env)
  333. self._generate_cura_version(Path(self._site_packages, "cura"))
  334. entitlements_file = "'{}'".format(Path(self.cpp_info.res_paths[2], "dmg", "cura.entitlements"))
  335. self._generate_pyinstaller_spec(location = self._base_dir,
  336. entrypoint_location = "'{}'".format(Path(self.cpp_info.bin_paths[0], self._um_data()["runinfo"]["entrypoint"])).replace("\\", "\\\\"),
  337. icon_path = "'{}'".format(Path(self.cpp_info.res_paths[2], self._um_data()["pyinstaller"]["icon"][str(self.settings.os)])).replace("\\", "\\\\"),
  338. entitlements_file = entitlements_file if self.settings.os == "Macos" else "None")
  339. def package(self):
  340. self.copy("cura_app.py", src = ".", dst = self.cpp.package.bindirs[0])
  341. self.copy("*", src = "cura", dst = self.cpp.package.libdirs[0])
  342. self.copy("*", src = "resources", dst = self.cpp.package.resdirs[0])
  343. self.copy("*", src = "plugins", dst = self.cpp.package.resdirs[1])
  344. self.copy("requirement*.txt", src = ".", dst = self.cpp.package.resdirs[-1])
  345. self.copy("*", src = "packaging", dst = self.cpp.package.resdirs[2])
  346. def package_info(self):
  347. self.user_info.pip_requirements = "requirements.txt"
  348. self.user_info.pip_requirements_git = "requirements-ultimaker.txt"
  349. self.user_info.pip_requirements_build = "requirements-dev.txt"
  350. if self.in_local_cache:
  351. self.runenv_info.append_path("PYTHONPATH", str(Path(self.cpp_info.lib_paths[0]).parent))
  352. self.runenv_info.append_path("PYTHONPATH", self.cpp_info.res_paths[1]) # Add plugins to PYTHONPATH
  353. else:
  354. self.runenv_info.append_path("PYTHONPATH", self.source_folder)
  355. self.runenv_info.append_path("PYTHONPATH", os.path.join(self.source_folder, "plugins"))
  356. def package_id(self):
  357. del self.info.settings.os
  358. del self.info.settings.compiler
  359. del self.info.settings.build_type
  360. del self.info.settings.arch
  361. # The following options shouldn't be used to determine the hash, since these are only used to set the CuraVersion.py
  362. # which will als be generated by the deploy method during the `conan install cura/5.1.0@_/_`
  363. del self.info.options.enterprise
  364. del self.info.options.staging
  365. del self.info.options.devtools
  366. del self.info.options.cloud_api_version
  367. del self.info.options.display_name
  368. del self.info.options.cura_debug_mode
  369. # TODO: Use the hash of requirements.txt and requirements-ultimaker.txt, Because changing these will actually result in a different
  370. # Cura. This is needed because the requirements.txt aren't managed by Conan and therefor not resolved in the package_id. This isn't
  371. # ideal but an acceptable solution for now.