Browse Source

Merge branch 'main' into PP-393-ASA-PA12-CF-SR30-Profiles

Casper Lamboo 1 year ago
parent
commit
ffddbc9edb

+ 3 - 6
plugins/XmlMaterialProfile/XmlMaterialProfile.py

@@ -579,9 +579,8 @@ class XmlMaterialProfile(InstanceContainer):
 
 
             meta_data[tag_name] = entry.text
             meta_data[tag_name] = entry.text
 
 
-            for tag_name, value in meta_data.items():
-                if tag_name in self.__material_metadata_setting_map:
-                    common_setting_values[self.__material_metadata_setting_map[tag_name]] = value
+            if tag_name in self.__material_metadata_setting_map:
+                common_setting_values[self.__material_metadata_setting_map[tag_name]] = entry.text
 
 
         if "description" not in meta_data:
         if "description" not in meta_data:
             meta_data["description"] = ""
             meta_data["description"] = ""
@@ -1223,9 +1222,7 @@ class XmlMaterialProfile(InstanceContainer):
         "diameter": "material_diameter"
         "diameter": "material_diameter"
     }
     }
     __material_metadata_setting_map = {
     __material_metadata_setting_map = {
-        "GUID": "material_guid",
-        "material": "material_type",
-        "brand": "material_brand",
+        "GUID": "material_guid"
     }
     }
 
 
     # Map of recognised namespaces with a proper prefix.
     # Map of recognised namespaces with a proper prefix.

+ 2 - 18
resources/definitions/fdmprinter.def.json

@@ -76,22 +76,6 @@
                     "type": "str",
                     "type": "str",
                     "enabled": false
                     "enabled": false
                 },
                 },
-                "material_type":
-                {
-                    "label": "Material Type",
-                    "description": "The type of material used.",
-                    "default_value": "",
-                    "type": "str",
-                    "enabled": false
-                },
-                "material_brand":
-                {
-                    "label": "Material Brand",
-                    "description": "The brand of material used.",
-                    "default_value": "",
-                    "type": "str",
-                    "enabled": false
-                },
                 "material_diameter":
                 "material_diameter":
                 {
                 {
                     "label": "Diameter",
                     "label": "Diameter",
@@ -6799,7 +6783,7 @@
                     "label": "Prime Tower",
                     "label": "Prime Tower",
                     "description": "<html>Print a tower next to the model, which serves to prime the material after each nozzle switch.<ul><li><b>None:</b> do not generate a prime tower</li><li><b>Normal:</b> generate a bucket in which secondary materials are primed</li><li><b>Interleaved:</b> generate a prime tower as sparse as possible. This will save time and filament, but is only possible if the used materials adhere to each other.</li></ul></html>",
                     "description": "<html>Print a tower next to the model, which serves to prime the material after each nozzle switch.<ul><li><b>None:</b> do not generate a prime tower</li><li><b>Normal:</b> generate a bucket in which secondary materials are primed</li><li><b>Interleaved:</b> generate a prime tower as sparse as possible. This will save time and filament, but is only possible if the used materials adhere to each other.</li></ul></html>",
                     "type": "enum",
                     "type": "enum",
-                    "value": "'none' if (extruders_enabled_count < 2) else ('interleaved' if (all(material_type_var == extruderValues('material_type')[0] for material_type_var in extruderValues('material_type')) and all(material_brand_var == extruderValues('material_brand')[0] for material_brand_var in extruderValues('material_brand'))) else 'normal')",
+                    "value": "'none' if (extruders_enabled_count < 2) else 'normal'",
                     "options":
                     "options":
                     {
                     {
                         "none": "None",
                         "none": "None",
@@ -6849,7 +6833,7 @@
                     "default_value": 5,
                     "default_value": 5,
                     "minimum_value": "line_width",
                     "minimum_value": "line_width",
                     "maximum_value_warning": "10.0",
                     "maximum_value_warning": "10.0",
-                    "enabled": "resolveOrValue('prime_tower_mode') != 'none'",
+                    "enabled": "resolveOrValue('prime_tower_mode') == 'sparse' or resolveOrValue('prime_tower_mode') == 'bucket'",
                     "settable_per_mesh": false,
                     "settable_per_mesh": false,
                     "settable_per_extruder": true
                     "settable_per_extruder": true
                 },
                 },