Browse Source

Fix scrollbar filling space by replacing custom implementation with generic UM.ScrollBar

CURA-9144
j.delarago 2 years ago
parent
commit
c294680022

+ 2 - 24
plugins/DigitalLibrary/resources/qml/SelectProjectPage.qml

@@ -6,7 +6,7 @@ import QtQuick.Window 2.2
 import QtQuick.Controls 2.3
 import QtQuick.Layouts 1.1
 
-import UM 1.2 as UM
+import UM 1.6 as UM
 import Cura 1.7 as Cura
 
 import DigitalFactory 1.0 as DF
@@ -148,29 +148,7 @@ Item
             contentHeight: projectsListView.implicitHeight
             anchors.fill: parent
 
-            ScrollBar.vertical: ScrollBar
-            {
-                // Vertical ScrollBar, styled similarly to the scrollBar in the settings panel
-                id: verticalScrollBar
-                visible: flickableView.contentHeight > flickableView.height
-
-                background: Rectangle
-                {
-                    implicitWidth: UM.Theme.getSize("scrollbar").width
-                    radius: Math.round(implicitWidth / 2)
-                    color: UM.Theme.getColor("scrollbar_background")
-                }
-
-                contentItem: Rectangle
-                {
-                    id: scrollViewHandle
-                    implicitWidth: UM.Theme.getSize("scrollbar").width
-                    radius: Math.round(implicitWidth / 2)
-
-                    color: verticalScrollBar.pressed ? UM.Theme.getColor("scrollbar_handle_down") : verticalScrollBar.hovered ? UM.Theme.getColor("scrollbar_handle_hover") : UM.Theme.getColor("scrollbar_handle")
-                    Behavior on color { ColorAnimation { duration: 50; } }
-                }
-            }
+            ScrollBar.vertical: UM.ScrollBar { id: verticalScrollBar }
 
             Column
             {

+ 4 - 19
plugins/Marketplace/resources/qml/Packages.qml

@@ -1,9 +1,10 @@
-// Copyright (c) 2021 Ultimaker B.V.
+// Copyright (c) 2022 Ultimaker B.V.
 // Cura is released under the terms of the LGPLv3 or higher.
 
 import QtQuick 2.15
 import QtQuick.Controls 2.15
-import UM 1.4 as UM
+
+import UM 1.6 as UM
 
 
 ListView
@@ -51,23 +52,7 @@ ListView
         }
     }
 
-    ScrollBar.vertical: ScrollBar
-    {
-        // Vertical ScrollBar, styled similarly to the scrollBar in the settings panel
-        id: verticalScrollBar
-        visible: packages.contentHeight > packages.height
-        anchors.right: parent.right
-        background: Item {}
-
-        contentItem: Rectangle
-        {
-            id: scrollViewHandle
-            implicitWidth: UM.Theme.getSize("scrollbar").width
-            radius: Math.round(implicitWidth / 2)
-            color: verticalScrollBar.pressed ? UM.Theme.getColor("scrollbar_handle_down") : verticalScrollBar.hovered ? UM.Theme.getColor("scrollbar_handle_hover") : UM.Theme.getColor("scrollbar_handle")
-            Behavior on color { ColorAnimation { duration: 50; } }
-        }
-    }
+    ScrollBar.vertical: UM.ScrollBar { id: verticalScrollBar }
 
     delegate: MouseArea
     {