Browse Source

Add doc for map/tree update/recreation

Lipu Fei 7 years ago
parent
commit
b8ac5b296b
2 changed files with 10 additions and 0 deletions
  1. 5 0
      cura/Machines/MaterialManager.py
  2. 5 0
      cura/Machines/QualityManager.py

+ 5 - 0
cura/Machines/MaterialManager.py

@@ -18,6 +18,11 @@ from .MaterialGroup import MaterialGroup
 # The models GUI and QML use are now only dependent on the MaterialManager. That means as long as the data in
 # MaterialManager gets updated correctly, the GUI models should be updated correctly too, and the same goes for GUI.
 #
+# For now, updating the lookup maps and trees here is very simple: we discard the old data completely and recreate them
+# again. This means the update is exactly the same as initialization. There are performance concerns about this approach
+# but so far the creation of the tables and maps is very fast and there is no noticeable slowness, we keep it like this
+# because it's simple.
+#
 class MaterialManager(QObject):
 
     materialsUpdated = pyqtSignal()  # Emitted whenever the material lookup tables are updated.

+ 5 - 0
cura/Machines/QualityManager.py

@@ -152,6 +152,11 @@ class QualityNode(ContainerNode):
 # The models GUI and QML use are now only dependent on the QualityManager. That means as long as the data in
 # QualityManager gets updated correctly, the GUI models should be updated correctly too, and the same goes for GUI.
 #
+# For now, updating the lookup maps and trees here is very simple: we discard the old data completely and recreate them
+# again. This means the update is exactly the same as initialization. There are performance concerns about this approach
+# but so far the creation of the tables and maps is very fast and there is no noticeable slowness, we keep it like this
+# because it's simple.
+#
 class QualityManager(QObject):
 
     qualitiesUpdated = pyqtSignal()