Browse Source

Always use extruder stack when adding settings per object - CURA-4482

ChrisTerBeke 7 years ago
parent
commit
a7383b42d5
1 changed files with 18 additions and 23 deletions
  1. 18 23
      plugins/PerObjectSettingsTool/PerObjectSettingsTool.py

+ 18 - 23
plugins/PerObjectSettingsTool/PerObjectSettingsTool.py

@@ -78,31 +78,26 @@ class PerObjectSettingsTool(Tool):
     def _onGlobalContainerChanged(self):
         global_container_stack = Application.getInstance().getGlobalContainerStack()
         if global_container_stack:
-            self._multi_extrusion = global_container_stack.getProperty("machine_extruder_count", "value") > 1
 
-            # Ensure that all extruder data is reset
-            if not self._multi_extrusion:
-                default_stack_id = global_container_stack.getId()
-            else:
-                default_stack = ExtruderManager.getInstance().getExtruderStack(0)
-                if default_stack:
-                    default_stack_id = default_stack.getId()
-                else:
-                    default_stack_id = global_container_stack.getId()
-
-            root_node = Application.getInstance().getController().getScene().getRoot()
-            for node in DepthFirstIterator(root_node):
-                new_stack_id = default_stack_id
-                # Get position of old extruder stack for this node
-                old_extruder_pos = node.callDecoration("getActiveExtruderPosition")
-                if old_extruder_pos is not None:
-                    # Fetch current (new) extruder stack at position
-                    new_stack = ExtruderManager.getInstance().getExtruderStack(old_extruder_pos)
-                    if new_stack:
-                        new_stack_id = new_stack.getId()
-                node.callDecoration("setActiveExtruder", new_stack_id)
+            # used for enabling or disabling per extruder settings per object
+            self._multi_extrusion = global_container_stack.getProperty("machine_extruder_count", "value") > 1
 
-            self._updateEnabled()
+            extruder_stack = ExtruderManager.getInstance().getExtruderStack(0)
+
+            if extruder_stack:
+                root_node = Application.getInstance().getController().getScene().getRoot()
+                for node in DepthFirstIterator(root_node):
+                    new_stack_id = extruder_stack.getId()
+                    # Get position of old extruder stack for this node
+                    old_extruder_pos = node.callDecoration("getActiveExtruderPosition")
+                    if old_extruder_pos is not None:
+                        # Fetch current (new) extruder stack at position
+                        new_stack = ExtruderManager.getInstance().getExtruderStack(old_extruder_pos)
+                        if new_stack:
+                            new_stack_id = new_stack.getId()
+                    node.callDecoration("setActiveExtruder", new_stack_id)
+
+                self._updateEnabled()
 
     def _updateEnabled(self):
         selected_objects = Selection.getAllSelectedObjects()