Browse Source

Apply suggestions from code review

CURA-7440

Co-authored-by: Konstantinos Karmas <konskarm@gmail.com>

Jaime van Kessel 4 years ago
parent
commit
a46bf8d6fa

+ 2 - 1
cura/Arranging/ArrangeObjectsJob.py

@@ -35,4 +35,5 @@ class ArrangeObjectsJob(Job):
             no_full_solution_message = Message(i18n_catalog.i18nc("@info:status", "Unable to find a location within the build volume for all objects"),
                                                title = i18n_catalog.i18nc("@info:title", "Can't Find Location"))
             no_full_solution_message.show()
-        self.finished.emit(self)
+        self.finished.emit(self)
+        

+ 1 - 1
cura/Arranging/Nest2DArrange.py

@@ -23,7 +23,7 @@ def findNodePlacement(nodes_to_arrange: List["SceneNode"], build_volume: "BuildV
     :param build_volume: The build volume that we want to place the nodes in. It gets size & disallowed areas from this.
     :param fixed_nodes: List of nods that should not be moved, but should be used when deciding where the others nodes
                         are placed.
-    :param factor: The library that we use is int based. This factor defines how accuracte we want it to be.
+    :param factor: The library that we use is int based. This factor defines how accurate we want it to be.
     :return:
     """
 

+ 1 - 1
cura/MultiplyObjectsJob.py

@@ -74,7 +74,7 @@ class MultiplyObjectsJob(Job):
 
                 nodes.append(new_node)
         factor = 10000
-        found_solution_for_all, node_items = findNodePlacement(nodes, Application.getInstance().getBuildVolume(), fixed_nodes, factor = 10000)
+        found_solution_for_all, node_items = findNodePlacement(nodes, Application.getInstance().getBuildVolume(), fixed_nodes, factor = factor)
         not_fit_count = 0
         if nodes:
             operation = GroupedOperation()