Просмотр исходного кода

Apply division by zero prevention to the denominator

Rather than the numerator, which could not cause a division by zero exception.
Ghostkeeper 6 лет назад
Родитель
Сommit
9d8cf5ddde
1 измененных файлов с 1 добавлено и 2 удалено
  1. 1 2
      cura/PrinterOutput/PrintJobOutputModel.py

+ 1 - 2
cura/PrinterOutput/PrintJobOutputModel.py

@@ -132,8 +132,7 @@ class PrintJobOutputModel(QObject):
 
     @pyqtProperty(float, notify = timeElapsedChanged)
     def progress(self) -> float:
-        time_elapsed = max(float(self.timeElapsed), 1.0)  # Prevent a division by zero exception
-        result = time_elapsed / self.timeTotal
+        result = float(self.timeElapsed) / max(self.timeTotal, 1.0) # Prevent a division by zero exception.
         return min(result, 1.0)  # Never get a progress past 1.0
 
     @pyqtProperty(str, notify=stateChanged)