Browse Source

Set properties immediately upon constructing

Instead of afterwards. A bit more efficient.

Contributes to issue CURA-8609.
Ghostkeeper 3 years ago
parent
commit
9729f4f3d2
1 changed files with 4 additions and 3 deletions
  1. 4 3
      cura/Machines/Models/MaterialManagementModel.py

+ 4 - 3
cura/Machines/Models/MaterialManagementModel.py

@@ -330,11 +330,12 @@ class MaterialManagementModel(QObject):
         """
         if self._sync_all_dialog is None:
             qml_path = Resources.getPath(cura.CuraApplication.CuraApplication.ResourceTypes.QmlFiles, "Preferences", "Materials", "MaterialsSyncDialog.qml")
-            self._sync_all_dialog = cura.CuraApplication.CuraApplication.getInstance().createQmlComponent(qml_path, {})
+            self._sync_all_dialog = cura.CuraApplication.CuraApplication.getInstance().createQmlComponent(qml_path, {
+                "materialManagementModel": self,
+                "pageIndex": 0
+            })
         if self._sync_all_dialog is None:  # Failed to load QML file.
             return
-        self._sync_all_dialog.setProperty("materialManagementModel", self)
-        self._sync_all_dialog.setProperty("pageIndex", 0)
         self._sync_all_dialog.show()
 
     @pyqtSlot(result = QUrl)