Browse Source

Add FIXMEs where big changes are required

CURA-11561
Erwan MATHIEU 1 year ago
parent
commit
93cb358599

+ 1 - 0
plugins/3MFReader/ThreeMFWorkspaceReader.py

@@ -235,6 +235,7 @@ class ThreeMFWorkspaceReader(WorkspaceReader):
         containers_found_dict = {k: False for k in resolve_strategy_keys}
 
         # Check whether the file is a UCP, which changes some import options
+        #FIXME Instead of this, we should just check for the presence of the user-settings file, whatever the extension
         is_ucp = file_name.endswith('.ucp')
 
         #

+ 2 - 0
plugins/3MFWriter/ThreeMFWorkspaceWriter.py

@@ -34,6 +34,7 @@ class ThreeMFWorkspaceWriter(WorkspaceWriter):
         self._mode = None
         self._config_dialog = None
 
+    #FIXME We should have proper preWrite/write methods like the readers have a preRead/read, and have them called by the global process
     def _preWrite(self):
         is_ucp = False
         if hasattr(self._stream, 'name'):
@@ -150,6 +151,7 @@ class ThreeMFWorkspaceWriter(WorkspaceWriter):
 
         self._success = True
 
+    #FIXME We should somehow give the information of the file type so that we know what to write, like the mode but for other files types (give mimetype ?)
     def write(self, stream, nodes, mode=WorkspaceWriter.OutputMode.BinaryMode):
         self._success = False
         self._export_model = None