Browse Source

Endstop now stops listening upon destruction

Jaime van Kessel 9 years ago
parent
commit
7fda5e9a39

+ 5 - 0
plugins/USBPrinting/PrinterConnection.py

@@ -230,11 +230,16 @@ class PrinterConnection(OutputDevice, QObject, SignalEmitter):
         Logger.log("i", "Updating firmware of %s using %s", self._serial_port, file_name)
         self._firmware_file_name = file_name
         self._update_firmware_thread.start()
+
     @pyqtSlot()
     def startPollEndstop(self):
         self._poll_endstop = True
         self._end_stop_thread.start()
 
+    @pyqtSLot()
+    def stopPollEndstop(self):
+        self._poll_endstop = False
+
     def _pollEndStop(self):
         while self._is_connected and self._poll_endstop:
             self.sendCommand("M119")

+ 1 - 0
resources/qml/WizardPages/UltimakerCheckup.qml

@@ -22,6 +22,7 @@ Column
     property variant printer_connection: UM.USBPrinterManager.connectedPrinterList.getItem(0).printer
 
     Component.onCompleted: printer_connection.startPollEndstop()
+    Component.onDestruction: printer_connection.stopPollEndstop()
 
     Label
     {