Browse Source

Don't crash if the reply cannot be loaded

Fixes Sentry issue CURA-2RQ
Konstantinos Karmas 3 years ago
parent
commit
71748bff8d
1 changed files with 5 additions and 2 deletions
  1. 5 2
      plugins/Toolbox/src/Toolbox.py

+ 5 - 2
plugins/Toolbox/src/Toolbox.py

@@ -651,8 +651,11 @@ class Toolbox(QObject, Extension):
         self.resetDownload()
 
         if reply.attribute(QNetworkRequest.HttpStatusCodeAttribute) != 200:
-            Logger.log("w", "Failed to download package. The following error was returned: %s",
-                       json.loads(reply.readAll().data().decode("utf-8")))
+            try:
+                reply_error = json.loads(reply.readAll().data().decode("utf-8"))
+            except Exception as e:
+                reply_error = str(e)
+            Logger.log("w", "Failed to download package. The following error was returned: %s", reply_error)
             return
         # Must not delete the temporary file on Windows
         self._temp_plugin_file = tempfile.NamedTemporaryFile(mode = "w+b", suffix = ".curapackage", delete = False)