Browse Source

Simplify the check for new materials

If there is at least one material, we can already show the message without checking the rest of the installed packages.

CURA-8254
Konstantinos Karmas 3 years ago
parent
commit
658e54c8e5
1 changed files with 5 additions and 5 deletions
  1. 5 5
      cura/Machines/Models/MaterialManagementModel.py

+ 5 - 5
cura/Machines/Models/MaterialManagementModel.py

@@ -41,11 +41,11 @@ class MaterialManagementModel(QObject):
         a message prompting the user to sync the materials with their printers.
         """
         application = cura.CuraApplication.CuraApplication.getInstance()
-        new_materials_installed = False
-        for package_id, package_info in application.getPackageManager().installed_packages.items():
-            new_materials_installed = package_info["package_info"]["package_type"] == "material"
-        if new_materials_installed:
-            self._showSyncNewMaterialsMessage()
+        for package_id, package_data in application.getPackageManager().installed_packages.items():
+            if package_data["package_info"]["package_type"] == "material":
+                # At least one new material was installed
+                self._showSyncNewMaterialsMessage()
+                break
 
     def _showSyncNewMaterialsMessage(self):
         sync_materials_message = Message(