Browse Source

Change setting value defaults for maximum resolution to use deviation

All profiles that use maximum resolution should use maximum deviation instead, and halve it.

Contributes to issue CURA-6458.
Ghostkeeper 5 years ago
parent
commit
6325a5f1c2

+ 10 - 1
plugins/VersionUpgrade/VersionUpgrade40to41/VersionUpgrade40to41.py

@@ -1,4 +1,4 @@
-# Copyright (c) 2018 Ultimaker B.V.
+# Copyright (c) 2019 Ultimaker B.V.
 # Cura is released under the terms of the LGPLv3 or higher.
 
 import configparser
@@ -49,6 +49,15 @@ class VersionUpgrade40to41(VersionUpgrade):
         parser["general"]["version"] = "4"
         parser["metadata"]["setting_version"] = "7"
 
+        # Limit Maximum Deviation instead of Maximum Resolution. This should have approximately the same effect as before the algorithm change, only more consistent.
+        if "meshfix_maximum_resolution" in parser["values"]:
+            resolution = parser["values"]["meshfix_maximum_resolution"]
+            if resolution.startswith("="):
+                resolution = resolution[1:]
+            resolution = "=(" + resolution + ") / 2"
+            parser["values"]["meshfix_maximum_deviation"] = resolution
+            del parser["values"]["meshfix_maximum_resolution"]
+
         result = io.StringIO()
         parser.write(result)
         return [filename], [result.getvalue()]

+ 2 - 2
resources/definitions/peopoly_moai.def.json

@@ -173,8 +173,8 @@
         "minimum_polygon_circumference": {
             "value": "0.1"
         },
-        "meshfix_maximum_resolution": {
-            "value": "0.005"
+        "meshfix_maximum_deviation": {
+            "value": "0.003"
         },
         "skin_outline_count": {
             "value": 0