Browse Source

Fix string comparisons

Lipu Fei 6 years ago
parent
commit
4065a1204a

+ 1 - 1
plugins/Toolbox/src/AuthorsModel.py

@@ -53,7 +53,7 @@ class AuthorsModel(ListModel):
 
         # Filter on all the key-word arguments.
         for key, value in self._filter.items():
-            if key is "package_types":
+            if key == "package_types":
                 key_filter = lambda item, value = value: value in item["package_types"]  # type: ignore
             elif "*" in value:
                 key_filter = lambda item, key = key, value = value: self._matchRegExp(item, key, value)  # type: ignore

+ 1 - 1
plugins/Toolbox/src/PackagesModel.py

@@ -112,7 +112,7 @@ class PackagesModel(ListModel):
 
         # Filter on all the key-word arguments.
         for key, value in self._filter.items():
-            if key is "tags":
+            if key == "tags":
                 key_filter = lambda item, v = value: v in item["tags"]
             elif "*" in value:
                 key_filter = lambda candidate, k = key, v = value: self._matchRegExp(candidate, k, v)

+ 2 - 2
plugins/Toolbox/src/Toolbox.py

@@ -613,12 +613,12 @@ class Toolbox(QObject, Extension):
                             self._server_response_data[response_type] = json_data["data"]
                             self._models[response_type].setMetadata(self._server_response_data[response_type])
 
-                            if response_type is "packages":
+                            if response_type == "packages":
                                 self._models[response_type].setFilter({"type": "plugin"})
                                 self.reBuildMaterialsModels()
                                 self.reBuildPluginsModels()
                                 self._notifyPackageManager()
-                            elif response_type is "authors":
+                            elif response_type == "authors":
                                 self._models[response_type].setFilter({"package_types": "material"})
                                 self._models[response_type].setFilter({"tags": "generic"})