Browse Source

Don't connect when aborting while the signal is not yet connected

Do this using try-except so that it is thread safe.
Ruben D 6 years ago
parent
commit
33e49bebbe
1 changed files with 4 additions and 1 deletions
  1. 4 1
      plugins/Toolbox/src/Toolbox.py

+ 4 - 1
plugins/Toolbox/src/Toolbox.py

@@ -404,7 +404,10 @@ class Toolbox(QObject, Extension):
 
     def resetDownload(self) -> None:
         if self._download_reply:
-            self._download_reply.downloadProgress.disconnect(self._onDownloadProgress)
+            try:
+                self._download_reply.downloadProgress.disconnect(self._onDownloadProgress)
+            except TypeError: #Raised when the method is not connected to the signal yet.
+                pass #Don't need to disconnect.
             self._download_reply.abort()
         self._download_reply = None
         self._download_request = None