Browse Source

Add documentation for timers in Material and Quality managers

Lipu Fei 7 years ago
parent
commit
2dd7be1271
2 changed files with 6 additions and 0 deletions
  1. 3 0
      cura/Machines/MaterialManager.py
  2. 3 0
      cura/Machines/QualityManager.py

+ 3 - 0
cura/Machines/MaterialManager.py

@@ -39,6 +39,9 @@ class MaterialManager(QObject):
         self._default_machine_definition_id = "fdmprinter"
         self._default_machine_definition_id = "fdmprinter"
         self._default_approximate_diameter_for_quality_search = "3"
         self._default_approximate_diameter_for_quality_search = "3"
 
 
+        # When a material gets added/imported, there can be more than one InstanceContainers. In those cases, we don't
+        # want to react on every container/metadata changed signal. The timer here is to buffer it a bit so we don't
+        # react too many time.
         self._update_timer = QTimer(self)
         self._update_timer = QTimer(self)
         self._update_timer.setInterval(300)
         self._update_timer.setInterval(300)
         self._update_timer.setSingleShot(True)
         self._update_timer.setSingleShot(True)

+ 3 - 0
cura/Machines/QualityManager.py

@@ -169,6 +169,9 @@ class QualityManager(QObject):
         self._container_registry.containerAdded.connect(self._onContainerMetadataChanged)
         self._container_registry.containerAdded.connect(self._onContainerMetadataChanged)
         self._container_registry.containerRemoved.connect(self._onContainerMetadataChanged)
         self._container_registry.containerRemoved.connect(self._onContainerMetadataChanged)
 
 
+        # When a custom quality gets added/imported, there can be more than one InstanceContainers. In those cases,
+        # we don't want to react on every container/metadata changed signal. The timer here is to buffer it a bit so
+        # we don't react too many time.
         self._update_timer = QTimer(self)
         self._update_timer = QTimer(self)
         self._update_timer.setInterval(300)
         self._update_timer.setInterval(300)
         self._update_timer.setSingleShot(True)
         self._update_timer.setSingleShot(True)