Browse Source

CURA-4870 Fix binding loop in some components with the height property by changing the vertical alignments

Diego Prado Gesto 7 years ago
parent
commit
2818ff7f31

+ 1 - 2
resources/qml/Menus/ConfigurationMenu/ConfigurationItem.qml

@@ -77,7 +77,6 @@ Rectangle
             UM.RecolorImage {
                 id: buildplateIcon
                 anchors.left: parent.left
-                anchors.verticalCenter: parent.verticalCenter
                 width: UM.Theme.getSize("topbar_button_icon").width
                 height: UM.Theme.getSize("topbar_button_icon").height
                 sourceSize.width: width
@@ -90,7 +89,7 @@ Rectangle
             {
                 id: buildplateLabel
                 anchors.left: buildplateIcon.right
-                anchors.verticalCenter: parent.verticalCenter
+                anchors.verticalCenter: buildplateIcon.verticalCenter
                 anchors.leftMargin: Math.round(UM.Theme.getSize("default_margin").height / 2)
                 text: configuration.buildplateConfiguration
                 color: textColor

+ 1 - 2
resources/qml/Menus/ConfigurationMenu/PrintCoreConfiguration.qml

@@ -27,7 +27,6 @@ Column
             id: extruderLabel
             text: catalog.i18nc("@label:extruder label", "Extruder")
             elide: Text.ElideRight
-            anchors.verticalCenter: parent.verticalCenter
             anchors.left: parent.left
             font: UM.Theme.getFont("default")
             color: mainColor
@@ -37,7 +36,7 @@ Column
         Item
         {
             id: extruderIconItem
-            anchors.verticalCenter: parent.verticalCenter
+            anchors.verticalCenter: extruderLabel.verticalCenter
             anchors.left: extruderLabel.right
             anchors.leftMargin: Math.round(UM.Theme.getSize("default_margin").width / 2)
 

+ 1 - 1
resources/qml/Menus/ConfigurationMenu/SyncButton.qml

@@ -11,7 +11,7 @@ import Cura 1.0 as Cura
 Button
 {
     id: base
-    property var outputDevice: Cura.MachineManager.printerOutputDevices[0] != null ? Cura.MachineManager.printerOutputDevices[0] : null
+    property var outputDevice: Cura.MachineManager.printerOutputDevices[0]
     text: catalog.i18nc("@label:sync indicator", "No match")
     width: parent.width
     height: parent.height