Browse Source

Set preference for sending info to default state instead of removing them

CURA-5095
Jaime van Kessel 6 years ago
parent
commit
13eaa14752

+ 2 - 2
plugins/VersionUpgrade/VersionUpgrade34to35/VersionUpgrade34to35.py

@@ -88,9 +88,9 @@ class VersionUpgrade34to35(VersionUpgrade):
 
         # Need to show the data collection agreement again because the data Cura collects has been changed.
         if parser.has_option("info", "asked_send_slice_info"):
-            parser.remove_option("info", "asked_send_slice_info")
+            parser.set("info", "asked_send_slice_info", "False")
         if parser.has_option("info", "send_slice_info"):
-            parser.remove_option("info", "send_slice_info")
+            parser.set("info", "send_slice_info", "True")
 
         # Update version number.
         parser["general"]["version"] = "6"

+ 3 - 3
plugins/VersionUpgrade/VersionUpgrade34to35/tests/TestVersionUpgrade34to35.py

@@ -38,6 +38,6 @@ def test_upgradeVersionNr(test_name, file_data, upgrader):
     assert parser["general"]["version"] == "6"
     assert parser["metadata"]["setting_version"] == "5"
 
-    # Check if the data collection values have been removed
-    assert not parser.has_option("info", "asked_send_slice_info")
-    assert not parser.has_option("info", "send_slice_info")
+    # Check if the data collection values have been reset to their defaults
+    assert parser.get("info", "asked_send_slice_info") == "False"
+    assert parser.get("info", "send_slice_info") == "True"